Граф коммитов

512 Коммитов

Автор SHA1 Сообщение Дата
waterson%netscape.com 7b0457913d Bug 27222. Add a parser observer, so we're always guaranteed to be notified when an overlay completes (even if the overlay wasn't there). Keeps us from 'hanging' when an overlay file is missing. r=harishd, a=jevering 2000-03-07 02:33:44 +00:00
waterson%netscape.com 3a38a69faa Bug 29148. Don't abort in the case where an invalid stylesheet reference has somehow made it into the prototype document, but the stylesheet was never put into the cache (an empty CSS file will cause this to happen). Instead, just keep on truckin'. r=rjc, a=jar 2000-03-03 23:14:09 +00:00
pollmann%netscape.com 3328c4a8ea Bug 28670: Move XUL scrollbar removal to nsCSSFrameConstructor r=travis a=rickg 2000-02-29 06:51:05 +00:00
jdunn%netscape.com dd4717cd8d adding newline 2000-02-28 20:50:38 +00:00
saari%netscape.com 7e48b21ecd fix for 28467, a=jar, r=hyatt 2000-02-26 00:59:41 +00:00
law%netscape.com e52299f99b Fix from Chris Waterson to suppress bogus assertion failure when adding overlays to personal toolbar; this is a prerequisite to other changes for bug #11871; r=waterson@netscape.com, a=jevering@netscape.com 2000-02-25 02:28:45 +00:00
danm%netscape.com 698eb199f8 stop up small but profuse leak on NT; probably a runtime lib bug. r=waterson a=jevering 2000-02-22 04:13:24 +00:00
pollmann%netscape.com 239cf4050e Bug 14827: Naughty XUL documents no longer steal scrollbars r=harishd a=rickg 2000-02-19 02:41:48 +00:00
waterson%netscape.com 85010931c6 Bugs 27271, 27947. Re-order menu creation so that RDF-generated menus are created simultaneously with XUL content. Use style rather than content tree crawling to avoid over-eager creation of menu content. r=hyatt,danm a=jevering. 2000-02-19 00:56:13 +00:00
waterson%netscape.com 0b9f6cb34b Bug 27925. Check document's principal before loading RDF datasources; if principal == system principal, let it do whatever it wants, otherwise check each datasource's URL to ensure that it comes from the same origin as the document. Prevents, for example, untrusted XUL content from loading bookmarks. r=norris, a=chofmann 2000-02-17 21:05:52 +00:00
waterson%netscape.com 725a6b2b3d Revert fix for 26947, 27271 due to bad interaction with the 'find' datasource that causes crash-on-exit. a=chofmann. 2000-02-16 22:44:15 +00:00
waterson%netscape.com 21c4ae46b3 Bugs 27947, 27271. Re-order content-model-to-layout notification to avoid an incremental reflow. This ensures that 1) all menus will be completely created before they are displayed, and 2) the 'oncreate' handler runs after RDF content has been generated. r=hyatt 2000-02-16 07:36:35 +00:00
joki%netscape.com c564b74577 Fixes for bug 9544, 9552, 9558, 9561, and 13309. event handler 4x compat. and capture/bubble fixes. r:pollmann 2000-02-16 06:59:07 +00:00
sspitzer%netscape.com 505b02bd76 case sensitivity problem. r=sfraser 2000-02-15 09:42:41 +00:00
sfraser%netscape.com 92e0c2ac71 First Checked In. 2000-02-15 08:42:25 +00:00
hyatt%netscape.com 59c456d260 Fix for bug #25675. More focus memory framework being checked in for the
command dispatcher as well.
2000-02-11 00:59:32 +00:00
kmcclusk%netscape.com cd6f5d237b Prevent synchronous paints during reflows bug 20150; r=rods@netscape.com
Call SetTextAlign within SetupDC instead of in each DrawString on WIN32. bug 26973; r=rods@netscape.com
2000-02-09 15:48:01 +00:00
hyatt%netscape.com 8ac3ffd335 Fixing command dispatcher horkage. r=saari 2000-02-09 03:14:03 +00:00
dp%netscape.com 3c5ef57426 Fixing build bustage. 2000-02-09 02:43:48 +00:00
hyatt%netscape.com 6dd01225a8 Command dispatcher fix for PDT+ focus issues on Linux. r=saari 2000-02-09 01:32:42 +00:00
tbogard%aol.net 840c8350e1 GlobalWindow now calls up nsIDocShellTreeOwner rather than nsIBrowserWindow. GlobalWindow has mostly been re-organized as well as cleaned up to provide this new functionality. DocShellTreeOwners got implementations filled in and many bugs fixed. nsIScriptGlobalObject now talks in terms of docShells instead of webShells. Fixed a number of cases where people were walking through content viewers etc to get to a presShell and changed them to simply ask for the presShell from the docShell. GlobalWindow now deals completely in terms of docShells. r=vidur 2000-02-08 13:40:10 +00:00
joki%netscape.com 3480787577 Adding getPreventDefault method to events and fixing its propagation through content. r:hyatt 2000-02-08 02:05:57 +00:00
waterson%netscape.com d4305ba238 Tweak MOZ_COUNT_[CTOR|DTOR] macros. 2000-02-06 02:56:06 +00:00
alecf%netscape.com a59485a7ad hook up this object to the globalobjectowner so that we can report errors
r=waterson
2000-02-04 01:42:05 +00:00
waterson%netscape.com 65ae380cbe Bug 25333. Implement nsIScriptGlobalObjectOwner so we can report compilation errors. r=scc 2000-02-03 08:51:49 +00:00
waterson%netscape.com b0ab68c1e3 Bug 20677, 23905, attempt number 2. This time, in the DOM methods, we make sure to do a 'deep' set on mDocument *before* calling to their nsIContent brethren. This ensures that any code in layout that wants to access the document gets the right value. r=scc 2000-02-03 07:55:34 +00:00
valeski%netscape.com a567c875bb r=warren. nsIUnicharStreamLoader is dead. Now we have a generic byte stream loader that can be used for any sort of data. 2000-02-02 23:04:47 +00:00
waterson%netscape.com 8dd7b2ed23 Revert changes that cause mail sort to crash. 2000-02-02 19:46:03 +00:00
waterson%netscape.com a26daa2f0d Bugs 20677, 23905. Change nsXULElement to implement nsIContent like nsGenericElement and nsGenericHTMLElement. Specifically, do 'shallow' SetDocument() calls in AppendChildTo(), InsertChildAt() and ReplaceChildAt() methods. Change nsXULDocument to leave newly create element's mDocument as null (so 'null mDocument' means 'this element is not currently in the document'. Fix callers to ensure that a deep SetDocument() is made where necessary. r=hyatt 2000-02-01 22:57:36 +00:00
vidur%netscape.com e8157b30cb Fix for bugs 20485 and 24600. We no longer flush immediately in the content sink when we hit a script element. Instead the sink is a document observer and listens for BeginUpdate/EndUpdate notifications when evaluating a script and flushes only if necessary. Added BeginUpdate/EndUpdate notifications to nsIDocument and layout content (note that it's still necessary for XUL content). r=nisheeth,pollmann 2000-01-28 23:43:12 +00:00
hyatt%netscape.com 1b09ed7f43 Making the XUL key listener a bubbler. Removing its capability to handle
textareas and inputs.
2000-01-27 09:43:19 +00:00
sspitzer%netscape.com 1a7841574a change PR_ASSERT to NS_ASSERTION. on linux, PR_ASSERT calls abort, and
I was getting getting to the PR_ASSERT when copying text in a quoted mail message.  r=akkana, a=leaf
2000-01-26 20:39:28 +00:00
norris%netscape.com 7ec9655d07 Fix 23227 Document object vulnerability
r=mstoltz
2000-01-26 15:33:57 +00:00
waterson%netscape.com 07c10d9502 Minor code cleanup from review with brendan: use shared finalizer in nsJSUtils. 2000-01-26 01:56:56 +00:00
waterson%netscape.com a566daa16c Use NS_REINTERPRET_CAST instead of including private header files. 2000-01-26 01:55:59 +00:00
putterman%netscape.com 3ca3cf5499 r=waterson. Necessary for 24768. Put nsIDOMXULDocument into this. 2000-01-25 05:09:23 +00:00
nisheeth%netscape.com 22a5959edb Work done by Vidur and me. Added a FlushPendingNotifications() method to the document. This method flushes the pending content notifications from the content sink and the pending reflow notifications from the pres shell. This code is turned off for now so that it can be tested more thoroughly by Vidur and me. 2000-01-24 06:43:15 +00:00
jfrancis%netscape.com 75b2d70c6e fixing rdf build bustage 2000-01-23 00:25:21 +00:00
waterson%netscape.com d100985675 Bugs 18127, 20677, 23905. Partial fix. Give the nsXULPrototypeDocument it's own JSContext to use for compiling scripts and event handlers. Modify script and event handler code to compile shared scripts using this context, if appropriate. r=brendan 2000-01-22 22:00:35 +00:00
hyatt%netscape.com b8c4dff420 Adding a XUL element factory so that the XML content sink over in layout will
be able to make XUL elements. r=waterson
2000-01-19 03:28:06 +00:00
hyatt%netscape.com 1d0e1d86fd Patching XUL documents so that they support extensibility of content creation.
Patching the RDF generic builder so that it can build any type of content
element (using the generic factory building interface). r=waterson
2000-01-19 03:11:39 +00:00
waterson%netscape.com d5fbf22774 Bug 24134. Re-apply r1.233, which was steamrollered by tao's recent checkin. Re-using the r=valeski here. 2000-01-17 19:34:23 +00:00
danm%netscape.com 5a261c8ad9 reapplying changes from rev 1.234, which was lost as part of 1.235 2000-01-15 05:53:41 +00:00
alecf%netscape.com 94b65d019c attempted fix at build bustage. I have no idea if this is the "right" thing or not but it gets the build green 2000-01-15 03:51:31 +00:00
tao%netscape.com da49ef2262 bug 23400: Need to expose api GetDocumentCharacterSet() to JS. r=vidur. 2000-01-15 02:01:05 +00:00
brendan%mozilla.org dfaa05987e InitStandardClasses so JS compiler makes well-prototyped objects (22048,22098 r=shaver). 2000-01-14 00:49:30 +00:00
danm%netscape.com 05825e9716 removing initial window sizing from StartLayout (now done in nsWebShellWindow). Long overdue change; also necessary as part of bug 15775. r:hyatt@netscape.com 2000-01-13 23:49:25 +00:00
waterson%netscape.com a8efb387b8 Bug 23799. Ignore failure from GetContentType() in StartDocumentLoad(), because some channels may not have yet resolved the content type. In this case, cross our fingers and pray that it's text/xul. r=valeski 2000-01-13 23:23:51 +00:00
alecf%netscape.com 714e7a48a9 expose the form controls in a XUL document in the "controls" DOM attribute
this will make prefs and wizards much faster
r=hyatt
2000-01-13 02:59:08 +00:00
rjc%netscape.com b945bae5b3 Somehow, we lost some of the magical attributes we need to check for. (coalescing dup arcs, and allowing negative arcs) 2000-01-12 01:47:23 +00:00
waterson%netscape.com c0a53ad72f Bug 22915. Be sure to add the nsCachedChromeChannel to the load group on nsIChannel::SetLoadGroup(). Also, don't assume (in nsXULDocument::StartDocumentLoad) that when you 'hit' in the cache that the channel is actually a nsCachedChromeChannel; instead, inspect its content type. Finally, get rid of extraneous 'command' member variable in nsCachedChromeChannel. r=mscott 2000-01-11 21:18:19 +00:00
pp%ludusdesign.com 698852a4f4 Converting usage of ::GetIID() to NS_GET_IID().
Bug #20232, r=scc@netscape.com
2000-01-11 20:49:15 +00:00
waterson%netscape.com 971c4ab2ab Take out crufty debug printfs. 2000-01-11 02:49:18 +00:00
rpotts%netscape.com 023f2ff6e1 Made contentType a read/write attribute of nsIChannel 2000-01-08 06:26:04 +00:00
waterson%netscape.com 73e507347d Bug 22805. Wrap NS_GetWeakReference() with getter_AddRefs(). Thanks beard! r=beard 2000-01-06 20:01:56 +00:00
waterson%netscape.com 4c6aed1d16 Bug 19033. Wait until the parse is complete to set the 'root' element in the prototype document. This ensures that malformed XUL with too few close-tags won't leave the prototype document with a dangling pointer to a destroyed element. r=hyatt 2000-01-06 00:29:30 +00:00
sspitzer%netscape.com e32328cd40 only hyatt needs to see his debugging printfs. 1999-12-24 07:53:41 +00:00
waterson%netscape.com 48a17f7378 Bug 22305. Fix leak when replacing cache entry for style sheet and prototype document. r=buster, a=sdagley 1999-12-22 01:42:42 +00:00
jband%netscape.com ef9c82db1e Landing big set of DOM and XPConnect changes:
DOM: getting rid of JS_GetContextPrivate wherever possible. Use static parent
links where we can. When we do need to find this info about the caller
we call a function that knows how to get that info rather than inline calls
to JS_GetContextPrivate. This is all required for calling DOM objects on
non-DOM JSContexts as we do via xpconnect.

XPConnect: basic refactoring work to disassociate wrappers from the JSContext
that was active when the wrapper was constructed. This allows for calling into
wrapped JS objects on the right JSContext and for proper grouping of wrapped
native objects so that they can share proto objects. This also allows for
better sharing of objects and lays the foundations for threadsafety and
interface flattening.

Also, xpconnect tests are reorganized and improved.

fixes bugs: 13419, 17736, 17746, 17952, 22086

r=vidur r=mccabe r=norris r=cbegle
a=chofmann
1999-12-18 20:29:29 +00:00
hyatt%netscape.com d3e0848c19 Fixes for 3 PDT+ bugs (THAT'S RIGHT). Bugs 21895, 21832, and 21610. r=mjudge,
a=i'm leaving now for vacation, and i can't find anyone around, but i'm assuming that you
actually want them before January 3rd, so I'm checking them in.
1999-12-18 04:02:28 +00:00
waterson%netscape.com 59f08eb360 Bug 21364. Fix document leaks that occur via uncollected script objects: compile scripts against a special global object owned by the prototype document. shaver mostly did this work. r=brendan Bug 21661. Break circular reference between command dispatcher and XUL document. r=saari 1999-12-17 00:06:28 +00:00
hyatt%netscape.com 78ed47b45c Fix for 21610. r=waterson 1999-12-16 03:19:34 +00:00
waterson%netscape.com d13a83fb9f Bug 21610. Add support to distinguish key binding overlay from normal overlay documents. 1999-12-15 23:18:34 +00:00
hyatt%netscape.com 70f793378c Fix for PDT bug #21247. r=saari, mjudge 1999-12-11 00:06:29 +00:00
waterson%netscape.com bc16c6794e Bug 17680. Only need to add template builders on nodes that are more than -two- levels in from an overlay root. The first ply will be set up in nsXULDocument::OverlayForwardReference::Merge(). 1999-12-08 07:59:12 +00:00
hyatt%netscape.com c026e8d315 Fixing bustage on wensleydale. 1999-12-08 06:04:10 +00:00
hyatt%netscape.com f23566bf16 Massive rewrite of the key binding system and the command dispatcher. Key
bindings are now fully hierarchical.  In addition, DOM windows, input fields
and textareas can pull their key bindings from a separate XUL file.  This
allows configurable key bindings.

Massive rewrite of the command dispatcher system.  The command dispatcher now
deals with DOM windows in addition to DOM elements.  It now tracks both
successfully and works in conjunction with the new focus/blur architecture.

r=saari
1999-12-08 04:56:56 +00:00
waterson%netscape.com 77a02a8fff Bug 16709. Set 'content ID' fields on elements as they are constructed from XUL. 1999-12-06 23:05:31 +00:00
waterson%netscape.com c3688d7937 Bug 20897. Change flow-of-control; panic if we can't get from a presshell to a webshell and beyond. r=danm 1999-12-06 23:03:53 +00:00
waterson%netscape.com 38e938ebbc Bug 20470. Add weak reference from 'controllers' object back to command dispatcher. Miscellaneous cleanup. r=hyatt 1999-12-05 23:04:22 +00:00
waterson%netscape.com 82fb1998b7 Bug 18392. Use XUL document cache for retrieving master document. 1999-12-04 07:45:57 +00:00
vidur%netscape.com 1cf2db67a5 For bug 17325. Changed signature of css loader methods. R=nisheeth. 1999-12-04 01:29:18 +00:00
tbogard%aol.net 317758d9f3 include of nsIScriptGlobalObject.h is now in nsXULDocument.h. 1999-12-03 19:29:23 +00:00
tbogard%aol.net 72218fe6d8 Moved the include over. This should fix wensleydale. 1999-12-03 19:26:23 +00:00
tbogard%aol.net 94a95754d7 Hoping this will help wensleydale. 1999-12-03 12:09:10 +00:00
tbogard%aol.net eb96099e6d 1.) WebShell no longer implements nsIScriptContextOwner.
2.)  WebShell now implements the new nsIScriptGlobalObjectOwner.
3.)  WebShell supports GetInterface to nsIScriptGlobalObject.
4.)  Documents no longer carry around a reference to nsIScriptContextOwner.  Instead they hold on to a nsIScriptGlobalObject.  nsIDocument::GetScriptContextOwner has now become nsIDocument::GetScriptGlobalObject().  Same change to the set methods.
1999-12-03 09:24:22 +00:00
buster%netscape.com fd31de07ac bug 2253. added controller to html text input
r = kmcclusk, norris
1999-12-01 15:11:33 +00:00
waterson%netscape.com b226f5a42a Bug 16516. Doh! Fix use of NS_RELEASE()-ed pointer that was causing load handlers to not run on brutally shared docs. 1999-11-30 22:47:41 +00:00
ftang%netscape.com f6e3351358 fix bug 20181. r=ftang a=beard 1999-11-30 22:24:16 +00:00
warren%netscape.com 2db26922a6 Landing no_neckoutil2_branch. Bug #11159. Removes neckoutil_s.lib from build which helps beos and openvms. 1999-11-30 04:50:42 +00:00
waterson%netscape.com 947d490060 Fix RemoveStyleSheet() per pierre's comments. 1999-11-30 04:33:28 +00:00
hyatt%netscape.com 7ab98f7f26 Adding RemoveStyleSheet to nsIDocument (needed for skins). r=waterson 1999-11-29 22:15:07 +00:00
waterson%netscape.com 7e03717d55 Bug 20147. Make sure to correctly scope 'parent' when creating script objects. XUL document's parent is the window; XUL element's parent is the document. r=brendan 1999-11-29 20:53:40 +00:00
hyatt%netscape.com 9d73ef65cc More skin work. r=pavlov 1999-11-29 06:51:24 +00:00
tbogard%aol.net 85b5334721 nsXULDocument now uses the nsIBaseWindow interface for windowing stuff on webshell instead of nsIWebShell. This paves the way for the new docshell object to move in. 1999-11-29 06:04:15 +00:00
waterson%netscape.com dd7c188516 More random flailing to fix gcc-2.7.2.3 1999-11-24 23:39:34 +00:00
waterson%netscape.com 1260e2100c Random flailing to fix gcc-2.7.2.3 bustage. 1999-11-24 23:19:52 +00:00
waterson%netscape.com 1eb45f5c91 Expose nsIXULDocument and nsIXULPrototypeDocument as public interfaces. Properly implement nsIXULDocument::CreateFromPrototype(). 1999-11-24 22:46:09 +00:00
waterson%netscape.com 42f49b9da2 Add methods to individually flush prototypes and style sheets. 1999-11-24 22:44:52 +00:00
waterson%netscape.com 47352eeda1 Bug 20036. Fix style sheet ordering. 1999-11-24 22:43:45 +00:00
tbogard%aol.net af1ce8d410 Changed nsIPresContext& to nsIPresContext*. Changed nsEventStatus& to nsEventStatus*. Now more compatible with XPIDL. a=vidur r=scc 1999-11-24 06:03:41 +00:00
waterson%netscape.com eb971c4df2 Bug 19421. Brendan's fixes for brutal sharing of script, plus a 'placeholder channel' that ensures we don't fire the EndDocumentLoad() before the prototype walk completes. r=brendan 1999-11-23 01:44:51 +00:00
sfraser%netscape.com 5065e2a283 Workaround for bug 19421 -- no menus on mac. This is a problem with brutal sharing of overlays that waterson needs to fix. For now, turn off brutal sharing of scripts. r=brendan, saari. 1999-11-20 06:42:24 +00:00
brendan%mozilla.org e291840c27 Followup to my last checkin: get list-unlink vs. ResumeWalk order right (r=waterson@netscape.com) 1999-11-20 03:10:42 +00:00
rods%netscape.com f64b7ae035 removed select initialization code r=dcone bug 18241 1999-11-19 15:42:06 +00:00
buster%netscape.com fdbc16704a bug 12022, r=rickg 1999-11-19 08:26:56 +00:00
waterson%netscape.com 3c3b7dbdca Clean up some timing printfs. 1999-11-18 05:47:51 +00:00
brendan%mozilla.org 4849241687 Brutal JS script sharing (15146, r=waterson@netscape.com). 1999-11-18 02:25:33 +00:00
warren%netscape.com 34ecf73507 Necko API and implementation changes for retargeting. Needed for URL dispatching. r=mscott 1999-11-17 08:14:52 +00:00
waterson%netscape.com 3af1eee9aa Fix build bustage: disambiguate nsXULDocument::State from nsForwardReference::State by renaming to nsForwardReference::Phase. 1999-11-17 03:20:03 +00:00
waterson%netscape.com b20b076a88 Bug 13378. Make sure that we hook up any broadcasters that arrive in overlay subtrees. r=hyatt 1999-11-17 02:45:46 +00:00
norris%netscape.com 5b4b0169aa * Fix 12124 [DOGFOOD] Reading user's preferences
* Implement site-specific security policies (bug 858)
r=mstoltz
* Use Recycle rather than delete[] to clean up Purify logs
r=law
1999-11-16 05:07:31 +00:00
tbogard%aol.net 8c8bbce9a7 Changed places where containers were set to use nsISupports instead of nsIContentViewerContainer. r=dp 1999-11-15 22:17:54 +00:00
tbogard%aol.net 4fffbc4bf8 Changed interfaces to take nsISupports for the container instead of nsIContentViewerContainer. nsXULDocument was for some reason holding on to this interface (as a weak reference) but was never using it. I have therefore gotten rid of this member variable. r=dp 1999-11-15 22:14:37 +00:00
rods%netscape.com 1cbaf268cf added the call DoneAddingContent for the select after it has been created.
r=dcone,bug 18784,16821
1999-11-15 15:11:33 +00:00
waterson%netscape.com 1d36d9329e Bug 18102. Consolidate element map, command dispatcher, and broadcaster hookup into AddSubtreeToDocument(). Fixes over-eager hookup of broadcast listeners into unresolved overlay elements, which left a dangling pointer. r=saari, a=chofmann 1999-11-08 19:07:13 +00:00
dmose%mozilla.org 142ac52eaf updated xPL license boilerplate to v1.1, a=chofmann@netscape.com,r=endico@mozilla.org 1999-11-06 03:43:54 +00:00
waterson%netscape.com 87b8e4a574 Bug 18058. Remove 'commandDispatcher' from interface; obsolete, and leaky. r=hyatt, a=chofmann 1999-11-05 05:31:15 +00:00
waterson%netscape.com dfd9dd6eaa Bug 18058. Remove 'commandDispatcher' from interface; obsolete. r=hyatt, a=chofmann 1999-11-05 05:30:56 +00:00
waterson%netscape.com f9b4723956 Bug 17955. Don't unnecessarily add script event listeners to temporary nodes used for overlay hookup. r=hyatt, a=chofmann 1999-11-04 19:43:43 +00:00
waterson%netscape.com 2728cb5577 Bug 17847. Fix 'commandupdater' hookup for master document. r=hyatt, a=chofmann 1999-11-04 18:37:58 +00:00
hyatt%netscape.com 2da1dc5d17 Partial fix for 17848. Part 1 of 2. 2nd part will be checked in by hangas. r=hangas, a=brendan 1999-11-04 01:59:04 +00:00
cls%seawood.org bee74e223b Removed unused NECKO ifdefs.
a=leaf
1999-11-02 23:34:03 +00:00
warren%netscape.com 332749d6fa Made nsIUnicharStreamLoader be scriptable and deal with an xpcom observer instead of a proc pointer and void*. Part of bug#11159. r=nisheeth,kipp,pierre 1999-11-02 06:49:44 +00:00
waterson%netscape.com 22be6e4c41 Fix manky nsCOMPtr asserts. 1999-11-02 02:02:27 +00:00
waterson%netscape.com 676716c335 Bug 15146. Brutal sharing, Phase III. Turn on protoype, script, and style sheet caching. r=hyatt 1999-11-02 01:14:07 +00:00
brendan%mozilla.org f81d5969c6 (13163, r=alecf, scc, waterson, others; names available on request)
- Fix most of bug 13163 (see TODO for rest).  This entails adding a version-string argument to nsIScriptContext::EvaluateString and passing it around lots of places in content sinks. 

- Fix leaks and confusion about mSecurityManager and mNameSpaceManager in nsJSEnvironment.cpp.  These still need to move from nsJSContext to nsGlobalWindow or thereabouts, jband and vidur are looking at that. 

- Added comments and expanded tabs in nsJSEnvironment.cpp, esp. to EvaluateString.  Also changed various nsresult vars to be named rv.  Also restored brace/style conformity to nsJSProtocolHandler.cpp. 

- Factored CompileFunction from AddScriptEventListener to pave the way for brutal sharing of compiled JS event handlers via JS_CloneFunctionObject. 

- Lots of nsCOMPtr uses added.  I'm using one for mNameSpaceManager.  Hold mSecurityManager as a service explicitly, on the other hand (awaiting scc's fix to allow comptrs for services), and release in nsJSContext's dtor (fixing a leak).  These two managers should be moved to the window object -- TODO item below. 

- Hold JSRuntimeService along with JSRuntime for live of nsJSEnvironment, fix for shaver. 

- Fix window.setTimeout etc. so the filename and line number of the timeout expr is propagated.  This meant factoring nsJSUtils.cpp code. 

- Fix all content sinks to use the same, and up-to-date JavaScript version parsing (whether for script type or for old language attribute); also fix SplitMimeType clones to strip whitespace. 

- With waterson, fix bug in brutal-sharing version of XUL content sink: script src= should not evaluate the inline content of its tag.
1999-10-31 00:43:30 +00:00
troy%netscape.com a12c3d6c5d Folded reflow functions into nsIFrame and eliminated nsIFrameReflow and
nsIHTMLReflow. This saves 4 bytes per frame and cleans things up
1999-10-30 02:52:11 +00:00
waterson%netscape.com ada7441247 Bug 15146. Brutal content model sharing, Phase II. XUL content sink now constructs prototype documents; 'real' content model constructed from walking prototype. Landed XUL_SHARING_19991027_BRANCH (derived from XUL_SHARING_19991022_BRANCH). See branch comments for details. r=hyatt. 1999-10-29 01:21:15 +00:00
pepper%netscape.com b5b2656f52 Added a newline to the end of file so that AIX and HP compilers are happy.
r=mgleeson
1999-10-28 22:17:43 +00:00
hyatt%netscape.com e092fcee6b making the chrome registry work with dynamic overlays r=pavlov 1999-10-27 02:21:05 +00:00
waterson%netscape.com 15b4a60c84 Bug 15146. Factor nsXULElement's members into prototype and optional 'slots' for heavyweight elements. r=hyatt. 1999-10-20 18:55:32 +00:00
tbogard%aol.net 6bf524bc9e Removed the last of gimpy's warnings. r=gimpy. 1999-10-19 08:03:11 +00:00
warren%netscape.com 26fb3f9eba Took out redundant MOZ_COUNT_CTOR/DTOR calls. 1999-10-18 19:21:53 +00:00
peterl%netscape.com d168caadef Added namespace ID to the AttributeChanged notification
Part of the fix for Bug 15153
r=troy
1999-10-15 23:17:53 +00:00
rjc%netscape.com ae28cd2568 Fix leak in nsXULSortService (found by Boehm GC). Also, remove CTOR_COUNT stuff. Review: waterson@netscape.com 1999-10-15 06:27:02 +00:00
waterson%netscape.com a3b121502f Unclutter stuff by using nsCOMPtr in the nsElementMap::ContentListItem. Add leakenmacros to ContentListItem. Fix a leak in the the internal enumerator routine. Comment the internal enumerator routine since it's kinda funky. Add 'tag name' to the log messages. 1999-10-15 04:45:43 +00:00
hyatt%netscape.com b2a4325241 Landing re-architected command dispatcher. r=hangas(XUL/JS), saari(C++) 1999-10-14 10:58:25 +00:00
waterson%netscape.com c076e2aac8 Fix 'commandupdater' nodes; make sure that they are hooked up correctly from the XUL content sink; factor code to appropriately deal with being called from two places. r=hyatt. 1999-10-13 00:43:46 +00:00
waterson%netscape.com 9d26c76a5e Misc cleanup, r=hyatt 1999-10-08 07:26:39 +00:00
waterson%netscape.com e66ef0e374 Add elements to element map by 'ref', as well. 1999-10-08 07:26:14 +00:00
waterson%netscape.com c33474f2dd Bug 15687. Make sure to test whether CreateTemplateBuilder() succeeded before dereferencing the builder we get back. r=rjc 1999-10-07 23:07:00 +00:00
waterson%netscape.com 7324012292 Bug 13910. Make sure to update element map for XUL (as well as HTML) elements when changing 'id' or 'ref' attributes. 1999-10-07 10:09:17 +00:00
waterson%netscape.com b296404b6a Bug 13910. Make sure to add elements to the map by 'ref' attribute, as well. 1999-10-07 10:08:14 +00:00
rjc%netscape.com bb45ef1bde Add in CTOR/DTOR stuff for leak detection. Review: hyatt@netscape.com 1999-10-07 01:51:30 +00:00
vidur%netscape.com 0e75a67fe1 Added document.width/document.height to nsIDOMNSDocument. Bug 961. R: troy 1999-10-06 20:33:58 +00:00
mgleeson1%netscape.com 2e5a2e52e1 r=waterson enums used in structs must be public members for HPUX 1999-10-06 18:56:03 +00:00
waterson%netscape.com 92d627b5e0 Fix incorrect use of CBufDescriptor that was causing persistence to flake. 1999-10-06 06:42:27 +00:00
waterson%netscape.com cd0fab49cb Suppress assertions with context menus for now. 1999-10-06 06:40:06 +00:00
waterson%netscape.com 806774dd9d Fix dumb leak. 1999-10-06 01:02:11 +00:00
waterson%netscape.com de8f3449d5 Fix crasher when loading XUL in viewer and no localstore is present. 1999-10-05 22:22:40 +00:00
waterson%netscape.com 14d8b9492e Bug 15301. Remove RDF graph from XUL content model construction. Landed XUL_19991005_BRANCH; see branch comments for detailed checkin information. r=shaver,hyatt. 1999-10-05 21:13:55 +00:00
norris%netscape.com 716e97dd9c Fix 15458 "onLoadHandler does not work"
Reviewed by mstoltz.
1999-10-05 04:08:14 +00:00
rjc%netscape.com a8401f2c5c Fix bug # 15222: The composite datasource has a few operations which are somewhat "expensive". Have these behaviors on by default, but expose a method on the composite datasources so that they can be selectively turned off [for Mail/News, for example] if the capability is not needed/used (such as negative assertions). Review: waterson@netscape.com. Additional Mail/News Testing: putterman@netscape.com 1999-10-01 04:07:55 +00:00
waterson%netscape.com f002a3fe71 Fuck. These went in onto the tip and were supposed to be on the branch. Backing out. 1999-10-01 03:04:08 +00:00
waterson%netscape.com 61408ff762 Initial checkin on XUL_19990930_BRANCH, the RDF-ectomy. Single XUL documents hobbling along. 1999-10-01 03:01:22 +00:00
waterson%netscape.com 7d31268f14 Bug 13908. Add code to hook up 'forward observer declarations'. r=hyatt. 1999-09-30 02:32:34 +00:00
waterson%netscape.com e0218beabb Bug 14911. Revert sloppy checkin. The 'DocumentWillBeDestroyed' stuff was never meant to get checked in. It piggy-backed onto another bug fix; I wasn't careful. 1999-09-25 16:29:22 +00:00
waterson%netscape.com 8cda3dfecc Bug 14754. Support '.database' attribute on HTML elements. Fix ref='...' support for HTML templates. r=rjc, a=chofmann 1999-09-24 19:49:15 +00:00
law%netscape.com 3880a61e9a Fixes for context menus; a=hyatt (I just pressed the keys he told me to :-) 1999-09-22 06:27:28 +00:00
saari%netscape.com cb935f51c7 Changing broadcaster to use onbroadcast instead of oncommand. Adding the "braodcast" "commandupdate" and "input" events. Changed all xul observes nodes to use onbroadcast instead of onchange. 1999-09-21 23:02:35 +00:00
rpotts%netscape.com 452584594d The document LoadGroup is now a nsWeakPtr... 1999-09-21 06:44:56 +00:00
waterson%netscape.com 49cd3cea4d Comment out 'element already in map' warning for now. 1999-09-19 22:42:55 +00:00
waterson%netscape.com dce22b1ef1 Fix GetContentSink() to addref pointer on the way out thru XPCOM boundary. Hyatt: that's 20 XPCOM Hail Mary's for you. 1999-09-19 19:58:04 +00:00
rpotts%netscape.com f7a23e30ca Changed GetDocumentLoadGroup(...) to be XPCom complient. THis helps prevent leaks when using nsCOMPtrs. 1999-09-18 06:34:24 +00:00
waterson%netscape.com d7bc730b0d Bug 13790. Okay, let's try that again, this time without the frills. 1999-09-17 04:29:53 +00:00
waterson%netscape.com fe8d3ee23e Fix nsCOMPtr sloppiness. 1999-09-17 04:13:19 +00:00
waterson%netscape.com 6d9438412e Back out changes that will cause bustage on some compilers. 1999-09-17 04:12:08 +00:00
waterson%netscape.com bd4a3e6792 Bug 13970. Implement 'commandupdater=' attribute to hook up command udpater nodes to the XUL document's command dispatcher. Make API modifications to support command filtering. Some improvements to XUL document to factor out iteration code. 1999-09-17 04:01:46 +00:00
harishd%netscape.com 999afb72ec CreateXIF() and ToXIF() should return nsresult. 1999-09-15 17:57:55 +00:00
hyatt%netscape.com 04c56a701c Updating the nsIController interface. 1999-09-15 02:16:41 +00:00
hyatt%netscape.com 664a5ace95 Fixing minor bug in command dispatcher. 1999-09-15 02:12:50 +00:00
waterson%netscape.com 57e13eb1a7 Bug 13121. Deal with XUL documents that are created _before_ local store is available (e.g., because they come up before a profile has been selected). 1999-09-14 22:36:55 +00:00
waterson%netscape.com 06ea3cca41 Performance improvements. Make use of CBufDescriptor's where appropriate; replace attribute-based lazy bookkeeping with a private interface (non-XUL content can't be lazy, _anyway_). 1999-09-13 22:06:17 +00:00
warren%netscape.com d3eb73be23 Removed caps dependency from necko. Used nsCOMPtr for nsInputStreamChannel. 1999-09-11 18:45:36 +00:00
waterson%netscape.com 43eca09bd8 Remove SearchForNodeByID(). It's not necessary anymore now that all XUL content is build up-front. 1999-09-08 07:23:45 +00:00
waterson%netscape.com 49ac7e179a Replace nsRDFContentUtils with nsXULContentUtils, which can be acquired as a service. This allows it to keep cached member variables to other frequently-accessed services. 1999-09-07 02:51:13 +00:00
bruce%cybersight.com 4921b1d83b Use nsAllocator for char* data. 1999-09-04 13:59:52 +00:00
waterson%netscape.com 7a6584f998 Put the local store _first_, so that any persisted changes are picked up before default content. 1999-09-03 08:57:42 +00:00
waterson%netscape.com 2239643aca Persistence, again. 1999-09-03 07:02:25 +00:00
waterson%netscape.com 2d4a0bffa0 Replace calls to nsRDFContentUtils::MakeElementURI() with MakeElementResource(), which is what we wanted anyway. Tweak SplitProperty to use GetValueConst(). 1999-09-02 21:33:53 +00:00
waterson%netscape.com c1ca0ebd36 Bug 12811. Fix frame system notifications s.t. as _few_ as possible get forwarded through to layout. Temporarily remove timer hacks from tree widget. 1999-08-31 06:40:41 +00:00
waterson%netscape.com 6e2ab0076d Content model whackage. Remove all code that tried to keep the graph in sync with DOM changes. Regenerate JS from newer idlc compiler. Fix bug 12177. Fix miscellaneous breakage with templates. 1999-08-30 02:45:54 +00:00
norris%netscape.com d8507f844e * clean up nsScriptSecurityManager
* remove nsJSSecurityManager
* save principals in nsIChannels and nsIDocuments
1999-08-29 21:58:42 +00:00
hyatt%netscape.com de2f28c95a Fixes to enable the command dispatcher to properly instantiate. 1999-08-27 07:54:06 +00:00
hyatt%netscape.com 49d00452b7 Changing focus tracker to be the command dispatcher. 1999-08-25 01:49:24 +00:00
harishd%netscape.com 8ef5e0bd42 Commenting out a pre-condition in EndLoad() method.
Approved by waterson.
1999-08-24 18:37:05 +00:00
hyatt%netscape.com 7fcea47026 A complete rewrite of the broadcaster/observer system. Much improved. 1999-08-21 09:08:12 +00:00
waterson%netscape.com 43c0b70372 Fix build warning. 1999-08-06 20:34:55 +00:00
waterson%netscape.com b51825bc1d Bug 8159. Fix circularity between content model builder and composite datas source (via 'observer' which now refcounts). Destruction of a XULDocumentImpl now forces builder to do out-of-band release on composite datasource. 1999-08-06 17:59:05 +00:00
waterson%netscape.com 91a8ac09e7 Land TEMPLATE_19990726_BRANCH; RDF C++ content model builder exorcism. 1999-07-27 17:20:28 +00:00
hyatt%netscape.com 52037238fa Fixing the problem where a blank space appears at the top of every XUL file. 1999-07-25 04:38:57 +00:00
troy%netscape.com 36264ba5ab Change to StartLayout(): moved call to EnableRefresh() to before the InitialReflow()
call to work around a bug in the compositor
1999-07-21 04:47:15 +00:00
warren%netscape.com bf8423a769 Changed around load group insertion/removal to happen on mozilla thread. 1999-07-20 08:46:33 +00:00
joki%netscape.com d752334449 Updating DOM event apis and changing behavior to properly respect capturing, bubbling, and cancellation methods. 1999-07-19 19:54:34 +00:00
waterson%netscape.com e55647074b Bug 6873. Performance improvements to the generic builder. The template builder now instantiates template content 'lazily' when the frame system asks for it. 1999-07-19 19:18:10 +00:00
rickg%netscape.com 23b232d248 switch to faster string search API 1999-07-19 03:29:56 +00:00
mjudge%netscape.com c0b1525970 massive checkin for selection. adjusting nsIDOMSelection api and nsIFrameSelection. many "small" changes. this is not as bad as it looks. layout will not be affected other than "getter" calls for selection. and all consumers of selection should be in good shape. 1999-07-18 02:27:19 +00:00
peterl%netscape.com 3a3725dcca clean up some string usage 1999-07-18 00:01:21 +00:00
warren%netscape.com 84bd74a4fd Big changes for Necko load groups. Things are much happier now. Now images work (on pages, but not in chrome). 1999-07-16 11:14:36 +00:00
hyatt%netscape.com 1146e0fe11 Initializing a member variable to nsnull. 1999-07-16 08:26:42 +00:00
hyatt%netscape.com 592408790f Continuing XUL overlay work. 1999-07-16 07:10:20 +00:00
waterson%netscape.com 159456c774 Don't set up the composite datasource and XUL builder until immediately before we start to layout the document; this avoids a bunch of useless OnAssert()'s getting propogated and dropped. 1999-07-16 04:03:52 +00:00
waterson%netscape.com fb0dd58baf Bug 8514. Add support s.t. 'ref=' changes will re-root a tree control (or other RDF-generated content). 1999-07-15 01:22:59 +00:00
waterson%netscape.com a475eefcf3 Bug 8318. Don't include rdf:local-store in the generic builder until we have all of the persistence issues sorted out. 1999-07-12 18:24:26 +00:00
hyatt%netscape.com e710d64d06 Fixing redraw problems on initial show of window. 1999-07-07 22:34:10 +00:00
waterson%netscape.com a3fd49276e Bug 7722. PR_LOG instead of assert when an attempt is made to create element with a bogus namespace. 1999-07-07 06:52:21 +00:00
peterl%netscape.com 39583487e8 fixed css quirk support in XUL
removed dead code
1999-07-07 01:17:21 +00:00
hyatt%netscape.com 5101e52906 Trying to fix build bustage. 1999-07-06 18:53:41 +00:00
hyatt%netscape.com 29aef8ae97 Will do intrinsic sizing when the window is really small (doesn't have to be
0, since Linux barfs on that).
1999-07-05 16:54:14 +00:00
hyatt%netscape.com 73b08a974d Checking in support for intrinsic sizing of chrome. 1999-07-04 04:09:54 +00:00
hyatt%netscape.com a14d2e671e Making sure the default scrolling behavior for a webshell in XUL is
OVERFLOW_HIDDEN always.  Scrolling behavior set on the box itself
can be used to enable scrolling.
1999-07-02 05:29:18 +00:00
hyatt%netscape.com fa48a0b102 Fixing StartLayout so that it asserts and leaves the function if no root
content is available.
1999-07-01 07:34:19 +00:00
pinkerton%netscape.com 358bcc130a Changing CreatePopup to return the popup. Adding a bunch of stuff for tooltips to the popup code. Fixing some bugs in webshell with loading malformed popups. Renamed "popup" to "popupElement" in the document and added "tooltipElement" as well. 1999-07-01 00:07:41 +00:00
nisheeth%netscape.com 6e140506a0 Adding the architecture for an external transformation engine to hook into Raptor's layout process. One way this architecture can be used is for doing XSL transforms using a 3rd party component that implements the XSL processor. More details will be posted in mozilla.layout.
Currently enabled on windows only.  Set MOZ_XSL to 1 in your environment and build mozilla/layout.
1999-06-28 14:12:07 +00:00
warren%netscape.com fbd6d1dc57 Necko ifdefs for layout and rdf. 1999-06-26 06:36:26 +00:00
warren%netscape.com 32d4f24430 Changed URLGroup to LoadGroup 1999-06-25 02:31:51 +00:00
warren%netscape.com 4001aade80 Renamed nsIURLGroup to nsILoadGroup in preparation for necko. 1999-06-25 02:17:37 +00:00
waterson%netscape.com b6f0320775 Fix use of nsString with nsAutoString where appropriate. 1999-06-24 21:19:02 +00:00
waterson%netscape.com 4b1f9242e4 Land RDF_19990617_BRANCH. Add Change() and Move() methods to nsIRDFDataSource; add OnChange() and OnMove() methods to nsIRDFObserver. Factor nsIRDFDatasource::Init() and ::Flush() into nsIRDFRemoteDataSource. Change ownership model s.t. a datasource reference counts its observers. 1999-06-24 00:22:58 +00:00
warren%netscape.com 1f76168d21 Renamed nsIURL to nsIURI in preperation for necko. More NECKO ifdefs too. 1999-06-23 03:29:44 +00:00
valeski%netscape.com e23b3c673c NECKO ifdef (ifdef'd _off_ by default) this checkin should not impact anything. checkin approved. If someone runs into a problem, call me at 303.546.0061. 1999-06-18 17:34:08 +00:00
waterson%netscape.com ae793413a5 Fix incorrect use of dont_QueryInterface() with dont_AddRef(). Use nsCOMPtr in broadcast hookup code. 1999-06-12 19:33:37 +00:00
waterson%netscape.com 1715e9d49e Don't rely on rdf_PossiblyMake[Relative|Absolute](); rather, use XUL-specific functions to do it. 1999-06-09 08:30:47 +00:00
hyatt%netscape.com 45176e2d9e Adding new idl. 1999-06-08 21:58:32 +00:00
hyatt%netscape.com 38639ff1bc Fixes for several bugs. 1999-06-04 22:05:47 +00:00
alecf%netscape.com fb914c4e6d oops, forgot to make this native code for C++ 1999-06-03 20:47:09 +00:00
alecf%netscape.com a91815677d add XPIDL stubs for these DOM objects so that we can access them from XPConnect 1999-06-03 04:39:14 +00:00
hyatt%netscape.com e95b75d902 Focus tracker actually tracks! 1999-05-28 22:55:10 +00:00
hyatt%netscape.com cfd6d1f384 Adding the focus tracker to the XUL document. 1999-05-28 20:24:58 +00:00
waterson%netscape.com 246d4762ab Bug 6895. Create HTML elements (not XUL elements) when the tag is in the HTML namespace. Minor performance enhancements to reduce number of calls to layout during content model construction. 1999-05-28 11:30:59 +00:00
hyatt%netscape.com 736192ee1b Implementing document and window capture in the XUL DOM. 1999-05-27 21:03:59 +00:00
peterl%netscape.com 7d7fd6b8dd tweaks to CSS loader usage 1999-05-26 23:42:29 +00:00
hyatt%netscape.com cec22bc0a9 Better fix for 6746. 1999-05-25 00:29:55 +00:00
hyatt%netscape.com 5cca8d81b3 Fixes for bugs 6746 and 6747. Approved by chofmann@netscape.com. 1999-05-20 06:39:37 +00:00
waterson%netscape.com 80334ce89a Implement nsIDOMNSDocument properly. Factor logic for createElement & createElementWithNamespace. 1999-05-19 04:28:40 +00:00
peterl%netscape.com 9bc56b4862 fixed ambiguous cast for nsCOMPtr on linux 1999-05-19 00:05:40 +00:00
peterl%netscape.com 3faa8b3b5c added css loader support
fixed document observer calls
1999-05-18 23:02:00 +00:00
hyatt%netscape.com 2ce85ee0fa Disabling the cloned style sheets. This is causing trouble. Will probably have
to force them to be reparsed.
1999-05-18 10:21:11 +00:00
hyatt%netscape.com 0b3f6c19ea Fixes. 1999-05-18 09:28:00 +00:00
hyatt%netscape.com 6c62cd6df5 Oh yeah, baby. 1999-05-18 09:03:53 +00:00
hyatt%netscape.com 02eabdf348 Popup listener knows how to be a blur listener. 1999-05-18 08:37:41 +00:00
hyatt%netscape.com f42e39e419 Typo. 1999-05-18 07:42:31 +00:00
hyatt%netscape.com 6810f55bd3 Working on popup documents. 1999-05-18 07:40:59 +00:00
hyatt%netscape.com 7d4f43e0f9 La la la. 1999-05-16 09:40:42 +00:00
hyatt%netscape.com d5f2bd61ce More popup work. 1999-05-16 09:09:00 +00:00
hyatt%netscape.com a48945c0a3 Fixing build bustage 1999-05-16 08:50:27 +00:00
hyatt%netscape.com 4c5b8bc7ed Added the method that will give me the new popup doc. 1999-05-16 08:05:32 +00:00
hyatt%netscape.com 19ffc42c57 Implementing HandleDOMEvent in nsXULDocument.cpp. Events now bubble to the
document and in turn will now bubble to the window.
1999-05-16 07:05:51 +00:00
hyatt%netscape.com e0323b8d8a Added support for document.popup, so that event handlers in popup content
can refer to the popup's originating element.
1999-05-15 08:46:14 +00:00
warren%netscape.com 87b26617d5 Fixed nsICollection (and Count in particular) to be xpidl friendly. 1999-05-13 04:56:04 +00:00
vidur%netscape.com 6d2292083f Added GetContentType method to nsIDocument interface. 1999-05-11 20:22:52 +00:00
rjc%netscape.com 53b2c8b4e9 Add refcnt'ing support in Element map for content nodes. (Not 100% if this is the right thing to do, but it does fix a crashing bug where the nodes are freed too early!) 1999-05-08 10:29:24 +00:00
waterson%netscape.com 8d3ff0f53b Factor interfaces into individual .idl files. 1999-05-05 03:09:50 +00:00
hyatt%netscape.com e4b0beec4c Switching over to nsIEventQueues. Adding support for onunload, onabort, and
onerror.  Adding support for event capturing through script.  Adding support
for robust error-checking in the chrome registry.
1999-05-04 23:32:25 +00:00
pinkerton%netscape.com 1680448437 pinkerton/scc. appr chofmann. Bug #4127, et al. Fixing ownership models (more work to come). 1999-04-30 09:04:36 +00:00
waterson%netscape.com 99ad51582d Bug 5490 et al. Don't include local store in XUL document composite datasource until we have XUL syntax for deciding what attributes and elements are shared. r=hyatt, a=chofmann 1999-04-28 20:46:53 +00:00
waterson%netscape.com 5808d55c70 Fixed the text of a debug log message. 1999-04-28 04:19:28 +00:00
ftang%netscape.com 2e97bf7dcc change S/GetDocumentCharacterSet method for nsIDocument interface. 1999-04-27 21:49:25 +00:00
waterson%netscape.com 3f3dced3eb Land RDF_19990426_BRANCH, which extracted some static C++ routines for manipulating RDF containers into bona fide interfaces. Also, fix a memory leak in the nsElementMap: be sure to hold a reference to the resource that is the key. 1999-04-27 05:53:53 +00:00