Alexandre Poirot
92a0d9b020
Bug 1833584 - [devtools] Copy JS stacktrace when creating bugs from app boundary error. r=devtools-reviewers,bomsy
...
Differential Revision: https://phabricator.services.mozilla.com/D178291
2023-05-22 10:01:01 +00:00
Hubert Boma Manilla
065102493d
Bug 1832019 - [devtools] Enable blackbox lines by default r=devtools-reviewers,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D178032
2023-05-21 18:09:02 +00:00
Hubert Boma Manilla
b77fe13f82
Bug 1832510 - [devtools] Update source map package in MC r=devtools-reviewers,ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D177734
2023-05-21 18:09:02 +00:00
Mark Banner
2a53076d43
Bug 1826063 - Automatic fixes for enabling Prettier on production xhtml and html files. r=mossop,webdriver-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,fxview-reviewers,sgalich,nalexander,devtools-reviewers,sclements,denschub,robwu,owlish
...
Differential Revision: https://phabricator.services.mozilla.com/D177938
2023-05-20 12:26:56 +00:00
Mark Banner
4e94d55741
Bug 1826063 - Tidy up devtools production html files before formatting. r=bomsy
...
Differential Revision: https://phabricator.services.mozilla.com/D178354
2023-05-20 12:26:55 +00:00
Mark Banner
730da94f3a
Bug 1826062 - Manual fixes for Prettier 2.8.8 upgrade. r=mossop,webdriver-reviewers,extension-reviewers,devtools-reviewers,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D177908
2023-05-20 12:26:55 +00:00
Mark Banner
130a655906
Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
...
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner
c987af1ae4
Bug 1826062 - Manual fixes for Prettier 2.0.5 upgrade. r=mossop,devtools-reviewers,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D177907
2023-05-20 12:26:52 +00:00
Mark Banner
8219a5c503
Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
...
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Hubert Boma Manilla
116486a521
Bug 1828647 - [devtools] Stop automatically unblackboxing a source when a breakpoint is added to a blackboxed source r=devtools-reviewers,nchevobbe
...
There is a bit of complexity around blackboxing, let's avoid side effects based of blackboxing.
#### Highlights of this patch
- This removes auto unblackboxing a source when a breakpoint is added. This should also fix Bug 1828585.
This will benefit the work around blackboxing sources on the x_google_ignoreList.
- Breakpoints created on ignored lines or in an ignored source are disabled by default
- Breakpoints are disabled once the line it is on gets ignored.
- Disabled breakpoints on ignored lines cannot be enabled until the line is unignored.
- Disabled breakpoints are enabled once the line is unignored.
Differential Revision: https://phabricator.services.mozilla.com/D177459
2023-05-19 15:38:36 +00:00
Katherine Patenio
ac4145f34d
Bug 1830419 - Convert PanelMutiView.jsm and CustomizableUITestUtils.jsm in browser/components/customizableui to ESMs r=search-reviewers,Standard8,devtools-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D178362
2023-05-18 18:34:51 +00:00
Iulian Moraru
170aaf5bb7
Backed out changeset bbb3bbd9b6af (bug 1830679) for causing dt failures on browser_storage_cache_delete.js. CLOSED TREE
2023-05-18 22:09:25 +03:00
Itiel
076aaf6671
Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane
...
Differential Revision: https://phabricator.services.mozilla.com/D176791
2023-05-18 17:19:45 +00:00
Pushpanjali
235f25ea9c
Bug 1822010 - Convert toolkit/components/url-classifier to ES modules. r=perftest-reviewers,webcompat-reviewers,geckoview-reviewers,devtools-reviewers,twisniewski,valentin,m_kato,anti-tracking-reviewers,timhuang,sparky
...
Differential Revision: https://phabricator.services.mozilla.com/D173390
2023-05-18 12:21:12 +00:00
Morgan Rae Reschenberg
e01e490415
Bug 1832000: Avoid checking non-interactive elem for interative semantics r=Jamie,devtools-reviewers,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D178248
2023-05-17 21:54:38 +00:00
Alexandre Poirot
e12a180909
Bug 1832081 - [devtools] Fix SourceTree icons always matching the currently selected source. r=devtools-reviewers,nchevobbe
...
Prevent using the exact same icon for all sources matching the currently selected one,
instead make it specific to each displayed source.
Differential Revision: https://phabricator.services.mozilla.com/D178015
2023-05-17 15:13:00 +00:00
Butkovits Atila
f3122de866
Backed out changeset fa170b66896e (bug 1832081) for causing Talos failures at browser-toolbox.js. CLOSED TREE
2023-05-18 03:15:46 +03:00
Alexandre Poirot
960da7edbe
Bug 1832081 - [devtools] Fix SourceTree icons always matching the currently selected source. r=devtools-reviewers,nchevobbe
...
Prevent using the exact same icon for all sources matching the currently selected one,
instead make it specific to each displayed source.
Differential Revision: https://phabricator.services.mozilla.com/D178015
2023-05-17 15:13:00 +00:00
Alexandre Poirot
2ca95198a2
Bug 1829640 - [devtools] Memoize getVisibleBreakpointPositions selector by using createSelector. r=jdescottes,devtools-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D177881
2023-05-17 12:59:19 +00:00
David Shin
9333fde7cf
Bug 1809568 - Part 1: Implement parsing for `baseline-source`. r=emilio,devtools-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D173884
2023-05-17 12:56:53 +00:00
Nicolas Chevobbe
3d0c4ffa20
Bug 1832810 - [devtools] Tweak style of MDN links in Compatibility panel. r=jdescottes,devtools-reviewers.
...
We make the link underlined, and we display a mdn icon next to it.
Differential Revision: https://phabricator.services.mozilla.com/D177912
2023-05-17 05:26:31 +00:00
Sandor Molnar
71c2b3db49
Backed out 3 changesets (bug 1809568) for causing build bustages in layout/generic/nsLineLayout.cpp CLOSED TREE
...
Backed out changeset 6c5bbcbafce9 (bug 1809568)
Backed out changeset b518133a5c34 (bug 1809568)
Backed out changeset 2407088e9b49 (bug 1809568)
2023-05-17 01:34:42 +03:00
David Shin
5f07daa337
Bug 1809568 - Part 1: Implement parsing for `baseline-source`. r=emilio,devtools-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D173884
2023-05-16 20:48:17 +00:00
Sandor Molnar
a50a2052fe
Backed out 3 changesets (bug 1809568) for causing node devtools failures in devtools/client/debugger/src/components/test/QuickOpenModal.spec.js CLOSED TREE
...
Backed out changeset 56ce741da8f5 (bug 1809568)
Backed out changeset 5a91ce4870e4 (bug 1809568)
Backed out changeset cc00422f050a (bug 1809568)
2023-05-16 22:22:31 +03:00
David Shin
9e3157e78c
Bug 1809568 - Part 1: Implement parsing for `baseline-source`. r=emilio,devtools-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D173884
2023-05-16 19:02:10 +00:00
Alexandre Poirot
edb0a32d82
Bug 1832567 - [devtools] Avoid using await for synchronous actions. r=devtools-reviewers,bomsy
...
Actions are dispatched synchronously by default, unless we dispatch an thunk action,
which may be asynchronous (but not always); or for action using "promise" attribute
which is made asynchronous by a middleware.
Differential Revision: https://phabricator.services.mozilla.com/D178013
2023-05-16 17:39:30 +00:00
Alexandre Poirot
770dd56daa
Bug 1832567 - [devtools] Stop using source.thread which no longer exists. r=devtools-reviewers,bomsy
...
This attribute has been removed since we moved to breakpoints per URL.
Differential Revision: https://phabricator.services.mozilla.com/D177781
2023-05-16 17:39:30 +00:00
Alexandre Poirot
70d1127a22
Bug 1832567 - [devtools] Clear breakpoints correctly on thread removal. r=devtools-reviewers,bomsy
...
Unfortunately, breakpoints aren't bound to a particular thread.
Instead they are bound to the source were the breakpoint is set.
Also sources aren't bound to a particular thread, this is especially true
when we are against an original source which may be used in distinct threads.
So let's use the sources list dispatched on REMOVE_THREAD to identify
the breakpoint to remove when a thread is removed.
Differential Revision: https://phabricator.services.mozilla.com/D177780
2023-05-16 17:39:30 +00:00
Alexandre Poirot
4a84d20f42
Bug 1767760 - [devtools] Ignore workers in invalid state. r=devtools-reviewers,nchevobbe
...
It isn't clear why the isDestroyed check isn't enough.
(Note that target and worker are the same object for workers)
But let's ignore workers with null names.
Differential Revision: https://phabricator.services.mozilla.com/D178014
2023-05-16 15:25:33 +00:00
Jon Coppeard
e9379365f8
Bug 1832267 - Make tests that check the sizes of JSObjects less strict r=jandem,devtools-reviewers,nchevobbe
...
The problem is that setting unique IDs on objects can increase their size and
this makes it hard to write exact tests.
This reverts my previous attempt to make the exact checks work and instead
makes them more forgiving.
Differential Revision: https://phabricator.services.mozilla.com/D178042
2023-05-16 12:27:28 +00:00
Julian Descottes
8f1c47f814
Bug 1767776 - [devtools] Wait for the property to be ready in browser_styleinspector_context-menu-copy-urls.js r=devtools-reviewers,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D178079
2023-05-16 07:05:51 +00:00
Nicolas Chevobbe
f92a6be70e
Bug 1660081 - [devtools] Tweak browser icons color in compatibility tooltip in dark mode. r=jdescottes,devtools-reviewers.
...
The tooltip background is lighter than the regular panel background,
which made the icons not contrasted enough.
Differential Revision: https://phabricator.services.mozilla.com/D177918
2023-05-16 05:15:44 +00:00
Nicolas Chevobbe
5f95367c14
Bug 1830012 - [devtools] Add version number below unsupported icon. r=jdescottes.
...
We are also moving the title that was set on the whole unsupported browser list
to the individual unsupported browser item, where we display the unsupported
versions from that specific browser.
Tests are updated accordingly.
Differential Revision: https://phabricator.services.mozilla.com/D176503
2023-05-16 05:15:44 +00:00
Nicolas Chevobbe
aa46f10520
Bug 1830013 - [devtools] Import compatibility.css in tooltip.css. r=jdescottes.
...
Put it in a layer so it gets a lower priority, to prevent selector clashes.
Differential Revision: https://phabricator.services.mozilla.com/D176502
2023-05-16 05:15:44 +00:00
Nicolas Chevobbe
c083fc8105
Bug 1830010 - [devtools] Use proper private methods and attributes in CssCompatibilityTooltipHelper. r=jdescottes.
...
Differential Revision: https://phabricator.services.mozilla.com/D176501
2023-05-16 05:15:44 +00:00
Cristian Tuns
4d57ea669d
Backed out 3 changesets (bug 1809568) for causing build bustages on nsLineLayout.cpp CLOSED TREE
...
Backed out changeset e862b1560caa (bug 1809568)
Backed out changeset 0a20b91de67b (bug 1809568)
Backed out changeset 6060fc7d49d4 (bug 1809568)
2023-05-15 13:03:03 -04:00
David Shin
40fa43a69d
Bug 1809568 - Part 1: Implement parsing for `baseline-source`. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D173884
2023-05-15 14:34:25 +00:00
Hubert Boma Manilla
1e4fe4e4c7
Bug 1824703 - [devtools] Add context menu item to hide / show ignored files r=nchevobbe,devtools-reviewers,bolsson
...
This patch adds a setting to hide / show all the ignored files
This is persisted across restarts of the toolbox.
Also if a file is ignored after the ignored files are hidden, the newly ignored file will
automatically disappear from tree list, so added a notification in the footer letting the user know that ignored files are currently hidden.
Differential Revision: https://phabricator.services.mozilla.com/D174476
2023-05-15 12:54:52 +00:00
Nicolas Chevobbe
a7ab28c728
Bug 1548662 - [devtools] Add test for pretty printing and navigating the call stack. r=ochameau,devtools-reviewers.
...
Differential Revision: https://phabricator.services.mozilla.com/D178008
2023-05-15 09:07:04 +00:00
Nicolas Chevobbe
bff321d727
Bug 1831302 - [devtools] remove unused debugger .stylelintrc and .stylelintignore. r=Gijs,devtools-reviewers,ochameau.
...
Differential Revision: https://phabricator.services.mozilla.com/D177910
2023-05-15 08:35:12 +00:00
Nicolas Chevobbe
e1ac3b19d8
Bug 1828026 - [devtools] Bail in ConsoleMessageWatcher#watch if passed frame target has a null window. r=jdescottes,devtools-reviewers.
...
Differential Revision: https://phabricator.services.mozilla.com/D177902
2023-05-15 05:08:28 +00:00
Alexandre Poirot
751ac3b42c
Bug 1832563 - [devtools] Fix typo introduced in bug 1822302. r=devtools-reviewers,nchevobbe
...
This attribute name changed during the review and I forgot to rename it in a later patch.
Differential Revision: https://phabricator.services.mozilla.com/D177779
2023-05-12 18:47:12 +00:00
Stanca Serban
23745be172
Backed out 2 changesets (bug 1830013, bug 1830010) for causing devtools failures in browser_parsable_css.js. CLOSED TREE
...
Backed out changeset dd5f418f4979 (bug 1830013)
Backed out changeset 799e3982cc8e (bug 1830010)
2023-05-12 18:50:12 +03:00
Nicolas Chevobbe
1909c30473
Bug 1830013 - [devtools] Import compatibility.css in tooltip.css. r=jdescottes.
...
Put it in a layer so it gets a lower priority, to prevent selector clashes.
Differential Revision: https://phabricator.services.mozilla.com/D176502
2023-05-12 14:28:37 +00:00
Nicolas Chevobbe
ffacd67c05
Bug 1830010 - [devtools] Use proper private methods and attributes in CssCompatibilityTooltipHelper. r=jdescottes.
...
Differential Revision: https://phabricator.services.mozilla.com/D176501
2023-05-12 14:28:37 +00:00
Alexandre Poirot
814f8e4d4f
Bug 1634721 - [devtools] Preserve selected source context (original vs generated), even when stepping through non-source-mapped code. r=devtools-reviewers,bomsy
...
(Also removing source argument on the action as it is redundant with location.source)
Differential Revision: https://phabricator.services.mozilla.com/D176899
2023-05-12 11:34:35 +00:00
Alexandre Poirot
2df4ffe04b
Bug 1825511 - [devtools] Log JavaScript traces to stdout with hyperlinks and handle them in firefox startup. r=nchevobbe,devtools-reviewers
...
The JavaScript tracer will log special format of links, including a precise location,
by appending `@${line}:${column}` to each frame's source's URL.
This URL pattern is later interpreted by DevTools command line handler in order
to automatically open the source's location in the debugger.
Differential Revision: https://phabricator.services.mozilla.com/D174098
2023-05-12 11:33:27 +00:00
Tooru Fujisawa
76c72072ba
Bug 1820951 - Part 2: Add tests. r=nchevobbe,devtools-reviewers
...
Depends on D175093
Differential Revision: https://phabricator.services.mozilla.com/D177613
2023-05-12 06:21:41 +00:00
Tooru Fujisawa
ce97c68a02
Bug 1820951 - Part 1: Implement DevToolsUtils.hasSafeGetter based on explicit allowlist and DebuggerObject.prototype.isNativeGetterWithJitInfo. r=nchevobbe,devtools-reviewers
...
Perform the same test as `nativeIsEagerlyEvaluateable` in `hasSafeGetter`.
Differential Revision: https://phabricator.services.mozilla.com/D175093
2023-05-12 06:21:41 +00:00
Tooru Fujisawa
c6cba3b9c2
Bug 1815381 - Part 4: Add tests with random native getters. r=nchevobbe,devtools-reviewers,ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D175092
2023-05-12 06:21:41 +00:00