The existing task's outcome is best achieved with a special purpose
build task, so here it is.
MozReview-Commit-ID: 3gYnAb69TdK
--HG--
rename : mobile/android/config/mozconfigs/android-api-15-frontend/nightly => mobile/android/config/mozconfigs/android-api-15-gradle-dependencies/nightly
rename : mobile/android/config/tooltool-manifests/android-frontend/releng.manifest => mobile/android/config/tooltool-manifests/android-gradle-dependencies/releng.manifest
extra : rebase_source : 252c283553d64bac17c2b922773023a349c297ea
extra : histedit_source : 2d8becbcdfa5d37829552e55b50fb7f9cbf56dea
This is a version produced locally from
1d07987217.
I used |./gradlew install| and then copied the pieces out of ~/.m2/repository.
Local builders should never download using this plugin, since |mach configure|
ensures that all the relevant pieces can already be found. It's just useful in
automation; and as an eventual replacement for chunks of |mach bootstrap|.
MozReview-Commit-ID: 9JiFe0xLr99
--HG--
extra : rebase_source : 5bbe5ada7fce0d3e8a702a09da7ff70fd639dc67
extra : histedit_source : aa7049abefafd652b0db2bd03ab15310967e0ad0
The alternative is to define an interface and two conditional
implementations, and then build only one depending on MOZ_ANDROID_GCM.
That's what we did for Adjust, and it works; but it's awkward here
because the the PushService code is truly part of the browser, and the
conditional code is compiled very early (much earlier than the
browser). (The Adjust library was built even earlier than the
existing conditional code, so this wasn't an issue.) To work around
this, we'd want to add conditional code to the main browser, which
complicates the build. This is expedient until we get to a proper
dependency injection scheme (for example, Dagger).
MozReview-Commit-ID: 18usWz8oC3B
An alternative implementation may have re-used TwoLinePageRow by disabling some
views. Disabling views is messy so I opted not to do that but I didn't realize
we needed to add favicons to the view so this may end up occurring in bug
1252309 anyway.
MozReview-Commit-ID: DOrvYryYYP4
--HG--
extra : rebase_source : b80c15427ead8a1557a9c9dc878da82b3d9d491c
Modifying the Bookmarks Adapter & wrapped Cursor felt all-over-the place so I'm
concerned the resulting code may be fragile. However, I can't see a better
solution off the top of my head, meaning it's probably not worth the time to
improve.
MozReview-Commit-ID: QgnsMQ3smB
--HG--
extra : rebase_source : 126b32720da759f68f65a57cee8fa173cdf5cbbf
HttpUrlConnection supports SNI and LoadFaviconTask does not require fancy HTTP features.
MozReview-Commit-ID: IuDyU4xk7qI
--HG--
extra : rebase_source : 5762fc17ae513cfac9dbba825ad2d7b85857e695
Otherwise we'll receive
"android.database.sqlite.DatabaseObjectNotClosedException: Application did not close the cursor or database object that was opened here"
on shutdown.
MozReview-Commit-ID: Dq0ikutJDNd
--HG--
extra : rebase_source : 6b9b54d9ce9519e90dd35733513973da3f391634
This should help us spot if we ever upload a misnamed test DB.
MozReview-Commit-ID: B0vJuEeyrS8
--HG--
extra : rebase_source : 8d050c54a7ccbf6df95f7d101cc691a99f5d7d7f
Carsten "Tomcat" Book
Ting-Yu Lin
Geoff Brown
Nick Alexander
Krishna
cijo
Margaret Leibovic
Jalpreet Singh Nanda
Barbara Bermes
Maurya Talisetti
Marco Castelluccio
Wes Kocher
Mark Hammond
Mike Taylor
Michael Comella
Christoph Kerschbaumer
Sebastian Kaspari
Chenxia Liu
Brendan Dahl
malayaleecoder
Andrzej Hunt