The "select" event handler workaround was originally added in bug 1379270 to make it
possible to focus and select the URL bar a little bit later. This ugly hack was to
workaround an issue with WebExtensions that override about:newtab with the
chrome_url_overrides property (the issue would be that the URL bar would not be
properly focused and selected if about:newtab was overridden).
Back in the day, this was necessary because the overriding URL was fully displayed
in the URL bar (moz-webextension://...). These days, when about:newtab is overridden,
the URL bar is still empty - we just end up showing the information about the
WebExtension overriding about:newtab to the left of the URL bar.
So I think we can remove the old workaround.
Differential Revision: https://phabricator.services.mozilla.com/D3447
--HG--
extra : moz-landing-system : lando
For some reason we might miss the initial focus event. This ensures the video
element is focused when the document loads.
Differential Revision: https://phabricator.services.mozilla.com/D3444
--HG--
extra : moz-landing-system : lando
Summary:
Mike DeBoer correctly noted in a comment at https://bugzilla.mozilla.org/show_bug.cgi?id=254592 that enabletimeout is no longer used and should be removed. I updated the timeout logic to treat a zero or negative value as effectively "no automatic timeout" for the quick-find dialog (otherwise, setting the timeout value to a small or negative value makes the feature unusable).
This is a corollary to the bugfix at https://phabricator.services.mozilla.com/D3404 ; I've split it out into a separate patch to avoid confusing that issue.
Update: this specific issue already had its own bug at https://bugzilla.mozilla.org/show_bug.cgi?id=260562, and another mention at https://bugzilla.mozilla.org/show_bug.cgi?id=265915 .
Reviewers: kmag
Reviewed By: kmag
Bug #: 260562
Differential Revision: https://phabricator.services.mozilla.com/D3504
--HG--
extra : rebase_source : 1c2b73d6af1343d536a2380dee784f8ea2339b61
extra : amend_source : cc00a2398b2c478003e842b4dc9b99bf53af6824
This crash happens because nsVideoFrame didn't know what to do with two
children in the UA Widget Shadow Root.
The two children are both videocontrols, with the first one being the lingering
DOM inserted by first constructor call that throws.
The subsequent appendChild of the same element caused the videocontrols
to be initialized again, since the previous run didn't return a widget
instance to UAWidgetsChild.
The fix here removes the throw statement added in
https://hg.mozilla.org/mozilla-central/rev/dca187f7c72c#l3.15 ,
allowing the constructor to complete.
Without this statement, we will rely on assertion in the test here
https://hg.mozilla.org/mozilla-central/rev/4ddca5eb06c2#l2.18
to fail on slower platforms to ensure the stylesheet is loaded synchronously.
An alternative fix would be to wrap up the contructor in a try catch block
from UAWidgetsChild and make sure the DOM is cleaned up when the constructor
throw. That however will hide the error thrown so I decided to remove the throw
statement instead.
Differential Revision: https://phabricator.services.mozilla.com/D3560
--HG--
extra : moz-landing-system : lando
Set SheetLoadData::mSyncLoad to true when the link element is in a UA Widget.
MozReview-Commit-ID: 2NPSJnL0rKl
--HG--
extra : rebase_source : 9af8c7add41b39f6eb8e3ac02dbefb9607b905f9
For elements with an animationProp, always set its hidden state from the
startFade() method, so the reverse-direction animation can be correctly
cancelled.
Additionally, considers elements with "fadeout" class as hidden,
so other states can be toggled correctly.
This patch fixes intermittent failures on slower platforms, and perma-orange
on Windows.
MozReview-Commit-ID: KgQXaryEHad
--HG--
extra : rebase_source : b2c7eb81110bf2a55820460cfc24b3418fd4bbdb
Also removing unremoved <xul:slider> properties and workarounds.
MozReview-Commit-ID: 8JrcDyDOBWS
--HG--
extra : rebase_source : ebd8c3af91d07769ab2d71e8ac9be541e7fae68f
This is documented throughly in bug 448909 comment 79.
It is no longer needed for our current setup.
MozReview-Commit-ID: 9XWCqGUYHW4
--HG--
extra : rebase_source : 7d8e042d2e11704b68fb42ea14b421d9eada4abb
Acknowledge the control bar hidden behavior caused by the bug.
Also, set the cursor state before early return, because the video might not
be in the same fullsreen state the last time control bar is hidden/shown.
MozReview-Commit-ID: 3oN3r8dsUvH
--HG--
extra : rebase_source : 34a95e9d5ddfd8abb96adde452858e4b7acb4946
The DOM elements within the UA Widget Shadow DOM should have its reflectors in
the UA Widget Scope. This is done by calling nsINode::IsInUAWidget() which
would check its containing shadow and its UA Widget bit.
To prevent JS access of the DOM element before it is in the
UA Widget Shadom DOM tree, various DOM methods are set to inaccessible to
UA Widget script. It would need to use the two special methods in ShadowRoot
instead to insert the DOM directly into the shadow tree.
MozReview-Commit-ID: Jz9iCaVIoij
--HG--
extra : rebase_source : b7b17be68dcde00cfeb207cb39cf16b486f2ab02
videocontrols.js handles the controls attribute with a callback named
"onattributechange" called by UAWidgets, replaces the CSS selectors.
MozReview-Commit-ID: 8rrw0Pbu8Dj
--HG--
rename : toolkit/content/widgets/videocontrols.xml => toolkit/content/widgets/videocontrols.js
extra : rebase_source : 8d8a38afac0273621f711b988c1be82d04865e33
Browsers can switch at runtime from remote to non-remote and vice versa,
which on the C++ side is detected from a XBL binding change which causes
nsIRemoteBrowser to either be implemented or not. Custom Elements can't
change at runtime in the same way, so unifying on a single [implements]
will allow browser (both remote and non-remote) to be migrated to a single
Custom Element.
To keep current functionality, this updates Qi calls into nsIRemoteBrowser
to instead Qi into nsIBrowser and check isRemoteBrowser.
Differential Revision: https://phabricator.services.mozilla.com/D3346
--HG--
extra : moz-landing-system : lando
Adds a new environment variable MOZ_BROWSER_XHTML to change Firefox to load
a modified version of browser.xul as browser.xhtml. Adds the xhtml
namespace to the script tags to make them work.
MozReview-Commit-ID: 2adtOVzXHKd
Eliza Balazs
Timothy Guan-tin Chien
Mike Conley
Csoregi Natalia
shindli
Paolo Amadini
Emilio Cobos Álvarez
spillner
Drew Willcoxon
Tiberius Oros
Matthew Noorenberghe
Andrew Swan
Brian Grinstead
Cosmin Sabou
Kris Maglione
Brendan Dahl
Kanika Saini
Andreea Pavel
Suriyaa Sundararuban