* Change to isValidNumber to allow any number length in the range. This also removes 9 as a valid payment card number length
* Amend form autocomplete test for sensitive 9 digit numbers. We no longer consider them valid cc numbers, test for 19 digit numbers instead
* Fix intermittent issue in a session restore test. It turns out Date.now().toString() can sometimes pass the Luhn algorithm and look like a valid credit card number. I believe this could lead to it being treated as sensitive data which is not saved and restored, failing the test
Differential Revision: https://phabricator.services.mozilla.com/D8271
--HG--
extra : moz-landing-system : lando
The separate Activity Stream content process is currently pref-able, and I'd like to make sure
that the tree is green with it enabled and disabled. This patch makes it so that tests that
browse from about:home/about:newtab to some other page or back work properly even if there
are process flips.
Based on work originally by Jay Lim (:imjching) <jay@imjching.com>.
Differential Revision: https://phabricator.services.mozilla.com/D8265
--HG--
extra : moz-landing-system : lando
convert webcompat-reporter to a webextension
Differential Revision: https://phabricator.services.mozilla.com/D6575
--HG--
rename : browser/extensions/webcompat-reporter/skin/lightbulb.svg => browser/extensions/webcompat-reporter/icons/lightbulb.svg
extra : moz-landing-system : lando
Summary:
Resources that aren't secure (e.g. http) can be routed over secure transports
(e.g. http/2 alt-svc, https proxies). For display purposes (the site identity
widget) we don't want to treat these as secure. Bug 1040323 addressed this exact
issue but didn't include tests. Thus, when nsSecureBrowserUIImpl was
reimplemented in bug 832834, this aspect was neglected. This time, there is a
test.
Reviewers: Gijs
Tags: #secure-revision
Bug #: 1495321
Differential Revision: https://phabricator.services.mozilla.com/D7746
--HG--
extra : rebase_source : e17ec47938f41a692b41a7cf65f1d5e4b880e8a7
extra : amend_source : c445c2f5c7eff94be027e238c2f2befc91b3905a
Switching between menu options should maintain correct main action state when window sharing is requested.
Differential Revision: https://phabricator.services.mozilla.com/D7742
--HG--
extra : moz-landing-system : lando
This removes the old TRACKING_PROTECTION_EVENTS probe and replaces it with new
Telemetry events that record basic user interaction in the identity popup.
We are now measuring interaction with more elements than before, not just block/unblock.
We're also dropping the old way of measuring updates to onSecurityChange,
since with the recent changes to content blocking it would just record most page loads.
Differential Revision: https://phabricator.services.mozilla.com/D6895
--HG--
extra : moz-landing-system : lando
This probe was always supposed to measure TP enabled status for a session, not a window.
Differential Revision: https://phabricator.services.mozilla.com/D6893
--HG--
extra : moz-landing-system : lando
Since we don't take any action in this case, we shouldn't be logging telemetry for it.
Differential Revision: https://phabricator.services.mozilla.com/D8235
--HG--
extra : moz-landing-system : lando
By hiding the documentElement with display:none and then waiting to
show it until readystatechange, we can avoid inadvertently constructing
XBL bindings as a result scripts running during parse like connectedCallback.
This more closely matches XUL document behavior, where the initial
layout doesn't happen until everything is parsed and loaded. It also
lets us call gBrowserInit.onBeforeInitialXULLayout actually before
layout happens.
Differential Revision: https://phabricator.services.mozilla.com/D8297
--HG--
extra : moz-landing-system : lando
Use a homepage URL instead of a new tab URL by default in
browser.windows.create.
Differential Revision: https://phabricator.services.mozilla.com/D6030
--HG--
extra : moz-landing-system : lando
This also requires the 64-bits rust compiler and some build system
tweaks.
And since we make the 32-bits builds cross-compiles on CI, we also need
to adjust the MSVC build mozconfigs such that the host compiler points
to the right MSVC cl. Likewise, the DIA SDK is used for host things, so
use the 64-bits version or it.
Differential Revision: https://phabricator.services.mozilla.com/D7845
--HG--
extra : moz-landing-system : lando
The sandbox blocks GetTempFileName's prior response, causing the system to end up searching a number of (inaccessible) folders to use as a replacement for the temp folder. This patch provides a path to a new folder on the command line for the plugin process. This new temp folder, specific to this plugin process instance, is then communicated to the system via the TEMP/TMP environment variables. This is similar to what is done for the content process but avoids nsDirectoryService, which doesn't exist in plugin processes.
Differential Revision: https://phabricator.services.mozilla.com/D7532
--HG--
extra : moz-landing-system : lando
Disable browser_tabclose.js for frequently failing on win32. Bug 1470280 makes this much more prevalent.
--HG--
extra : histedit_source : 487748b3e2ac76e98db0fd343536f39b9ada1f29
Check if we have permission from the OS to access the camera and microphone after the user has granted access to a site.
If permission is denied at the OS level, but granted to the site within Firefox, return NotFoundError.
Differential Revision: https://phabricator.services.mozilla.com/D5458
--HG--
extra : moz-landing-system : lando
This commit also removes dwarf-exceptions from the x64 build.
sjlj exceptions are needed on x86 because there is a bug currently involving
SEH exceptions on x86. However on x64 there is not, so we can use the
default SEH and get rid of dwarf exceptions. Additionally, to use SEH
exceptions, we need to -fuse-cxa-atexit
Differential Revision: https://phabricator.services.mozilla.com/D7759
--HG--
extra : moz-landing-system : lando
Chrome sets both KeyboardEvent.keyCode and KeyboardEvent.charCode of "keypress"
event to same value. On the other hand, our traditional behavior is, sets
one of them to 0.
Therefore, we need to set keyCode value to charCode value if the keypress
event is caused by a non-function key, i.e., it may be a printable key with
specific modifier state and/or different keyboard layout for compatibility
with Chrome. Similarly, we need to set charCode value to keyCode value if
the keypress event is caused by a function key which is not mapped to producing
a character.
Note that this hack is for compatibility with Chrome. So, for now, it's enough
to change the behavior only for "keypress" event handlers in web content. If
we completely change the behavior, we need to fix a lot of default handlers
and mochitests too. However, it's really difficult because default handlers
check whether keypress events are printable or not with following code:
> if (event.charCode &&
> !event.altKey && !event.ctrlKey && !event.metaKey) {
or
> if (!event.keyCode &&
> !event.altKey && !event.ctrlKey && !event.metaKey) {
So, until we stop dispatching "keypress" events for non-printable keys,
we need complicated check in each of them.
And also note that this patch changes the behavior of KeyboardEvent::KeyCode()
when spoofing is enabled and the instance is initialized by initKeyEvent() or
initKeyboardEvent(). That was changed by bug 1222285 unexpectedly and keeping
the behavior makes patched code really ugly. Therefore, this takes back the
old behavior even if spoofing is enabled.
Differential Revision: https://phabricator.services.mozilla.com/D7974
--HG--
extra : moz-landing-system : lando
I have not changed the entity names since the meaning of the strings has not changed.
Differential Revision: https://phabricator.services.mozilla.com/D8262
--HG--
extra : moz-landing-system : lando
QueryFullProcessImageNameW may fail in some environments when dwFlags is zero
due to NT-to-DOS path conversions. CreateFile will convert the argumant back to
an NT path anyway.
--HG--
extra : source : 54778cf89825c24f656fcf8ebcef5aa3bf4e6839
extra : intermediate-source : b40d295b3c43d5cffa453bc0536af2bada4eeac2
This increases the default amount of content processes on nightly to 8. It
is nightly only and will not ride the trains.
--HG--
extra : rebase_source : 54bfae28921240d985957d59bf64ca91bd6a0f19
extra : intermediate-source : 72e7ef77480d0845ceabb5d3747a5523db6bda9d
extra : source : d5375325488f449c45dd032bc8167ebebca07497
This updates the test to use a multiple of the default process count rather
than hardcoding 8.
--HG--
extra : rebase_source : b5d7d34b4994ea7e2e453ec833f218919146636f
extra : source : 403c3d0daf6a24a7bb21e9f8ca2493cb4956fb4c
browser_preferences_usage.js hardcodes a max value of 15 accesses which doesn't scale well as we increase the number of processes. Instead we'll base the max on a multiplier of the default process count which should avoid bustage in the future but still catch egregious accesses.
--HG--
extra : rebase_source : 5484be4833dfc220126f893c722c793e7be93ed1
extra : source : 60699c2387f6e51398c345996a97551a867bd2d7
This increases the default amount of content processes on nightly to 8. It
is nightly only and will not ride the trains.
--HG--
extra : rebase_source : a39b9aa36e10e18b8c8e050d69d639178b6f1a5a
extra : source : d5375325488f449c45dd032bc8167ebebca07497
This updates the test to use a multiple of the default process count rather
than hardcoding 8.
--HG--
extra : rebase_source : 2aa15de90a58e38e480aca5e10f0b680820ecb2c
browser_preferences_usage.js hardcodes a max value of 15 accesses which doesn't scale well as we increase the number of processes. Instead we'll base the max on a multiplier of the default process count which should avoid bustage in the future but still catch egregious accesses.
--HG--
extra : rebase_source : 9c047b27b6d7a2666f8889ffcee3754762e40987
This commit also removes dwarf-exceptions from the x64 build.
sjlj exceptions are needed on x86 because there is a bug currently involving
SEH exceptions on x86. However on x64 there is not, so we can use the
default SEH and get rid of dwarf exceptions. Additionally, to use SEH
exceptions, we need to -fuse-cxa-atexit
Differential Revision: https://phabricator.services.mozilla.com/D7759
--HG--
extra : moz-landing-system : lando
nsIBrowserSearchService::currentEngine and nsIBrowserSearchService::defaultEngine are the same thing.
The use of defaultEngine makes more sense and thus we are phasing out the use of currentEngine and replace it with defaultEngine.
Differential Revision: https://phabricator.services.mozilla.com/D7972
--HG--
extra : moz-landing-system : lando
This patch add a mochitest which tests all pointer events to assure
touch and pen pointer events will be spoofed into mouse pointer events.
However, we are not able to test the suppressing of the non-primary
pointer events since we cannot generate a pointer event with isPrimary
as false so far.
Depends on D6005
Differential Revision: https://phabricator.services.mozilla.com/D6006
--HG--
extra : moz-landing-system : lando
Changed the validation function for PageInfo to use a more general validateItemProperties.
This changes the error message being thrown. Changed the respective test cases to accomodate the change.
Differential Revision: https://phabricator.services.mozilla.com/D5831
--HG--
extra : moz-landing-system : lando
This also requires the 64-bits rust compiler and some build system
tweaks.
Differential Revision: https://phabricator.services.mozilla.com/D7845
--HG--
extra : moz-landing-system : lando
This is to simplify a later patch that makes it easier to deal with process
flipping.
Depends on D7936
Differential Revision: https://phabricator.services.mozilla.com/D7937
--HG--
extra : moz-landing-system : lando
This patch removes linux64-jsdcov from the available builds on taskcluster along with any hacks used to run it. It also removes any 'coverage' entries that were added to skip tests.
Differential Revision: https://phabricator.services.mozilla.com/D7919
--HG--
extra : moz-landing-system : lando
The Custom Element migration missed the [modifiers=accel] in XBL on the DOMMouseScroll handler.
Differential Revision: https://phabricator.services.mozilla.com/D7780
--HG--
extra : moz-landing-system : lando
On about:preferences, if a user enters "doh" or "trr" in the search, it brings them to the Connection Settings panel.
Differential Revision: https://phabricator.services.mozilla.com/D7363
--HG--
extra : moz-landing-system : lando
Each of the tests account for search shortcuts being there, so turning them off was leading to failures. Instead, we'll leave them on, since that will be the default case, and let the tests decide on the behaviour for themselves.
Differential Revision: https://phabricator.services.mozilla.com/D7731
--HG--
extra : moz-landing-system : lando
Change to using an event listener to follow when the selection changes more accurately. Also switch to using GUIDs as they are better defined than indexes.
Differential Revision: https://phabricator.services.mozilla.com/D7537
--HG--
extra : moz-landing-system : lando
We should not go into infinite process creation loop when we are unsure if
Firefox is a child of itself.
--HG--
extra : rebase_source : 9aafb03b727b3ccacd5374804a3116558313896f
refactor some code into the search service. This is necessary to
allow the searchservice to pull multiple locales or regions from a single
extension, based on data the searchservice maintains.
Differential Revision: https://phabricator.services.mozilla.com/D7632
--HG--
extra : moz-landing-system : lando
mkaply for overall search engine api changes
adw for searchservice changes. note that a small part of it will be removed in favor of the fix from bug 1485508
aswan for webextension side. note that I want to do better with the distribution signal, that can be in bug 1488517
Differential Revision: https://phabricator.services.mozilla.com/D4473
--HG--
extra : moz-landing-system : lando
This patch also removes the menuseparator before the Send Tabs to Device menuitem since there shouldn't be a logical separation between that menuitem and the others.
Differential Revision: https://phabricator.services.mozilla.com/D7569
--HG--
extra : moz-landing-system : lando
This moves UAWidgetsChild.jsm from browser to toolkit so that
Fennec and Reftest could pick it up.
Differential Revision: https://phabricator.services.mozilla.com/D5085
--HG--
rename : browser/actors/UAWidgetsChild.jsm => toolkit/actors/UAWidgetsChild.jsm
extra : moz-landing-system : lando
Bug 1470555 moved the title from a dtd to a properties file, so we can and should now set the action's title directly when the action is created in PageActions.jsm. But it's a PluralForm string, so we need to jump through that hoop.
Differential Revision: https://phabricator.services.mozilla.com/D5721
--HG--
extra : moz-landing-system : lando
Pass sandbox parameters to content processes on the command
line allowing for early sandbox startup. Limited to Nightly
until confirmed to be stable and ready to ride the trains.
Enable early sandbox startup by default on Nightly and use
pref "security.sandbox.content.mac.earlyinit" to disable
early startup for debugging purposes.
Once early startup is stable, the original sandbox startup
code can be removed.
Depends on D6719
Differential Revision: https://phabricator.services.mozilla.com/D6720
--HG--
extra : moz-landing-system : lando
This test appears to have been disabled since 2014, and about:home has changed
a whole bunch since then. I also believe that searching from the new about:home
is being tested elsewhere.
Depends on D6956
Differential Revision: https://phabricator.services.mozilla.com/D6957
--HG--
extra : moz-landing-system : lando
When navigating to an about: page that doesn't exist (e.g.
"about:somethingthatdoesnotexist"), the docShell will call
nsSecureBrowserUIImpl::OnLocationChange with a request that is null.
Consequently, we can't use that to QueryInterface to a nsISecurityEventSink to
call OnSecurityChange. The previous implementation would use the prior
request's nsISecurityEventSink, which was a bug but luckily this produced the
correct behavior. Since the original docShell the nsSecureBrowserUIImpl was
initialized with is what needs to be notified, we can just QueryInterface that
to an nsISecurityEventSink and call OnSecurityChange directly instead.
Differential Revision: https://phabricator.services.mozilla.com/D6951
--HG--
rename : browser/base/content/test/siteIdentity/browser_tls_handshake_failure.js => browser/base/content/test/siteIdentity/browser_navigation_failures.js
extra : moz-landing-system : lando
Sam Foster
Felipe Gomes
Mike Conley
Ed Lee
Edouard Oger
Matt Howell
shindli
Thomas Wisniewski
Narcis Beleuzu
Dana Keeler
Gijs Kruitbosch
Tiberius Oros
Shane Caraveo
prathiksha
Johann Hofmann
Ehsan Akhgari
ffxbld
Dão Gottwald
Mark Banner
Brian Grinstead
Brindusan Cristian
Jonathan Kingston
Rob Wu
Mike Hommey
Michael Kaply
Ciure Andrei
David Parks
Eric Rahm
Daniel Varga
Dorel Luca
Gurzau Raul
Haik Aftandilian
Marco Bonardo
Doug Thayer
Tom Ritter
Nazım Can Altınova
Masayuki Nakano
Noemi Erli
Abdelrhman Ahmed
Timothy Guan-tin Chien
Ryan VanderMeulen
Diego Pino Garcia
Bogdan Tara
Jared Wein
Masatoshi Kimura
Csoregi Natalia
Siddhant085
Ursula Sarracini
Tim Huang
Tomislav Jovanovic
Abdoulaye O. Ly
k88hudson
Gregory Mierzwinski
Matthew Noorenberghe
Paolo Amadini
Jason Laster
Daisuke Akatsuka
Andrew Swan
Erica Wright
Tim Nguyen
Oriol Brufau
Luca Greco
Vincent Cote
Eden Chuang
Christoph Kerschbaumer
Cosmin Sabou
Eliza Balazs
Drew Willcoxon