Add test to to ensure that the looping video (without audio track) which has been suspended can continute to playback correctly after we resume video decoding.
Differential Revision: https://phabricator.services.mozilla.com/D30419
--HG--
extra : moz-landing-system : lando
There were many inconsistent ways to retrieve process/thread ids in the
profiler. Now we have only one platform-dependent implementation each:
profiler_current_process_id() and profiler_current_thread_id().
Note that this removes the need for the small `class Thread` in platform.h.
However memory_hooks.cpp still needs to be built non-unified, because of the
required order of #includes (replace_malloc.h before replace_malloc_bridge.h),
which could be disturbed by other cpp's.
Differential Revision: https://phabricator.services.mozilla.com/D29977
--HG--
extra : moz-landing-system : lando
In some cases, Gecko supplies a display item with an image clip
mask where the image itself does not exist in the resource cache.
In these cases, WR would skip requesting the image, but would
still try to fetch the image info during batching, causing a panic.
This patch skips adding clip items to the batching pass if the
image mask does not exist.
It also adds support to wrench for a crash test when the image
mask is invalid.
Differential Revision: https://phabricator.services.mozilla.com/D30560
--HG--
extra : moz-landing-system : lando
The normal looping process is that, goes to `completed` state first, notify playback ended, and finally media element would call seek to the start position in order to start looping again.
However, if we're in the seamless looping mode, we can stay in `loopingDecoding` state and repeating the looping without going to other states. Otherwise, we should go to `completed` state if decoding has ended.
Differential Revision: https://phabricator.services.mozilla.com/D30307
--HG--
extra : moz-landing-system : lando
The client_id part of browser_html_discover_view_clientid.js was failing
on TV because of a pre-existing, test-specific issue in Telemetry.
Fixing this is not trivial, so just check that the ID was set instead of
checking its exact value.
See the comment for more details; the fix will be part of bug 1537933
Differential Revision: https://phabricator.services.mozilla.com/D30001
--HG--
extra : moz-landing-system : lando
- Fill stars based on whether the rating is within the 0.5 range of a
0.5-multiple, rather than checking whether the rating is at least as
large as the 0.5-multiple. This follows the boundaries at:
bb9277eeff/src/ui/components/Rating/index.js (L139-L140)
- Use a review star rating instead of re-using the bookmark star.
This is not necessarily to be more consistent with AMO's stars,
but to prevent the stars from becoming non-stars if we ever change
the bookmark icon. The SVG icon is based on the path at:
bb9277eeff/src/ui/components/IconStar/index.js (L19)
- Turn it into a custom element to make re-use easier.
Differential Revision: https://phabricator.services.mozilla.com/D29480
--HG--
extra : moz-landing-system : lando
Require `extensions.htmlaboutaddons.discover.enabled` to be enabled
before the HTML-based discopane is shown. This allows the feature
to be turned on and/or off independent of the other HTML views.
Differential Revision: https://phabricator.services.mozilla.com/D29478
--HG--
extra : moz-landing-system : lando
Like in case of bug 1506534, this telemetry is sampled periodically every time 2GB of data is written to the cache, i.e. when the cache was used for some time and there is a chance that its content has changed significantly.
Differential Revision: https://phabricator.services.mozilla.com/D29678
--HG--
extra : moz-landing-system : lando
This commit avoids moz.build tasks when we're already within `mach
build`.
This is belt-and-braces: from within `mach build`, we want the main
moz.build dependency graph to arrange for the Gradle invocations to be
in the right state. It's only in other situations, like `mach android
...` or invocation from Android Studio, that we want Gradle to arrange
to be in the right state vis. moz.build.
Differential Revision: https://phabricator.services.mozilla.com/D30426
--HG--
extra : moz-landing-system : lando
The inline comment explains what is happening here. The issue is that
client.mk is setting MOZ_OBJDIR (and autoconf.mk is setting CC/CXX and
others) as part of `mach build`, which means that recursively invoking
`mach build` sees a different environment, and that triggers
reconfigure.
In some situations we can avoid this by recognizing that the
environment has changed and setting it back to what it was at the time
of `mach build` before client.mk adjusts it.
Differential Revision: https://phabricator.services.mozilla.com/D30425
--HG--
extra : moz-landing-system : lando
SSLTokensCache is a simple memory only storage for resumption tokens which are get and set using API for external TLS session caches in NSS.
Differential Revision: https://phabricator.services.mozilla.com/D29465
--HG--
extra : moz-landing-system : lando
We never emit an XPT for an interface that is not scriptable, so this
flag is never used.
Differential Revision: https://phabricator.services.mozilla.com/D30529
--HG--
extra : moz-landing-system : lando
When adjusting box's position, we would choose a axis first and move the box along this axis to see whether we can place this box without overlapping with other boxes and fully inside the rendering area.
If the box has been over the boundary along the moving direction, we should move box back to the original position and change the moving direction to see whether we can find another best place for the box.
Although the adjustment can run without timeout now, it still doesn't match the result of the reference, so change the state to `fail`.
Differential Revision: https://phabricator.services.mozilla.com/D29765
--HG--
extra : moz-landing-system : lando
On Android, sometime we can't get the first frame, which would cause intermittent fail. See bug1546128.
On Windows, sometime we would get incorrect text color rendering, which would also cause intermittent fail. See bug1546133.
It seems that we won't get these two bug fixed recently, so I'm going to disable them on these two platforms.
Differential Revision: https://phabricator.services.mozilla.com/D28359
--HG--
extra : moz-landing-system : lando
Sometime there are some color rendering differences between the test and the reference, which is small enough to be ignored because human can't be aware of that difference.
Differential Revision: https://phabricator.services.mozilla.com/D27179
--HG--
extra : moz-landing-system : lando
According to the spec [1] 7.2.10.2, we should use the first line box's height or width as positioning unit to adjust box's position.
We will also use this value to adjust box when `snap-to-line` is false.
There, we implement a new chrome-only API to acquire this information, which would return the first line box's size in the `block` frame.
[1] https://www.w3.org/TR/webvtt1/#ref-for-webvtt-cue-snap-to-lines-flag-12
Differential Revision: https://phabricator.services.mozilla.com/D29745
--HG--
extra : moz-landing-system : lando
When adjusting cue's position, the goal is to place cue boxes fully inside the rendering area, and place in the right place.
In order to check whether the box is correctly inside the rendering area, we have to know the correct size of the cue box.
Therefore, we implement the new chrome-only APIs to acquire this information (box's height and width), and this returned value won't be affected by CSS transformation, which is good for positioning.
Differential Revision: https://phabricator.services.mozilla.com/D27178
--HG--
extra : moz-landing-system : lando
This will allow us to copy the pdbs for test files into the resulting
test file archive, but doesn't do it automatically.
Bug 1505936 is for copying some of them.
Differential Revision: https://phabricator.services.mozilla.com/D29761
--HG--
extra : moz-landing-system : lando
Changes:
- set `macosx64-ccov` tests to 8 chunks (unchanged from m-c)
- set windows and linux `ccov` to 6 chunks (from 8)
- set `linux64.*/debug` to 6 chunks (from 10 and 8)
- set `android-em` to 8 chunks (unchanged)
- set default chunks to be 5 (from 8)
Differential Revision: https://phabricator.services.mozilla.com/D29713
--HG--
extra : moz-landing-system : lando
Changes:
- change the default chunk count to 4 (from 6)
- increase `ccov` chunk count to 8 (from 6)
- `qr` and `linux64/debug` are to remain at 6 chunks
- reduce all other `linux` chunks to 3 (from 6)
- `windows/debug` (including `qr`) chunks reduced to 5 (from 6)
Default chunk count of 4 for Windows and macOS are conservative, leading to sub-20 minute runtimes for most chunks.
Differential Revision: https://phabricator.services.mozilla.com/D29875
--HG--
extra : moz-landing-system : lando
alwu
Gerald Squelart
Jean-Yves Avenard
Brindusan Cristian
Glenn Watson
Rob Wu
Noemi Erli
David Walsh
James Graham
Michal Novotny
Gijs Kruitbosch
Nick Alexander
Mike Shal
Andrew McCreight
Tom Ritter
Narcis Beleuzu
Paul Zuehlcke
Chris Hartjes
Edwin Gao
Byron Campen [:bwc]
Ed Lee
shindli