Граф коммитов

1309 Коммитов

Автор SHA1 Сообщение Дата
Mark Banner bd625e4e9f Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - automatically update .eslintrc.js test config files for new config locations. r=jaws
MozReview-Commit-ID: LH0CQOPfoe6

--HG--
extra : rebase_source : 83eaf40c5cbb5e25cfb3f3b5afadf4fbf0422c92
2017-03-20 12:36:37 +01:00
Thom Chiovoloni 130ff3a299 Bug 1345754 - Skip sync bookmark repair and validation if we have pending changes r=markh
MozReview-Commit-ID: ClQRXGZGV9p

--HG--
extra : rebase_source : 4ae8ead7a9121dc383fcfc5ebf757f44e46f5679
2017-03-14 14:26:20 -04:00
Edouard Oger e4ec1eb1d3 Bug 1343735 - Respect max_record_payload_bytes limit. r=markh
MozReview-Commit-ID: 1aDwl1cq2Hh

--HG--
extra : rebase_source : a29abc5c1f3b9eefea26fe93b5ee82f4b3d12924
2017-03-15 17:12:17 -04:00
Mark Hammond dfa642bc63 Bug 1348743 - avoid running a bookmark validation on every sync. r=tcsc
MozReview-Commit-ID: 49sWR56kfrj

--HG--
extra : rebase_source : f13d7ef61b343820347579b76352cd65a322c8eb
2017-03-20 19:13:42 +11:00
Wes Kocher 1a61788cb8 Backed out changeset a2ec162fa051 (bug 1348743) for eslint failures a=backout
MozReview-Commit-ID: 2rfgqYueacf
2017-03-20 16:32:06 -07:00
Mark Hammond 10c7be4d14 Bug 1348743 - avoid running a bookmark validation on every sync. r=tcsc
MozReview-Commit-ID: 49sWR56kfrj

--HG--
extra : rebase_source : e68d0050fb3b6b48e5c61abed98827dbbf449923
2017-03-20 19:13:42 +11:00
Thom Chiovoloni 4f8d16041f Bug 1342320 - Use PlacesUtils and not PlacesSyncUtils in sync bookmark decline/undecline test r=markh
MozReview-Commit-ID: DgbCeKgSxoE

--HG--
extra : rebase_source : d7a73f871436a3c557e3ea921439da3e6f55e13c
2017-03-14 13:01:10 -04:00
Mark Hammond f13f9ed085 Bug 1347373 - better handling of requests that have only non-existing items and of errors. r=kitcambridge
MozReview-Commit-ID: 7kcky3wJb4j

--HG--
extra : rebase_source : 108dde9145e323410e8799053581dc9bb4b80e42
2017-03-16 20:53:06 +11:00
Joseph Cameron 4ad85c5308 Bug 1345023 - Changed SYNC_API_VERSION to 1.5 and updated SUPPORTED_PROTOCOL_VERSIONS to reflect this change. r=markh
MozReview-Commit-ID: 98knOLicr9E

--HG--
extra : rebase_source : 1acbb125c0512842abdfab068094cc744ce2d329
2017-03-15 22:18:43 -04:00
David Rajchenbach-Teller 2508d8532a Bug 1086549 - Converting Sync tests from removePage to History.remove. Patch by Yoric, updated by Standard8. r=markh
MozReview-Commit-ID: 3dZljFrvJUA

--HG--
extra : rebase_source : 355265e0dbdc169df308ba15212997373f781ea3
2014-10-24 14:57:02 +02:00
Edouard Oger fe217294a0 Bug 1346136 - Add more leeway in backoff testing. r=markh
MozReview-Commit-ID: 4M86B9BVbq9

--HG--
extra : rebase_source : 726bf645306864410f18bac78c3484e347e9ff7d
2017-03-10 15:39:41 -05:00
Edouard Oger 036a984325 Bug 745410 - Remove microsummary support from Sync. r=kitcambridge
MozReview-Commit-ID: BdBgxHeHndj

--HG--
extra : rebase_source : 1049da5ecc1a61ef6a042f67ab37b619118eb45a
2017-03-10 15:03:07 -05:00
Wes Kocher 0cca2c83d5 Backed out changeset 9c8eac7852f6 (bug 745410) for build failures a=backout
MozReview-Commit-ID: JY6fS63iCwJ
2017-03-10 13:19:34 -08:00
Edouard Oger 5e9bd0d28b Bug 745410 - Remove microsummary support from Sync. r=kitcambridge
MozReview-Commit-ID: BdBgxHeHndj

--HG--
extra : rebase_source : 184b254f3299209f98cfc50f6630050a2ca29ab1
2017-03-10 15:03:07 -05:00
Thom Chiovoloni 577f26289e Bug 676563 - Add dateAdded field to synced bookmarks r=markh,rnewman
MozReview-Commit-ID: 5dxoTGrypqm

--HG--
extra : rebase_source : 94af07afc4c0ae2faccc33247fa8f2df91683cce
2017-01-17 14:45:08 -05:00
Edouard Oger 682b54d712 Bug 1339861 - Mark Sync clients as stale if not in the FxA device list. r=markh
MozReview-Commit-ID: 84Tl3QTHInO

--HG--
extra : rebase_source : c05a5462be71b9eb0bc1bddc6a6a74f1b13088b7
2017-02-28 16:35:01 -05:00
BharatR123 56b41b115e Bug 1345009 - remove _migratePrefs() function and related test and references in xpcshell.ini r=markh
MozReview-Commit-ID: CbXXPLNXUet

--HG--
extra : rebase_source : 81ace434bc1ecdff3a84b9c8a978343d052ad1ea
2017-03-07 14:41:46 +05:30
Kit Cambridge 35e400d22b Bug 1345005 - Ensure validation prefs are set for all tests that run a full sync. r=tcsc
Some of our tests call `Svc.Prefs.resetBranch("")` or
`Service.startOver()`, which resets the validation prefs to their
default values. This patch makes it a bit more explicit which tests
perform a full sync, and should run validation.

MozReview-Commit-ID: 7a0wR8nuJeW

--HG--
extra : rebase_source : 18ff025671c9dd5e2e30d441940f5c2fb804cae3
2017-03-06 11:29:19 -08:00
Zibi Braniecki 100766fec4 Bug 1335877 - Remove resource://services-common/stringbundle.js from gecko. r=gandalf
MozReview-Commit-ID: FNoj7XH71E4

--HG--
extra : rebase_source : 294d3e425ca60e2aac6149998da7f39f62864ae5
2017-03-06 09:39:52 -08:00
Carsten "Tomcat" Book 1bc7720a43 Backed out changeset 0bd17b868a31 (bug 1335877) for causing regression bug 1344760 2017-03-06 17:03:11 +01:00
Edouard Oger 69b317e280 Bug 1321119 - Allow to Sync more tabs and reduce tabs history to 5. r=markh
MozReview-Commit-ID: 7kRg4XQeT4C

--HG--
extra : rebase_source : 7558c92cc3fefe1ade2359008df9102f5ba72322
2017-03-01 13:47:20 -05:00
Zibi Braniecki 4b7b3d4092 Bug 1335877 - Remove resource://services-common/stringbundle.js. r=rnewman
MozReview-Commit-ID: M7V6JS5myy

--HG--
extra : rebase_source : a47d739d3dd67ce563088aaf9fab5421de376cd7
2017-03-02 15:26:53 -08:00
Mark Hammond b86ff30666 Bug 1317223 (part 7) - disable tests on ASAN due to bug 1344085. r=kitcambridge
MozReview-Commit-ID: 6L72ACMcDBq
2017-03-03 10:54:45 +11:00
Mark Hammond 5712360194 Bug 1317223 (part 6) - integration tests for the bookmark repair requestor and responder. r=tcsc
A poor start, but at least it's something.

MozReview-Commit-ID: 8us4v6Y21oM
2017-03-01 23:17:05 +11:00
Mark Hammond 9b6693b8ee Bug 1317223 (part 5) - a bookmark repair responder. r=kitcambridge
This is the "repair responder" - it handles a "repairRequest" command sent
by another client and attempts to take the list of IDs that client lists as
missing and upload whatever records are necessary such that the requesting
client would then be likely to find a complete and valid tree on the server.

MozReview-Commit-ID: 4xw19nH6EfL
2017-02-28 15:34:37 +11:00
Kit Cambridge 46e87ef366 Bug 1317223 (part 4) - formalize weak tracking in `BookmarksChangeset`. r=markh
MozReview-Commit-ID: C6otrtSuhZH
2017-02-06 10:19:27 -08:00
Mark Hammond 8c4e55d022 Bug 1317223 (part 3) - a bookmark repair requestor. r=markh,tcsc
The bookmark repair requestor takes the validation results and possibly
initiates a bookmark repair.

MozReview-Commit-ID: 7rRNbBx8Vo3
2017-03-02 19:21:53 +11:00
Mark Hammond de20e8f357 Bug 1317223 (part 2) - add 'doctor' concept and move bookmark validation logic to it. r=tcsc
This patch defines the concept of a "doctor" for collections. The doctor is
responsible for running all validators and deciding whether or not to initiate
a repair request based on the validation results.

MozReview-Commit-ID: 6NLRE6L0OpA
2017-03-02 17:14:31 +11:00
Mark Hammond 79d7981ee8 Bug 1342851 - record the last-modified time of a Sync client record. r=rnewman
MozReview-Commit-ID: 2jtCsl3sy3X

--HG--
extra : rebase_source : f0d24ca1a990abd8499f7f07eb7561840441dd1a
2017-02-27 12:44:12 +11:00
Edouard Oger baba07044d Bug 1317667 - Use dates further in the future in test_bookmark_duping. r=kitcambridge
MozReview-Commit-ID: 3R3tbbzio2I

--HG--
extra : rebase_source : f87d2261859ff7195e795e2e2ba4c5285536e6cf
2017-02-27 11:44:22 -05:00
Gijs Kruitbosch b0f2da2a20 Bug 1341097 - part 3: don't dispatch oodles of titlechanged notifications for new history entries, r=mak
MozReview-Commit-ID: 7jHOcCQ5ZBb

--HG--
extra : rebase_source : 6dff335e78857e7c860ebe7ec6ea415fe0f9e3f6
2017-02-27 18:26:21 +00:00
Kit Cambridge ffd9158f97 Bug 1335752 - Disable persistence and clean up after `RotaryEngine` in tests. r=markh
MozReview-Commit-ID: 8feE9O6Dv3W

--HG--
extra : rebase_source : c01eed08e72fd4ff654b3afed0472cb5185aec4e
2017-02-13 13:48:08 -08:00
Thom Chiovoloni c396116b69 Bug 1337993 - Ensure we mark all current bookmarks for reupload when bookmark engine enabled state changes. r=kitcambridge
MozReview-Commit-ID: 4gOmqrzUr77

--HG--
extra : rebase_source : ee645449c2bb08cc13a6b9040a0bbdd506d5c0a3
2017-02-13 14:28:06 -05:00
Mark Hammond cd73a70071 Bug 1340357 - remove all special eslint rules in services/. r=eoger
MozReview-Commit-ID: 6zMOBoWLOhJ

--HG--
extra : rebase_source : cf546abd9a52230746c0c05f7bb716cae42815bf
2017-02-17 12:34:45 +11:00
Ethan Glasser-Camp b228d5b47d Bug 1321570 - use dependency injection for fxAccounts, r=kmag
Get rid of the ugly hack where test code monkeypatches a singleton to
convince the rest of the ExtensionStorageSync code that a fake user is
logged in. Instead, take a handle to the fxAccounts service at
construction time. Test code can provide any kind of fxAccounts it
wants, including one that has a hard-coded user.

This provokes a bunch of changes:

- ExtensionStorageSync is now no longer a singleton, but a class. You
  have to instantiate it in order to do anything with it. A global
  instance extensionStorageSync is provided for use by Sync code as
  well as WebExtension code.

- CryptoCollection is now also a class, and each ExtensionStorageSync
  instance has its own CryptoCollection. This dependency should maybe
  also be injected, but for the time being it doesn't provide us any
  value to do so.

- Converting singletons with asynchronous methods to classes is a pain
  in the neck. We convert async method foo from `foo:
  Task.async(....)` to `async foo() { .... }`. While we're here,
  convert KeyRingEncryptionRemoteTransformer#decode to async/await to
  eliminate a need for `let self = this`.

- Update Sync code and WebExtension code to use extensionStorageSync.

- There's a cyclic dependency where CryptoCollection#sync depends on
  ExtensionStorageSync#_syncCollection which depends on
  CryptoCollection#getKeyRing. As a short-term hack, we now require an
  ExtensionStorageSync argument to CryptoCollection#sync.

- KeyRingEncryptionRemoteTransformer now takes a handle to fxAccounts
  on construction time as well. Because this is the only
  EncryptionRemoteTransformer subclass that accesses fxAccounts, we
  can get rid of the hack where the tests monkeypatch something in the
  EncryptionRemoteTransformer prototype.

- CollectionKeyEncryptionRemoteTransformer now takes a handle to a
  CryptoCollection, rather than relying on a global one.

- A bunch of methods that previously assumed access to fxAccounts now
  check if fxAccounts is present (i.e. if we're on Android). Strictly
  speaking, this isn't required by this change, but it helps make
  certain kinds of failure a little easier to diagnose.

- Update tests, including extracting a domain-specific helper method
  to hide the use of CollectionKeyEncryptionRemoteTransformer. We now
  no longer monkeypatch in our mock fxaService, but pass it to the
  test so that it can do whatever it wants with it. We also provide an
  ExtensionStorageSync instance for convenience. Access to the global
  cryptoCollection is now done through an ExtensionStorageSync
  instance.

To summarize, we've gone from a situation where a bunch of singletons
had implicit dependencies on other singletons in a shared global
namespace, to a situation where dependencies are provided explicitly
using method/constructor arguments. This highlights some of the
dependencies present:

- ExtensionStorageSync depends on CryptoCollection and fxAccounts if
  it needs to sync

- Every collection created via openCollection needs a handle to
  CryptoCollection so it can correctly create its remote transformers

- CryptoCollection needs a handle to fxAccounts so it can create its
  own remote transformer for its special collection

Most of this is only possible, or at least much easier, because we no
longer try to juggle Sqlite connections but just keep one around
forever.

However, please note:

- CryptoCollection needs a handle to ExtensionStorageSync to actually
  perform syncing logic because that's where we foolishly put the
  logic to make requests

- There's still a backing Sqlite store which is shared by everything

- There's still a singleton tracking contexts that opened extensions
  which we manage to try to clean contexts up correctly

MozReview-Commit-ID: DGIzyRTdYZ1

--HG--
extra : rebase_source : 305a98b8e1ece3ae7a5e8a2fdb5c58d8e7c496d9
2017-01-10 16:44:01 -05:00
Ethan Glasser-Camp 4f7afb05a6 Bug 1321570 - Move ExtensionStorageSync crypto out of services/sync, r=kmag
Since services/sync doesn't ship on Android, this meant
conditionally-defining some variables such as `cryptoCollection` and
`CollectionKeyEncryptionRemoteTransformer` depending on whether or not
we were on Android. However, none of these definitions really rely on
functionality that isn't present on Android (although you can't really
use them yet either). Move the dependency together with the dependant
code so we can simplify a bit. This lets us remove conditional uses of
`cryptoCollection` and `CollectionKeyEncryptionRemoteTransformer`.

Because the WebExtensions source directory has more stringent eslint
rules, we end up reformatting and commenting a bit in addition to
moving.

MozReview-Commit-ID: 2ddDeymYFNi

--HG--
rename : services/sync/tests/unit/test_extension_storage_crypto.js => toolkit/components/extensions/test/xpcshell/test_ext_storage_sync_crypto.js
extra : rebase_source : f84c0810b6a447f2104f96c9dc9d6139743f269c
2017-02-13 15:06:02 -05:00
Phil Ringnalda aa72959f4e Bug 1338439 followup, placate eslint 2017-02-12 20:50:46 -08:00
Mark Hammond e23f30ffed Bug 1338439 - Sync event telemetry should use the same flowID when sending a command to multiple clients, and should include a reason for some commands. r=tcsc
MozReview-Commit-ID: 7a6qjRUswGL

--HG--
extra : rebase_source : a6112f4fb8762f3cde4a85aaa5ef4a8d11b15947
2017-02-10 16:49:33 +11:00
Kit Cambridge e73b9cdef7 Bug 1338668 - Ignore tag query folder IDs when comparing client and server bookmark records. r=tcsc
MozReview-Commit-ID: 2Mz9fTsTou5

--HG--
extra : rebase_source : e2030c91a20356d61677a212fa57f88d680bfb90
2017-02-10 15:03:34 -08:00
Phil Ringnalda 3063243dfc Bug 1323867 followup, placate eslint 2017-02-07 16:20:31 -08:00
Kit Cambridge 1e92ba873d Bug 1323867 - Bump bookmark validation threshold to 1k. r=tcsc
This patch also refactors `compareServerWithClient` and
`inspectServerRecords` to periodically yield back to the main thread,
since validating a large number of bookmarks in a tight loop causes
jank. Yielding every 50 records for 50ms is somewhat arbitrary, but
keeps things snappy for my profile (2947 records).

MozReview-Commit-ID: 99DJtNvNeHI

--HG--
extra : rebase_source : cc0991106c17ce906b8779afbe9eced0e27cc4b4
2017-01-12 14:02:45 -07:00
Kit Cambridge 912d625cf7 Bug 1325523 - Persist tracked IDs on finalization, and don't persist IDs in Sync tests. r=markh
MozReview-Commit-ID: CpQP2aM1DO

--HG--
extra : rebase_source : 02fa555cc44bd9d94a6c3beedf00fa1746f0c637
2017-02-07 11:51:06 -08:00
Mark Hammond f02fca824e Bug 1310065 - use more reliable preferences for calculating the client count in the sync scheduler. r=eoger
This patch switches to using preferences written by the clients engine to
determine the number of clients so it's correct before the first sync for
a browser session.

It also fixes another bug I discovered - if a mobile device dropped from the
client list, the preference for the number of mobile devices would remain at
1 rather than resetting to zero.

MozReview-Commit-ID: IPythSQcorx

--HG--
extra : rebase_source : 4ce465e3958d037f90312553a0c353cdc161c0fe
2017-01-25 18:11:05 +11:00
Edouard Oger cfc8f37c1b Bug 1317667 - Use async bookmark methods in test_bookmark_duping. r=kitcambridge
MozReview-Commit-ID: CpvcDXKkfcl

--HG--
extra : rebase_source : 4d143bdf9af7727933a74a9f05c7a56baa5c321b
2017-02-03 13:52:39 -05:00
Edouard Oger f7e895d911 Bug 1329850 - Sync records creation failures are reported to telemetry. r=markh
MozReview-Commit-ID: AEOlmkmyIvY

--HG--
extra : rebase_source : 71c2a627bd0291fa2b9448710e6b0eb1fae36719
2017-01-24 17:05:12 -05:00
Sebastian Hengst 573326d526 Backed out changeset 20863de3b8f4 (bug 1329850) for eslint failure: redeclaration of collection in deeper scope in test_syncengine_sync.js. r=backout 2017-01-31 18:46:39 +01:00
Edouard Oger ecdeb55693 Bug 1329850 - Sync records creation failures are reported to telemetry. r=markh
MozReview-Commit-ID: AEOlmkmyIvY

--HG--
extra : rebase_source : bce1d12bf1fdb7867ac0f290fdfe4e6b5d761bcc
2017-01-24 17:05:12 -05:00
Mark Banner 8cf0d4744c Bug 1333044 - Enable no-undef eslint rule for services/. r=markh
MozReview-Commit-ID: IrtWclENDth

--HG--
extra : rebase_source : 72df6ddc457431ae77f953a00712462e4902b5f1
2017-01-23 15:15:05 +00:00
Mark Banner df3fdf012f Bug 1333044 - Fix no-shadow issues in services/. r=markh
MozReview-Commit-ID: KqYfpjdR7QS

--HG--
extra : rebase_source : b93a673073045ddfec6e4b4b347b4e8494425310
2017-01-23 14:07:55 +00:00
Mark Banner 2ecc79b536 Bug 1333044 - Prepare services/ for enabling no-undef eslint rule. r=jaws
MozReview-Commit-ID: 29KwwyZH2jn

--HG--
extra : rebase_source : c4b19fe3714b19b445011ae1c413ca0e624cb46e
2017-01-17 12:25:43 +00:00
Edouard Oger 1d38375171 Bug 1296767 part 13 - Repair Weave Service getStorageInfo. r=markh
MozReview-Commit-ID: E4S5xYTNDIH
2017-01-27 13:31:58 -05:00
Edouard Oger ad36606986 Bug 1296767 part 11 - Remove Weave.Service.serverURL and friends. r=markh
MozReview-Commit-ID: Kmsxn10sA2X
2017-01-27 13:31:58 -05:00
Edouard Oger f5eb6dc494 Bug 1296767 part 7 - Remove non-in-content legacy Sync pref screens. r=markh
MozReview-Commit-ID: LK9akz4chd1
2017-01-27 13:31:57 -05:00
Edouard Oger ea99e4442d Bug 1296767 part 6 - Remove startOverKeepIdentity pref. r=markh
MozReview-Commit-ID: 7YDYTCRiKZa
2017-01-27 13:30:48 -05:00
Edouard Oger cdce850c10 Bug 1296767 part 5 - Remove add_identity_test helper. r=markh
MozReview-Commit-ID: 12pP01IHRyp
2017-01-27 13:30:48 -05:00
Edouard Oger df80e282e9 Bug 1296767 part 4 - Update tests to work with the BrowserID identity manager. r=markh
MozReview-Commit-ID: AFRyZFW6xZU
2017-01-27 13:30:48 -05:00
Edouard Oger bf4dae4e25 Bug 1296767 part 3 - Make BrowserID the only Sync identity manager. r=markh
MozReview-Commit-ID: IC7kRjgtPp8
2017-01-27 13:30:47 -05:00
Edouard Oger c94655827a Bug 1296767 part 2 - Remove Sync UserApi. r=markh
MozReview-Commit-ID: CdgLxCN52Os
2017-01-27 13:30:47 -05:00
Edouard Oger bb525e4654 Bug 1296767 part 1 - Remove J-PAKE from Sync. r=markh
MozReview-Commit-ID: iD4OJv436i
2017-01-27 13:30:47 -05:00
Wes Kocher c3cc3b6407 Backed out 13 changesets (bug 1296767) for xpcshell failures a=backout CLOSED TREE
Backed out changeset 41ed77788333 (bug 1296767)
Backed out changeset 1c0c9289b532 (bug 1296767)
Backed out changeset 50294db1d871 (bug 1296767)
Backed out changeset 26c065f79c54 (bug 1296767)
Backed out changeset 0362a78d6978 (bug 1296767)
Backed out changeset 4e71cf94e4ee (bug 1296767)
Backed out changeset f6f59447d22a (bug 1296767)
Backed out changeset 6c9b792cc296 (bug 1296767)
Backed out changeset 46a52b10a868 (bug 1296767)
Backed out changeset 5d70d87d2a8f (bug 1296767)
Backed out changeset 8219686be6a2 (bug 1296767)
Backed out changeset 0a989b0cea67 (bug 1296767)
Backed out changeset 9f59a0b75c1f (bug 1296767)

MozReview-Commit-ID: 2XBNsd8JrZL

--HG--
extra : amend_source : 1afafaa8127fcebac31ce1d7743dc16872fa0522
2017-01-26 11:16:12 -08:00
Edouard Oger 1595b78c75 Bug 1296767 part 13 - Repair Weave Service getStorageInfo. r=markh
MozReview-Commit-ID: E4S5xYTNDIH

--HG--
extra : rebase_source : 6a98b9503183bbf679622b00073d162fd3e4f5e4
2017-01-23 15:19:04 -05:00
Edouard Oger f49ecb465d Bug 1296767 part 11 - Remove Weave.Service.serverURL and friends. r=markh
MozReview-Commit-ID: Kmsxn10sA2X

--HG--
extra : rebase_source : 87bebd2abc19a6b62647d4bcb48193765a3622e2
2017-01-19 13:19:33 -05:00
Edouard Oger b41402ea7b Bug 1296767 part 7 - Remove non-in-content legacy Sync pref screens. r=markh
MozReview-Commit-ID: LK9akz4chd1

--HG--
extra : rebase_source : b7113c37a486f88ae1138c54e314bb0ff07ef1af
2017-01-18 17:39:11 -05:00
Edouard Oger 17b83cde16 Bug 1296767 part 6 - Remove startOverKeepIdentity pref. r=markh
MozReview-Commit-ID: 7YDYTCRiKZa

--HG--
extra : rebase_source : 41574e70bd92ee2abe6f92a799c57e1f5910f8b4
2017-01-18 16:30:38 -05:00
Edouard Oger 9050cab070 Bug 1296767 part 5 - Remove add_identity_test helper. r=markh
MozReview-Commit-ID: 12pP01IHRyp

--HG--
extra : rebase_source : 2c5af253df77ed08dd8bdf0c7645ed98e6a96c9a
2017-01-18 15:52:47 -05:00
Edouard Oger cfef81983f Bug 1296767 part 4 - Update tests to work with the BrowserID identity manager. r=markh
MozReview-Commit-ID: AFRyZFW6xZU

--HG--
extra : rebase_source : 6110e19a51d6d3375b47f785c8f644ee879fb924
2017-01-13 15:59:32 -05:00
Edouard Oger 49552f7919 Bug 1296767 part 3 - Make BrowserID the only Sync identity manager. r=markh
MozReview-Commit-ID: IC7kRjgtPp8

--HG--
extra : rebase_source : ec10c24400afa4b1c1fd3840f31a9d57d498ec8a
2017-01-13 15:02:21 -05:00
Edouard Oger eb0c42bf7a Bug 1296767 part 2 - Remove Sync UserApi. r=markh
MozReview-Commit-ID: CdgLxCN52Os

--HG--
extra : rebase_source : c270d7dfbaf621c1eb8f440009b361212969a8bc
2017-01-13 15:54:46 -05:00
Edouard Oger 0c915a6f46 Bug 1296767 part 1 - Remove J-PAKE from Sync. r=markh
MozReview-Commit-ID: iD4OJv436i

--HG--
extra : rebase_source : 1653284a3b2e014719a7eb37588f99df868e2060
2017-01-10 13:47:24 -05:00
Kit Cambridge 009412ee92 Bug 1332024 - Finalize tracker storage and consolidate cleanup logic in engine tests. r=markh
MozReview-Commit-ID: 8t9bXFrLA1Z

--HG--
extra : rebase_source : 51e15f6cc8fd44947f42cc59be413df6775291b0
2017-01-24 09:59:09 -08:00
Carsten "Tomcat" Book aaafcb0f0a Backed out changeset f8b29e24280b (bug 1333044) for perma failures in test_load_modules.js
--HG--
extra : rebase_source : ef649da0bb1acaabcb55a42e5df4164f1cf8b6d4
2017-01-25 15:29:53 +01:00
Carsten "Tomcat" Book f868542f9b Backed out changeset 06a658a93aab (bug 1333044)
--HG--
extra : rebase_source : 554fed79a1c36ce418ab95952cde9669a3297cb6
2017-01-25 15:29:35 +01:00
Carsten "Tomcat" Book a6178c3af9 Backed out changeset 9c6b98edac72 (bug 1333044)
--HG--
extra : rebase_source : e81a05f7fa7ffca19ced3e0aca62ada7bde935b2
2017-01-25 15:29:33 +01:00
Mark Banner eb102a103e Bug 1333044 - Enable no-undef eslint rule for services/. r=markh
MozReview-Commit-ID: IrtWclENDth

--HG--
extra : rebase_source : 19e5895756579ecf88d5be70e8aaaf8c3166ada1
2017-01-23 15:15:05 +00:00
Mark Banner caa2f51ce1 Bug 1333044 - Fix no-shadow issues in services/. r=markh
MozReview-Commit-ID: KqYfpjdR7QS

--HG--
extra : rebase_source : 32511d0a015fe57f0b8262b0faa28dbd4bd7a623
2017-01-23 14:07:55 +00:00
Mark Banner 33c00194c2 Bug 1333044 - Prepare services/ for enabling no-undef eslint rule. r=jaws
MozReview-Commit-ID: 29KwwyZH2jn

--HG--
extra : rebase_source : 9b5edc75897af35754433b6fccfcecf83293c62b
2017-01-17 12:25:43 +00:00
Jared Wein a1b9179389 Bug 1330791 - Enable the no-native-reassign rule for eslint in /services and fix the associated error. r=markh
MozReview-Commit-ID: 65EsZGCJPMD

--HG--
extra : rebase_source : 4dc9dddaa26d1c10f859dc7a08b64168a1d0fdd5
2017-01-12 18:28:48 -05:00
Jared Wein 516a926c6e Bug 1330791 - Enable the no-redeclare rule for eslint in /services and fix the associated errors. r=markh
MozReview-Commit-ID: 7ADLmPB4eSu

--HG--
extra : rebase_source : 94a966d6cbc5c2b6b6097355fc3aa84dd50e27f5
2017-01-12 18:19:47 -05:00
Jared Wein ac53e1b8be Bug 1330791 - Enable no-else-return rule for eslint in /services and fix associated errors. r=markh
MozReview-Commit-ID: 7Os4uZQCDox

--HG--
extra : rebase_source : 2a1d9ef6fb6510f7f3b02b6c727bc706e56637b0
2017-01-12 18:14:54 -05:00
Jared Wein d019dbcaa8 Bug 1330791 - Enable the no-useless-call eslint rule for /services and fix associated errors. r=markh
MozReview-Commit-ID: Ixd7jk5G5CB

--HG--
extra : rebase_source : 0f5817cb03f26c28d401706069ba9aa23f6acce3
2017-01-12 18:08:10 -05:00
Jared Wein 7cb8b041fe Bug 1330791 - Enable the no-unused-vars rule for eslint in /services and fix associated errors. r=markh
MozReview-Commit-ID: DFcvEllwGSb

--HG--
extra : rebase_source : c6abc288124c1c47480cc73db8294195d8832fa2
2017-01-12 18:02:08 -05:00
Mark Banner 16e6d381ac Bug 503613 - Remove old 'tail =' lines from xpcshell.ini files; r=gps
MozReview-Commit-ID: 62Hp5ISxowJ

--HG--
extra : rebase_source : daa8efb3409031fea553f4fd0c9d0746e38dc308
extra : histedit_source : b4c23aacf678ba0d0ac9c09191a7c494ead11a08
2017-01-18 10:30:39 +00:00
Kit Cambridge 14b98b514b Bug 1317579 - Don't send a sync ping for self-hosters. r=tcsc
MozReview-Commit-ID: 601nfXW0gT6

--HG--
extra : rebase_source : e0f96250cb101c3de020fadd856f28f0d8a4bfa8
2016-12-22 19:00:34 -07:00
Wes Kocher 20dc006d88 Backed out 14 changesets (bug 1330791) for various android failures a=backout
Backed out changeset eada8de7256f (bug 1330791)
Backed out changeset a3c656a9f3ca (bug 1330791)
Backed out changeset e0cbc754e841 (bug 1330791)
Backed out changeset 49d8016fab12 (bug 1330791)
Backed out changeset 53d4b83ccd22 (bug 1330791)
Backed out changeset b35cbfcd801f (bug 1330791)
Backed out changeset 25a6356de622 (bug 1330791)
Backed out changeset 46f9c247550d (bug 1330791)
Backed out changeset ef7356099bd3 (bug 1330791)
Backed out changeset a5fe483288db (bug 1330791)
Backed out changeset 4902107b7568 (bug 1330791)
Backed out changeset 5b2b2be2e389 (bug 1330791)
Backed out changeset 610ec89e98bb (bug 1330791)
Backed out changeset 631adda26a21 (bug 1330791)

MozReview-Commit-ID: GGUFW29U3TL
2017-01-17 17:06:36 -08:00
Jared Wein 4bca295e61 Bug 1330791 - Enable the no-native-reassign rule for eslint in /services and fix the associated error. r=markh
MozReview-Commit-ID: 65EsZGCJPMD

--HG--
extra : rebase_source : 716697450e8506240a50a29508bf4943c37f48ef
2017-01-12 18:28:48 -05:00
Jared Wein 16f3cc90b4 Bug 1330791 - Enable the no-redeclare rule for eslint in /services and fix the associated errors. r=markh
MozReview-Commit-ID: 7ADLmPB4eSu

--HG--
extra : rebase_source : 2305e778e5a37a6c32753b021789c3a8c0077c69
2017-01-12 18:19:47 -05:00
Jared Wein d3dba448bd Bug 1330791 - Enable no-else-return rule for eslint in /services and fix associated errors. r=markh
MozReview-Commit-ID: 7Os4uZQCDox

--HG--
extra : rebase_source : 8d14b02c97b8024268b5625a633393e75efed117
2017-01-12 18:14:54 -05:00
Jared Wein e1a3fb1d47 Bug 1330791 - Enable the no-useless-call eslint rule for /services and fix associated errors. r=markh
MozReview-Commit-ID: Ixd7jk5G5CB

--HG--
extra : rebase_source : a4c226744a30df49d408a8c904fefa27b1439388
2017-01-12 18:08:10 -05:00
Jared Wein 42349d27b4 Bug 1330791 - Enable the no-unused-vars rule for eslint in /services and fix associated errors. r=markh
MozReview-Commit-ID: DFcvEllwGSb

--HG--
extra : rebase_source : 24dc56342d6b1a95df64c0c7c5a1819344cfe603
2017-01-12 18:02:08 -05:00
Jared Wein 43bac26d30 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a

--HG--
extra : rebase_source : 014c0b04d8538dc5f15bc6dd4ed6bd220c55c5d4
2017-01-17 09:48:17 -06:00
Wes Kocher f8a62a9ce6 Merge m-c to inbound, a=merge
MozReview-Commit-ID: ASajzspkOe1
2017-01-13 15:48:34 -08:00
Florian Quèze 1e42cad36c Bug 1330464 - script-generated removal of additional parameters that don't exist in the interface, r=jaws. 2017-01-13 20:21:53 +01:00
Jared Wein 65605f286e Bug 1330014 - Add .eslintrc.js file to /services and run eslint --fix to automatically fix most of the errors. --fix brings the error count down from 4083 to 321 errors. r=markh,standard8
MozReview-Commit-ID: EjyAssqiQk8

--HG--
extra : rebase_source : cbfc8d4474b6c3d46eb21374e33fd3341403444f
2017-01-10 12:09:02 -05:00
Iris Hsiao 55313b4bc9 Backed out changeset 7e0a0bd74199 (bug 1330014) 2017-01-13 11:06:43 +08:00
Jared Wein 81cb5e57b9 Bug 1330014 - Add .eslintrc.js file to /services and run eslint --fix to automatically fix most of the errors. --fix brings the error count down from 4083 to 321 errors. r=markh,standard8
MozReview-Commit-ID: EjyAssqiQk8

--HG--
extra : rebase_source : d783829bc7fced3044d0d076c4786a6957d29bb6
2017-01-10 12:09:02 -05:00
Kit Cambridge 08ec8494fb No bug - Log tracker contents in test_telemetry.js to diagnose intermittent failures. a=testonly
MozReview-Commit-ID: 2qUNV7Cz7pd

--HG--
extra : rebase_source : b9c6e4c6adc506f05ef7ec5982444aebdba32fc4
2017-01-11 15:30:25 -07:00
Mark Banner 582fcb8090 Bug 1329614 - [eslint] Catch more cases of importing globals from 'var foo = Cu.import('...');'. r=jaws
MozReview-Commit-ID: 5NKHHb70YA6

--HG--
extra : rebase_source : 4551e56f56065349fb9ddc8d90e67f9dc84c1701
2017-01-09 10:12:26 +00:00
Florian Quèze fc6379e827 Bug 1329182 - remove trailing newURI null parameters in the rest of the tree, r=jaws. 2017-01-09 20:27:26 +01:00
Mark Hammond 5f7905c8f3 Bug 1289536 (part 2) - Add a unique flowID GUID to each command sent via the clients collection. r=rnewman
MozReview-Commit-ID: 4eTFDq4Yr7S

--HG--
extra : rebase_source : faa5cb3ddd41e107b898412b0c9c5899df91c335
2016-11-04 12:46:57 +11:00
Mark Hammond 85c80336b8 Bug 1289536 (part 1) - Add events to Sync ping. r=gfritzsche
MozReview-Commit-ID: 184fIhelOa6

--HG--
extra : rebase_source : bf7c96a473b92a42411fe5c94ac6802d42ff57d5
2016-11-04 17:57:09 +11:00
Thom Chiovoloni 1330224f6a Bug 1301389 - Only include the uid and device ID once in the sync ping. r=markh
Previously this was included for each sync. In addition to being less efficient,
this makes certain info that's planned to be added in the future more difficult.

MozReview-Commit-ID: fjOvAJJVI6

--HG--
extra : rebase_source : edb9a60a101c1110560c1ceb61a927248bed06e9
2016-11-21 16:34:46 -05:00
Kit Cambridge 1897a70d72 Bug 1325523 - Clean up after tests that modify tracker contents. r=markh
MozReview-Commit-ID: 45g4n4UipTW

--HG--
extra : rebase_source : 1be78706cab9b42d0c6c949243b9a835351486fa
2016-12-29 18:18:38 -07:00
Kit Cambridge 4797a3b6cd Bug 1319175 - Switch to `JSONFile` for tracker persistence. r=markh
MozReview-Commit-ID: 6nhGe9aHSk3

--HG--
extra : rebase_source : 43449f689a47287e034b80d3cbdd2fd5fbba44ab
2016-12-20 12:25:27 -07:00
Wes Kocher b5de71ec44 Merge m-c to autoland, a=merge 2016-12-01 15:46:49 -08:00
Kit Cambridge 666a52df0a Bug 1319037 - Disable trace logging and increase timeout factor for test_bookmark_tracker.js. a=testonly
MozReview-Commit-ID: EmSdy92cYzc

--HG--
extra : rebase_source : 8e15718c657cbd7fd1ecae0bf4a4c86c51a70b8c
2016-11-29 13:21:56 -07:00
Kit Cambridge 52ddf2d3d0 Bug 1319328 - Wait for pending statements before checking annos in test_mobile_query. a=testonly
MozReview-Commit-ID: BW5b0FgvwMD

--HG--
extra : rebase_source : 6af0f95c3aca4e434533bc496f1b695b8c74100d
2016-11-29 13:13:20 -07:00
André Bargull 82ed270fce Bug 1319937 - Remove String generics uses in services/sync. r=markh 2016-11-24 13:17:08 -08:00
Thom Chiovoloni 39c3163cf7 Bug 1321396 - Skip oversized records without aborting the sync by default in sync engines. r=markh
MozReview-Commit-ID: 7hgzyKb2UxY

--HG--
extra : rebase_source : 7c7f238a8e46b0776afe83798061d1539b07f76c
2016-11-30 17:28:52 -05:00
Mark Hammond 632c46235a Bug 1317216 - consistently use the Sync client GUID as the basis for the device ID in the sync ping. r=tcsc
MozReview-Commit-ID: BDTqnM7de6n

--HG--
extra : rebase_source : 169b3ad54dd19b5ef319d1e09684c0fd474e695b
2016-11-10 19:12:55 +11:00
Mark Hammond 40140fc9de Bug 1319323 (part 2) - improve sync unit tests; SyncTestingInfrastructure now uses the FxA identity provider. r=tcsc
MozReview-Commit-ID: 2zpZMpvbAy

--HG--
extra : rebase_source : a33b15a3ef8acf39a7a423694093a690ca519c88
2016-11-22 15:03:47 +11:00
Mark Hammond f3312b9b72 Bug 1319323 (part 1) - improve sync unit tests; remove many ensureLegacyIdentityManager calls. r=tcsc
MozReview-Commit-ID: CV6cpo2Tp5O

--HG--
extra : rebase_source : 03f8fb39e69065bf7263b8bc20e4b2641a247b01
2016-11-21 12:22:24 +11:00
Kit Cambridge 73fba410f4 Bug 1173359 - Exclude hidden pages and framed links from syncing. r=markh
MozReview-Commit-ID: 8I4Sulyr0H7

--HG--
extra : rebase_source : 55fb1ff567c0a2916bc0153a09c41b03d396cfeb
2016-11-22 12:52:09 -07:00
Kit Cambridge ce8909d3fb Bug 1173359 - Convert the history tracker tests to use async functions. r=markh
MozReview-Commit-ID: CFNLQkRa7Qb

--HG--
extra : rebase_source : 086dbe074f6979428e826aa1faa7ab75100a0dad
2016-11-22 12:34:02 -07:00
Mark Hammond 682d81fa5d Bug 1316500 - remove use of tasks and promise.jsm promises from Sync tests. r=tcsc
MozReview-Commit-ID: 5itPSLBKguc

--HG--
extra : rebase_source : 2b16f697902736ef39cded96c1bd98b547136263
2016-11-10 14:34:38 +11:00
Thom Chiovoloni 15acd98009 Bug 1273342 - Don't retry skippable records that fail to sync due to being too large. r=markh
MozReview-Commit-ID: HjzL1crTVDB

--HG--
extra : rebase_source : 887c3364bf0dec05353c2ea7e7c23d6393158fa3
2016-11-21 15:37:35 -05:00
Kit Cambridge 8c2abe0611 Bug 1318414 - Default to empty strings for titles and parent titles if not set. r=rnewman,tcsc
MozReview-Commit-ID: DppxJuVrbAM

--HG--
extra : rebase_source : a214d54fda7d25798039fc9844c34cabd3165a27
2016-11-19 08:29:26 -08:00
Kit Cambridge ccee4d37f5 Bug 1258127 - Add migration logic for old synced bookmarks. r=markh,rnewman
MozReview-Commit-ID: Gye30bYZejy

--HG--
extra : rebase_source : 882c4769d28ad4b56829e5b6037f74c04028f03a
2016-11-18 14:00:56 -08:00
Kit Cambridge 4c26a7b758 Bug 1258127 - Move bookmark deletion logic into `PlacesSyncUtils.bookmarks.remove`. r=tcsc
This patch moves most of `BookmarksStore::deletePending` and
`BookmarksStore::_shouldReviveRemotelyDeletedRecord` into
`PlacesSyncUtils.bookmarks.remove` and `touch`, respectively. Both
methods use the same approach as `PlacesSyncUtils.bookmarks.dedupe` to
amend the `_modified` changeset with new change records.

We use the new `SYNC_REPARENT_REMOVED_FOLDER_CHILDREN` change source to
bump the change counters for the reparented items and their new
parents, without bumping the score and triggering extra syncs.

MozReview-Commit-ID: 1SZvygWNkgL

--HG--
extra : rebase_source : 97fdac6ccb0d0326a3da7e42259dc6a961994ac3
2016-11-17 15:07:14 -08:00
Kit Cambridge 69350f8b7b Bug 1258127 - Move bookmark de-duping logic into `PlacesSyncUtils.bookmarks.dedupe`. r=markh
This patch moves the logic from `BookmarksEngine::_switchItemToDupe`
into `PlacesSyncUtils.bookmarks.dedupe`, and updates it to work with
the new tracker. `dedupe` returns an object containing new change
records, which the bookmarks engine merges into the initial changeset
from `PlacesSyncUtils.bookmarks.pullChanges`.

This patch also removes `changeItemID` and
`PlacesSyncUtils.bookmarks.changeGuid`, since `dedupe` subsumes them.

MozReview-Commit-ID: Iw3YRxWuZnK

--HG--
extra : rebase_source : 6fd80c64b160103e1090b87a300ed74b8ef85eed
2016-11-17 15:04:19 -08:00
Kit Cambridge ccf45973d0 Bug 1258127 - Update the bookmarks engine to pull changes from Places. r=markh
MozReview-Commit-ID: 4YESuxP2rRf

--HG--
extra : rebase_source : 9c2f5830d10ba280e45c30076f19f498e6913fd0
2016-11-17 15:39:15 -08:00
Phil Ringnalda 1583627c71 Backed out changeset ca02f30bc3a0 (bug 1316500) for eslint failures 2016-11-16 19:32:10 -08:00
Mark Hammond e35c5ab29f Bug 1316500 - remove use of tasks and promise.jsm promises from Sync tests. r=tcsc
MozReview-Commit-ID: 5itPSLBKguc

--HG--
extra : rebase_source : 9c0ee4387d4b3d7df56c1e9ccda0ec39cd5b11e2
2016-11-10 14:34:38 +11:00
Kit Cambridge 6cd5db91d6 Bug 1303679 - Remove Places roots, reading list items, and pinned sites from the Sync server. r=markh
MozReview-Commit-ID: AhOBOnXsTYi

--HG--
extra : rebase_source : 1f39b406b1a9215ca04ff4602cc8fac54163916f
2016-11-09 14:23:54 -08:00
Ethan Glasser-Camp 2ee9c896d5 Bug 1253740 - Add crypto, including tests, r=rnewman
MozReview-Commit-ID: Jq8QRoNtPwb

--HG--
extra : rebase_source : 3524b723c3bf14263b54a97e4b21256d9abd180f
extra : source : 66877faacf75cd4de31ae868ce034d254ec8a080
2016-09-08 14:21:18 -04:00
Ethan Glasser-Camp ff10caa15d Bug 1253740 - Introduce extension-storage engine with a sanity test, r=markh
Note that this "enables" the engine using a pref, even though it might
not be ready yet, so that the tests can pass.

MozReview-Commit-ID: AZ0TVERiQDU

--HG--
extra : rebase_source : 8ca202c1ec79e068fb9395207792942a228d4433
extra : intermediate-source : 93f41b72d8e7023b5f22c727436e836de87c9ca7
extra : source : 183547f4dbbedc9ee3399b6a474016d0e89a12e8
2016-09-08 14:23:12 -04:00
Wes Kocher 57c08b3b40 Backed out 9 changesets (bug 1253740) for xpcshell failures a=backout
Backed out changeset 903890f218dd (bug 1253740)
Backed out changeset 1b13fe394b66 (bug 1253740)
Backed out changeset e1312ab53299 (bug 1253740)
Backed out changeset 5b5338a2baeb (bug 1253740)
Backed out changeset d3d89d4e2d87 (bug 1253740)
Backed out changeset 96da5e6944b8 (bug 1253740)
Backed out changeset 4fbff333994f (bug 1253740)
Backed out changeset 653788e146f2 (bug 1253740)
Backed out changeset b98fa03d8c15 (bug 1253740)
2016-11-11 18:59:24 -08:00
Ethan Glasser-Camp 8be871dd00 Bug 1253740 - Add crypto, including tests, r=rnewman
MozReview-Commit-ID: Jq8QRoNtPwb

--HG--
extra : rebase_source : f00b8108330a244229cf8b409bc59a4c5f331e2c
extra : source : 66877faacf75cd4de31ae868ce034d254ec8a080
2016-09-08 14:21:18 -04:00
Ethan Glasser-Camp 138ba0ff0a Bug 1253740 - Introduce extension-storage engine with a sanity test, r=markh
Note that this "enables" the engine using a pref, even though it might
not be ready yet, so that the tests can pass.

MozReview-Commit-ID: AZ0TVERiQDU

--HG--
extra : rebase_source : 3078b86c4255afd66a9c4faf895dc2b6fc43a152
extra : intermediate-source : 93f41b72d8e7023b5f22c727436e836de87c9ca7
extra : source : 183547f4dbbedc9ee3399b6a474016d0e89a12e8
2016-09-08 14:23:12 -04:00
Thom Chiovoloni 8363f8b9c7 Bug 1313573 - Validate the sync ping during TPS test runs r=markh
MozReview-Commit-ID: Jy7VpAvhbPf

--HG--
extra : rebase_source : 36dce5d68a7236d90af50756ac58dbe021d35f4f
2016-11-02 14:25:07 -04:00
Sebastian Hengst 0dc4492dd2 Bug 1310297 - Remove test annotations using b2g, mulet or gonk: services. r=RyanVM
MozReview-Commit-ID: DuzsFEaAeYr

--HG--
extra : rebase_source : b6c4cb95bf0563b0abd48949d50d2c156c86602b
2016-11-05 11:29:21 +01:00
Thom Chiovoloni b9e92c7821 Bug 1309774 - Part 2. Add version number to validation data in sync ping. r=markh
MozReview-Commit-ID: FlDSEsT1ah9

--HG--
extra : rebase_source : 327bcac18dba5c685092e311e2be880b6d616e07
2016-10-20 15:20:07 -04:00
Thom Chiovoloni c392f4a9b5 Bug 1309774 - Part 1. Sync bookmark validator should only expect to see children of roots on server. r=markh
MozReview-Commit-ID: EEoDmsnBraA

--HG--
extra : rebase_source : f122432d49a820e5e0857d82760737bd846bf377
2016-10-20 15:17:33 -04:00
Sebastian Hengst 900199872a Backed out changeset 39e08d903b48 (bug 1253740) 2016-11-02 16:40:07 +01:00
Sebastian Hengst a3865de0a1 Backed out changeset 77be2faa619f (bug 1253740) 2016-11-02 16:40:03 +01:00
Ethan Glasser-Camp 1ecd3de17d Bug 1253740 - Add crypto, including tests, r=rnewman
MozReview-Commit-ID: Jq8QRoNtPwb

--HG--
extra : rebase_source : c1eae5a9f720b02bf8aaa0f9b5bb2d205d037677
extra : source : 66877faacf75cd4de31ae868ce034d254ec8a080
2016-09-08 14:21:18 -04:00
Ethan Glasser-Camp adbd884871 Bug 1253740 - Introduce extension-storage engine with a sanity test, r=markh
Note that this "enables" the engine using a pref, even though it might
not be ready yet, so that the tests can pass.

MozReview-Commit-ID: AZ0TVERiQDU

--HG--
extra : rebase_source : e8518187e3a4f404bad193ce26f6c523ec06abe0
extra : intermediate-source : b052cf501ce8a838706f63f46eb6262b63ac5560
extra : source : 183547f4dbbedc9ee3399b6a474016d0e89a12e8
2016-09-08 14:23:12 -04:00
Thom Chiovoloni 665270b3e6 Bug 1312320 - Report mozIStorageError properly in sync ping r=markh
This required adding a new error type to the sync ping.

MozReview-Commit-ID: LoGEjI0hFRo

--HG--
extra : rebase_source : 579c33d5c4b762ac99ba39cb10bd6d4cb4c428d0
2016-10-24 11:13:26 -04:00
Kit Cambridge f8747ad476 Bug 1312857 - Pass the correct change sources in `getOrCreateTagFolder` and `importJSONNode`. r=markh
MozReview-Commit-ID: Gga9kiC3AxK

--HG--
extra : rebase_source : 0b07551617c277aeaec619d0a4432874fc77e9ec
2016-10-25 11:39:56 -07:00
Kit Cambridge 6a43fd2448 Bug 1312494 - Fix up queries that point to the wrong folder in `_ensureMobileQuery`. r=tcsc
This patch also reports validation errors for left pane queries on the
server, and removes incorrect mobile query migration code.

MozReview-Commit-ID: FT7kAZJapqE

--HG--
extra : rebase_source : 1aa2a14a245bc0bb2a044d951a4c5d274b9d9f13
2016-10-24 12:06:00 -07:00
Thom Chiovoloni 1debb3df7a Bug 1294599 - Implement batched downloads of sync collections on desktop r=markh,rnewman
MozReview-Commit-ID: 6la9t1FxQhH

--HG--
extra : rebase_source : 6fb7df03219bc5643eefc9683bd584325193f3e1
2016-10-06 17:52:27 -04:00
Thom Chiovoloni 0117e0cf73 Bug 1299978 - Reupload parents of revived bookmarks and buffer folder deletion during sync r=markh,rnewman
MozReview-Commit-ID: BDfp5FffCWh

--HG--
extra : rebase_source : 0caecb27d753577373e150dd770370bd328dbe32
2016-10-05 14:04:50 -04:00
Thom Chiovoloni b072bd5c1e Bug 1311557 - Ensure custom sync engines aren't reported in sync ping. r=markh
MozReview-Commit-ID: 1aRxo9JcCLn

--HG--
extra : rebase_source : d0136d682c656fe257fbef7c47cf793d0478cad8
2016-10-20 20:05:03 -04:00
Kit Cambridge e32178708e Bug 1310941 - Fix `BookmarksTracker.onItemChanged` arguments to avoid triggering syncs for remote changes. r=tcsc
MozReview-Commit-ID: K1OcL5m6opv

--HG--
extra : rebase_source : 610d395625a0c4841298331163bc55b89bf7fb31
2016-10-18 08:26:43 -07:00
Sebastian Hengst 9f8d517918 Backed out changeset 3ae77edf8ed2 (bug 1310941) for frequent intermittent xpcshell failure in test_bookmark_engine.js. r=backout 2016-10-18 21:45:09 +02:00
Kit Cambridge 5c7c675383 Bug 1310941 - Fix `BookmarksTracker.onItemChanged` arguments to avoid triggering syncs for remote changes. r=tcsc
MozReview-Commit-ID: K1OcL5m6opv

--HG--
extra : rebase_source : 5c1fb39a027cfebb363a8031639256d3ae7c86d0
2016-10-18 08:26:43 -07:00
Thom Chiovoloni be9c5a302c Bug 1308567 - Include information about associated devices in sync ping r=bsmedberg,markh
MozReview-Commit-ID: 45c4skQHswy

--HG--
extra : rebase_source : 794f0b0d453596fdec84066bfbb966d81da62372
2016-10-11 14:07:52 -04:00
Mark Hammond 6cbb6e1ffe Bug 1310525 - don't exceed sqlite's max variable limit when many changed bookmarks exist. r=kitcambridge
MozReview-Commit-ID: H2l2L9fZm9t

--HG--
extra : rebase_source : 128c420cf7dc7d6ba1ef71bbc99be5a518a1dcab
2016-10-17 12:54:05 +11:00
Thom Chiovoloni c9102d7409 Bug 1308841 - Sanity check client-side bookmark roots in sync validator r=markh
MozReview-Commit-ID: 6Y5qfCtVYWf

--HG--
extra : rebase_source : e02121eea46e1625d7ce202e9b379cdf4d3254f9
2016-10-11 12:54:01 -04:00
Kit Cambridge 8d01843b2f Bug 1309647 - Remove remaining uses of `BookmarkSpecialIds` from `_ensureMobileQuery`. r=tcsc
MozReview-Commit-ID: A6u6SIx2jBL

--HG--
extra : rebase_source : 9ff9a42971d73e7d34755085fd70e8bd94930443
2016-10-12 10:56:00 -07:00
Kit Cambridge 484808a00f Bug 1295521 - Add a `toSyncBookmark` method and clean up `BookmarksStore`. r=markh
MozReview-Commit-ID: 3h2qnOtNPN9

--HG--
extra : rebase_source : 0d657035d02c8bd261f1124072d6a248c94c7e09
2016-09-20 01:52:58 -07:00