This makes prefs definition simpler, more consistent, and less error-prone.
Differential Revision: https://phabricator.services.mozilla.com/D41145
--HG--
extra : moz-landing-system : lando
This patch fixes the issue by updating the allow list as soon as the
switch been toggled. And the reload still happens after the 500ms delay.
We cache the target tab in order to reload the correct tab in case tabs
change and reload the target tab after the delay. In additon, we won't
reload the tab if is has been closed since it is totally unnecessary.
We also add a test for this.
Differential Revision: https://phabricator.services.mozilla.com/D43139
--HG--
extra : moz-landing-system : lando
performAction, performActionOnRow and performActionOnCell are methods of the
nsITreeView interface that are never called. This is to remove these methods.
A comm-central patch will be along shortly.
Differential Revision: https://phabricator.services.mozilla.com/D39273
I didn't switch to using an A element with href= since the link target depends on the value of a preference, which is set at runtime in browser_dismissFooter.js and would necessitate refactoring of the test.
Differential Revision: https://phabricator.services.mozilla.com/D43124
--HG--
extra : moz-landing-system : lando
The site identity and security sub panels now contain that much information that it warrants to make these more easily navigable for NVDA and other screen readers. The panels behave as before, but the added roles and heading levels cause NVDA and other screen readers to use their browse mode features instead of regular application interaction so blind and visually impaired users can review the information more easily.
Differential Revision: https://phabricator.services.mozilla.com/D42924
--HG--
extra : moz-landing-system : lando
We need to start engagement event recording when the view opens due to `openViewOnFocus`. We already do for mouse clicks since we call `engagementEvent.start` from `_on_mousedown`. But we don't for the Ctrl/Command-L key shortcut. The shortcut command calls `openLocation` in browser.js, which calls `gURLBar.startQuery` but not `engagementEvent.start`.
Every time we call `engagementEvent.start`, we do it before calling `input.startQuery`. The one exception is in `input._on_drop` because there we just handle the dropped value directly instead of starting a new query with it.
The inverse is also mostly true, i.e., every time we call `input.startQuery`, we also call `engagementEvent.start`. The three exceptions are: in UITour (where it looks like we should be calling `urlbar.search` instead), in `UrlbarInput` after picking a keyword offer result, and in `openLocation` in browser.js (mentioned above). So really the only valid place is after picking a keyword entry.
So, it makes sense to move `engagementEvent.start()` into `input.startQuery` so that callers don't have to call it. I added an `event` param to `startQuery`, since `engagementEvent.start` needs one. I considered removing that need. It's possible, but then we would need a way to avoid calling `engagementEvent.start` in the keyword offer case, so `startQuery` would need something like a `suppressEngagementEvent` param. `event` basically functions as that, so I left it.
Another thing to point out about this patch is that I chose to record a "typed" value when the pageproxystate is invalid and the view opens due to `openViewOnFocus`. The view does not show the user's top sites in that case, so "topsites" seems wrong.
Differential Revision: https://phabricator.services.mozilla.com/D42749
--HG--
extra : moz-landing-system : lando
The preference is only exposed if media.videocontrols.picture-in-picture.enabled is set
to true.
Differential Revision: https://phabricator.services.mozilla.com/D42688
--HG--
extra : moz-landing-system : lando
This patch ultimately overrides the user-agent which Fennec users send to Google Search pages, choosing a phone- or tablet-specific UA as appropriate.
It involves adding four new metadata keys to the webcompat addon's metadata for user-agent overrides: blocks, permanentPref, experiment, telemetryKey:
- "blocks" specifies URLs for which any requests should be aborted. This allows us to block the Google service worker for now, as it has caused "content corrupted" issues in the past with other enhanced search addons (see https://github.com/wisniewskit/google-search-fixer/issues/1).
- "permanentPref" specifies an about:config preference, which dictates whether the injection is used. Users may set this to `false` to disable the injection outright, and permanently; `true` or `undefined` values allow the injection to function normally.
- "experiment" specifies the name of the experiment this feature is optionally gated behind. Only a Fennec-specific implementation is provided in this patch. The implementation simply queries Switchboard to determine if the experiment is active.
- "telemetryKey" specifies which telemetry key should be flipped to "true" when this injection runs. We will use this to note whether enhanced search has actually been enabled for this profile. Only a Fennec-specific implementation is given in this patch, which actually just sets a Fennec Shared Preference, which Fennec's core telemetry ping later reads in Java to know what the ping should contain.
Differential Revision: https://phabricator.services.mozilla.com/D41074
--HG--
extra : moz-landing-system : lando
This patch adds a test case to check the visibility of the track counter
is correct in different situations, including zero tracker, one tracker
and multiple trackers.
Also, this patch fixes an issue that the
BrowserTestUtils.waitForAttributes() won't work if the waiting
attributes doesn't have a value or has an empty string as its value.
We check the value of the observing attribute to verify if it is
existing, however an empty string will be treated as a false, so it
won't pass the check if the attribute doesn't have a value. Hence, we
should use hasAttribute() instead of getAttribute() to check the
existence of the attribute.
Differential Revision: https://phabricator.services.mozilla.com/D42718
--HG--
extra : moz-landing-system : lando
By only hiding the tracker counter when the tracker counter is zero and
show the counter always other than that. By doing so, the counter
would be shown properly according the tracker number.
Differential Revision: https://phabricator.services.mozilla.com/D42717
--HG--
extra : moz-landing-system : lando
We use the locale of the application to show the number of the trakcer
counter.
Differential Revision: https://phabricator.services.mozilla.com/D42716
--HG--
extra : moz-landing-system : lando
This Change removes all call to Exists() in Directory Provider component, which creates the possibility for the componenet to return an empty list. SearchService.jsm is modified to handle this possibility.
Differential Revision: https://phabricator.services.mozilla.com/D42772
--HG--
extra : moz-landing-system : lando
* Skip showing the password manager items in the context menu from an about: page
Differential Revision: https://phabricator.services.mozilla.com/D42963
--HG--
extra : moz-landing-system : lando
Instead of using symlinks, copy .dylib files to the ${OBJDIR}/dist/Nightly{Debug}.app/Contents/MacOS dir for local builds.
Differential Revision: https://phabricator.services.mozilla.com/D41926
--HG--
extra : moz-landing-system : lando
This picks up various improvements, especially to how configurations are handled and some new rules.
Differential Revision: https://phabricator.services.mozilla.com/D37271
--HG--
extra : moz-landing-system : lando
This is the last message that WebProgressChild was sending to the
RemoteWebProgress in the parent process, so we can remove the module entirely.
Differential Revision: https://phabricator.services.mozilla.com/D35091
--HG--
extra : moz-landing-system : lando
At least for now, this behavior is behind a hidden pref. The intent is to
experiment with the feature and determine that way whether enabling it
permanently is a good idea, and if so the pref gate will be removed in a
separate bug.
This patch depends on bug 1567247 and will fail to build without it.
Differential Revision: https://phabricator.services.mozilla.com/D41100
--HG--
extra : moz-landing-system : lando
We intentionally only clean out the prefs registry key during uninstall, unlike
the other registry keys that the installer creates, because we might want to do
experiments that involve the procedures that normally clean out registry keys.
This leaves open the possibility that an experiment causes some problem that
by its nature makes it difficult to disable the experiment, since it wouldn't
be disabled by either a normal update or a paveover install, but it's
necessary to make sure that experiments persist for longer than e.g. a single
update cycle.
Depends on D40327
Differential Revision: https://phabricator.services.mozilla.com/D40328
--HG--
extra : moz-landing-system : lando
This Change removes all call to Exists() in Directory Provider component, which creates the possibility for the componenet to return an empty list. SearchService.jsm is modified to handle this possibility.
Differential Revision: https://phabricator.services.mozilla.com/D42772
--HG--
extra : moz-landing-system : lando
Disable -ftrivial-auto-var-init for DllBLocklistWin.cpp with clang-cl because the file's interceptions happen so early in the main process that the loader hasn't yet resolved the import of memset (used by -ftrivial-auto-var-init) from vcruntime140.dll.
Disable -ftrivial-auto-var-init on Linux32 because it causes some xpcshell test failures.
Differential Revision: https://phabricator.services.mozilla.com/D42273
--HG--
extra : moz-landing-system : lando
This patch fixes the style issue by make the container of the permission
granted indicator to centered align its children.
Differential Revision: https://phabricator.services.mozilla.com/D42617
--HG--
extra : moz-landing-system : lando
Corroborator.jsm no longer causes file I/O on early startup before user input is possible.
Depends on D41693
Differential Revision: https://phabricator.services.mozilla.com/D42585
--HG--
extra : moz-landing-system : lando
* Add a new extensionStorage actor to enable inspection of data stored by an extension using the WebExtension storage.local API in the Storage panel client.
* The actor is only listed when the developer toolbox is targeting an extension process. For multi-process Firefox (e10s), this applies to only the toolbox accessed in about:debugging.
* The actor is gated behind a preference: devtools.storage.extensionStorage.enabled. This preference is set to false by default.
* The Storage panel displays storage item values as strings. If a storage item value is not JSON-stringifiable, it will be displayed in the table as "Object".
* It should be noted that extension storage.local’s storage backend is in the process of migrating from a JSON file to IndexedDB as of Firefox 66 for performance reasons. This actor only works for extensions that have migrated to the IndexedDB storage backend.
* In-line comments referencing Bugs 1542038 and 1542039 indicate places where the implementation may differ for local storage versus the other storage areas in the actor.
Differential Revision: https://phabricator.services.mozilla.com/D34415
--HG--
extra : moz-landing-system : lando
The mozconfig in the task definition is overriden in hazard-browser.sh,
so it has effectively no effect, and hazard-browser.sh has been using
js/src/devtools/rootAnalysis/mozconfig.haz since bug 1321014.
Differential Revision: https://phabricator.services.mozilla.com/D41879
--HG--
extra : moz-landing-system : lando
Running with -silent does not result in the quit application granted notification.
Without that notification, we have a deadlock in EnvironmentAddonBuilder where it blocks
beforeShutdown waiting on the XPIDatabase to load.
Differential Revision: https://phabricator.services.mozilla.com/D41877
--HG--
extra : moz-landing-system : lando
Don't show the login in about:logins if the username or password cannot be decrypted.
Differential Revision: https://phabricator.services.mozilla.com/D40845
--HG--
extra : moz-landing-system : lando
While NVDA works fine with the current implementation, JAWS needs the divs themselves to have an explicit role to pick them up properly and read them to the user. Since the divs essentially contain a graphical representation, the "img" role is appropriate to use in this context. This makes JAWS pick up the information for each bar.
Differential Revision: https://phabricator.services.mozilla.com/D42266
--HG--
extra : moz-landing-system : lando
In order to use `mscom::ProcessRuntime` in the maintenance service, we need
`ProcessRuntime` to be able to distinguish between more than just whether or not
the current process is the parent process.
I've added a new `ProcessCategory` enum to track this information, and revised
the constructors so that we now have one that accepts a ProcessCategory.
The `ProcessCategory` constructor is private inside XUL, since the
`GeckoProcessType` variant should always be used in that case.
We also slightly change apartment initialization to depend on the underlying
`ProcessCategory` value.
Finally, I modify the one case where we instantiate a `ProcessRuntime` in the
launcher process to use the new constructor.
Differential Revision: https://phabricator.services.mozilla.com/D42225
--HG--
extra : moz-landing-system : lando
In the old way, if referrer is ommited we will not be able to go to
download page. In that case, we should use originalReferrer in
ReferrerInfo object
Differential Revision: https://phabricator.services.mozilla.com/D39875
--HG--
extra : moz-landing-system : lando
This test runs on a cross-process iframe, so some code has to get
moved into a call to SpecialPowers.spawn().
Differential Revision: https://phabricator.services.mozilla.com/D42387
--HG--
extra : moz-landing-system : lando
Includes:
- Text for legend tabs
- Accessible colors for Lockwise and Monitor cards' number labels.
Differential Revision: https://phabricator.services.mozilla.com/D41648
--HG--
extra : moz-landing-system : lando
We've had this enabled and holding on Nightly for a while now, but
it's not been able to ride the trains due to a number of issues.
In the interests of testing what we ship, we should disable it until
it's closer to being ready to ship.
Differential Revision: https://phabricator.services.mozilla.com/D42209
--HG--
extra : moz-landing-system : lando
This patch adds some missing rules for showing the proper hover state in Linux.
Depends on D42282
Differential Revision: https://phabricator.services.mozilla.com/D42283
--HG--
extra : moz-landing-system : lando
We need to overwrite the '-moz-appearance' CSS rule of the buttons in
the footer section of the protections panel in order to properly style
the buttons.
Differential Revision: https://phabricator.services.mozilla.com/D42282
--HG--
extra : moz-landing-system : lando
This patch adds the permission granted indicator to the identity panel.
The granted indicator will be shown if there is any granted permission.
And it will got update if permission changes. We also update a test for
this change.
Differential Revision: https://phabricator.services.mozilla.com/D42121
--HG--
extra : moz-landing-system : lando
This patch adds a permission indictor on the lock icon and it is only
shown if there is any permission has been granted.
Differential Revision: https://phabricator.services.mozilla.com/D42119
--HG--
extra : moz-landing-system : lando
The patch also removes several comments from the top of the file, every single
one of which is incorrect.
Differential Revision: https://phabricator.services.mozilla.com/D41315
--HG--
extra : moz-landing-system : lando
The graphics sanity test code calls GetSnapshot early on (see bug 1573852). We
currently allow it later, but there's nothing that keeps it from happening
early so we should allow it.
Differential Revision: https://phabricator.services.mozilla.com/D42191
--HG--
extra : moz-landing-system : lando
This adds some polish to the existing markup, making it all a bit more intuitive.
1. Associate the graph legend to the fake table so it becomes kind of the caption for that table for screen reader users. Screen reader users will then hear something like "Table showing a graph of .." plus the table information they already get since bug 1573197 landed.
2. Actually combine the number and tab's title into a spoken label for screen readers on each radio button, and for the description, use the explanatory paragraph's content. That way, screen reader users can just tab and arrow to each item in focus mode and hear all the relevant information at once without having to skip back and forth between the elements.
Differential Revision: https://phabricator.services.mozilla.com/D42082
--HG--
extra : moz-landing-system : lando
The remaining uses all need adjustements to in-tree mozconfigs, so they
all need to be done at once.
However, to make things slightly more intelligible, we do this in two
steps. This is step 1: we modify the use_toolchain transform to take care of
the transformation, while keeping the task definitions intact, so that
we only deal with mozconfig and build script adjustements here.
Differential Revision: https://phabricator.services.mozilla.com/D41890
With the removal of the old Chromium file_util code, we should no longer
be using temporary files with names starting with "org.chromium.", so the
crash reporter and main thread I/O test no longer need to recognize that
prefix.
Differential Revision: https://phabricator.services.mozilla.com/D34629
--HG--
extra : moz-landing-system : lando
The tests for unexpected main thread I/O had exemptions for the specific
paths that were being used for shared memory, which would cause it to
fail with the changes in this bug. This patch does two things:
1. On Linux, /dev/shm is always tmpfs (a memory filesystem), so it's not
going to cause disk I/O, and it's used by glibc to implement the POSIX
standard shm_open API. This allows all /dev/shm paths instead of
limiting it to a hard-coded prefix.
2. On MacOS, with the patches in this bug, we'll no longer use temporary
files for shared memory on current OS versions, but we still need them on
older versions to avoid an OS bug (https://crbug.com/project-zero/1671),
and they are backed by disk in this case, so we want to allow only the
IPC files. However, the path prefix has changed.
Differential Revision: https://phabricator.services.mozilla.com/D34628
--HG--
extra : moz-landing-system : lando
The main part of the change is the change to ChildSHistory - make it possible to have Go() to be called asynchronously
and also let one to cancel pending history navigations. History object (window.history) can then use either the sync or
async Go(), depending on the dom.window.history.async pref.
LoadDelegate, which is used by GeckoView, needs special handling, since
it spins event loop nestedly. With session history loads and same-document loads we can just
bypass it.
To deal with same-document case, MaybeHandleSameDocumentNavigation is split to IsSameDocumentNavigation,
which collects relevant information about the request and returns true if same-document navigation should happen,
and then later HandleSameDocumentNavigation uses that information to trigger the navigation.
SameDocumentNavigationState is used to pass the information around.
referrer-policy-test-case.sub.js is buggy causing tests to pass only on Firefox with sync history API.
nested-context-navigations-iframe.html.ini is added because of https://bugzilla.mozilla.org/show_bug.cgi?id=1572932
Differential Revision: https://phabricator.services.mozilla.com/D41199
--HG--
extra : moz-landing-system : lando
If Init() completes before we call EnsureGPUReady we won't send GetDeviceStatus
so we can safely ignore if unused.
Differential Revision: https://phabricator.services.mozilla.com/D41851
--HG--
extra : moz-landing-system : lando
This makes prefs definition simpler, more consistent, and less error-prone.
Differential Revision: https://phabricator.services.mozilla.com/D41324
--HG--
extra : moz-landing-system : lando
This will allow these heuristics to be used on mobile.
This depends on GeckoView supporting a JavaScript module
at resource:///modules/BrowserUsageTelemetry.jsm with the
interface described in nsIBrowserUsage.idl. Bug 1573238 has
been filed in order to implement this module on GeckoView.
Differential Revision: https://phabricator.services.mozilla.com/D41621
--HG--
extra : moz-landing-system : lando
We show the number of tracker if the data is up-to-date when opening the
panel.
Differential Revision: https://phabricator.services.mozilla.com/D41747
--HG--
extra : moz-landing-system : lando
The patch also removes several comments from the top of the file, every single
one of which is incorrect.
Differential Revision: https://phabricator.services.mozilla.com/D41315
--HG--
extra : moz-landing-system : lando
MANUAL PUSH: This is mhowell manually combining a new contributor's patch stack.
Differential Revision: https://phabricator.services.mozilla.com//D41477
--HG--
extra : source : 7219965f391ab9b548ea0e9305ef5acafd2640d5
extra : amend_source : 9a7c03a5e8a7c6a2ec7ca005cda08336846ec977
For accessibility, the address bar is now exposed as a parent combo box which contains the input and the results list.
The combo box role on urlbarView-body-inner is no longer needed and has therefore been removed.
This means screen readers no longer report an extraneous combo box whenever the results list is opened.
Differential Revision: https://phabricator.services.mozilla.com/D40917
--HG--
extra : moz-landing-system : lando
The patch adds back the 'position: relative;' rule to the tracking
protection icon container. This is need in order to position the blue
dot.
Differential Revision: https://phabricator.services.mozilla.com/D41507
--HG--
extra : moz-landing-system : lando
Replaced the message body div with an unstyled button element, which creates the correct tabbing behavior.
Differential Revision: https://phabricator.services.mozilla.com/D41829
--HG--
extra : moz-landing-system : lando
Some tests check that the remote type is "web", but with Fission it
will instead start with "webIsolated=".
I fixed some of the errors in
browser_new_web_tab_in_file_process_pref.js and
browser_httpResponseProcessSelection.js, but there are other failures,
so they remain disabled.
Differential Revision: https://phabricator.services.mozilla.com/D42354
--HG--
extra : moz-landing-system : lando
This is probably the simplest way to implementing this. We might also decide to show the normal lock icon, but still
show a bit of a different text in the popup. I think this that might just be confusing though.
Differential Revision: https://phabricator.services.mozilla.com/D41285
--HG--
extra : moz-landing-system : lando
Don't show the login in about:logins if the username or password cannot be decrypted.
Differential Revision: https://phabricator.services.mozilla.com/D40845
--HG--
extra : moz-landing-system : lando
This change adds a new export, SendUIMessageToVRWindow, from vrhost.dll
that allows the caller to forward a subset of UI messages to the VR
window in Firefox.
Differential Revision: https://phabricator.services.mozilla.com/D40828
--HG--
extra : moz-landing-system : lando
Sylvestre Ledru
Coroiu Cristina
Dorel Luca
Matthew Noorenberghe
Luke Crouch
Ed Lee
Nicholas Nethercote
Sebastian Hengst
Nihanth Subramanya
Tim Huang
Ciure Andrei
Sam Foster
Alex Vincent
Narcis Beleuzu
Michael Kaply
Andrew Swan
Noemi Erli
mcrawford@mozilla.com
Jared Wein
Omkar Konaraddi
Tim Nguyen
Peter Van der Beken
Emilio Cobos Álvarez
Olli Pettay
Mike Hommey
Dão Gottwald
Ryan VanderMeulen
Vijay Budhram
Johann Hofmann
Marco Zehe
Andrei Oprea
Drew Willcoxon
Mike Conley
ffxbld
Thomas Wisniewski
ruthra kumar
Paul Zuehlcke
Mark Banner
lesleynorton
Andreas Farre
Arpit Bharti
Haik Aftandilian
Kris Maglione
harry
Oana Pop Rus
Barret Rennie
Matt Howell
Emily McMinn
Thomas Nguyen
Megha
Daniel Varga
Mihai Alexandru Michis
Andrew McCreight
Chris Peterson
Micah Tigley
Brindusan Cristian
Robert Helmer
Abdoulaye O. Ly
Bianca Danforth
Carolina
Cosmin Sabou
Razvan Maries
Moritz Birghan
Shane Caraveo
Aaron Klotz
Nan Jiang
Sebastian Streich
dennisschagt
Jeff Muizelaar
Csoregi Natalia
Scott
meghaaa
Bogdan Tara
Jed Davis
Ehsan Akhgari
L10n Bumper Bot
Itiel
arthur.iakab
Edouard Oger
Gijs Kruitbosch
Francesco Lodolo (:flod)
Dale Harvey
preyunk
James Teh
Liang-Heng Chen
mandy cheang
Stephen Horlander
Alexander Surkov
Erica Wright
Tom Schuster
thomasmo
Jan-Ivar Bruaroey