The current implementation of addContentEventListener() is centered
around the message manager. When any message manager goes away, it
cleans up everything, which does not work when Fission is enabled and
we do a cross-process navigation.
My new implementation instead uses window actors. Message manager
shared state is used to store the set of expected event listeners. New
windows, after the function is called for the first time in a test,
will get listeners added properly. Of windows that exist at the first
time the function is called in a test, only windows associated with
the BC of the browser that is passed in will get added, which is a
disadvantage relative to the current setup. That could probably be
fixed.
We auto remove at the end of the test, not when any message manager is
torn down, so there's never a need to disable auto removal.
Differential Revision: https://phabricator.services.mozilla.com/D48777
--HG--
extra : moz-landing-system : lando
This allows generic code, like a testing JSM, to do clean up when a
test completes, in a way that will work in different test suites.
Differential Revision: https://phabricator.services.mozilla.com/D50648
--HG--
extra : moz-landing-system : lando
Android TV has appropriate configuration, so updating these defaults makes
no practical difference, but I think it looks a little more modern.
Differential Revision: https://phabricator.services.mozilla.com/D50986
--HG--
extra : moz-landing-system : lando
Adds an additional "unload" listener in BrowserTestUtils.browserLoaded to
unregister the original load listener and reject the promise.
This was broken because BrowserTestUtils.waitForNewWindow adds an observer that
fires for every new window. The observer calls BrowserTestUtils.browserLoaded on
all of these windows, and since only one of them loads the URL we care about, we
never unregister the event listeners from the remaining windows.
Depends on D49005
Differential Revision: https://phabricator.services.mozilla.com/D50658
--HG--
extra : moz-landing-system : lando
This also updates the two functions (BrowserTestUtils.firstBrowserLoaded,
browser_broadcastchannel.js#browserFrameLoaded) that rely on the previous
event to use the new one.
Depends on D49001
Differential Revision: https://phabricator.services.mozilla.com/D49002
--HG--
extra : moz-landing-system : lando
This is the smallest change that helps having a clean baseline when we start using "Inspect Element" in the inspector custom test
Differential Revision: https://phabricator.services.mozilla.com/D50589
--HG--
extra : moz-landing-system : lando
The patch removes the usage of elements based on anonymous nodes,
which are soon to be completely removed. Also code which is no longer
in use by Firefox-UI tests can simply be removed.
Differential Revision: https://phabricator.services.mozilla.com/D50803
--HG--
extra : moz-landing-system : lando
This updates the Gecko implementation to match the following change to
the Web Animations spec:
792453b952 (diff-4c9f5c055fb219a7fcad23a9a7a80b64)
Differential Revision: https://phabricator.services.mozilla.com/D50768
--HG--
rename : testing/web-platform/tests/web-animations/interfaces/Document/getAnimations.html => testing/web-platform/tests/web-animations/interfaces/DocumentOrShadowRoot/getAnimations.html
extra : moz-landing-system : lando
normal-flow-overconstrained-vlr-005.xht and
normal-flow-overconstrained-vrl-004.xht have been fixed by blink team
per bug 1580385 comment 1, and Firefox passes them. We can delete the
meta files.
Differential Revision: https://phabricator.services.mozilla.com/D50776
--HG--
extra : moz-landing-system : lando
The spec change HTMLObjectElement tabIndex default to 0, but `test_object_plugin_nav.html` will fail due to HTMLObjectElement’s sequence focus and .focus() rely on default tabIndex. In this patch I separate the logic to not rely on default tabIndex for HTMLObjectElement's plugin type and align the spec.
Differential Revision: https://phabricator.services.mozilla.com/D50801
--HG--
extra : moz-landing-system : lando
This is part of an attempt to make subtest names independent of the performance of the test.
Depends on D47024
Differential Revision: https://phabricator.services.mozilla.com/D47025
--HG--
extra : moz-landing-system : lando
With this patch, picture cache slices are constructed each time
a new scroll root is established. This reduces rasterization
cost on pages that have large fixed position elements, and pages
that contain multiple scroll roots.
Differential Revision: https://phabricator.services.mozilla.com/D50026
--HG--
extra : moz-landing-system : lando
Automatic update from web-platform-tests
[ElementTiming] Cleanup window.location.href usage in tests
This CL removes window.location.href usage in element-timing tests and
uses window.location.origin instead, which makes the pathname
computation cleaner. It also adds t.step_func where it is missing.
Change-Id: Iabaac33eb65f9ed24f68e7fa583c8de05d1264c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872762
Reviewed-by: Tom McKee <tommckee@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707954}
--
wpt-commits: e42570fe16dd112aeacad78eb011daca434629a0
wpt-pr: 19813
Automatic update from web-platform-tests
[ElementTiming] Allow empty but present elementtiming attribute
This CL changes the behavior in cases where the elementtiming attribute
is set but not to a specific value, so that the affected elements are
considered registered for observation. It also adds a test with image
and text testcases. This follow the spec change at
https://github.com/WICG/element-timing/pull/38
Bug: 1011009
Change-Id: If33f55b0992545e6e13f108b923bbcfc546f4d33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871638
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707947}
--
wpt-commits: 6174e0943360abb81f64a54205a7782531cddcaa
wpt-pr: 19812
Automatic update from web-platform-tests
[Reland] Composited Worklet Animations: Fixed updating local time on main thread.
The original CL caused flakiness of /virtual/threaded/animations/animationworklet* tests
(crbug.com/1014966). The reason for the flakiness is change in timing of main thread effect local
time update.
Reverted CL: https://chromium-review.googlesource.com/c/chromium/src/+/1826872
The reverted CL is in Patchset 1.
Patchset 2 fixes the tests by explicitly waiting for the effects to change.
This CL changes how local time of composited worklet animations is updated on main thread:
instead of polling local time on main thread, the local time is posted via animation events
by the composited thread to the main thread.
Design document: https://docs.google.com/document/d/1vUxaKBLDHQv9ACJUQJH4RXjuQTlWIsSiAFYkMrjccyc/edit?usp=sharing
Changes made:
- Expanded AnimationEvent to support worklet animation time update event type.
- Reused existing mechanism of posting animation events to the main thread to support new
event type.
- Removed "peek" logic.
- Enabled tests that previously failed.
Bug: 943787
Change-Id: I9a2965f204cad15b405be82305c38788c0eafd62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864518
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#707904}
--
wpt-commits: f256ed473b61236ab154e21797c8b96436062bb0
wpt-pr: 19774
Automatic update from web-platform-tests
Update service_worker_unregister_and_register()
Allows callsites of this helper function to pass RegistrationOptions.
It will be useful for testing module service workers.
Bug: 824647
Change-Id: Idc9a5c012144da46dfc4d692ce26df9f604a6ea1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851624
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704963}
--
Stop using default parameters in service_worker_unregister_and_register()
The previous CL (crrev.com/c/1851624) seemed to make some tests flaky.
I'm not sure the exact reason. This CL attempts to fix flakiness by not
using default parameters.
Bug: N/A
Change-Id: Ia6fae23881704e4eb41e33ebe3e22e89872d7f87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866093
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707713}
--
wpt-commits: 9cb445cb5b453bc5aecb0c349ab062627bcefe10, 9c6848c2e4d7284ba326fe7898c6616c9b29854d
wpt-pr: 19613
Automatic update from web-platform-tests
autofocus: Change the timing of 'flush autofocus candidates'
* ScriptedAnimationController kicks Document::FlushAutofocusCandidates
Now ScriptedAnimationController takes into account of existence of
autofocus candidates.
* Document::FlushAutofocusCandidates needs to call
UpdateStyleAndLayoutTree() for each of candidates.
IsFocusable() needs up-to-date style. UpdateStyleAndLayoutTree() was
unnecessary because FlushAutofocusCandidates() was called after
layout.
Bug: 1015275
Change-Id: I06dcb9b3cd2564d35fba3f893e7ce4b8736c91bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863067
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707201}
--
wpt-commits: fd4814ce7fcc4d6c23c73aac62daa8299feb0510
wpt-pr: 19747
Automatic update from web-platform-tests
s/NFC/NDEF/g in NFC interfaces and dictionaries (#19805)
This CL renames NFCReader to NDEFReader, NFCWriter to NDEFWriter,
NFCReadingEvent to NDEFReadingEvent, NFCScanOptions to NDEFScanOptions,
NFCPushOptions to NDEFPushOptions, and NFCError to NDEFError as
suggested in Web NFC spec at https://github.com/w3c/web-nfc/pull/392
Bug: 520391
Change-Id: Ifc7d26d68b76bbf771a83cba94fc275819c28cfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869227
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#707736}
--
wpt-commits: 9f8e5f67582ccdef98faa436aa5996f2b6ffe207
wpt-pr: 19805
Automatic update from web-platform-tests
Fix URL setter tests for gopher no longer being special
Part of https://github.com/whatwg/url/issues/455.
--
wpt-commits: 43feb7f612fe9160639e09a47933a29834904d69
wpt-pr: 19790
Automatic update from web-platform-tests
Make a check for the initial value of selectionDirection less strict. (#10571)
Only run tests for the non-applicability of the selection API for supported types.
There's little point in running these tests; they should all fail, because
browsers will fall back to the 'text' type, which does support the API.
I didn't make the test fail if one of the types is not supported; there's
already a number of tests for that, and it isn't really the point of this one.
--
wpt-commits: b25863a805ab244fddb460cce3f6ebf62af12e70
wpt-pr: 10571
Marco Bonardo
Andrew McCreight
Geoff Brown
Henrik Skupin
Kashav Madan
Cosmin Sabou
Narcis Beleuzu
Emilio Cobos Álvarez
Julian Descottes
Brian Birtles
Neil Deakin
Ting-Yu Lin
John Dai
Karl Tomlinson
David Burns
Andreea Pavel
Nicolas Chevobbe
Glenn Watson
Rob Wu
Mihai Alexandru Michis
James Graham
moz-wptsync-bot
Raphael Kubo da Costa
Victor Costan
Nicolás Peña Moreno
Olga Gerchikov
autofoolip
Kenichi Ishibashi
Kent Tamura
Stephen McGruer
Domenic Denicola
Ms2ger