This patch:
-Maintains consistency between the fxa and remote tabs' panels "sync now" buttons
-Removes a fluent string no longer in use
-Restores tooltip functionality
Differential Revision: https://phabricator.services.mozilla.com/D106651
* Applies it on toolbarpaletteitem for customize mode.
* Stops applying it on every child of the first toolbaritem child, since the content of toolbaritem is unpredictable (zoom-controls, reload/stop, profiler icon & dropmarker.
Differential Revision: https://phabricator.services.mozilla.com/D108258
This is not an exhaustive redress of the WebRTC panel. It just replaces the labels
preceding the camera/microphone selectors with icons if Proton is enabled. There's
still a bunch of styling work to do in this panel for Proton, but that will occur
in a follow-up patch.
Differential Revision: https://phabricator.services.mozilla.com/D107718
There are a few things happening in this patch:
1. New colours are defined in proton-dark/manifest.json. This will be merged with dark/manifest.json when Proton is ready.
2. I removed specific rules for [lwt-default-theme-in-dark-mode]. The [current plan](https://docs.google.com/document/d/1Zh1Nr_lBKpCp4mW-cn6ouaq0ZueK-ReQokyKfQvWiSE/edit#) is to merge proton-dark/manifest.json with default-theme/manifest.json when Proton is ready.
3. Two different borders can now be set on the Urlbar: toolbar_field_focus_border when the panel is closed, and popup_border when it is open. This is a behaviour change, but it's actually consistent with [the documentation](https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/theme#images).
4. popup_border/arrowpanel-border-color is now transparent on non-LWT non-Linux non-HCM. This affects other panels, but I verified with UX on Slack that all light mode Proton panels are losing their border in favour of drop-shadows. These colours are set in browser-custom-colors which is a new sheet that will set Proton's saturated colours. I also moved some rules to that sheet from urlbarView.inc.css that were serving the same purpose.
5. A border is now shown around the searchbar popup. We never set a border-width on it! We were setting border-color so I don't know if this was intentional or just a bug.
Differential Revision: https://phabricator.services.mozilla.com/D107011
With the changes in part 1, the newtab page would now be rendered with a dark
theme if the user has prefers-color-scheme: dark due to OS styling, but
explicitly selects the provided "Light" theme.
This patch explicitly specifies the text and background colors in the "Light"
theme, ensuring that the newtab page will always be rendered with a light
colorscheme if the "Light" theme is selected, which is more in-line with the
previous behaviour and consistent with the built-in "Dark" theme.
Differential Revision: https://phabricator.services.mozilla.com/D107772
I also noticed while trying out this patch that the context menu navigation
icons really need to also scale with the font size, so I've fixed that here
along with the submenu arrows.
Differential Revision: https://phabricator.services.mozilla.com/D107570
We use it for the awesomebar outline so I think it makes sense, it certainly
feels off to have a blue tab line but an accent-colored outline.
Differential Revision: https://phabricator.services.mozilla.com/D107626
The regression is actually caused by having changed urlbar-icon padding to a padding-inline, that was actually
an oversight due to the padding being excessive, with a 1px transparent border, we only need a 1 px padding.
This patch also tries to unify the padding management across urlbar icons and identity icons, because otherwise
in compact mode some icons padding gets unusually large, and they don't grow enough in touch mode.
Once Proton will be default this will allow simpler management of the paddings and urlbar sizes.
Differential Revision: https://phabricator.services.mozilla.com/D107422
Wrapping text can mean the container name takes up more vertical space.
The buttons should keep their ideal spacing instead of stretching vertically.
Differential Revision: https://phabricator.services.mozilla.com/D107486
This was originally added in bug 1120967 to space the help button that used to appear in the header. The help button has since been removed.
It's bogus in this case, because it accidentally overrides the display value of some description (which used to force their own display value).
Differential Revision: https://phabricator.services.mozilla.com/D107334
This moves some inline styles into CSS and fixes modal masks and shadows to match the spec.
I also noticed some negative effects from other Proton button styles on close-icon buttons in dialogs
in about:preferences (e.g. check the oversized titlebar for the fonts dialog) that I fixed here.
Differential Revision: https://phabricator.services.mozilla.com/D107109
CLOSED TREE
Backed out changeset 0580aaec32a0 (bug 1693277)
Backed out changeset be8108cd9820 (bug 1693277)
Backed out changeset 8b9986d057d7 (bug 1693277)
This moves some inline styles into CSS and fixes modal masks and shadows to match the spec.
I also noticed some negative effects from other Proton button styles on close-icon buttons in dialogs
in about:preferences (e.g. check the oversized titlebar for the fonts dialog) that I fixed here.
Differential Revision: https://phabricator.services.mozilla.com/D107109
certviewer.html, being a toolkit file, shouldn't link to an icon in browser. This results in a broken image icon in Thunderbird.
Differential Revision: https://phabricator.services.mozilla.com/D107166
Before decoupling the permission panel in Bug 1596897, the permission indicator was
not shown if we had a blocked permission icon to show instead. With the decoupled
permissions panel it needs to be shown whenever we have permissions listed in the
panel. The granted permissions icon is now the anchor for the panel.
Differential Revision: https://phabricator.services.mozilla.com/D106771
This patch:
-Maintains consistency between the fxa and remote tabs' panels "sync now" buttons
-Removes a fluent string no longer in use
-Restores tooltip functionality
Differential Revision: https://phabricator.services.mozilla.com/D106651
This patch:
-Maintains consistency between the fxa and remote tabs' panels "sync now" buttons
-Removes a fluent string no longer in use
-Restores tooltip functionality
Differential Revision: https://phabricator.services.mozilla.com/D106651
This patch:
-Maintains consistency between the fxa and remote tabs' panels "sync now" buttons
-Removes a fluent string no longer in use
-Restores tooltip functionality
Differential Revision: https://phabricator.services.mozilla.com/D106651
This patch changes the selection colour in the Urlbar view. It only changes the colours when a theme is not applied, to not break the many themes that depend on the panel background/color being Highlight/HighlightText. It also only changes the default theme on macOS and the default Windows theme. Windows High Contrast and Linux OS themes would break if the autocomplete background was not Highlight.
This patch also reduces the padding in the search one-offs and changes the color of arrowpanel-dimmed slightly to better match the spec. The hover colour shown in the spec is rgb(240,240,244). The new arrowpanel-dimmed colour is rgb(240,240,240).
Differential Revision: https://phabricator.services.mozilla.com/D105535
This patch mainly does three things:
1. Changes the necessary CSS to meet the Proton spec.
2. Removes several calls to UrlbarInput.startLayoutBreakout(), because the Urlbar no longer expands when the panel is not open.
3. Introduces a [suppress-focus-border] attribute. This attribute hides the 2px focus ring around the Urlbar. This ensures that we don't flash the focus ring when the user clicks a Urlbar that will autoOpen, seeing as the open Urlbar no longer has a border. It also hides the focus border after the user presses Esc, as specified in Figma.
Differential Revision: https://phabricator.services.mozilla.com/D105097
Dao points out at https://phabricator.services.mozilla.com/D105097#inline-590409 that prefers-contrast is not adequate when accounting for various Linux OS themes. We have to use the OS accent color on Linux if we want to maintain compatibility with OS themes. This follows not supporting the new color for the unfocused Urlbar on Linux (see D104898) and not supporting the grey result-highlight colour on Linux (see D105535). We should change focus-outline-color universally on Linux for the same reasons.
Differential Revision: https://phabricator.services.mozilla.com/D105672
I'm keeping the generic 'animate' selectors which are still used for the bookmark/star animation.
This should make it easier to add other animations to the library in future, if that
ends up useful, and making them more specific to the star animation doesn't seem like it gains
us anything. The de-duplication from bug 1393565 helps a lot here.
Differential Revision: https://phabricator.services.mozilla.com/D106153
`appearance` CSS rules allow elements to take on system appearance. For UI elements that we want to take on system styling, we set `appearance: auto` combined with platform-specific rules like `-moz-default-appearance: -moz-mac-vibrant-titlebar-light;`
macOS sidebar vibrancy broke because a background-color was being applied to `root`. That colour appeared under elements with `appearance: auto` set, so we wouldn't see the platform-specific styling. This patch moves the root background-color to `#navigator-toolbox`, so that it does not appear under `#sidebar-box`.
We still want a background colour applied to sidebars when a lwtheme includes one. We only want `appearance: auto` applied to sidebars when the active theme does not have sidebar styling rules. That's why `#sidebar-box:not(:-moz-lwtheme)` is changed to `#sidebar-box:not([lwt-sidebar])`.
This patch also removes the rule
```
:root:-moz-lwtheme {
appearance: none;
}
```
from osx/global/global.css. There's no corresponding addition of a `#navigator-toolbox { appearance:none; }` rule because that rule already exists in [osx/browser.css](https://searchfox.org/mozilla-central/rev/7067bbd8194f4346ec59d77c33cd88f06763e090/browser/themes/osx/browser.css#45).
Differential Revision: https://phabricator.services.mozilla.com/D104416
The named colours are hopefully going to get factored out in bug 1693702,
but this allows us to fix the styling of the Zoom controls in light theme
for now.
Differential Revision: https://phabricator.services.mozilla.com/D105710
This supports a new `helpUrl` payload property on all results. It causes results
in the view to have a help button that can be selected and picked independently
of the main part of the result. When picked, the help button loads the
`helpUrl`. It looks and acts the same as the help buttons we already have for
tip results.
The help button should be flush with the trailing edge of the result row, and it
should be selectable independently from the main part of the result. To achieve
that without disrupting things too much, I create the button inside of
`.urlbarView-row` but outside of `.urlbarView-row-inner`. The "main" part of the
row is `.urlbarView-row-inner`. I made `.urlbarView-row` have `display: flex` so
the the inner part can have `flex: 1` so it can fill up the entire row except
for the help button.
This also reworks view selection a little so that for each row, we look for
selectable elements in the row instead of assuming that the row itself is
selectable. That also lets us remove a couple of special cases for tip and
dynamic results.
Differential Revision: https://phabricator.services.mozilla.com/D105095
Some GTK themes use very soft colors for selection backgrounds, using
darker colors for the text. This makes the tab and focus outlines in the
tab bar not have sufficient contrast with usual backgrounds.
I needed to do this for bug 1690778, but it seems worth doing it on the
front-end as well.
Differential Revision: https://phabricator.services.mozilla.com/D104547
- Added a new permission panel managed by the gPermissionPanel object
- Updated identity-box to separate identity and permission section
Differential Revision: https://phabricator.services.mozilla.com/D99892
Doug Thayer
Tim Nguyen
smolnar
Emma Malysz
Gijs Kruitbosch
Bogdan Tara
Jared Wein
Mike Conley
Zibi Braniecki
Alexandru Michis
Csoregi Natalia
Harry Twyford
Nika Layzell
Marco Bonardo
Erica Wright
Molly Howell
Julien Wajsberg
Narcis Beleuzu
Greg Tatum
Emilio Cobos Álvarez
Geoff Lankow
Jonathan Kew
Paul Zuehlcke
Sam Foster
Butkovits Atila
Drew Willcoxon
Micah Tigley
Dorel Luca
Yura Zenevich
Bernard Igiri
Itiel
Noemi Erli