Граф коммитов

9 Коммитов

Автор SHA1 Сообщение Дата
Noemi Erli f19596c1f0 Backed out changeset dc38da197244 (bug 1552464) for devtools failures in browser_telemetry_viewport_change.js 2019-05-24 15:48:34 +03:00
Razvan Caliman 49cc754a87 Bug 1552464 - Add telemetry probe to count the number of viewport changes in RDM. r=mtigley,nchevobbe.
This patch adds telemetry instrumentation to count the number of times the RDM viewport properties are changed (dimensions and rotation). This count will be correlated with the panel open count and time spent open to refine the baseline for RDM usage and filter out accidental usage.

A new Redux middleware, `telemetryMiddleware`, is introduced to the RDM Redux store. This observes actions dispatched to the store. For `RESIZE_VIEWPORT` and `ROTATE_VIEWPORT` actions, it increases a numeric value for the new scalar telemetry probe, `"devtools.responsive.viewport_change_count"`.

Other actions may be observed in this middleware for future telemetry instrumentation of RDM.

The `RESIZE_VIEWPORT` action is a dispatched with a high frequency when dragging to resize. Therefore, we debounce logging for this action. To ensure the test can reliably test counting this action without adding needless complexity to account for the asynchronicity, the `debounce()` utility is extended with an `immediate` parameter to cause the very first call to be executed immediately before going into the debounce behaviour.

Differential Revision: https://phabricator.services.mozilla.com/D31645

--HG--
extra : moz-landing-system : lando
2019-05-24 08:52:41 +00:00
Oana Pop Rus d71e3be10c Backed out changeset 3c2a368a4c8b (bug 1552464) for xpcshell failures on test_rotate_viewport.js on a CLOSED TREE
--HG--
extra : amend_source : 15c8845b921292468c076b10b0b68c523a835e98
2019-05-22 14:57:46 +03:00
Razvan Caliman b12bac57a5 Bug 1552464 - Add telemetry probe to count the number of viewport changes in RDM. r=mtigley,nchevobbe.
This patch adds telemetry instrumentation to count the number of times the RDM viewport properties are changed (dimensions and rotation). This count will be correlated with the panel open count and time spent open to refine the baseline for RDM usage and filter out accidental usage.

A new Redux middleware, `telemetryMiddleware`, is introduced to the RDM Redux store. This observes actions dispatched to the store. For `RESIZE_VIEWPORT` and `ROTATE_VIEWPORT` actions, it increases a numeric value for the new scalar telemetry probe, `"devtools.responsive.viewport_change_count"`.

Other actions may be observed in this middleware for future telemetry instrumentation of RDM.

The `RESIZE_VIEWPORT` action is a dispatched with a high frequency when dragging to resize. Therefore, we debounce logging for this action. To ensure the test can reliably test counting this action without adding needless complexity to account for the asynchronicity, the `debounce()` utility is extended with an `immediate` parameter to cause the very first call to be executed immediately before going into the debounce behaviour.

Differential Revision: https://phabricator.services.mozilla.com/D31645

--HG--
extra : moz-landing-system : lando
2019-05-21 18:40:23 +00:00
Julian Descottes 640fe52298 Bug 1454696 - Run eslint --fix for prefer-const;r=yulia
MozReview-Commit-ID: F6xUXCgdRE4

--HG--
extra : rebase_source : 65de1b0aba412d9044b5196115f74276caa058f2
2018-06-01 12:36:09 +02:00
J. Ryan Stinnett 23ff4cc75d Bug 1443081 - Apply spacing via `eslint --fix` for DevTools. r=jdescottes
MozReview-Commit-ID: 2RVNt140Zte
2018-03-12 13:44:41 -05:00
sole b5e8924a44 Bug 1383037 - Use only one debounce function in devtools. r=pbro
MozReview-Commit-ID: J9t90N1U2XY

--HG--
extra : rebase_source : 8c8383729e8079a01f5b432a008839986cc2ebc8
2017-10-03 11:03:19 +01:00
Hossain Al Ikram b91c660165 Bug 1386545 - Edit comment to stop false-positiveing for sdk/ usages in debounce.js file. r=sole 2017-08-05 07:50:00 -04:00
sole b7601c1b53 Bug 1378817 - Stop using sdk/lang/functional in DevTools. r=jdescottes
MozReview-Commit-ID: CXMu5a0KNGT

--HG--
extra : rebase_source : acdb62a83a4f27c566ea6c9dabf0d0dce9b253e0
2017-07-20 17:57:28 +01:00