56be5080d2
Bug 1807687 - Simplify Windows keyboard indicator setting handling. r=NeilDeakin
...
The only thing that can explain this is the WM_UPDATEUISTATE state
getting out of sync in a way that we think we need to unconditionally
show focus indicators for a window.
I tried to first make this less error prone (see patch above) but
digging more into these messages, I'm pretty sure we just don't need all
this code. See:
* https://devblogs.microsoft.com/oldnewthing/20130516-00/?p=4343
* https://devblogs.microsoft.com/oldnewthing/20130517-00/?p=4323
In particular, this is intended to be a windows feature to not show
keyboard indicators on dialogs until you use the keyboard. But that's
how Gecko dialogs behave already due to how :focus-visible behaves as
per:
https://searchfox.org/mozilla-central/rev/43ee5e789b079e94837a21336e9ce2420658fd19/toolkit/components/prompts/src/CommonDialog.jsm#319
I haven't been able to repro this state, but sounds believable that it
could happen after opening a native dialog or so on?
The purpose of this code is to implement the 'Underline access keys' in
the Keyboard Accessibility control panel of windows.
There's an easier way of tracking this, via the SPI_GETKEYBOARDCUES SPI,
documented in:
https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-systemparametersinfoa
Hook that into LookAndFeel rather than using custom IPC and so on.
Differential Revision: https://phabricator.services.mozilla.com/D165578
2023-01-09 18:19:03 +00:00
93acdfad59
Bug 1777574, automate CC zone handling, r=mccr8
...
Differential Revision: https://phabricator.services.mozilla.com/D155084
2022-09-07 11:22:51 +00:00
fb38c597a4
Bug 1596852 - Handle parent-process <browser type=chrome> in JSWindowActors. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D132731
2021-12-10 22:34:10 +00:00
8e411675ac
Bug 1744877 - Remove --disable-xul. r=Gijs
...
Building with --disable-xul has been busted since _at least_ bug
1082579, for more than 7 years (I didn't try to track that down
further). It's time to recognize that the option serves no purpose.
Differential Revision: https://phabricator.services.mozilla.com/D133161
2021-12-08 21:37:11 +00:00
e191336f32
Backed out changeset ed22265c6a3d (bug 1596852) for causing mochitest failures.
...
CLOSED TREE
2021-12-06 22:07:43 +02:00
517f887537
Bug 1596852 - Handle parent-process <browser type=chrome> in JSWindowActors. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D132731
2021-12-06 18:06:48 +00:00
4803e61816
Bug 708901 - Migrate to nsTHashSet in dom/base. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D108593
2021-03-24 17:56:46 +00:00
f54ee076ae
Backed out 13 changesets (bug 708901, bug 1184468) for causing build bustage on GeckoViewHistory.cpp. CLOSED TREE
...
Backed out changeset b1e4c01e63b8 (bug 708901)
Backed out changeset 37b52cce83c0 (bug 708901)
Backed out changeset eee75f33f060 (bug 708901)
Backed out changeset 479bf64c7986 (bug 708901)
Backed out changeset 15a8fb94d15d (bug 708901)
Backed out changeset be31ccd9a61d (bug 708901)
Backed out changeset fc54f4eaedd5 (bug 708901)
Backed out changeset 03c3a56c3d13 (bug 708901)
Backed out changeset 73f11d3c1298 (bug 708901)
Backed out changeset aed22fd80893 (bug 708901)
Backed out changeset 74d8249fbe7e (bug 708901)
Backed out changeset acb725eb3c1d (bug 1184468)
Backed out changeset 70f3ea6efec4 (bug 1184468)
2021-03-24 19:26:20 +02:00
82e566bfca
Bug 708901 - Migrate to nsTHashSet in dom/base. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D108593
2021-03-24 16:58:58 +00:00
1c71a222fc
Bug 1653729 - Part 1: Generalize do_QueryActor API, r=kmag
...
This changes the set of types which can be passed as the second argument to
do_QueryActor to ones which can be unambiguously converted to a JSActorManager,
and combines nsCOMPtr_helper implementations.
Differential Revision: https://phabricator.services.mozilla.com/D84067
2020-08-04 21:34:29 +00:00
73f14abd78
Bug 1638910 - Clear JSActorService EventListener references in Unlink, r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D76018
2020-05-26 22:19:31 +00:00
cd067d3c2e
Bug 1580448 - Rename JSWindowActor into JSActor;r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D70038
2020-04-30 16:42:53 +00:00
e22cd35728
Backed out 9 changesets (bug 1580448) for linux build bustages in /builds/worker/workspace/obj-build/dist/include/mozilla/dom/JSWindowActorChild.h CLOSED TREE
...
Backed out changeset 6b4db1a501df (bug 1580448)
Backed out changeset 677257a41457 (bug 1580448)
Backed out changeset 6db8de5fc125 (bug 1580448)
Backed out changeset fd7527c86239 (bug 1580448)
Backed out changeset bfbd3330b0a5 (bug 1580448)
Backed out changeset dafa80c63322 (bug 1580448)
Backed out changeset 2a1701831a6a (bug 1580448)
Backed out changeset 9b548bd38671 (bug 1580448)
Backed out changeset 358f764ae48b (bug 1580448)
2020-04-30 10:58:27 +03:00
e3ac58091c
Bug 1580448 - Rename JSWindowActor into JSActor;r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D70038
2020-04-30 07:33:28 +00:00
38afb32dc5
Bug 1626555 - Make `dom/base` buildable outside of `unified-build` environment. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D69183
2020-04-29 09:02:05 +00:00
021fdf8b13
Bug 1605209 - Turn actor names into nsCString;r=nika
...
This should save (a little) memory and avoid quite a few conversions.
Differential Revision: https://phabricator.services.mozilla.com/D70341
2020-04-17 10:56:22 +00:00
ca80197a2f
Backed out 4 changesets (bug 1605209) for causing browser-chrome failures at dom/ipc/tests/JSWindowActor/browser_crash_report.js
...
CLOSED TREE
Backed out changeset 6eb1cc169dbf (bug 1605209)
Backed out changeset d81b566ad94f (bug 1605209)
Backed out changeset e0e6dbf1d48d (bug 1605209)
Backed out changeset 289f5bbac1ae (bug 1605209)
2020-04-17 13:49:04 +03:00
5435691b55
Bug 1605209 - Turn actor names into nsCString;r=nika
...
This should save (a little) memory and avoid quite a few conversions.
Differential Revision: https://phabricator.services.mozilla.com/D70341
2020-04-16 08:58:21 +00:00
8d3992adb0
Bug 1558520, rework remote controller to use JSWindowActor instead of having the browser have a controller, r=smaug
...
When searching for the controller for a command in nsWindowRoot::GetControllerForCommand, look for a focused browsing context instead and get the controller through the Controllers actor associated with that browsing context. When a command update occurs in a window in the child process, send the list of commands to the parent process along with the browsing context for that window. The parent will pass this information to the controllers actor. As long as we can get the right currently focused browsing context descendant, we can get the correct command state and invoke commands through the right actor.
Differential Revision: https://phabricator.services.mozilla.com/D66222
--HG--
rename : toolkit/modules/RemoteController.jsm => toolkit/actors/ControllersParent.jsm
extra : moz-landing-system : lando
2020-03-12 16:47:57 +00:00
cde7e014c2
Bug 1620322 - Part 9: Move ContentBlockingLog to antitracking to keep all related code together in the same place; r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D65822
--HG--
rename : dom/base/ContentBlockingLog.cpp => toolkit/components/antitracking/ContentBlockingLog.cpp
rename : dom/base/ContentBlockingLog.h => toolkit/components/antitracking/ContentBlockingLog.h
extra : moz-landing-system : lando
2020-03-09 23:36:39 +00:00
0186cbe565
Backed out 8 changesets (bug 1620322) for bustages on nsContentSink.cpp . CLOSED TREE
...
Backed out changeset f41739c64dff (bug 1620322)
Backed out changeset be942a7f329e (bug 1620322)
Backed out changeset a916987c7c71 (bug 1620322)
Backed out changeset ead3484ffb5f (bug 1620322)
Backed out changeset 4e1e8b9afa1a (bug 1620322)
Backed out changeset 473bba698e5a (bug 1620322)
Backed out changeset 0e5e5d41597d (bug 1620322)
Backed out changeset 31b24d79db3d (bug 1620322)
--HG--
rename : toolkit/components/antitracking/ContentBlockingLog.cpp => dom/base/ContentBlockingLog.cpp
rename : toolkit/components/antitracking/ContentBlockingLog.h => dom/base/ContentBlockingLog.h
rename : toolkit/components/antitracking/ContentBlocking.cpp => toolkit/components/antitracking/AntiTrackingCommon.cpp
rename : toolkit/components/antitracking/ContentBlocking.h => toolkit/components/antitracking/AntiTrackingCommon.h
2020-03-09 22:18:36 +02:00
8530d61140
Bug 1620322 - Part 9: Move ContentBlockingLog to antitracking to keep all related code together in the same place; r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D65822
--HG--
rename : dom/base/ContentBlockingLog.cpp => toolkit/components/antitracking/ContentBlockingLog.cpp
rename : dom/base/ContentBlockingLog.h => toolkit/components/antitracking/ContentBlockingLog.h
extra : moz-landing-system : lando
2020-03-09 18:12:42 +00:00
a48fac9e3b
Backed out 8 changesets (bug 1620322) for causing bustages in ContentBlockingLog.cpp CLOSED TREE
...
Backed out changeset 3dcf513e36cb (bug 1620322)
Backed out changeset 46714855ce1d (bug 1620322)
Backed out changeset 0eb2b5f7322f (bug 1620322)
Backed out changeset 72d640fa0740 (bug 1620322)
Backed out changeset 4533bb4e5177 (bug 1620322)
Backed out changeset 659270edd419 (bug 1620322)
Backed out changeset 6802c18b1914 (bug 1620322)
Backed out changeset 60ff34db9f15 (bug 1620322)
--HG--
rename : toolkit/components/antitracking/ContentBlockingLog.cpp => dom/base/ContentBlockingLog.cpp
rename : toolkit/components/antitracking/ContentBlockingLog.h => dom/base/ContentBlockingLog.h
rename : toolkit/components/antitracking/ContentBlocking.cpp => toolkit/components/antitracking/AntiTrackingCommon.cpp
rename : toolkit/components/antitracking/ContentBlocking.h => toolkit/components/antitracking/AntiTrackingCommon.h
2020-03-09 19:19:41 +02:00
271a1e1e51
Bug 1620322 - Part 9: Move ContentBlockingLog to antitracking to keep all related code together in the same place; r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D65822
--HG--
rename : dom/base/ContentBlockingLog.cpp => toolkit/components/antitracking/ContentBlockingLog.cpp
rename : dom/base/ContentBlockingLog.h => toolkit/components/antitracking/ContentBlockingLog.h
extra : moz-landing-system : lando
2020-03-09 10:23:30 +00:00
ed104ffa03
Bug 1581925 - Part 1: Capture parent process JSWindowActor events at InProcessBrowserChildMessageManager, r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D46864
--HG--
extra : moz-landing-system : lando
2019-10-07 19:35:06 +00:00
35cc00a25c
Backed out 2 changesets (bug 1581925) for devtools failures at browser_toolbox_textbox_context_menu.js. CLOSED TREE
...
Backed out changeset f79a5830bfef (bug 1581925)
Backed out changeset 2e3b0b1cebea (bug 1581925)
2019-10-02 03:04:43 +03:00
e549d2cdb8
Bug 1581925 - Part 1: Capture parent process JSWindowActor events at InProcessBrowserChildMessageManager, r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D46864
--HG--
extra : moz-landing-system : lando
2019-09-26 21:09:34 +00:00
9adecce6d4
Backed out changeset ac6d8297cdc4 (bug 1581925) for test_bug89419.xul & test_MozDomFullscreen_event.xul failures CLOSED TREE
2019-09-24 21:56:18 +03:00
e71f3992f5
Bug 1581925 - Capture parent process JSWindowActor events at InProcessBrowserChildMessageManager, r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D46864
--HG--
extra : moz-landing-system : lando
2019-09-23 22:31:05 +00:00
fe31845697
Bug 1545499 - Make whether to show focus-rings for all content by default a pref, and disable it on Android. r=NeilDeakin
...
This pref toggled gives me the desired behavior on Linux, and it should be
trivial to revert to the previous behavior if needed.
Depends on D33393
Differential Revision: https://phabricator.services.mozilla.com/D33394
--HG--
extra : moz-landing-system : lando
2019-06-03 15:12:24 +00:00
d143aaa5f3
Bug 1545499 - Remove dead code for threading accelerator state. r=NeilDeakin
...
It's only moved around, but not actually used anywhere.
I have no idea what this was supposed to control in the past but it doesn't seem
useful to keep it around.
Differential Revision: https://phabricator.services.mozilla.com/D33393
--HG--
extra : moz-landing-system : lando
2019-06-03 15:29:06 +00:00
cadf33a327
Bug 1525720, part 2 - Move UITabResolutionChanged method to nsIRemoteTab interface from BrowserParent. r=smaug
...
This reduces the amount of code that assumes that BrowserParent implements nsIRemoteTab.
Differential Revision: https://phabricator.services.mozilla.com/D31430
--HG--
extra : source : 5f1c1b609ec1ecc28734e1b6daeeb3f6854ded38
2019-04-24 23:05:40 -05:00
57f573a6ff
Backed out 18 changesets (bug 1525720) for mass failures on Windows platform e.g ProcessPriorityManager.cpp on a CLOSED TREE.
...
Backed out changeset 1f2e86c2d691 (bug 1525720)
Backed out changeset 9b79caa460a0 (bug 1525720)
Backed out changeset e65cb2d4c5a5 (bug 1525720)
Backed out changeset 99f971a02d87 (bug 1525720)
Backed out changeset d25963c72ff7 (bug 1525720)
Backed out changeset 810b73719871 (bug 1525720)
Backed out changeset ee10a8254481 (bug 1525720)
Backed out changeset 1bcf9f586c55 (bug 1525720)
Backed out changeset d3b2ac8d5ca4 (bug 1525720)
Backed out changeset 697774dd8984 (bug 1525720)
Backed out changeset eadeacbe4483 (bug 1525720)
Backed out changeset 32eeee79d628 (bug 1525720)
Backed out changeset 07678a2fa9e7 (bug 1525720)
Backed out changeset 757b4f595cc4 (bug 1525720)
Backed out changeset b255e0a84e12 (bug 1525720)
Backed out changeset 9a255864f75d (bug 1525720)
Backed out changeset 5f1c1b609ec1 (bug 1525720)
Backed out changeset 00d83f1d02e0 (bug 1525720)
2019-05-23 01:57:16 +03:00
e084a16216
Bug 1525720, part 2 - Move UITabResolutionChanged method to nsIRemoteTab interface from BrowserParent. r=smaug
...
This reduces the amount of code that assumes that BrowserParent implements nsIRemoteTab.
Differential Revision: https://phabricator.services.mozilla.com/D31430
--HG--
extra : rebase_source : d639864ba86001cf90a8b3d42b6eda97a7f829ac
extra : histedit_source : 6f6f1e0b6d3561e478391ce9e72a8a2dbc280983
2019-04-24 23:05:40 -05:00
bc14bd97eb
Bug 1550927. Stop using idl [array] for getting supported controller commands. r=masayuki
...
Differential Revision: https://phabricator.services.mozilla.com/D30764
--HG--
extra : moz-landing-system : lando
2019-05-21 17:06:06 +00:00
0eeced87be
Bug 1534395 - Rename TabParent to BrowserParent. r=nika
...
This commit renames TabParent to BrowserParent.
Differential Revision: https://phabricator.services.mozilla.com/D28133
--HG--
rename : dom/ipc/TabParent.cpp => dom/ipc/BrowserParent.cpp
rename : dom/ipc/TabParent.h => dom/ipc/BrowserParent.h
extra : rebase_source : d2706b9f42177d8de16068b7b1d088a44b8720a4
extra : histedit_source : a617ddac45c58050ef799116a67d2d983f2a8f6d%2C1d1dabd8761a32d548a6fbf1027be960698f6a5e
2019-04-09 16:38:15 -05:00
3675f2449b
Bug 1534395 - Rename nsITabParent to nsIRemoteTab. r=nika,mconley
...
nsITabParent is exposed to frontend code and is generally used as a representation of a remote tab. We could just rename the interface to nsIBrowserParent and worry about it later, but I think it's better to rename the interface to nsIRemoteTab so that we can later work on splitting the interface away from the PBrowser protocol.
Note: Some frontend code refers to a TabParentId. This commit renames this to RemoteTabId. We need to figure out the purpose of TabId with fission.
Differential Revision: https://phabricator.services.mozilla.com/D28132
--HG--
rename : dom/interfaces/base/nsITabParent.idl => dom/interfaces/base/nsIRemoteTab.idl
extra : rebase_source : 9d8a1790a7bb10195ad063644d1a93d63b2afb72
2019-04-09 15:59:37 -05:00
05cfd24507
Bug 1523631 - Part 2: Add support for event listeners to JS Window Actor Protocols, r=jdai,qdot
...
This patch takes the approach of keeping track of a list of nsWindowRoot
objects in the JSWindowActorService. Listeners are then maintained for
each type of actor for every nsWindowRoot.
Depends on D20012
Differential Revision: https://phabricator.services.mozilla.com/D20013
--HG--
extra : moz-landing-system : lando
2019-02-22 19:28:50 +00:00
e5e885ae31
Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
...
# ignore-this-changeset
--HG--
extra : amend_source : 7221c8d15a765df71171099468e7c7faa648f37c
extra : histedit_source : a0cce6015636202bff09e35a13f72e03257a7695
2019-01-18 10:16:18 +01:00
58c7fc4d20
Bug 1353867 - Change WindowProxyHolder's native type to BrowsingContext. r=bzbarsky
...
Make the WindowProxyHolder hold a strong reference to a BrowsingContext, as in the future
we might not have a nsPIDOMWindowOuter (if the document is loaded in a different process).
Differential Revision: https://phabricator.services.mozilla.com/D12651
--HG--
extra : moz-landing-system : lando
2019-01-02 13:27:05 +00:00
a17049feac
Bug 1353867 - Change WindowProxy type. r=bzbarsky
...
Add a WindowProxyHolder type and generate binding code that takes or returns it whenever
the WebIDL refers to the WindowProxy type. This patch just makes the WindowProxyHolder
hold a strong reference to a nsPIDOMWindowOuter.
Differential Revision: https://phabricator.services.mozilla.com/D12650
--HG--
extra : moz-landing-system : lando
2019-01-02 13:26:56 +00:00
265e672179
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
5b753da289
Bug 1470325 - s/FooBinding/Foo_Binding/g - r=qdot
...
MozReview-Commit-ID: JtTcLL5OPF0
2018-06-26 17:05:01 -07:00
597b4545d2
Bug 1429903 part 4. Remove nsIDOMEventTarget. r=mccr8
...
MozReview-Commit-ID: 9XuenUHxfPx
2018-04-20 00:49:30 -04:00
0b77426fa7
Bug 1449631 part 11. Remove nsIDOMEventTarget::AddSystemEventListener. r=smaug
...
The security checks outer window did here don't seem right, because the whole
point is that this method is only called by C++ code for its own purposes.
We're not adding random untrusted listeners via addSystemEventListener!
MozReview-Commit-ID: JdS5gTESclu
2018-04-05 13:42:42 -04:00
2cdc7450c3
Bug 1449631 part 10. Devirtualize AddEventListener. r=smaug
...
The CanCallerAccess check in the "webidl" version of
nsGlobalWindowOuter::AddEventListener was pointless, because bindings never
call things on outer windows.
MozReview-Commit-ID: 1CGMJ277bPu
2018-04-05 13:42:42 -04:00
88937275cc
Bug 1449631 part 9. Remove nsIDOMEventTarget::AddEventListener. r=smaug
...
Also switch the XPCOM-y version of EventTarget::AddEventListner to a
Nullable<bool> for aWantsUntrusted.
The three-arg overload of AddEventListener in ContentFrameMessageManager was
never called, so all the AddEventListener overloads there are not needed.
MozReview-Commit-ID: 4IhqHmPVWzE
2018-04-05 13:42:42 -04:00
14f26fccf6
Bug 1449631 part 8. Remove nsIDOMEventTarget::GetEventTargetParent. r=smaug
...
MozReview-Commit-ID: 5wQ2LYrjUxf
2018-04-05 13:42:41 -04:00
adbcff27c1
Bug 1449631 part 7. Remove nsIDOMEventTarget::GetTargetFor* methods. r=smaug
...
MozReview-Commit-ID: AIzDo67mTDf
2018-04-05 13:42:41 -04:00
4292bca4ee
Bug 1449631 part 6. Remove nsIDOMEventTarget::DispatchEvent. r=smaug
...
MozReview-Commit-ID: 8YMgmMwZkAL
2018-04-05 13:42:41 -04:00
Emilio Cobos Álvarez
Olli Pettay
Mike Hommey
Alexandru Michis
Simon Giesecke
Csoregi Natalia
Nika Layzell
David Teller
Stefan Hindli
Andi-Bogdan Postelnicu
Daniel Varga
Neil Deakin
Ehsan Akhgari
Narcis Beleuzu
Noemi Erli
Brindusan Cristian
Bogdan Tara
Ryan Hunt
Gurzau Raul
Boris Zbarsky
Peter Van der Beken
Sylvestre Ledru
Jeff Gilbert