Boris Zbarsky
00cd5d4380
Bug 1619112 part 5. Stop accepting nsAString in ErrorResult error-throwing. r=smaug
...
Callers should pass in UTF-8, since that's what the JS engine ends up with in the end anyway.
The various URL changes are because NS_NewURI converts incoming nsAString to
UTF-8 anyway. So we might as well do that up-front and then use the UTF-8
string for both the NS_NewURI call and the error-reporting if it fails.
Differential Revision: https://phabricator.services.mozilla.com/D65543
--HG--
extra : moz-landing-system : lando
2020-03-06 21:08:02 +00:00
Tom Schuster
2f52c3fd94
Bug 1615897 - Blob URL should not ignore query parameter and revokeObjectURL additionally should not ignore fragments. r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D63939
--HG--
extra : moz-landing-system : lando
2020-02-25 07:56:07 +00:00
Tom Schuster
88855a7ee5
Bug 1558915 - Use infallible nsIURI::SchemeIs in dom/. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D40108
--HG--
extra : source : 3da6e9e86be4a4a9eeaceec222398475b6679193
2019-08-02 08:54:18 +00:00
Mihai Alexandru Michis
0cc257addd
Backed out 2 changesets (bug 1558915) for causing bustages. CLOSED TREE
...
Backed out changeset e44c9fd81e5b (bug 1558915)
Backed out changeset 3da6e9e86be4 (bug 1558915)
2019-08-02 12:17:42 +03:00
Tom Schuster
f115dd9113
Bug 1558915 - Use infallible nsIURI::SchemeIs in dom/. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D40108
--HG--
extra : moz-landing-system : lando
2019-08-02 08:54:18 +00:00
Boris Zbarsky
5062731c15
Bug 1565688. Remove unused IOService arg from NS_NewURI. r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D37968
--HG--
extra : moz-landing-system : lando
2019-07-15 13:39:51 +00:00
Andrea Marchesini
9023382549
Bug 1558923 - Remove nsContentUtils::GetThreadSafe{ASCII,UTF8}Origin, r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D34767
--HG--
extra : moz-landing-system : lando
2019-06-13 19:45:52 +00:00
Andrea Marchesini
7009293bd7
Bug 1558923 - Simplify URL API, r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D34766
--HG--
extra : moz-landing-system : lando
2019-06-13 19:45:19 +00:00
Narcis Beleuzu
8e2da98d46
Backed out 2 changesets (bug 1558923) for mochitest crashes on AssertIsOnMainThread(). CLOSED TREE
...
Backed out changeset 643de99320a8 (bug 1558923)
Backed out changeset f758b5ccd0c0 (bug 1558923)
2019-06-13 20:59:33 +03:00
Andrea Marchesini
0d82acdb60
Bug 1558923 - Remove nsContentUtils::GetThreadSafe{ASCII,UTF8}Origin, r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D34767
--HG--
extra : moz-landing-system : lando
2019-06-13 16:42:53 +00:00
Andrea Marchesini
ac563a2551
Bug 1558923 - Simplify URL API, r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D34766
--HG--
extra : moz-landing-system : lando
2019-06-13 16:23:11 +00:00
Noemi Erli
dec16f16c7
Backed out 2 changesets (bug 1558923) for failures in nsContentUtils.cpp
...
Backed out changeset 12c977801cb2 (bug 1558923)
Backed out changeset d8a688f1b7ce (bug 1558923)
2019-06-13 19:19:05 +03:00
Andrea Marchesini
15529ee673
Bug 1558923 - Remove nsContentUtils::GetThreadSafe{ASCII,UTF8}Origin, r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D34767
--HG--
extra : moz-landing-system : lando
2019-06-13 15:10:58 +00:00
Andrea Marchesini
b35598172a
Bug 1558923 - Simplify URL API, r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D34766
--HG--
extra : moz-landing-system : lando
2019-06-13 15:10:24 +00:00
Cosmin Sabou
934be35969
Backed out 2 changesets (bug 1558923) for build bustages on dom/URL.h. CLOSED TREE
...
Backed out changeset 0bb5857422f2 (bug 1558923)
Backed out changeset d0411a373ace (bug 1558923)
2019-06-13 13:35:54 +03:00
Andrea Marchesini
7f7c7c2ee3
Bug 1558923 - Remove nsContentUtils::GetThreadSafe{ASCII,UTF8}Origin, r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D34767
--HG--
extra : moz-landing-system : lando
2019-06-13 10:19:03 +00:00
Andrea Marchesini
ddcdb92776
Bug 1558923 - Simplify URL API, r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D34766
--HG--
extra : moz-landing-system : lando
2019-06-13 10:19:03 +00:00
Ryan Hunt
00e98538aa
Bug 1523969 part 6 - Move method definition inline comments to new line in 'dom/'. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D21106
--HG--
extra : rebase_source : ea3f51c2c11247114deccbc86e90fb02b8a97257
2019-02-25 16:05:29 -06:00
Emilio Cobos Álvarez
d2ed260822
Bug 1517241 - Rename nsIDocument to mozilla::dom::Document. r=smaug
...
Summary: Really sorry for the size of the patch. It's mostly automatic
s/nsIDocument/Document/ but I had to fix up in a bunch of places manually to
add the right namespacing and such.
Overall it's not a very interesting patch I think.
nsDocument.cpp turns into Document.cpp, nsIDocument.h into Document.h and
nsIDocumentInlines.h into DocumentInlines.h.
I also changed a bunch of nsCOMPtr usage to RefPtr, but not all of it.
While fixing up some of the bits I also removed some unneeded OwnerDoc() null
checks and such, but I didn't do anything riskier than that.
2019-01-03 17:48:33 +01:00
Sylvestre Ledru
265e672179
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Jeff Gilbert
5b753da289
Bug 1470325 - s/FooBinding/Foo_Binding/g - r=qdot
...
MozReview-Commit-ID: JtTcLL5OPF0
2018-06-26 17:05:01 -07:00
Emilio Cobos Álvarez
fffb25b74f
Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj
...
This was done automatically replacing:
s/mozilla::Move/std::move/
s/ Move(/ std::move(/
s/(Move(/(std::move(/
Removing the 'using mozilla::Move;' lines.
And then with a few manual fixups, see the bug for the split series..
MozReview-Commit-ID: Jxze3adipUh
2018-06-01 10:45:27 +02:00
Andrea Marchesini
3ef72562fe
Bug 1454889 - Remove createObjectURL()'s MediaStream overload, r=valentin
2018-04-24 16:19:51 +02:00
Narcis Beleuzu
2b99556758
Backed out changeset 0c5a4939300c (bug 1454889) for causing frequent Leaks (Bug 1378025). a=backout
2018-05-07 12:06:25 +03:00
Andrea Marchesini
3abafd2746
Bug 1454889 - Remove createObjectURL()'s MediaStream overload, r=valentin
2018-04-24 16:19:51 +02:00
Andrea Marchesini
027c6e34d8
Bug 1454656 - Unify URLWorker and URLMainThread, r=smaug
2018-04-24 12:01:46 +02:00
Andrea Marchesini
4b23deda27
Bug 1448328 - Use thread-safe nsIURI in the URI API - part 1 - No getter/setter runnables, r=valentin
2018-04-14 01:06:35 +02:00
Andrea Marchesini
c3889f808d
Bug 1368955 - Split URL.cpp in URLMainThread.{cpp,h} and URLWorker.{cpp,h}, r=qdot
...
--HG--
rename : dom/url/URL.cpp => dom/url/URLMainThread.cpp
rename : dom/url/URL.cpp => dom/url/URLMainThread.h
rename : dom/url/URL.cpp => dom/url/URLWorker.cpp
rename : dom/url/URL.cpp => dom/url/URLWorker.h
2017-05-31 21:18:56 +02:00
Andrea Marchesini
d7289f085d
Bug 1368950 - Remove URL Constructor with a URL base argument, r=qdot
2017-05-31 21:18:19 +02:00
Andrea Marchesini
4ee48ef4d0
Bug 1358114 - Use IPCBlob in BlobURL, r=smaug
2017-04-24 12:16:49 +02:00
Sebastian Hengst
d3da87ad97
Backed out changeset a180e3f4de16 (bug 1358114)
2017-04-24 15:43:05 +02:00
Andrea Marchesini
5046098373
Bug 1358114 - Use IPCBlob in BlobURL, r=smaug
2017-04-24 12:16:49 +02:00
Valentin Gosu
1c5fbd8c6e
Bug 1342438 - Remove url .hash encoding/decoding prefs r=bagder
...
These prefs have been added close to two years ago:
dom.url.encode_decode_hash and dom.url.getters_decode_hash
The main reason for their existence was in case we encounter any web-compat issues. At this point the extra code is mostly useless, and flipping the pref may lead to crashes.
MozReview-Commit-ID: LhAHkYmv0TR
--HG--
extra : rebase_source : 8f2d50d5633496cf165b3925d952bb6475bce3e0
2017-03-08 22:19:34 +01:00
Andrea Marchesini
16bc4a8d06
Bug 1334564 - Deprecate URL.createObjectURL(mediastream), r=smaug, r=rjesup
2017-02-07 08:58:35 +01:00
Andrea Marchesini
899a146699
Bug 1336018 - Get rid of objectURLOptions dictionary in URL.createObjectURL, r=smaug
2017-02-03 08:28:52 +01:00
Sebastian Hengst
1fef20171e
Backed out changeset bfaa720977d2 (bug 1336018) for failing test_exception_messages.html. r=backout on a CLOSED TREE
2017-02-02 16:51:55 +01:00
Sebastian Hengst
cf329a5f4a
Backed out changeset 95fe30082f2c (bug 1334564)
2017-02-02 16:51:18 +01:00
Andrea Marchesini
8f2647aa6b
Bug 1334564 - Deprecate URL.createObjectURL(mediastream), r=smaug
2017-02-02 15:25:54 +01:00
Andrea Marchesini
73af520c01
Bug 1336018 - Get rid of objectURLOptions dictionary in URL.createObjectURL, r=smaug
2017-02-02 15:15:54 +01:00
Andrea Marchesini
94547f20bb
Bug 604026 - Sync event loops in workers should be created only if compatible with the worker shutdown status, r=bkelly
2017-01-05 10:05:32 +01:00
Masatoshi Kimura
0c6dc2ea73
Bug 1323683 - Fold nsIURIWithQuery into nsIURI. r=valentin.gosu
...
MozReview-Commit-ID: BFfgr42sNyx
--HG--
extra : rebase_source : a28d6a3c96f0c86dd7269147f130b3195b1f1faf
2016-12-28 20:40:21 +09:00
Andrea Marchesini
9f4ca5a041
Bug 1310483 - Implement nsIURIWithQuery for having query part in simple URI, r=valentin
2016-11-14 13:04:33 +01:00
Nicholas Nethercote
34dcc7b852
Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm.
...
This change avoids lots of false positives for Coverity's CHECKED_RETURN
warning, caused by NS_WARN_IF's current use in both statement-style and
expression-style.
In the case where the code within the NS_WARN_IF has side-effects, I made the
following change.
> NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
> -->
> Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
In the case where the code within the NS_WARN_IF lacks side-effects, I made the
following change.
> NS_WARN_IF(!condWithoutSideEffects);
> -->
> NS_WARNING_ASSERTION(condWithoutSideEffects, "msg");
This has two improvements.
- The condition is not evaluated in non-debug builds.
- The sense of the condition is inverted to the familiar "this condition should
be true" sense used in assertions.
A common variation on the side-effect-free case is the following.
> nsresult rv = Fn();
> NS_WARN_IF_(NS_FAILED(rv));
> -->
> DebugOnly<nsresult rv> = Fn();
> NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed");
--HG--
extra : rebase_source : 58788245021096efa8372a9dc1d597a611d45611
2016-09-02 17:12:24 +10:00
Eric Rahm
ee9ba04219
Bug 1262948 - Remove warning from URL constructor. r=baku
...
Remove warning if constructing a new URI fails. An exception is still thrown on failure.
2016-08-15 11:16:25 -07:00
Geoff Lankow
d14b295017
Bug 1287657 - Context menu items should not be disabled for media with a blob URL; r=kinetik, r=baku
2016-07-25 22:41:52 +12:00
Andrea Marchesini
8183e57459
Bug 1279493 - Use blob URLs exclusively rather than having mediastream and mediasource URLs, r=smaug
2016-07-21 14:31:43 +02:00
Andrea Marchesini
be759d0233
Bug 1286955. Don't use an ErrorResult on multiple threads in the Worker URL implementation. r=bzbarsky
2016-07-15 22:35:12 -04:00
Carsten "Tomcat" Book
e75558e07b
Backed out changeset cf2bb72412a0 (bug 1286955) for hazard failures
2016-07-16 10:03:27 +02:00
Andrea Marchesini
fccb098fcb
Bug 1286955. Don't use an ErrorResult on multiple threads in the Worker URL implementation. r=bzbarsky
2016-07-15 22:35:12 -04:00
Andrea Marchesini
9b8df4a1d1
Bug 1270185 - create dom/url for URL API and its tests, r=ehsan
...
--HG--
rename : dom/base/URL.cpp => dom/url/URL.cpp
rename : dom/base/URL.h => dom/url/URL.h
rename : dom/base/URLSearchParams.cpp => dom/url/URLSearchParams.cpp
rename : dom/base/URLSearchParams.h => dom/url/URLSearchParams.h
rename : dom/base/test/file_url.jsm => dom/url/tests/file_url.jsm
rename : dom/workers/test/file_url.jsm => dom/url/tests/file_worker_url.jsm
rename : dom/workers/test/jsm_url_worker.js => dom/url/tests/jsm_url_worker.js
rename : dom/workers/test/test_bug883784.jsm => dom/url/tests/test_bug883784.jsm
rename : dom/workers/test/test_bug883784.xul => dom/url/tests/test_bug883784.xul
rename : dom/base/test/test_unknown_url_origin.html => dom/url/tests/test_unknown_url_origin.html
rename : dom/base/test/test_url.html => dom/url/tests/test_url.html
rename : dom/base/test/test_url.xul => dom/url/tests/test_url.xul
rename : dom/base/test/test_urlExceptions.html => dom/url/tests/test_urlExceptions.html
rename : dom/base/test/test_urlSearchParams.html => dom/url/tests/test_urlSearchParams.html
rename : dom/base/test/test_urlSearchParams_utf8.html => dom/url/tests/test_urlSearchParams_utf8.html
rename : dom/base/test/test_url_data.html => dom/url/tests/test_url_data.html
rename : dom/base/test/test_url_empty_port.html => dom/url/tests/test_url_empty_port.html
rename : dom/base/test/test_url_malformedHost.html => dom/url/tests/test_url_malformedHost.html
rename : dom/base/test/test_urlutils_stringify.html => dom/url/tests/test_urlutils_stringify.html
rename : dom/workers/test/test_url.html => dom/url/tests/test_worker_url.html
rename : dom/workers/test/test_url.xul => dom/url/tests/test_worker_url.xul
rename : dom/workers/test/test_urlApi.html => dom/url/tests/test_worker_urlApi.html
rename : dom/workers/test/test_urlSearchParams.html => dom/url/tests/test_worker_urlSearchParams.html
rename : dom/workers/test/test_url_exceptions.html => dom/url/tests/test_worker_url_exceptions.html
rename : dom/workers/test/urlApi_worker.js => dom/url/tests/urlApi_worker.js
rename : dom/workers/test/urlSearchParams_worker.js => dom/url/tests/urlSearchParams_worker.js
rename : dom/workers/test/url_exceptions_worker.js => dom/url/tests/url_exceptions_worker.js
rename : dom/workers/test/url_worker.js => dom/url/tests/url_worker.js
2016-06-29 07:44:18 +02:00