Remove the pref dom.xhr.lowercase_header.enabled, as we are unaware of any actionable compat concerns now that bug 1540688 landed, and an ESR had been spun off.
Differential Revision: https://phabricator.services.mozilla.com/D39636
--HG--
extra : moz-landing-system : lando
Some double definitions would have caused C++ compile errors, but some would
not, and I'm not even sure what the runtime behaviour would have been in those
latter cases...
The patch also removes a duplicated definition of privacy.resistFingerprinting,
which snuck in recently.
Differential Revision: https://phabricator.services.mozilla.com/D39431
--HG--
extra : moz-landing-system : lando
We unconditionally clamp all times to 20us and not just performance.now()
This will consistently apply a 'safe' minimal clamping (it's not safe but
I guess it's safer than ns-level precision) to all timestamps, and remove
intermittents that are caused by comparing a clamped performance.now() to
an unclamped [something else].
Differential Revision: https://phabricator.services.mozilla.com/D38806
--HG--
extra : moz-landing-system : lando
We unconditionally clamp all times to 20us and not just performance.now()
This will consistently apply a 'safe' minimal clamping (it's not safe but
I guess it's safer than ns-level precision) to all timestamps, and remove
intermittents that are caused by comparing a clamped performance.now() to
an unclamped [something else].
Differential Revision: https://phabricator.services.mozilla.com/D38806
--HG--
extra : moz-landing-system : lando
They're infallible in practice and always `NS_OK`. (This stems from
`AddVarCacheNoAssignment()` always returning `NS_OK`.)
As a result, the commit removes lots of unnecessary checks.
Differential Revision: https://phabricator.services.mozilla.com/D39804
--HG--
extra : moz-landing-system : lando
It's an annoyingly long name that causes lots of line breaking, and it's not
exposed outside of libpref.
Differential Revision: https://phabricator.services.mozilla.com/D39803
--HG--
extra : moz-landing-system : lando
This makes it clear that these run when prefs are initialized (like
`InitVarCache()`) rather than being vanilla `set` calls that happen at any
point during runtime.
Differential Revision: https://phabricator.services.mozilla.com/D39650
--HG--
extra : moz-landing-system : lando
Lots of operations in Preferences.cpp can only occur in the parent process
and/or on the main thread. It has a bunch of assertions to enforce/document
this. This commit adds some more, because they're really useful for
understanding the code.
The commit also removes an unnecessary `XRE_IsParentProcess()` check in
`pref_SetPref()` (because that condition is always true, as the added assertion
indicates), and renames a parameter in `InitVarCachePrefs()`.
Differential Revision: https://phabricator.services.mozilla.com/D39649
--HG--
extra : moz-landing-system : lando
Converts dom.timeout.enable_budget_timer_throttling from varcache pref to static pref, removes entry from all.js, adds entry to StaticPrefList.yaml. Uses the all.js value and not the value declared in TimeoutManager.cpp. Since this removes the last varcache pref from TimeoutManager::Initialize(), I also removed the Initialize() function and its call in nsGlobalWindowInner.
Differential Revision: https://phabricator.services.mozilla.com/D39455
--HG--
extra : moz-landing-system : lando
Converts dom.timeout.budget_throttling_max_delay varcache pref to static pref, removes entry from all.js, and adds entry to StaticPrefList.yaml
Differential Revision: https://phabricator.services.mozilla.com/D39451
--HG--
extra : moz-landing-system : lando
Converts dom.timeout.foreground_budget_regeneration_rate varcache pref in TimeoutManager.cpp to static pref, removes entry in all.js, adds entry in StaticPrefList.yaml.
Differential Revision: https://phabricator.services.mozilla.com/D39436
--HG--
extra : moz-landing-system : lando
Converts dom.timeout.background_budget_regeneration_rate varcache pref in TimeoutManager.cpp to static pref, removes entry in all.js, adds entry to StaticPrefList.yaml.
Differential Revision: https://phabricator.services.mozilla.com/D39435
--HG--
extra : moz-landing-system : lando
Converts dom.disable_open_click_delay from a VarCache pref in TimeoutManager.cpp to StaticPref, removes all.js entry, and corrects a typo where the value was mentioned in nsGlobalWindowInner.cpp.
Differential Revision: https://phabricator.services.mozilla.com/D39424
--HG--
extra : moz-landing-system : lando
Converts dom.timeout.max_consecutive_callbacks_ms varcache pref in TimeoutManager.cpp to static pref, removes associated variables and all.js entry, and adds entry to StaticPrefList.yaml.
Differential Revision: https://phabricator.services.mozilla.com/D39425
--HG--
extra : moz-landing-system : lando
Converts dom.timeout.throttling_delay in TimeoutManager.cpp from varcache pref to static pref, removes entry in all.js, and adds entry in StaticPrefList.yaml. Favors the all.js value over the declared value in TimeoutManager.cpp.
Differential Revision: https://phabricator.services.mozilla.com/D39426
--HG--
extra : moz-landing-system : lando
Removes dom.min_tracking_timeout_value and dom.min_tracking_background_timeout_value, because they are never used.
Differential Revision: https://phabricator.services.mozilla.com/D39429
--HG--
extra : moz-landing-system : lando
Converts dom.min_background_timeout_value in TimeoutManager.cpp to static pref, removes entry in all.js, adds entry to StaticPrefList.yaml.
Differential Revision: https://phabricator.services.mozilla.com/D39430
--HG--
extra : moz-landing-system : lando
Converts dom.min_timeout_value varcache pref from TimeoutManager::Initialize() to a static pref, and removes its entry and associated constants from TimeoutManager.cpp and all.js
Differential Revision: https://phabricator.services.mozilla.com/D39416
--HG--
extra : moz-landing-system : lando
`AddVarCache()` has a `bool aSkipAssignment` parameter. This patch removes that
parameter by splitting the function in two: `AddVarCache()` and
`AddVarCacheNoAssignment()`. (The former calls the latter.)
There are also tons of `Add*VarCache()` functions with `aSkipAssignment`
parameters that default to `false`. These defaults are never overridden, so
this patch removes the unnecessary arguments.
Differential Revision: https://phabricator.services.mozilla.com/D39433
--HG--
extra : moz-landing-system : lando
This requires replacing inclusions of it with inclusions of more specific prefs
files.
The exception is that StaticPrefsAll.h, which is equivalent to StaticPrefs.h,
and is used in `Codegen.py` because doing something smarter is tricky and
suitable for a follow-up. As a result, any change to StaticPrefList.yaml will
still trigger recompilation of all the generated DOM bindings files, but that's
still a big improvement over trigger recompilation of every file that uses
static prefs.
Most of the changes in this commit are very boring. The only changes that are
not boring are modules/libpref/*, Codegen.py, and ServoBindings.toml.
Differential Revision: https://phabricator.services.mozilla.com/D39138
--HG--
extra : moz-landing-system : lando
Instead of generating a single `init/StaticPrefList.h`, we now generate:
- `init/StaticPrefListAll.h`;
- `StaticPrefsAll.h`;
- one `init/StaticPrefList_*.h` file for each pref group;
- one `StaticPrefs_*.h` file for each pref group.
`StaticPrefs.h` still exists -- it's equivalent to all the `StaticPrefs_*.h`
files combined -- so no `.cpp` files are changed by this commit. The next
commit will remove that file and replace inclusions of it with inclusions of
the new files.
The patch also adds checking of the type of the `do_not_use_directly` field.
Differential Revision: https://phabricator.services.mozilla.com/D39134
--HG--
extra : moz-landing-system : lando
For background information on what "cancel content JS" does, see bug 1493225.
Differential Revision: https://phabricator.services.mozilla.com/D38264
--HG--
extra : moz-landing-system : lando
Detailed page load performance measurements from Denis indicate this should be okay
on the reference hardware and now we have 10/100/1000 warm-up thresholds so there's
a nice pattern there.
Differential Revision: https://phabricator.services.mozilla.com/D39146
--HG--
extra : moz-landing-system : lando
These files exist because they were the proof-of-concept first step for
splitting the static prefs header files. Now that those header files can be
generated from a script, we need to move the `accessibility.*` prefs into the
YAML file.
Differential Revision: https://phabricator.services.mozilla.com/D39132
--HG--
extra : moz-landing-system : lando
There was a missing setter function for this combination, which hasn't been
used before.
Differential Revision: https://phabricator.services.mozilla.com/D39263
--HG--
extra : moz-landing-system : lando
Streamlined ifdefs by removing the remaining instances of PREF_VALUE. Also, changed media.eme.enabled to benefit from IS_NIGHTLY_BUILD, and removed duplicate logic in media.rdd-vorbis.enabled.
Differential Revision: https://phabricator.services.mozilla.com/D38952
--HG--
extra : moz-landing-system : lando
Defines and uses constants for patterns that commonly recur in StaticPrefList.yaml, such as #ifdef NIGHTLY_BUILD
Differential Revision: https://phabricator.services.mozilla.com/D38948
--HG--
extra : moz-landing-system : lando
Updated repetitive #ifdef RELEASE_OR_BETA pattern to use the existing constant at the top of the file. Renamed NOT_IN_RELEASE_OR_BETA_VALUE to IS_NOT_RELEASE_OR_BETA, to follow naming conventions in child revisions.
Differential Revision: https://phabricator.services.mozilla.com/D38947
--HG--
extra : moz-landing-system : lando
Nicholas Nethercote
Ehsan Akhgari
Thomas Wisniewski
Olli Pettay
Dylan Roeh
Daniel Varga
Tom Ritter
Andreea Pavel
Christoph Kerschbaumer
Kristen Wright
Jonathan Kew
Andrea Marchesini
Dragana Damjanovic
Csoregi Natalia
Tom Schuster
Jim Porter
Jan de Mooij
Paul Adenot