Sometimes the messageText can be a longString, which was crashing
the whole console output since we were always assuming messageText
was a plain string.
We now render non-string messageText with reps so it handles longStrings.
A mocha test is added to ensure this works as expected.
Differential Revision: https://phabricator.services.mozilla.com/D30875
--HG--
extra : moz-landing-system : lando
We now have stacktrace for expressions evaluated in the console
that throws, and we are stripping any frames that are devtools
internals.
But the way we were doing this meant that we were only having
one `debugger eval code` frame, even if the expression in the console
had multiple frames.
Also, if an expression was throwing without having any `debugger eval
code` frame (e.g. expression with SyntaxError), we were sending internal
frames.
This patch should fix those 2 cases and a linux 64 ccov intermittent
caused by a different line number for an internal frame in a fixture
packet.
Tests cases are added to the existing mochitest to ensure this
works as expected.
Differential Revision: https://phabricator.services.mozilla.com/D30934
--HG--
extra : moz-landing-system : lando
Rather straighforward -- as per jryans recommendation, I have renamed the file to reflect
our naming conventions.
Differential Revision: https://phabricator.services.mozilla.com/D28641
--HG--
rename : devtools/shared/specs/script.js => devtools/shared/specs/thread.js
extra : moz-landing-system : lando
We need a complete specification in order to move forward with the front conversion. I
think this will also impact other parts of the refactoring, such as some of the thread specific code
in the debugger-client. This is a first pass, I did not go into detail about the return types.
Differential Revision: https://phabricator.services.mozilla.com/D28640
--HG--
extra : moz-landing-system : lando
The test was disabled in Bug 1535484 because it was failing.
To fix the test, we need to pass a dispatch prop to the
EvaluationResult component.
Differential Revision: https://phabricator.services.mozilla.com/D30855
--HG--
extra : moz-landing-system : lando
This allows us to benefit from the linkification that
is done there. We crop the URL at 120 chars for now. We might
consider bumping this up depending on the feedback we get.
We add both a mocha and a mochitest to make sure this work as expected.
Differential Revision: https://phabricator.services.mozilla.com/D29007
--HG--
extra : moz-landing-system : lando
This new prop allow us to define a maximum length for indivual
URLs (as opposed to `cropLimit`, which sets it for the whole text).
The URL regex is also modified to be able to linkify messages
wrapped in curly quotes.
Some tests are added to ensure we handle this prop as expected.
Differential Revision: https://phabricator.services.mozilla.com/D29006
--HG--
extra : moz-landing-system : lando
Importing scripts in shared head files is hard to maintain because it forces all browser ini that use the shared file to whitelist all its imports.
The debugger context helper is almost unused in the inspector, so it would be easier to just import it in the few tests that require it.
Also removed the whitelist entry in rules' browser.ini, no test in this suite used it.
Differential Revision: https://phabricator.services.mozilla.com/D30882
--HG--
extra : moz-landing-system : lando
### Changes
Probably the most important change apart from the tooltips is that we now only support one property at a time. This allows us to short circuit at the first invalid property and improve performance. This was previously agreed with Razvan but there were some relics left in the code.
`toolbox.xul`
- Added tooltips.ftl
`devtools/client/inspector/markup/test/helper_events_test_runner.js`:
- Had to change to synthesizeMouseAtCenter because CSS changes caused the original to fail.
`devtools/client/inspector/rules/rules.js`:
- Added `VIEW_NODE_INACTIVE_CSS` to node types and sorted alphabetically.
- Added new nodeInfo data for Inactive CSS icons.
`devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js` &
`devtools/client/inspector/rules/test/browser_rules_inactive_css_grid.js`:
- removed some listeners that are no longer needed
`devtools/client/inspector/rules/test/head.js`:
- Refactored `getPropertiesForRuleIndex()` in order to pass along information needed for testing our Fluent strings.
- Refactored `checkDeclarationIsInactive()` to check tooltip contnts using a new method.
- Added `checkInteractiveTooltip()` for checking the tooltip contents themselves.
- Simple changes to `runInactiveCSSTests()`.
`devtools/client/inspector/rules/views/text-property-editor.js`:
- We no longer create the tooltip by adding the title attribute.
`devtools/client/inspector/shared/node-types.js`:
- Changed the enum to use strings to simplify debugging.
- Added `VIEW_NODE_INACTIVE_CSS`.
- Sorted alphabetically.
`devtools/client/inspector/shared/tooltips-overlay.js`:
- Introduced a new tooltip type called `interactiveTooltip`.
`devtools/client/locales/en-US/inspector.properties`:
- Removed strings.
`devtools/client/locales/en-US/tooltips.ftl`:
- Added structured versions of the properties from `inspector.properties`.
`devtools/client/shared/widgets/tooltip/HTMLTooltip.js`:
- Made the tooltips obey the "prevent popup autohide" option in the browser debugger.
`devtools/client/shared/widgets/tooltip/InactiveCSSTooltipHelper.js`:
- Main file for handling InactiveCSS Tooltips.
`devtools/client/themes/tooltips.css`:
- Made arrow tooltips follow the Proton theme.
`devtools/server/actors/utils/inactive-property-helper.js`:
- General changes to support Fluent.
- Bail on first inactive property found.
### Latest Try (expecting green)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=de28939206d444dc4b534a3e5cc7a84b8797bec3
Differential Revision: https://phabricator.services.mozilla.com/D29372
--HG--
extra : moz-landing-system : lando
### Summary of Changes
1. Added `element-style.js::refreshUnusedCssAll()`:
- This method refreshes the CSS declarations for every property change and then calls `element-style.js::_updatePropertyUsed()` for each pseudo element.
2. Added `element-style.js::_updatePropertyUsed()`:
- This method simply updates the unused CSS HTML for each property that needs it.
3. Added `alerticon-unused.svg`.
4. A tiny bit of tidying in `devtools/client/themes/rules.css`:
- Added blank lines before comments.
- Changed `0px` to `0`;
- Merged both the `#ruleview-class-panel .classes` rules.
- Added used and unused CSS styles.
- Hooked `InactivePropertyHelper` into `devtools/server/actors/styles.js`
5. `devtools/server/actors/utils/inactive-property-helper.js` contains the actual unused CSS engine.
6. This feature exposed a race condition inside `head.js::assertShowPreviewTooltip()`. It was mousing over an element and sometimes the tooltip emitted "shown" before we added the listener. This is now fixed.
### Try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=016f8dc8e05dbaa89bc5a79b822ce23e786d3fc1
Differential Revision: https://phabricator.services.mozilla.com/D26879
--HG--
extra : moz-landing-system : lando
With the changes I made, any time the debugger is paused, only the token directly after the column breakpoint is highlighted. My commit also changes highlighting rules for debug lines without column breakpoints. I collected examples in the document below demonstrating cases with and without column breakpoints.
https://docs.google.com/document/d/1w9kaAzVgns5oQnONTPuPiREyhaq6NGd4mp6yvVUEU1Y/edit?usp=sharing
I changed one CSS file because without that change, the next column breakpoint after the token would also be highlighted which was misleading.
I would appreciate any feedback on these changes. Thank you!
Differential Revision: https://phabricator.services.mozilla.com/D30089
--HG--
extra : moz-landing-system : lando
Simply moved the callback from the icon to the button and updated the test.
Differential Revision: https://phabricator.services.mozilla.com/D30339
--HG--
extra : moz-landing-system : lando
Depends on D28036
If a context menu is opened in the toolbox document when running in a frame with type=content, keyboard navigation will not move to the context menu when it's opened.
Differential Revision: https://phabricator.services.mozilla.com/D27695
--HG--
extra : moz-landing-system : lando
Depends on D27693
Menu::popup and popupAtZoom are expecting a toolbox argument as last argument.
However, half of the callsites do not have access to the toolbox and just pass
a { doc } object. This is misleading when trying to work on menu.js because you
cannot rely on toolbox APIs.
Differential Revision: https://phabricator.services.mozilla.com/D28036
--HG--
extra : moz-landing-system : lando
Using chromeEventHandler will allow us to catch events fired from any frame.
By default when DevTools are in a type=chrome frame, events also bubble across frames.
With type=content this is no longer the case.
Differential Revision: https://phabricator.services.mozilla.com/D27693
--HG--
extra : moz-landing-system : lando
The original bug was being caused by a mouseleave from the token and mouseenter into the bracket arrow being triggered immediately after the preview was rendered. This appears less often on longer variable names, but happen all the time for single character variable names.
The problem no longer persists after removing cursor events from the bracket arrow.
Differential Revision: https://phabricator.services.mozilla.com/D30222
--HG--
extra : moz-landing-system : lando
Depends on D28036
If a context menu is opened in the toolbox document when running in a frame with type=content, keyboard navigation will not move to the context menu when it's opened.
Differential Revision: https://phabricator.services.mozilla.com/D27695
--HG--
extra : moz-landing-system : lando
Depends on D27693
Menu::popup and popupAtZoom are expecting a toolbox argument as last argument.
However, half of the callsites do not have access to the toolbox and just pass
a { doc } object. This is misleading when trying to work on menu.js because you
cannot rely on toolbox APIs.
Differential Revision: https://phabricator.services.mozilla.com/D28036
--HG--
extra : moz-landing-system : lando
Using chromeEventHandler will allow us to catch events fired from any frame.
By default when DevTools are in a type=chrome frame, events also bubble across frames.
With type=content this is no longer the case.
Differential Revision: https://phabricator.services.mozilla.com/D27693
--HG--
extra : moz-landing-system : lando
Add an `if` statement to handle logpoint when double click.
Add Mochitest for both conditional breakpoint and logpoint
Differential Revision: https://phabricator.services.mozilla.com/D30291
--HG--
extra : moz-landing-system : lando
Once RDM is up-and-running, the Zoom UI will stay synchronized with the
zoom level of the RDM content pane. These changes ensure that the RDM
tools are forced to 100%, and then does a fixup to get the Zoom UI to
match the RDM content pane zoom level again.
Differential Revision: https://phabricator.services.mozilla.com/D26045
--HG--
extra : moz-landing-system : lando
There is no need to transfer these properties because the swap makes
the outer browser act as if it is remote, and then the message manager
tunnel ensures that the outer browser will get and set the zoom values
from the inner browser.
Differential Revision: https://phabricator.services.mozilla.com/D29911
--HG--
extra : moz-landing-system : lando
The prior code calls '.cleanup()', but ActorPools have no 'cleanup' method. I
think it means to call 'destroy'.
Differential Revision: https://phabricator.services.mozilla.com/D29755
--HG--
extra : moz-landing-system : lando
- Use an explicit 12x12 size in the SVG code
- Add a 12x12 variant of the globe icon, with a 1px stroke similar to the info icon
- Tweak the inner shapes of the info icon so that it looks a bit more clearly like a lowercase "i"
Differential Revision: https://phabricator.services.mozilla.com/D29961
--HG--
extra : moz-landing-system : lando
The conditional breakpoint panel is wrapped in CodeMirror (starting from 6b0b968515). When hitting `Enter`, debugger/node_modules/codemirror/lib/codemirror.js will run line 7153 onKeyDown(), in which a new line is added. Then ConditionalPanel.js onKey() runs.
Solution: Ask CodeMirror not to add a new line when hit `Enter`.
Question:
I added two test cases to Mochitest. If I put a `debugger;` statement in the test file, ran ./mach mochitest --jsdebugger file/path`, keep `step over`, all tests pass. But when I ran`./mach mochitest same/file/path`, terminal stopped at "waiting for state change" then gave an error "Failed to retrieve MOZ_UPLOAD_DIR env var."
Error message screenshot:
{F1285339}
Differential Revision: https://phabricator.services.mozilla.com/D29068
--HG--
extra : moz-landing-system : lando
This mochitest had a very short SW timeout of 1 second, sometimes the worker would already be terminated before we could finish to attach a toolbox.
Increase the timeout to 4 seconds.
Differential Revision: https://phabricator.services.mozilla.com/D29154
--HG--
extra : moz-landing-system : lando
Changes impact theme-twisty icons in the TreeView component:
- Make sure theme-twisty uses the selection color (white) in selected rows;
but override that style for Network details accordion headers.
- Improve the vertical alignment and pixel-perfect icon rendering by
making sure the icon element takes the full available height (16px)
and avoiding assymetrical padding (affects the rendering of centered
background-image, making them blurry on 1x displays).
- Tweak the horizontal spacing of theme-twisty icons so that they take
up a total of 20px width (similar to what is used in Debugger and
Inspector), versus 17px previously.
Differential Revision: https://phabricator.services.mozilla.com/D29550
--HG--
extra : moz-landing-system : lando
This patch introduces a new type of content process, which has a dynamic name.
This type of content process is labeled as `webIsolated=${SITE_ORIGIN}` and is
used within fission-enabled windows.
To enable this, additional information about the fission status of the target
window must be passed into E10SUtils. This was done by updating every call site
manually to pass an extra boolean. A better solution perhaps should be used in
the future.
With this patch enabled, we now perform process switches, but only when
navigating to HTTP URIs. If we navigate to a non-HTTP URI in an iframe with
fission enabled, it will not behave correctly. This must be done in a
follow-up.
Differential Revision: https://phabricator.services.mozilla.com/D29570
--HG--
extra : moz-landing-system : lando
Depends on D28457
This commit separates the test-related changes from part one in D28457.
It updates the test fixtures to include the newly introduced `cssSelectors` field for messages used in tests.
It adds a test file for the newly introduced `CSSWarning` React component which is mostly a trimmed-down clone of the test for `PageError` component from which the component was forked. For now, just the basic toggle behavior of the component is tested. The test for calling the server to query DOM elements is not yet instrumented.
Differential Revision: https://phabricator.services.mozilla.com/D29345
--HG--
extra : moz-landing-system : lando
This patch builds on [Bug 1537876](https://bugzilla.mozilla.org/show_bug.cgi?id=1537876) which associates CSS selectors with error messages where applicable.
This patch introduces a new React component, `CSSWarning`, for messages of type CSS. It forks the`PageError` component which was shared for `LOG` messages of type `JAVASCRIPT` and type `CSS`.
The `CSSWarning` component is expandable when the message has an associated CSS selector. When expanded, it runs a `document.querySelectorAll()` command to list all elements matching the selector. Clicking on any of the elements in the result jumps to the Inspector and select the corresponding node in the markup view.
Not all errors have associated CSS selectors. Not all selectors match elements. The errors/warnings are a result of the CSS Parser; there is no guarantee that the CSS rule is used anywhere on the document. The query may return an empty `NodeList`.
Differential Revision: https://phabricator.services.mozilla.com/D28457
--HG--
extra : moz-landing-system : lando
Removed the Service Workers menu item, added Remote Debugging instead. Remote Debugging is displayed just above WebIDE
Differential Revision: https://phabricator.services.mozilla.com/D29219
--HG--
extra : moz-landing-system : lando
Added borders for error / warning messages. Reduced line height in message body. Added more space between device list / message and refresh device button
Differential Revision: https://phabricator.services.mozilla.com/D29652
--HG--
extra : moz-landing-system : lando
Fixed second line that has been cut off in the sidebar item detail of the remote runtime
Differential Revision: https://phabricator.services.mozilla.com/D29649
--HG--
extra : moz-landing-system : lando
We now also only access the document when the state is
nsIWebProgress::STATE_STOP. The comments in the previous code indicated that
touching the document inside the event handler when the state is not STATE_STOP
would result in the content creating a new about:blank document to retrieve the
values from. However, it then went on to do this in another location, causing a
document to be created whenever we received an onStateChange event. This should
no longer occur.
Differential Revision: https://phabricator.services.mozilla.com/D28125
--HG--
extra : moz-landing-system : lando
We now also only access the document when the state is
nsIWebProgress::STATE_STOP. The comments in the previous code indicated that
touching the document inside the event handler when the state is not STATE_STOP
would result in the content creating a new about:blank document to retrieve the
values from. However, it then went on to do this in another location, causing a
document to be created whenever we received an onStateChange event. This should
no longer occur.
Differential Revision: https://phabricator.services.mozilla.com/D28125
--HG--
extra : moz-landing-system : lando
The button (using a div) did not have any hover state before this patch.
While the CSS tried to control the stroke color, the SVG was not set up
for this – also fixed in this bug to correctly use the theme colors.
Differential Revision: https://phabricator.services.mozilla.com/D24742
--HG--
extra : moz-landing-system : lando
Finally! the goal of all of this: removing three functions from threadClient that really belong as part of source client. PauseLongString is never used except in tests. ThreadLongString is only ever used by sourceClient. Same goes for the arrayBuffer method. This clears all of that out.
Differential Revision: https://phabricator.services.mozilla.com/D21715
--HG--
extra : moz-landing-system : lando
This introduces an ArrayBuffer front, so that we no longer need to go through the thread client to get an array buffer for the sourceFront (this is the only place it is used).
It also converts the arrayBufferActor to a protocol.js actor. I was running into an issue between them. I need to double check what this issue was. If these two refactors need to be split, I can do that, but for now it looks like it wasn’t that large of a change.
Differential Revision: https://phabricator.services.mozilla.com/D27878
--HG--
rename : devtools/shared/client/array-buffer-client.js => devtools/shared/fronts/array-buffer.js
extra : moz-landing-system : lando
### Summary of Changes
1. Added `element-style.js::refreshUnusedCssAll()`:
- This method refreshes the CSS declarations for every property change and then calls `element-style.js::_updatePropertyUsed()` for each pseudo element.
2. Added `element-style.js::_updatePropertyUsed()`:
- This method simply updates the unused CSS HTML for each property that needs it.
3. Added `alerticon-unused.svg`.
4. A tiny bit of tidying in `devtools/client/themes/rules.css`:
- Added blank lines before comments.
- Changed `0px` to `0`;
- Merged both the `#ruleview-class-panel .classes` rules.
- Added used and unused CSS styles.
- Hooked `InactivePropertyHelper` into `devtools/server/actors/styles.js`
5. `devtools/server/actors/utils/inactive-property-helper.js` contains the actual unused CSS engine.
6. This feature exposed a race condition inside `head.js::assertShowPreviewTooltip()`. It was mousing over an element and sometimes the tooltip emitted "shown" before we added the listener. This is now fixed.
### Try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=016f8dc8e05dbaa89bc5a79b822ce23e786d3fc1
Differential Revision: https://phabricator.services.mozilla.com/D26879
--HG--
extra : moz-landing-system : lando
After reviewing how the EnvironmentClient is used, it looks like the use of eventSource
might be some cruft from the past. Here is the try run:
https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=242251058&revision=df4bb52f188f79b8006e8c40401e5af2258493ce
with the exception of whatever is going on Window 7 (which appeares also on central), it looks like
things are working as expected. The environment client will eventually have the event emitter, once
it is moved to being a front.
adding @nchevobbe as a subscriber, as this touches a dependancy of the scratchpad.
Differential Revision: https://phabricator.services.mozilla.com/D28962
--HG--
extra : moz-landing-system : lando
Fixes a small issue with the splitconsole shortcut in about:devtools-toolbox
Differential Revision: https://phabricator.services.mozilla.com/D29028
--HG--
extra : moz-landing-system : lando
The idea is to wait for ADB runtimes to be available before trying to render the initial route.
This way if we happen to find the runtime matching the current runtime, and if we still have a connected client for it, we can display the same runtime page.
Differential Revision: https://phabricator.services.mozilla.com/D28094
--HG--
extra : moz-landing-system : lando
The test is marked as perma-fail because there are complications with
getting RDM and WindowSnapshot.js to work together. 4 approaches are
discussed in the test itself, and one is attempted, which perma-fails.
The approach that is attempted is the most likely to be turned into an
unexpected pass in the future, so the test is being added as perma-fail.
Differential Revision: https://phabricator.services.mozilla.com/D28900
--HG--
extra : moz-landing-system : lando
Include the name of the window/parent hostname in the save HAR filename, e.g. if on mozilla.org, would download as "mozilla.org_Archive [time].har"
Differential Revision: https://phabricator.services.mozilla.com/D28732
--HG--
extra : moz-landing-system : lando
Depends on D27686
Toolbox, zoom keys and inspector search should use the chromeeventhandler as event target.
They need to capture events from inner frames.
Differential Revision: https://phabricator.services.mozilla.com/D27688
--HG--
extra : moz-landing-system : lando
As we will move shortcuts to use chromeEventHandler as their target, we need an easy way to add and remove them on host switch.
The chromeEventHandler will change when switching from window to docked hosts (and vice versa)
Differential Revision: https://phabricator.services.mozilla.com/D27685
--HG--
extra : moz-landing-system : lando
Add a max width on infobar when inspecting elements.
The intent is to prevent very long infobars due to autogenerated classes or id.
Differential Revision: https://phabricator.services.mozilla.com/D28276
--HG--
extra : moz-landing-system : lando
Using split("-") was clashing with the connection type "this-firefox".
Added unit test for remote-client-manager.
Differential Revision: https://phabricator.services.mozilla.com/D28066
--HG--
extra : moz-landing-system : lando
Depends on D28629
Follows exactly the same pattern as showSystemAddons. Enabled by default for local builds, disabled otherwise.
Differential Revision: https://phabricator.services.mozilla.com/D28630
--HG--
extra : moz-landing-system : lando
Using the toolbox window to read the "direction" seems to fix the issue.
Added a mochitest, had to create a dedicated browser ini file in order to setup RTL properly.
Differential Revision: https://phabricator.services.mozilla.com/D28841
--HG--
extra : moz-landing-system : lando
The className was making the color purple, although we want it to be red.
Removing the className makes it red.
Differential Revision: https://phabricator.services.mozilla.com/D28616
--HG--
extra : moz-landing-system : lando
David Walsh
Derek Li
Oriol Brufau
Geoff Brown
Florens Verschelde
Christoph Walcher
Yura Zenevich
Belén Albeza
Kestrel
Nicolas Chevobbe
Razvan Maries
Brian Hackett
Andreea Pavel
yulia
Gabriel Luong
Michael Ratcliffe
Julian Descottes
Tim Nguyen
arthur.iakab
Danielle Leblanc-Cyr
Dorel Luca
Miriam
Csoregi Natalia
shindli
Sorin Davidoi
derek-li
Sebastian Hengst
Krishnal Ciccolella
Cameron McCormack
Oana Pop Rus
Daisuke Akatsuka
jaril
Emilio Cobos Álvarez
Jason Laster
Daniel Varga
chujun
Ola Gasidlo
Bogdan Tara
Brad Werth
Jim Blandy
Mihai Alexandru Michis
Megan Bailey
Nika Layzell
Micah Tigley
Daniel Holbert
Coroiu Cristina
Razvan Caliman
Barret Rennie
Gurzau Raul
Brindusan Cristian
Thomas Nguyen
Brian Grinstead
Harald Kirschner
Andrew Swan
Mats Palmgren
neha
Sylvestre Ledru
Joel Maher
Logan Smyth
Narcis Beleuzu
lloan
Thomas
Mellina Yonashiro
Honza Bambas
Wizard