Wraps the header container and the preferences list in a grid layout
that is meant to be a "single source of truth" for nested grids via
subgrid.
Differential Revision: https://phabricator.services.mozilla.com/D86866
Some tests made some assumptions about the number of returned entries
by performance.getEntries, and these assumptions are not valid
anymore once we added new entries.
Depends on D66463
Differential Revision: https://phabricator.services.mozilla.com/D68645
It has some properties which make it footgunny, especially in the face of
Fission. Callers should use WindowGlobalChild.innerWindowId instead.
Differential Revision: https://phabricator.services.mozilla.com/D82801
In `getMappedExpression`, we check if the expression contains `await `, and in
such case, transform the input to handle top-level await expressions.
The catch is that we first check the existence of this.parserService, and the
getter for parserService will start the parser worker if it wasn't the case yet.
That means we were always spawning the parser worker, even if it wasn't going
to be used, consuming unnecessary resources.
This patch removes the conditions in the if, as `parserService` will always be truthy.
Differential Revision: https://phabricator.services.mozilla.com/D86826
Sometimes, it might happen that the user triggered the popup
opening (by typing a letter) and hit Enter before the popup
was already shown, which would result in a blank popup being opened.
This patch addresses that by storing the popup opening promise
and if it exists in the code that handle the Enter key, wait until
the promise resolves and hide the popup.
It would be tricky to write a consistent test as this race is depending
on the server response time and the time it take for the popup to be
shown; but manual tests seemed to indicate this fixes the issue.
Differential Revision: https://phabricator.services.mozilla.com/D86548
We already had a function that was returning a resourceType dictionnary for
a given watcher or target actor, on which we were then checking the targetType
to return the appropriate dictionnary.
It feels appropriate to have a dedicated function to get the dictionnary from
the targetType only, so we can call it from other places instead of repeating
the same instructions.
Differential Revision: https://phabricator.services.mozilla.com/D86979
We check if telemetry "devtools.tooltip.shown" is set for label
"css-compatibility" once the tooltip is toggled visible during
the test.
Differential Revision: https://phabricator.services.mozilla.com/D86403
Based on initital implementation of inactive css tooltip telemetry
implementation in D32810
We record toggling of tooltip using `sendOpenScalarToTelemetry`
against the label "css-compatibility".
Differential Revision: https://phabricator.services.mozilla.com/D86402
Before this change the styling of the inputs in the Debugger was inconsistent. This patch addresses this issue by:
1. Modifying the appearance of the placeholder text by setting its `color` to `--theme-text-color-alt` and its `opacity` to `1`. This ensures that the placeholder text has a contrast ratio of 4.74 when paired with a white background and passes the 4.5:1 contrast requirement of WCAG.
2. Modifying the height of the inputs in the Primary and Secondary Panes so that they are all `24px`.
{F2406940}
Differential Revision: https://phabricator.services.mozilla.com/D85630
`MediaPlayback` thread has been renamed to `MediaController` thread, so update the captured thread list for media preset.
Differential Revision: https://phabricator.services.mozilla.com/D86749
The key of the object is incorrectly used as `css-compatibility-experimental-supported-message`
instead of `experimental-supported`. This leads to the l10n translation
for undefined msgId leading to failure of appearance of tooltip.
This patch fixes the problem and adds a test to prevent regression.
Differential Revision: https://phabricator.services.mozilla.com/D86584
Depends on D84973
This was highlighted by browser_grids_grid-list-on-iframe-reloaded.js which fails without this fix.
Differential Revision: https://phabricator.services.mozilla.com/D84974
Nicolas Chevobbe
Cody Welsh
Sonia Singla
Csoregi Natalia
Sean Feng
Jan Odvarko
Julian Descottes
Daisuke Akatsuka
Kris Maglione
Shinichi Morimoto
iamnk
Christoph Kerschbaumer
Alexandre Poirot
Bogdan Tara
Luca Leone
Kriyszig
Kyle Knaggs
alwu
Noemi Erli
Emma Malysz
Butkovits Atila
Varun Dey