3af8c4138c
Bug 1651519: Remove nsIDOMWindowUtils::currentInnerWindowID. r=nika,remote-protocol-reviewers,webcompat-reviewers,whimboo
...
It has some properties which make it footgunny, especially in the face of
Fission. Callers should use WindowGlobalChild.innerWindowId instead.
Differential Revision: https://phabricator.services.mozilla.com/D82801
2020-08-17 20:20:50 +00:00
cb8dd8e93e
Bug 1640105 - Skip failed tests, r=dragana,remote-protocol-reviewers,necko-reviewers,maja_zf
...
Differential Revision: https://phabricator.services.mozilla.com/D86224
2020-08-10 09:20:35 +00:00
e9022983f1
Bug 1632722 - IO.read hits 'too many arguments' r=remote-protocol-reviewers,jgraham
...
Differential Revision: https://phabricator.services.mozilla.com/D86262
2020-08-07 09:08:01 +00:00
31755b431d
Bug 1657650 - Require that Mach command providers subclass MachCommandBase. r=remote-protocol-reviewers,marionette-reviewers,maja_zf,mhentges,froydnj
...
Today we don't require that `mach` `CommandProvider`s subclass from any particular parent class and we're very lax about the requirements they must meet. While that's convenient in certain circumstances, it has some unfortunate implications for feature development.
Today the only requirements that we have for `CommandProvider`s are that they have an `__init__()` method that takes either 1 or 2 arguments, the second of which must be called `context` and is populated with the `mach` `CommandContext`. Again, while this flexibility is occasionally convenient, it is limiting. As we add features to `mach`, having a better idea what the shape of our `CommandProvider`s are and how we can instantiate them and use them is increasingly important, and this gives us additional control when having `mach` configure `CommandProvider`s based on data that is only available at the `mach` level. In particular, we plan to leverage this in bugs 985141 and 1654074.
Here we add validation to the `CommandProvider` decorator to ensure all classes inherit from `MachCommandBase`, update all `CommandProvider`s in-tree to inherit from `MachCommandBase`, and update source and test code accordingly.
Follow-up work: we now require (de facto) that the `context` be populated with a `topdir` attribute by the `populate_context_handler` function, since instantiating the `MachCommandBase` requires a `topdir` be provided. This is fine for now in the interest of keeping this patch reasonably sized, but some additional refactoring could make this cleaner.
Differential Revision: https://phabricator.services.mozilla.com/D86255
2020-08-07 18:24:59 +00:00
d6f531d3a5
Bug 1654922 - Part 2: Remove DocumentChannel pref from mach and mochitest tools, r=mattwoodrow,remote-protocol-reviewers,maja_zf
...
Depends on D85483
Differential Revision: https://phabricator.services.mozilla.com/D85484
2020-07-31 13:06:08 +00:00
b7e932192e
Bug 1652270. Convert nsFrameLoader::Print to return a Promise. r=farre,remote-protocol-reviewers,marionette-reviewers,jgraham,whimboo,mixedpuppy
...
(Instead of requiring callers to pass an nsIWebProgressListener.)
Differential Revision: https://phabricator.services.mozilla.com/D83249
2020-07-22 23:17:45 +00:00
687f235fbc
Backed out changeset f95c19e45ab2 (bug 1652270) for reftest failures on test-text.html . CLOSED TREE
2020-07-22 20:36:53 +03:00
8c0fb25348
Bug 1652270. Convert nsFrameLoader::Print to return a Promise. r=farre,remote-protocol-reviewers,marionette-reviewers,jgraham,whimboo,mixedpuppy
...
(Instead of requiring callers to pass an nsIWebProgressListener.)
Differential Revision: https://phabricator.services.mozilla.com/D83249
2020-07-22 15:54:01 +00:00
990d081d9f
Backed out 2 changesets (bug 1651519) for WPT failures in webdriver/tests/switch_to_frame/switch.py. CLOSED TREE
...
Backed out changeset 7b973a0e7be9 (bug 1651519)
Backed out changeset 55e9184c5617 (bug 1651519)
2020-07-22 02:47:34 +03:00
e7d942c77f
Bug 1651519: Remove nsIDOMWindowUtils::currentInnerWindowID. r=nika,remote-protocol-reviewers,webcompat-reviewers,whimboo
...
It has some properties which make it footgunny, especially in the face of
Fission. Callers should use WindowGlobalChild.innerWindowId instead.
Differential Revision: https://phabricator.services.mozilla.com/D82801
2020-07-21 19:02:27 +00:00
d91c6dc40b
Backed out 2 changesets (bug 1651519) for wpt failures in webdriver/tests/switch_to_frame/switch.py. CLOSED TREE
...
Backed out changeset 52317abc5c68 (bug 1651519)
Backed out changeset 45448dca59a4 (bug 1651519)
2020-07-21 21:55:57 +03:00
9c2c147159
Bug 1651519: Remove nsIDOMWindowUtils::currentInnerWindowID. r=nika,remote-protocol-reviewers,webcompat-reviewers,whimboo
...
It has some properties which make it footgunny, especially in the face of
Fission. Callers should use WindowGlobalChild.innerWindowId instead.
Differential Revision: https://phabricator.services.mozilla.com/D82801
2020-07-21 16:59:28 +00:00
2bcdc17387
Bug 1649883 - Fix user pref for pocket toggle off. r=gvn,remote-protocol-reviewers,perftest-reviewers,maja_zf
...
Differential Revision: https://phabricator.services.mozilla.com/D82773
2020-07-15 14:51:02 +00:00
b6be72f351
Bug 1649554: Part 1 - Move deprecated component registration helpers out of XPCOMUtils. r=mccr8,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,webcompat-reviewers,whimboo,twisniewski
...
Differential Revision: https://phabricator.services.mozilla.com/D81749
2020-07-10 23:58:30 +00:00
9d78661f88
Bug 1649221: Update ChromeUtils.generateQI callers to pass strings. r=mccr8,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,preferences-reviewers,agi,whimboo,Bebe,twisniewski
...
Differential Revision: https://phabricator.services.mozilla.com/D81594
2020-07-10 23:58:28 +00:00
3c1b71a6e4
Bug 1651618 - Use cookie 'SameSite' attribute with capital 'S' everywhere, r=flod,fluent-reviewers,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,whimboo,sparky
...
Differential Revision: https://phabricator.services.mozilla.com/D82872
2020-07-09 20:40:15 +00:00
0856418749
Bug 1651469 - [puppeteer-test] Report errors in mocha hooks r=remote-protocol-reviewers,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D82813
2020-07-09 14:01:50 +00:00
74a6bd97cd
Bug 1644349 - [remote] Remove usage of windowIdToFrameIdMap in the Network observer. r=remote-protocol-reviewers,maja_zf
...
Differential Revision: https://phabricator.services.mozilla.com/D82691
2020-07-08 19:55:45 +00:00
f8fbd2e85e
Bug 1651312 - [remote] Fix invalid data type checks in browser-chrome tests. r=remote-protocol-reviewers,maja_zf
...
Differential Revision: https://phabricator.services.mozilla.com/D82678
2020-07-08 13:47:22 +00:00
24c63a2d0c
Bug 1647439 - Sync Puppeteer to v5.0.0 r=remote-protocol-reviewers,jgraham
...
Differential Revision: https://phabricator.services.mozilla.com/D82072
2020-07-02 18:57:38 +00:00
9b12e5b93a
Bug 1647439 - [remote] Clobber puppeteer lib/ when there are .ts changes r=remote-protocol-reviewers,jgraham
...
Differential Revision: https://phabricator.services.mozilla.com/D82071
2020-07-02 18:52:55 +00:00
c0005663ae
Bug 1647439 - Sync vendored puppeteer to v4.0.1 r=remote-protocol-reviewers,jgraham
...
Differential Revision: https://phabricator.services.mozilla.com/D82070
2020-07-02 18:52:52 +00:00
d12c7d9231
Bug 1647439 - [remote] Don't record unexpected skips when there's no expectation metadata r=remote-protocol-reviewers,jgraham
...
Differential Revision: https://phabricator.services.mozilla.com/D82068
2020-07-02 18:46:57 +00:00
3cde6129cc
Bug 1647439 - [remote] Remove 'jobs' argument r=remote-protocol-reviewers,jgraham
...
The environment variable it sets has been removed upstream and in practice we
never run tests in parallel.
Differential Revision: https://phabricator.services.mozilla.com/D82067
2020-07-02 18:46:49 +00:00
2456548253
Bug 1647439 - [remote] Preserve custom mocha recorder when vendoring Puppeteer r=remote-protocol-reviewers,jgraham
...
Differential Revision: https://phabricator.services.mozilla.com/D82066
2020-07-02 18:46:42 +00:00
2aa7a2a4f2
Bug 1595710 - Add support for "platform" to Emulation.setUserAgentOverride r=remote-protocol-reviewers,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D80391
2020-06-30 21:28:29 +00:00
a96e2000f8
Bug 1611843 - Always use an unknown entry id to check for an invalid history entry id. r=remote-protocol-reviewers,maja_zf
...
Differential Revision: https://phabricator.services.mozilla.com/D81659
2020-06-30 12:52:36 +00:00
4a218f2c31
Bug 1648959 - Done internal linking in docs in remote Directory.r=championshuttler,remote-protocol-reviewers,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D81463
2020-06-29 20:34:46 +00:00
cfaa250d14
Bug 1646923 - [remote] Update puppeteer metadata r=remote-protocol-reviewers,whimboo
...
Depends on D80796
Differential Revision: https://phabricator.services.mozilla.com/D80797
2020-06-24 05:03:30 +00:00
408f595e19
Bug 1646923 - [remote] Add metadata checks for skipped and extra tests r=remote-protocol-reviewers,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D80796
2020-06-25 05:39:22 +00:00
c8d948863f
Bug 1637640 - [remote] Update Puppeteer expectation data. r=remote-protocol-reviewers,maja_zf
...
Depends on D79452
Differential Revision: https://phabricator.services.mozilla.com/D79453
2020-06-22 06:16:11 +00:00
a1c4dfc684
Bug 1637640 - [remote] Enable page load events for frames. r=remote-protocol-reviewers,maja_zf
...
Differential Revision: https://phabricator.services.mozilla.com/D79452
2020-06-22 04:51:46 +00:00
221b0c6839
Bug 1644695 - [remote] Return the frameId of the frame when DOM.describeNode is called with a frame element. r=remote-protocol-reviewers,maja_zf
...
Depends on D79450
Differential Revision: https://phabricator.services.mozilla.com/D79451
2020-06-15 15:22:56 +00:00
02f1323cb3
Bug 1636373 - [remote] Only emit Runtime.executionContextsCleared event for top-level execution contexts. r=remote-protocol-reviewers,maja_zf
...
This also fixes a hang in Puppeteer's DOMWorld.js when resolving
the current executionContext promise. With the extra event all
the Puppeteer internal contexts for the tab target have been destroyed.
Differential Revision: https://phabricator.services.mozilla.com/D79450
2020-06-16 20:49:03 +00:00
58ca41961b
Bug 1645541, use outerWindowId from the windowGlobal instead of using the Browser:Init message, Also makes the BrowserTab actor specific to the main browser, r=mconley,remote-protocol-reviewers,maja_zf
...
Differential Revision: https://phabricator.services.mozilla.com/D79609
2020-06-17 15:01:28 +00:00
e1d05bdc1d
Bug 1644228 - Remove support for IMPACTED_TESTS; r=remote-protocol-reviewers,firefox-build-system-reviewers,rstewart,whimboo
...
IMPACTED_TESTS was added in bug 1184405, but is under-utilized in current moz.build
annotations; also bug 1516847 removed use of IMPACTED_TESTS in 'mach test'. This
patch removes remaining support for IMPACTED_TESTS.
Differential Revision: https://phabricator.services.mozilla.com/D79141
2020-06-12 08:04:08 +00:00
ffec6f608b
Bug 1643656 - Remove prefers-color-scheme: no-preference. r=gl,remote-protocol-reviewers,hiro,whimboo
...
It was removed from the spec.
Differential Revision: https://phabricator.services.mozilla.com/D78834
2020-06-14 23:26:04 +00:00
9ae88523bb
Bug 1550571 - Pref on Browsing Context preservation r=kmag,remote-protocol-reviewers,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D77764
2020-06-10 06:51:36 +00:00
2756eea4aa
Bug 1639467 - [remote] Enable page events after loading initial page in browser_frameAttached.js. r=remote-protocol-reviewers,maja_zf
...
Differential Revision: https://phabricator.services.mozilla.com/D78698
2020-06-10 21:00:45 +00:00
f761608e79
Backed out changeset bca9f7459a16 (bug 1643656) for reftests perma failures. CLOSED TREE
2020-06-09 18:24:48 +03:00
6b86e22f72
Bug 1643656 - Remove prefers-color-scheme: no-preference. r=gl,remote-protocol-reviewers,hiro,whimboo
...
It was removed from the spec. Bug 1643934 updates the WPT tests.
Differential Revision: https://phabricator.services.mozilla.com/D78834
2020-06-09 13:21:54 +00:00
7e9799c2c7
Bug 1643606 - Remove remnants of the toolkit.cosmeticAnimations.enabled pref. r=Gijs,remote-protocol-reviewers,marionette-reviewers,extension-reviewers,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D78462
2020-06-08 16:03:51 +00:00
228fa97fb8
Bug 1628599 - Fixing all links pointing to docs.firefox-dev.tools r=Honza,remote-protocol-reviewers,perftest-reviewers,maja_zf,davehunt
...
Differential Revision: https://phabricator.services.mozilla.com/D77560
2020-06-01 10:58:38 +00:00
91ed2688dd
Bug 1632710 - [puppeteer] vendor v3.1.0 r=remote-protocol-reviewers,whimboo,jgraham
...
This requires a custom mocha reporter under puppeteer/
and changes in output parsing.
Differential Revision: https://phabricator.services.mozilla.com/D77625
2020-06-05 18:53:38 +00:00
22b8a4c02c
Bug 1632710 - [puppeteer] Remove experimental/ dir r=remote-protocol-reviewers,jgraham,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D77624
2020-06-02 20:49:00 +00:00
c0b000a0ed
Bug 1641839 - [remote] Only emit Page.frameAttached and Page.frameAttached for frames. r=remote-protocol-reviewers,maja_zf
...
Differential Revision: https://phabricator.services.mozilla.com/D77483
2020-06-02 16:00:26 +00:00
5ccae203ff
Bug 1638358 - Cookie Schemeful Same-Site - part 3 - update add/addNative methods, r=mayhemer,remote-protocol-reviewers,marionette-reviewers,maja_zf,MattN,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D75627
2020-06-02 13:49:27 +00:00
e960b9f449
Backed out 7 changesets (bug 1640405, bug 1638358) for failures on browser_webconsole_network_messages_status_code.js. CLOSED TREE
...
Backed out changeset ef5f7479ddf8 (bug 1640405)
Backed out changeset 286e0c83eb30 (bug 1638358)
Backed out changeset 89e396b2896e (bug 1638358)
Backed out changeset 33ad5fa05209 (bug 1638358)
Backed out changeset d213264c1379 (bug 1638358)
Backed out changeset 6bc05236afb4 (bug 1638358)
Backed out changeset 87e9d0ed3982 (bug 1638358)
2020-06-02 15:16:42 +03:00
b4173bc59e
Bug 1638358 - Cookie Schemeful Same-Site - part 3 - update add/addNative methods, r=mayhemer,remote-protocol-reviewers,marionette-reviewers,maja_zf,MattN,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D75627
2020-06-02 09:13:51 +00:00
79fe28f0d6
Backed out 6 changesets (bug 1638358) for perma failures on browser_webconsole_navigate_to_parse_error.js. CLOSED TREE
...
Backed out changeset beb85cf281d5 (bug 1638358)
Backed out changeset 39f2e21623aa (bug 1638358)
Backed out changeset 2c873c72bf1f (bug 1638358)
Backed out changeset e91292c7c719 (bug 1638358)
Backed out changeset 0219ef931cd9 (bug 1638358)
Backed out changeset 4ac06f3992f4 (bug 1638358)
2020-06-02 00:24:46 +03:00
Kris Maglione
Kershaw Chang
Maja Frydrychowicz
Ricky Stewart
Anny Gakhokidze
Jonathan Watt
Narcis Beleuzu
Dorel Luca
Scott
Andrea Marchesini
Henrik Skupin
Gabriel Luong
chocos
Neil Deakin
Geoff Brown
Emilio Cobos Álvarez
Paul Bone
Razvan Maries
Dão Gottwald
Sonia Singla
Csoregi Natalia