Sometimes about:blank would match a non-private window, ensure we're looking
for a url specific to the private window.
Differential Revision: https://phabricator.services.mozilla.com/D21454
--HG--
extra : moz-landing-system : lando
The timer cancelling in UnifiedComplete.js seems to make the tests more stable with QuantumBar for some reason. Without it, some of the sub-tests would tend to time out. This might be better once we can implement a proper waitForResult() that doesn't have to wait for the entire search to be complete.
Differential Revision: https://phabricator.services.mozilla.com/D21006
--HG--
extra : moz-landing-system : lando
This patch rewrites the browser_ext_browserAction_popup.js test file to make it easier to follow the
sequence of its test cases (in the previous version of this test file, the logic that was executing
the sequence of test cases was fragmented in a bunch of listeners, in both the test extension and
the privileged test code) and to make the test able to wait for the popups to be fully loaded or
fully destroyed before moving to the next test case.
Differential Revision: https://phabricator.services.mozilla.com/D21427
--HG--
extra : moz-landing-system : lando
The bug indicated that the setUninstallURL did not honor empty url during runtime.
Steps to reproduce:
1. Install an extension, uninstall URL is set
2. Update the extension, changing the uninstall URL string to null (empty)
3. Uninstall the extension
Differential Revision: https://phabricator.services.mozilla.com/D18499
--HG--
extra : moz-landing-system : lando
The main behavior changes are:
1) We no longer create a new Window when doing document.open(). We use the
same Window but remove all the event listeners on it and on the existing DOM
tree before removing the document's existing kids.
2) We no longer create a new session history entry. The existing one always
gets replaced instead.
3) We now support document.open on documents that are not in a Window.
The reasons for the various test changes are as follows:
The change to browser_modifiedclick_inherit_principal.js is because we no
longer set the docshell to a wyciwyg URL when document.open() happens and the
test was depending on that to terminate.
browser_wyciwyg_urlbarCopying.js is being removed because it's trying to test
wyciwyg URIs, which no longer exist.
The changes in docshell/test/navigation are because document.open() no longer
affects session history. One of the tests was testing the interactions there
and is being removed; another is being repurposed to just test that
document.open() does not affect history.length.
The change to test_x-frame-options.html is because document.open() now removes
event listeners on the window, which it didn't use to do (and in the specific
case in this test reused the existing inner too, so the listener was still
around in practice). The new behavior matches other browsers.
The removal of test_bug172261.html is because document.open() no longer affects
session history, so you can't go back across it or forward to the "opened"
state, so the situation that test is trying to test no longer exists.
The changes to test_bug255820.html are because reloading a document after
document.open() will now just load the URL of the document that was the entry
document for the open() call, not reload the written content. So there's not
much point testing reload behavior, and in this test it was just reloading the
toplevel test file inside the frames.
The change to test_bug346659.html is because now we no longer create a new
Window on document.open().
The change to test_bug1232829.html is because document.open() (implicit in this
test) no longer adds history entries, so the back() was just leaving the test
page instead of going back across the document.open(). The test is a
crashtest in practice, so might still be testing something useful about how
document.open() interacts with animations.
The change to test_bug715739.html is because the URL of the document after
document.open() is now the URL of the entry document, not a wyciwyg URL, so
reload() has different behavior than it used to.
The change to test_bug329869.html is because now when we go back we're
reloading the original document we had, not doing a wyciwyg load, and the
security info now doesn't include the untrusted script.
The changes to the wpt expectations are removing a bunch of expected failures
now that we pass those tests and disabling some tests that are fundamentally
racy and hence fail randomly. The latter all have github issues filed for the
test problem.
The change to testing/web-platform/tests/common/object-association.js is fixing
tests that were not matching the spec (and were failing in other browsers).
The change to parser-uses-registry-of-owner-document.html is fixing tests that
were not matching the spec (and were failing in other browsers).
The change to document-write.tentative.html is because the test was buggy: it
was using the same iframe element for all its tests and racing loads from some
tests against API calls from other tests, etc. It's a wonder it ever managed
to pass, independent of these patches (and in fact it doesn't pass according to
wpt.fyi data, even in Firefox).
The changes in html/browsers/history/the-history-interface are because
document.open() no longer adds history entries. The test was failing in all
other browsers for the same reason.
The changes in html/browsers/history/the-location-interface are because
reloading a document.open()-created thing now loads the URL of the page that
was the entry document for the open() call. The test was failing in all other
browsers.
The change to reload_document_open_write.html is because we now reload the url
of the document that entered the script that called open() when we reload, not
the written content. Other browsers were failing this test too; Gecko with
the old document.open implementation was the only one that passed.
The change to http-refresh.py is to fix a test bug: it was not returning a
Content-Type header, so we were putting up helper app dialogs, etc.
The change to test_ext_contentscript.js is because we no create a new global
for document.open() calls. Kris Maglione OKed this part.
Differential Revision: https://phabricator.services.mozilla.com/D17323
--HG--
extra : moz-landing-system : lando
This adds a mechanism that discards tabs when the browser detects a low-memory
scenario. Tabs are discarded in LRU order prioritizing regular tabs over
pinned ones, pinned ones over tabs playing audio and all of the previous over
pinned tabs playing audio.
Differential Revision: https://phabricator.services.mozilla.com/D20476
--HG--
extra : moz-landing-system : lando
This removes the need to go through the browser-to-tab mapping when discarding
a tab and simplifies the relevant code. Besides being renamed discardBrowser()
was also split so that one can check if a tab can be discarded prior to trying
it.
Differential Revision: https://phabricator.services.mozilla.com/D20475
--HG--
extra : moz-landing-system : lando
Previously, if the accesskey attribute was missing then the label would reach up
to binding parent to find it's accesskey. In practice, bindings already do
[xbl:inherits=accesskey] to send it down to the label anyway.
The problem with this is that for controls without accesskeys, the attribute doesn't get set,
so the label will access the control from JS. This is fine for XBL, since typically
the label XBL will construct at the same time as the control, but when migrating
to Custom Elements, the label gets connected even when the control is hidden.
Differential Revision: https://phabricator.services.mozilla.com/D12355
--HG--
extra : moz-landing-system : lando
On browser startup, include the value of the browser.contentblocking.category pref with the main ping.
Differential Revision: https://phabricator.services.mozilla.com/D20731
--HG--
extra : moz-landing-system : lando
When we open firefox with pinned tabs, we first paint a window with
one tab open, and then that tab gets displaced after the pinned tabs
come in. This aims to ensure that our first paint contains the
pinned tab, so that we don't have tabs moving around after first
paint.
MozReview-Commit-ID: GC1y6NlgLTd
Differential Revision: https://phabricator.services.mozilla.com/D18742
--HG--
extra : moz-landing-system : lando
This test was failing intermittently in opt and pgo builds because there was a slightly chance that
the test extension may be calling browser.extension.getViews while the popup context was unloading
but it wasn't still destroyed and so it wasn't yet removed from the set of the extension views.
This patch fixes this intermittency by changing the promiseBrowserContentUnloaded test helper to
ensure that the unloadPromise is resolved when the "inner-window-destroyed" message for the
extension window is being notified to the "observer service" listeners, as it is what
the ExtensionPageChild is listening to decide when the ExtensionPageContextChild should be
unloaded and removed from the set of the extension views.
Differential Revision: https://phabricator.services.mozilla.com/D20658
--HG--
extra : moz-landing-system : lando
Summary: Before this change no style for invalid input fields was included in Firefox and thus invalid text fields where not highlighted as invalid as per the Firefox Photon design guide.
Test Plan:
Screenshot: https://hostux.pics/images/2019/01/25/image5123a27cc99ab189.png
# Installed my add-on: https://addons.mozilla.org/firefox/addon/mastodon-simplified-federation/
# Go to settings page and enter some invalid string in the input field.
# Open add-on debugger and inspect that element.
# (important!) Disable my workaround I added. (in options.css), see the screenshot at the top right, where I did this.
# And you can still see the invalid style…
Reviewers: rpl, bwinton
Reviewed By: bwinton
Subscribers: bwinton, caitmuenster
Bug #: 1514567
Differential Revision: https://phabricator.services.mozilla.com/D17558
--HG--
extra : rebase_source : ea0ee02b258f4767164bf6fe76dec0df2d7d8b70
extra : amend_source : 7570445162cbe059171bb73c934d37018fe54a3d
Luca Greco
Alphan Chen
lloan
Shane Caraveo
Mark Banner
Marco Bonardo
Oriol Brufau
Ciure Andrei
sagarwala
Boris Zbarsky
Gabriele Svelto
Mike Conley
jcit
Felipe Gomes
Daisuke Akatsuka
shindli
Brian Grinstead
Noemi Erli
Erica Wright
Christoph Kerschbaumer
Doug Thayer
Jonathan Kingston
Cosmin Sabou
ui.manish
Matthew Noorenberghe
