47217eaaec
Bug 1195474 - Annotate 759249-1.html and 415394-1.xhtml as asserting in e10s mode. a=me
...
--HG--
extra : amend_source : 6f6f04e2566e9e74bad340ceb9238566e3a55f5e
2015-08-17 15:48:20 -04:00
786a11f445
Bug 1183896. Don't assume that relatively positioned table cells actually have positioned offsets computed, because in the case of position:sticky they don't. r=dholbert
2015-07-16 17:53:52 -04:00
4e6c40d7ea
Bug 1131451 part 1 - Replace containerWidth with containerSize in logical-coordinate classes and APIs, frame classes, etc. r=dholbert
2015-07-16 10:07:57 +01:00
76e21c1574
Bug 1177614 - Provide a utility method on nsHTMLReflowState to return the computed size including border-padding, for use as a container for logical coordinate conversions, or zero if unconstrained. r=dholbert
2015-07-16 10:07:46 +01:00
a8939590de
Bug 1182996 - Fix and add missing namespace comments. rs=ehsan
...
The bulk of this commit was generated by running:
run-clang-tidy.py \
-checks='-*,llvm-namespace-comment' \
-header-filter=^/.../mozilla-central/.* \
-fix
2015-07-13 08:25:42 -07:00
f851061a41
Bug 1177690 - part 2 - Tidy up the use of DrawTableBorderSegment similarly in BCInlineDirSeg::Paint. r=dholbert
2015-07-08 09:07:52 +01:00
83ad3b3e8e
Bug 1177690 - part 1 - Bevel the correct ends of horizontal collapsed-border segments in vertical-rl writing mode. r=dholbert
2015-07-08 09:07:52 +01:00
2d07dec2df
Bug 1177690 - part 0 - Tidy up some erratic whitespace. r=dholbert
2015-07-08 09:07:52 +01:00
e93a33b701
Bug 1180166 - Ensure all elements of tableBorderReset[] are properly initialized. r=dholbert
2015-07-05 20:27:53 +01:00
a5d7c41309
Bug 1177076 patch 2 - Convert nsTableOuterFrame to work with logical coordinates. r=dholbert
2015-07-03 11:37:33 +01:00
4f0102e602
Bug 1178250 - Don't call ConsiderChildOverflow until the child has been placed in the right location when reflowing a vertical-rl table. r=dholbert
2015-06-30 10:14:19 +01:00
cb57b1ad8c
Bug 1177925: Use range-based "for" loops for nsFrameList iteration, in various places in layout. r=tn
2015-06-29 13:02:21 -07:00
fa16a00d09
Bug 1173958: whitespace and bracing changes to make FixedTableLayoutStrategy conform to local style, r=jfkthame
2015-06-26 09:03:12 -07:00
dc5f8159fe
Bug 1173958: convert FixedTableLayoutStrategy to logical coordinates, r=jfkthame
2015-06-26 08:58:22 -07:00
0cb8df0560
Bug 1157569 - Followup to address review nits (renamings, comment updates) from parts 13 and 14.
2015-06-27 11:16:18 -07:00
d22a7ebb8c
Bug 1157569 - part 14 - Finish conversion of border-collapse code in nsTableFrame to logical coordinates. r=dholbert
2015-06-27 11:16:10 -07:00
f9a52f8a25
Bug 1157569 - part 13 - More conversion of physical to logical terminology in border-collapse calculations. r=dholbert
2015-06-27 11:16:03 -07:00
8dcfdf89d6
Bug 1177606 - Correct the row positioning within rowGroups in vertical-rl tables when distributing extra width. r=dholbert
2015-06-26 16:50:38 -07:00
6c2cc390da
Bug 1177600 - Properly adjust table row and cell positions when their containing block-size changes in vertical-rl writing mode. r=dholbert
2015-06-26 16:50:21 -07:00
55b7401f32
Bug 1174711 patch 5 - Copy inline-size rather than width from prev-in-flow when initializing nsTableFrame. r=dholbert
2015-06-24 16:23:59 -07:00
d6ddc659a1
Bug 1176523 - Convert Get/SetContinuousBCBorderWidth in nsTableColFrame and nsTableColGroupFrame to logical coordinates. r=dholbert
2015-06-24 09:56:54 -07:00
2a63c0bc82
Bug 1176354 - Rename nsTableRowFrame::GetBSize to differentiate better from nsIFrame::BSize. r=dholbert
2015-06-23 13:41:31 -07:00
d1f05cc84f
Bug 1176555 - Replace explicit bit-twiddling of frame state flags by human-readable nsIFrame state-manipulation methods in table layout code. r=dholbert
2015-06-23 13:41:29 -07:00
442eb4da56
Bug 1176105 - Remove the (largely gutted) nsTableIterator class, and replace with simple frame-list iteration. r=dholbert
2015-06-23 11:47:45 -07:00
1833a394b6
Bug 1176414 - Clean up/rename various column index variables in nsTableRowFrame and nsTableFrame. r=dholbert
2015-06-23 11:45:17 -07:00
39c5f7f91a
Bug 1176337 - Remove unnecessarily gcc-4.4-specific cast from nsTableRowFrame::ReflowChildren(), now that we require newer gcc. r=dholbert
2015-06-23 11:44:59 -07:00
fab7a6ae8d
Bug 1176070 - Optimize nsTableFrame's FirstInFlow() lookups from calls to GetColumnISize(). r=dholbert
2015-06-23 11:44:36 -07:00
f0a5c3023f
Bug 1174711 - patch 4 - Rename mSpecialHeightReflow to mSpecialBSizeReflow, and update comments to match. r=dholbert
2015-06-22 10:33:34 +01:00
2d252085be
Bug 1174711 - patch 3 - Rename a couple more frame-state bits from physical to logical. r=dholbert
2015-06-22 10:33:34 +01:00
2c538d45a5
Bug 1174711 - patch 2 - Convert nsTableFrame to work with logical coordinates. r=dholbert
2015-06-22 10:33:34 +01:00
10bd90547b
Bug 1174711 - patch 1 - Rename nsIPercentHeightObserver to nsIPercentBSizeObserver, and update related frame methods to match. r=dholbert
...
--HG--
rename : layout/base/nsIPercentHeightObserver.h => layout/base/nsIPercentBSizeObserver.h
2015-06-22 10:33:34 +01:00
d2e0daf015
Bug 1174700 - patch 2 - Convert nsTableFrame::SetColumnDimensions to work with logical-order iteration over the table, so that column coordinates and collapsed borders are correct. r=dholbert
2015-06-20 21:00:33 +01:00
31469f3572
Bug 1174700 - patch 1 - Convert nsTableRowFrame and nsTableRowGroupFrame to work with logical coordinates. r=dholbert
2015-06-20 21:00:26 +01:00
2c5c24868e
Back out changesets ed293fc9596c and f18cb4c41578 (bug 1174700) for fatal assertions in all Windows debug reftest runs.
...
CLOSED TREE
Assertion failure: origKidNormalPosition.B(wm) == 0, at c:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/src/layout/tables/nsTableRowFrame.cpp:861
TEST-UNEXPECTED-FAIL | file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/writing-mode/ua-style-sheet-size-1.html | application terminated with exit code 1
2015-06-20 22:41:07 -07:00
cb44db0b95
Bug 1174700 - patch 2 - Convert nsTableFrame::SetColumnDimensions to work with logical-order iteration over the table, so that column coordinates and collapsed borders are correct. r=dholbert
2015-06-20 21:00:33 +01:00
daf28cd1e7
Bug 1174700 - patch 1 - Convert nsTableRowFrame and nsTableRowGroupFrame to work with logical coordinates. r=dholbert
2015-06-20 21:00:26 +01:00
bf0d1d0f6f
Bug 1173307 - Convert nsTableCellFrame to work with logical coordinates. r=dholbert
2015-06-18 10:11:40 +01:00
a3380043e5
Bug 1174507 - Replace the frame flag CONTAINS_RELATIVE_HEIGHT with CONTAINS_RELATIVE_BSIZE, and adjust callsites appropriately. r=dholbert
2015-06-18 07:33:50 +01:00
4bcd16152c
Bug 1174631 (part 3) - Replace SpanningCellSorter's uses of PL_DHashTableEnumerate() with PLDHashTable::Iterator. r=dholbert.
...
--HG--
extra : rebase_source : a84a8548d6d88e558d8ec1cdde09af2d2cb58084
2015-06-16 21:09:39 -07:00
84d9d4e6f1
Bug 1157569 - part 12 - Convert physical values from BCPropertyData to logical when returning from Get[Included]OuterBCBorder. r=roc
2015-06-17 11:03:25 +01:00
50566a67a3
Bug 1173305 - Convert BasicTableLayoutStrategy to work with logical coordinates. r=dholbert
2015-06-16 15:45:46 +01:00
479bf4c89b
Bug 1174450 part 9 - Remove the nsRenderingContext* param from Intrinsic*SizeOffsets methods since it's unused. r=jfkthame
2015-06-16 11:21:04 +00:00
d4298ccd14
Bug 1172774: for a box with a writing mode orthogonal to its containing block, calculate positioning values (margin, padding and offsets) in the writing mode of the containing block, r=jfkthame
2015-06-10 23:42:56 -07:00
6e3fc0bd96
Bug 1171328 - Convert nsTableFrame::GetChildAreaOffset() and its friends to use LogicalMargin. r=dholbert
...
--HG--
extra : source : 5d48d96995a1b2fd4aefc463d0f2fb2d156e0406
2015-06-10 13:13:49 +12:00
de95224fec
Bug 1169432 part 5: Use range-based 'for' loops when walking frame lists, in nsTableFrame. r=mats
2015-06-05 15:39:35 -07:00
fff00b71d3
Bug 1169432 part 4: Convert NS_ASSERTION(false, ...) to NS_ERROR(...) in nsTableFrame. r=mats
2015-06-05 15:39:27 -07:00
b864ce9764
Bug 1169432 part 3: Use nsTArray::Contains instead of nsTArray::IndexOf(), for brevity, in nsTableFrame. r=mats
2015-06-05 15:39:13 -07:00
d19a227430
Bug 1169432 part 2: Refactor nsTableFrame::Init. r=mats
2015-06-05 15:39:06 -07:00
7f1b0db94c
Bug 1147834: Use abstract coordinates in nsHTMLReflowState, r=jfkthame
2015-06-04 03:43:02 -07:00
e849e6588b
Bug 1170416 (part 3) - Remove the PLDHashTable2 typedef. r=froydnj.
...
--HG--
extra : rebase_source : 9510ea47204fffa163cac43aeaaac6ae1ad80419
2015-05-19 16:46:17 -07:00
7dfbf70ce7
Backed out changeset 4126c66c9a80 (bug 1166728) for Gaia sound_manager_test.js failures.
...
CLOSED TREE
2015-05-29 15:16:53 -04:00
f2ec992500
Bug 1166728 - Remove box-sizing: padding-box, as per CSS WG. r=dholbert
2015-05-29 09:17:00 -04:00
45b95898e0
Backed out changeset 541cd29ea626 (bug 1166728) because the updated patch wasn't posted to the bug.
2015-05-29 12:48:22 -04:00
3bacc6993c
Bug 1166728 - Remove box-sizing: padding-box, as per CSS WG. r=dholbert
2015-05-27 09:57:00 -04:00
47df1bbfe3
Backed out changeset dd96df1da2b5 (bug 1166728) for making test_bug320799.html permafail on Mulet.
...
CLOSED TREE
--HG--
extra : rebase_source : 4ff4ea2d22a0beb2af011cec40f90efba2e452b9
2015-05-28 11:01:18 -04:00
2e3823f252
Bug 1166728 - Remove box-sizing: padding-box, as per CSS WG. r=dholbert
...
--HG--
extra : rebase_source : 6103761cd36cbba2c8e048db2a0d6cd75cad2020
2015-05-27 09:57:00 -04:00
7c9227860d
Bug 1167696 part 2: Remove nsTableReflowState's frame constructor-arg; get it from passed-in reflow state instead. r=mats
2015-05-25 19:43:50 -07:00
98a086029d
Bug 1167696 part 1: Remove nsTableReflowState's unused constructor & nsPresContext arg. r=mats
2015-05-25 19:43:10 -07:00
51dc9c3dc9
Bug 1166598 (part 2) - Use PLDHashTable2 in SpanningCellSorter. r=froydnj,dbaron.
...
--HG--
extra : rebase_source : 2ca65083c218523b8f6dba043979f61358a79ca1
2015-05-05 16:11:43 -07:00
548da769cc
Bug 1167765: Misc whitespace cleanup in nsTableFrame.cpp. whitespace/rewrapping-only, no review, DONTBUILD
2015-05-22 14:23:44 -07:00
64a7a40bf2
Bug 1159127 - Always redirect inserting col group frame to first-in-flow table frame. r=mats
...
--HG--
extra : source : 2f6fc7196b2bc0720035c3007bbafb63e2e974bd
2015-05-20 13:29:43 +12:00
bf6ef0da30
Bug 1157569 part 12 - Remove useless m{Start,End}Side from BCMapCellInfo. r=roc
...
--HG--
extra : source : ac5101097059182858dc0f5d20fe0263b5d5ca7a
2015-05-04 19:09:25 +12:00
1f8102a880
Bug 1157569 part 11 - Rename methods and fields in nsTableCellFrame from physicals to logicals. r=roc
...
--HG--
extra : source : fa5e5be043d1887ac62b8e2ab5b67366cf207058
2015-05-04 19:09:25 +12:00
79661faf79
Bug 1157569 part 9 - Rename methods and fields in nsTableRowFrame from physicals to logicals. r=roc
...
--HG--
extra : source : ce0fb2e11506e7aafffd88ee628bf8485648de24
2015-05-04 19:09:25 +12:00
a6a99c50ec
Bug 1157569 part 8 - Move some code in BCPaintBorderIterator::SetDamageArea for less computation. r=roc
...
--HG--
extra : source : ccac169ecb8651b6a9f598444f228bdf14866f2c
2015-05-04 19:09:25 +12:00
df305b8624
Bug 1157569 part 7 - Rename methods and fields in nsTableColFrame from physicals to logicals. r=roc
...
--HG--
extra : source : 9f6e318183c92842dfe337aa6da9af62cfc45cd8
2015-05-04 19:09:25 +12:00
ffd497f5a6
Bug 1157569 part 6 - Rename methods and fields in BCMapCellInfo from physicals to logicals. r=roc
...
--HG--
extra : source : 354bacf8949d29d8f44862b5b1b514da824d62ee
2015-05-04 19:09:25 +12:00
ac14c15e2c
Bug 1157569 part 5 - Convert GetColorAndStyle, GetPaintStyleInfo, and CompareBorders in nsTableFrame to accept writing mode and logical side. r=roc
...
This changes behavior of border collapse on RTL tables, but it seems
that there is no test coverage on those cases, and those cases should
have been broken before, due to the mix of m{Start,End}side and
physical sides in the methods. Hence this change should be fine, as
long as we are going to fix it in later patches.
--HG--
extra : source : b9e8bf39a62add595d939ebd3714d7e6a690af22
2015-05-04 19:09:25 +12:00
4a5f54af06
Bug 1157569 part 4 - Replace mTableIsLTR with mTableWM in BCMapCellInfo & BCPaintBorderIterator. r=roc
...
--HG--
extra : source : 7e56026f20086c4b1c705609562b9dc43ccb2b91
2015-05-04 19:09:25 +12:00
38812d4032
Bug 1157569 part 3 - Merge two GetColorAndStyle functions in nsTableFrame. r=roc
...
--HG--
extra : source : a2eef88e064cefd04b14409ac78245dafffbee7f
2015-05-04 19:09:25 +12:00
bd0cb193a2
Bug 1157569 part 2 - Convert output parameters of GetColorAndStyle/GetPaintStyleInfo in nsTableFrame to use pointers. r=roc
...
--HG--
extra : source : cea85dbc11f7ea58e2c64be5d619c847bdcb368c
2015-05-04 19:09:25 +12:00
48d1d4f3e5
bug 1157569 part 1 - Rename BC_BORDER_{TOP,RIGHT,BOTTOM,LEFT}_HALF* to BC_BORDER_{START,END}_HALF*. r=roc
...
--HG--
extra : source : 5a1c4c8f584b89b2d65c43f325ffa4a070a4f7b6
2015-05-04 19:09:25 +12:00
ef54b4b14f
Bug 1159990 - Add TableArea struct and replace nsIntRect with it for table damage area. r=roc
...
--HG--
extra : source : bdc7bf00559b80ae6a4f9c60848e34542f438218
2015-05-01 09:46:59 +12:00
0c5653824d
Bug 1159101 part 5 - Initialize writing mode of desired mode of table cell frame from its table frame on a CLOSED TREE. r=roc
...
--HG--
extra : source : ad2134d545e36298124b6ec5aea600d3689022ad
extra : amend_source : 8bf117c8a17a8a9d0144a00709a8963f8b7efd14
2015-04-30 18:27:54 +12:00
b67d865b08
Bug 1159101 part 4 - Override GetWritingMode() in nsTable{{Col,Row}{,Group},Cell}Frame. r=roc
...
--HG--
extra : source : 4b8d51cfa3331c052ede29b56bb7172088e47873
2015-04-30 16:24:59 +12:00
82e7b5cf9f
Bug 1159101 part 3 - Replace most of nsTableFrame::GetTableFrame() usage with new GetTableFrame() methods. r=roc
...
--HG--
extra : source : 626bc4d2a946d0499a529f974abe2711c0174241
2015-04-30 16:24:59 +12:00
e30901b6a0
Bug 1159101 part 2 - Add GetTableFrame() for table inner frames. r=roc
...
--HG--
extra : source : c470aa2508be969b203ec686f8375383a5de6959
2015-04-30 16:24:59 +12:00
b076220a42
Bug 1159101 part 1 - Alter dependencies among headers of table struct frames. r=roc
...
--HG--
extra : source : 47d27fc19bd60b57a2d910c60c48ae047c66c65c
2015-04-30 16:24:59 +12:00
ebde6b9f4f
Bug 1157835: Remove the MSVC_ENABLE_PGO flag from the build system. r=glandium
...
--HG--
extra : rebase_source : 0c47c99bb8b92f8361a51fd81b20a2cc8647a986
2015-04-27 19:59:27 -04:00
085da9302a
Bug 1156632 - Remove unused forward class declarations - patch 5 - rdf, parser, layout and something else, r=ehsan
2015-04-22 08:29:22 +02:00
cfff5e52c5
Bug 1155621 - Make nsIntRect and nsIntPoint typedefs of mozilla::gfx::IntRect and mozilla::gfx::IntPoint. r=Bas
2015-04-21 17:04:57 +02:00
7f6df34459
Bug 1152354 - Re-introduce the incremental reflow hack in nsSimplePageSequenceFrame for now, since the regressions are worse than the original problem (bug 1108104). r=roc
...
--HG--
extra : rebase_source : bd5feeaa5e69ddcec8af6f80ad5ec2b6be5ed8ab
2015-04-20 05:46:00 -04:00
2557a4c19e
Bug 1155880 part 3: Rename nsTableFrame::GetColumnWidth to use "ISize" instead of "Width". r=jfkthame
2015-04-18 16:01:27 -07:00
d4904872c9
Bug 1155880 part 2: Rename nsTableColFrame Get/Set/ResetFinalWidth methods to use "ISize" instead of "Width". r=jfkthame
2015-04-18 16:01:26 -07:00
2f0de265e8
Bug 1155880 part 1: Rename nsITableLayoutStrategy::ComputeColumnWidths and associated comments to use "ISize" instead of "Width". r=jfkthame
2015-04-18 16:01:24 -07:00
31279a26d4
Bug 1155412: Use mozilla::Maybe instead of hardcoded placement-new, for reflow state created in nsTableOuterFrame::OuterBeginReflowChild() and used by its caller. r=dbaron
2015-04-17 15:56:01 -07:00
1e4637780c
Bug 1155798: Drop end-of-line whitespace from C++ files in layout/tables. (whitespace-only, no review, DONTBUILD)
2015-04-17 11:42:05 -07:00
2f31bdf840
Bug 1143299 - Make frame insertion methods deal with aPrevFrame being on an overflow list. r=roc a=abillings
2015-04-11 00:21:06 +00:00
ea742f35e6
Bug 1148833 part 4 - Fix indentation of some Reflow params (white-space changes only).
2015-03-29 22:38:40 +00:00
ed9ed2d61a
Bug 1148833 part 3 - Remove nsIFrame::WillReflow and add a non-virtual MarkInReflow method instead that sets NS_FRAME_IN_REFLOW. Call it at the start of Reflow(). r=roc
2015-03-29 22:38:40 +00:00
883849ee32
Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj
...
This patch was automatically generated using the following script:
function convert() {
echo "Converting $1 to $2..."
find . \
! -wholename "*/.git*" \
! -wholename "obj-ff-dbg*" \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert MOZ_OVERRIDE override
convert MOZ_FINAL final
2015-03-21 12:28:04 -04:00
69bd92ee0e
Bug 1145036 part 2 - Rename nsTableFrame::GetCellSpacingX/Y to GetCol/RowSpacing. r=roc
...
--HG--
extra : source : f499ce6fd4e7d007a053fb5dda47d32c698d71ce
2015-03-20 15:16:00 +11:00
b4efb87d4a
Bug 1145036 part 1 - Rename mBorderSpacingX/Y to mBorderSpacingCol/Row. r=heycam
...
--HG--
extra : source : 4f0a5e14993dd26e4a25d5f05ea1ec274bebe4e6
2015-03-20 15:16:00 +11:00
72f3e0b5cb
Bug 1141252. Don't mark the TablePainter display item as having background-attachment:fixed content if the background-attachment:fixed image will be painted by a dedicated nsDisplayTableCellBackground. r=mats
...
--HG--
extra : rebase_source : 4e932f88532896f4a65ffd86445c623ba1b66ec6
2015-03-12 15:08:26 +13:00
3d3de907e0
Bug 1082249. Invalidate background-attachment:fixed table-part backgrounds when scrolled. r=mattwoodrow
...
--HG--
extra : rebase_source : 766292ba08aafee922c4d42d702167a08a62bb4f
2015-03-05 00:02:14 +13:00
da27c29b8c
Bug 1139180 - Add BUG_COMPONENT metadata to moz.build for files in layout/. r=roc
...
--HG--
extra : transplant_source : %E16mjh%96Y%AB%96%23%A3%BDCF%F6%8D%95%BF%FE%BC
2015-03-03 17:03:19 -08:00
a1282d848c
Bug 992077 patch 4 - Stop using OverflowChangedTracker::CHILDREN_AND_PARENT_CHANGED for the overflow area updates dealing with absolutely positioned elements contained by relatively positioned table parts. r=mats
...
The old code here was also updating overflow areas on more frames than
needed. (Using CHILDREN_CHANGED on positionedPart itself causes test
failures because positionedPart's overflow area doesn't change in the
overflow updating process, so no overflow change is propagated to the
parent; it's the parent that actually needs the update.)
2015-02-16 16:34:29 +13:00
3a7b0a9f57
Bug 1131901 (part 1) - Make PL_DHashTableAdd() infallible by default, and add a fallible alternative. r=froydnj.
...
I kept all the existing PL_DHashTableAdd() calls fallible, in order to be
conservative, except for the ones in nsAtomTable.cpp which already were
followed immediately by an abort on failure.
--HG--
extra : rebase_source : 526d96ab65e4d7d71197b90d086d19fbdd79b7b5
2015-02-02 14:48:58 -08:00
63e3218e4c
Back out changesets 2fcef6b54be7, 2be07829fefc, 66dfe37b8532, df3fcd2be8fd, 0a436bce77a6 (bug 1050035) for causing intermittent crashes and assertion failures.
...
--HG--
extra : rebase_source : eb30be83c3143c6c203585a80a18f180025efaba
2015-02-10 14:39:49 -08:00
9bc6846579
Bug 1128769 (Part 4) - Record the last draw result when drawing CSS tables and use it to decide whether to sync decode. r=tn
2015-02-05 20:45:56 -08:00
Ryan VanderMeulen
Boris Zbarsky
Jonathan Kew
Birunthan Mohanathas
Daniel Holbert
Simon Montagu
L. David Baron
Nicholas Nethercote
Mats Palmgren
Xidorn Quan
Kyle Zentner
David Major
Andrea Marchesini
Nicolas Silva
Ehsan Akhgari
Robert O'Callahan
Seth Fowler