mozilla
/
gecko-dev
зеркало из https://github.com/mozilla/gecko-dev.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность
592 467 коммитов 615 Ветки 98 Теги 5,7 GiB
Граф коммитов

5136 Коммитов

Автор SHA1 Сообщение Дата
Kit Cambridge 04142e96e3 Bug 1439038 - Merge `Engine` and `SyncEngine`. r=eoger 
MozReview-Commit-ID: GbuW3gFLCga

--HG--
extra : rebase_source : b15ea149ff5ddca7cdb45b0ef195c07bf4915411
 2018-02-16 16:43:42 -08:00
Kartikey 9d57bd2ba2 Bug 1011480 - Remove CommonUtils.laterTickResolvingPromise() and replace it by Async.promiseYield() and Async.jankYielder(). r=eoger 
MozReview-Commit-ID: 3YSGVKgqdUq
 2018-02-20 10:31:58 +08:00
Kit Cambridge eb8e51bd1d Bug 1438740 - Add a consistency check to ensure the synced bookmark mirror matches Places. r=markh 
MozReview-Commit-ID: CGzXDy95Bkx

--HG--
extra : rebase_source : fed4a4a91512780d77d38783939bef2d9bb630ae
 2018-02-15 18:36:24 -08:00
Mark Banner d6729b8d28 Bug 1432614 - Remove now unnecessary updating and maintenance of Places' root folder titles. r=kitcambridge,mak 
The titles for the root bookmark folders in the database will now never get updated. This
avoids doing maintenance and changing them if the locale changes.

The UI is now responsible for displaying the correct title.

WebExtensions API will get the UI visible names.

MozReview-Commit-ID: ErPPJXxy2d3

--HG--
extra : rebase_source : f08caa5b0d00ae81ffabf4a1076bd56b66414418
 2018-01-04 16:35:56 +00:00
Mark Banner 28f08cc0dc Bug 1443835 - Prevent modifications to the root folder via PlacesUtils.bookmarks.insert and PlacesUtils.bookmarks.update. r=mak 
MozReview-Commit-ID: KQjxc3PA2SY

--HG--
extra : rebase_source : 1a6063f424271ac3bfdae23af25a4e8abdd71ac9
 2018-03-07 17:24:01 +00:00
Jared Wein 9788800512 Bug 1436575 - Manually fix the errors from no-compare-against-boolean-literal that the autofix couldn't change. r=standard8 
MozReview-Commit-ID: 6NtfU76sPKv

--HG--
extra : rebase_source : 143891b98995658a5683e01631eba9f6a2bb7b6f
 2018-02-08 13:35:53 -05:00
Jared Wein c8d331f4c9 Bug 1436575 - Autofix errors from no-compare-against-boolean-literal. r=standard8 
MozReview-Commit-ID: 66sXxnOWDgw

--HG--
extra : rebase_source : a0bf26e37a03a1e77476bdeedfc1af3ebec32f2a
 2018-02-08 12:57:31 -05:00
Ethan Glasser-Camp fd05d53fe9 Bug 1388830 - upgrade kinto-http.js to 4.5.3. r=MattN 
This introduces an `UnparseableResponseError`, which exposes the text
of the actual non-JSON response. It's also catcheable by client
code (i.e. ExtensionStorageSync.jsm) if we believe this error is
common enough to be silenced.

MozReview-Commit-ID: H3ADFBFJRKA

--HG--
extra : rebase_source : 275b5084899646520d28b7c33e4bf5efdd11b996
 2018-02-14 12:48:09 -05:00
Ciure Andrei 72080bd73c Merge inbound to mozilla-central. a=merge 2018-02-13 00:08:37 +02:00
Tom Ritter c4edd2fe5c Bug 1435296 Address xpcshell test failures from increasing timer precision r=baku 
See the comment on "Address test failures caused by bumping timer precision to 2 ms"
for more details.

MozReview-Commit-ID: LrsucEPdZIo

--HG--
extra : rebase_source : 8147c034f7dc93f678eebc80b0afabf55729d804
 2018-02-12 11:41:38 -06:00
Marco Bonardo de4bd875a7 Bug 1432434 - Remove Bookmarks::getItemDateAdded and setItemDateAdded. r=kitcambridge 
MozReview-Commit-ID: XVoil1CK7c

--HG--
extra : rebase_source : 18213447f00177686dbc56d263674fa4e630663e
 2018-02-08 23:24:38 +01:00
Thom Chiovoloni ee6fffd334 Bug 1412332 - Enable sync passwords validator for nightly and beta users. r=markh 
This also fixes an issue where our engine enabled preference listener was overzealous.

MozReview-Commit-ID: DphLaEUkyOz

--HG--
extra : rebase_source : fdcf154adf2cb11ac3bb0140670ce2dce68f4586
 2018-01-31 20:00:29 -05:00
Marco Bonardo ee28acdb29 Bug 539517 - remove synchronous Bookmarks::SetItemIndex API. r=standard8 
MozReview-Commit-ID: 20kwLPazqPC

--HG--
extra : rebase_source : 7ac31306185573f6f94bcef4e89257d6a2ea2c2d
 2018-02-08 18:45:00 +01:00
Edouard Oger a0cec42f04 Bug 1415951 - Extend TPS to support Addresses and Credit Cards. r=tcsc 
MozReview-Commit-ID: 8VKBvm60ZSH

--HG--
extra : rebase_source : 88cb7b4145db018517c920907da79c70c46d50d2
 2018-02-05 14:39:32 -06:00
Thom Chiovoloni a98bc19750 Bug 1432995 - Check for HTTP error codes before error strings in the sync ping. r=markh 
MozReview-Commit-ID: KU15HVElChU

--HG--
extra : rebase_source : e0baba3644582aa16449bd87bf06bc611657fab5
 2018-01-29 15:01:04 -05:00
Nathan Watson 1605552221 Bug 1434262 - Remove PlacesTestUtils.clearHistory() r=mak 
MozReview-Commit-ID: In2RaM0LBsc

--HG--
extra : rebase_source : 0cb5dc65a53bfa384b93fb2a8c2af67ad9d3fe1c
 2018-01-31 22:03:05 -08:00
Edouard Oger 626be20bbb Bug 1427674 - Unify FxA content server URL preferences. r=markh,tcsc 
MozReview-Commit-ID: 3zhHGAzQr0R

--HG--
extra : rebase_source : 013457dfb434c92134d2f244b389d21620c83595
 2018-01-30 13:21:35 -05:00
Edouard Oger f5d827c682 Bug 1436637 - Revert back to a sync observer in Service. r=markh 
MozReview-Commit-ID: 2X7mo3stuy7

--HG--
extra : rebase_source : 1dfa43a9237baca4bbb08f98f14d3ccfd2888ee4
 2018-02-08 12:14:46 +08:00
Edouard Oger fe060b9d44 Bug 1436636 - Properly start/stop clients engine tracker. r=markh 
MozReview-Commit-ID: 19Xv1Hj18Nu

--HG--
extra : rebase_source : 7d81f54ec00891d3e0fa40e2930a01c9821cf684
 2018-02-08 11:45:22 +08:00
Marco Bonardo f3d9e285fa Bug 1437040 - Remove synchronous Bookmarks::GetItemIndex. r=standard8 
MozReview-Commit-ID: GpNkBI1Qe42

--HG--
extra : rebase_source : 3a17c1f81aa4375a4a111ed2d17ffad241a77d81
 2018-02-09 15:23:21 +01:00
Thom Chiovoloni d28f3cab37 Bug 1435655 - Ensure we properly initialize previousFailed and toFetch r=eoger 
MozReview-Commit-ID: KT9tJCSuUGh

--HG--
extra : rebase_source : 4b56237ff1f7c01c33f6b0bbe7baeefb0418efce
 2018-02-05 11:39:30 -05:00
Mark Banner 362505f227 Bug 1423896 - Make the All Bookmarks folder for the left pane of the Library a virtual query. r=mak 
MozReview-Commit-ID: HzJ9y1fiEz1

--HG--
extra : rebase_source : 27b0280e9dfef2626d187f9b8a81f23e4583302f
 2017-12-07 14:15:39 +00:00
Coroiu Cristina 1c85c04c62 Backed out 5 changesets (bug 1423896) for bustage at /src/toolkit/components/places/nsNavHistoryResult.cpp on a CLOSED TREE 
Backed out changeset 4012bc74e900 (bug 1423896)
Backed out changeset 12239646395f (bug 1423896)
Backed out changeset abf61cd5fb77 (bug 1423896)
Backed out changeset 569173c95238 (bug 1423896)
Backed out changeset 6401e950298d (bug 1423896)
 2018-02-07 14:07:31 +02:00
Mark Banner 7785b2e489 Bug 1423896 - Make the All Bookmarks folder for the left pane of the Library a virtual query. r=mak 
MozReview-Commit-ID: HzJ9y1fiEz1

--HG--
extra : rebase_source : 27b0280e9dfef2626d187f9b8a81f23e4583302f
 2017-12-07 14:15:39 +00:00
Andrew McCreight 5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian 
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
 2018-02-06 09:36:57 -08:00
Gurzau Raul bb16936244 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-02-02 00:25:44 +02:00
Gurzau Raul 1315ffda06 Merge inbound to mozilla-central. a=merge 2018-02-02 00:22:39 +02:00
Florian Quèze 2b1c8dccb6 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
David Keeler 087f092867 bug 1421084 - part 4/4 - remove nsNSSShutDown.h and (hopefully) all references to it r=mt,ttaubert 
MozReview-Commit-ID: 2mhvHsC5Nil

--HG--
extra : rebase_source : 651c2bcf8655f75756ea2bac788eb8c0781dc90a
 2018-01-24 14:44:01 -08:00
David Keeler ad5cec4768 bug 1421084 - part 3/4 - remove nsNSSShutDownObject::shutdown and virtualDestroyNSSReference r=mt,ttaubert 
MozReview-Commit-ID: ErL7ZjAGVVC

--HG--
extra : rebase_source : 2869aafaef729f0ad190f957919e8b9c40700477
 2018-01-24 14:29:08 -08:00
David Keeler a0e34baf27 bug 1421084 - part 2/4 - remove nsNSSShutDownObject::isAlreadyShutDown() r=mt,ttaubert 
MozReview-Commit-ID: DlS16pHE0Ik

--HG--
extra : rebase_source : d7596a3571478adefae4ffa5d446ff5234ba9ed7
 2018-01-23 12:22:56 -08:00
David Keeler e8cc0ba1ce bug 1421084 - part 1/4 - remove now-unnecessary nsNSSShutDownPreventionLock r=mt,ttaubert 
As of bug 1417680, the NSS shutdown tracking infrastructure is unnecessary (and
does nothing anyway). This series of changesets removes the remaining pieces in
a way that is hopefully easy to confirm is correct.

MozReview-Commit-ID: 8Y5wpsyNlGc

--HG--
extra : rebase_source : ef6b481510d949e404a4ef5615097d66e566c947
 2018-01-23 10:37:47 -08:00
Edouard Oger e3f37a97a4 Bug 633062 p8 - Add Async observers. r=kitcambridge,markh,tcsc 
MozReview-Commit-ID: IvwyleXBcNH

--HG--
extra : rebase_source : eb8f5db734cedb2810642723ed1652defeb16d88
 2018-01-04 18:07:10 -05:00
Edouard Oger 815460e8cf Bug 633062 p7 - Make most of the addon reconciler async. r=markh 
Except observers, which will be handled in the last commit of this series.

MozReview-Commit-ID: IvwyleXBcNH

--HG--
extra : rebase_source : 8054777b015c3b07c6599bdb00c9d32572313395
 2017-12-07 17:56:50 -05:00
Edouard Oger 71ff2629c2 Bug 633062 p6 - Remove event loop spinning from head_helper.js addon-related methods. r=markh 
MozReview-Commit-ID: 4Be253tJlXq

--HG--
extra : rebase_source : 461b2c5ad4076d39933b491a6d7a0065e2eb75b3
 2017-12-08 16:07:49 -05:00
Edouard Oger 4bc7feea45 Bug 633062 p5 - Remove event loop spinning from addonutils.js. r=markh 
MozReview-Commit-ID: 1PSX4tOieEH

--HG--
extra : rebase_source : c68d862761e9704e8cbb3235ce5491cb6d091c59
 2017-12-08 15:34:29 -05:00
Edouard Oger 825e2fa2b1 Bug 633062 p4 - Remove miscellaneous uses of event loop spinning in services/. r=markh 
MozReview-Commit-ID: IDGWJevEHLK

--HG--
extra : rebase_source : 0db05e713e55d680a85a1280d6540eec8c39f96c
 2017-12-08 14:41:02 -05:00
Edouard Oger 5568486701 Bug 633062 p3 - Remove event loop spinning from the EngineManager. r=markh 
MozReview-Commit-ID: 7tdKT8Wo3t4

--HG--
extra : rebase_source : 49b36a171f0bedf3ca04255af478bcec733d991b
 2017-12-08 13:10:25 -05:00
Edouard Oger 01342b993b Bug 633062 p2 - Make getTokenFromBrowserIDAssertion async. r=markh 
Also move promiseStopServer to the common/ head_helpers.js

MozReview-Commit-ID: B3Idnj6rPAZ

--HG--
extra : rebase_source : adb07d381aca118b9b49971f87e68a239dbcfb70
 2017-12-07 14:45:15 -05:00
Edouard Oger 81b643a035 Bug 633062 p1 - Introduce AsyncQueueCaller and AsyncObserver. r=markh 
MozReview-Commit-ID: GGuSkA5DZUQ

--HG--
extra : rebase_source : 54446d6d3758c17e2ce7423a4684f8cd35d052c5
 2018-01-04 18:06:57 -05:00
Noemi Erli 9df7ea51ac Backed out 8 changesets (bug 633062) as requested by eoger on a CLOSED TREE 
Backed out changeset 590656f7b5c5 (bug 633062)
Backed out changeset 0888aa122056 (bug 633062)
Backed out changeset 0780cf391c52 (bug 633062)
Backed out changeset 9798cbd03027 (bug 633062)
Backed out changeset 4b31c73a585f (bug 633062)
Backed out changeset 0a8866062136 (bug 633062)
Backed out changeset 20ff83289564 (bug 633062)
Backed out changeset 5e52125316e1 (bug 633062)
 2018-01-31 22:09:30 +02:00
Edouard Oger 6991ad1d07 Bug 633062 p8 - Add Async observers. r=kitcambridge,markh,tcsc 
MozReview-Commit-ID: IvwyleXBcNH

--HG--
extra : rebase_source : 30b4e09cb2a5f0da1845c842a464a277554f61a4
 2018-01-04 18:07:10 -05:00
Edouard Oger a636cbd98f Bug 633062 p7 - Make most of the addon reconciler async. r=markh 
Except observers, which will be handled in the last commit of this series.

MozReview-Commit-ID: IvwyleXBcNH

--HG--
extra : rebase_source : 8054777b015c3b07c6599bdb00c9d32572313395
 2017-12-07 17:56:50 -05:00
Edouard Oger 1cf9cd890d Bug 633062 p6 - Remove event loop spinning from head_helper.js addon-related methods. r=markh 
MozReview-Commit-ID: 4Be253tJlXq

--HG--
extra : rebase_source : 461b2c5ad4076d39933b491a6d7a0065e2eb75b3
 2017-12-08 16:07:49 -05:00
Edouard Oger 8a13eb4d47 Bug 633062 p5 - Remove event loop spinning from addonutils.js. r=markh 
MozReview-Commit-ID: 1PSX4tOieEH

--HG--
extra : rebase_source : c68d862761e9704e8cbb3235ce5491cb6d091c59
 2017-12-08 15:34:29 -05:00
Edouard Oger 7f72c53748 Bug 633062 p4 - Remove miscellaneous uses of event loop spinning in services/. r=markh 
MozReview-Commit-ID: IDGWJevEHLK

--HG--
extra : rebase_source : 0db05e713e55d680a85a1280d6540eec8c39f96c
 2017-12-08 14:41:02 -05:00
Edouard Oger 9a26bd581d Bug 633062 p3 - Remove event loop spinning from the EngineManager. r=markh 
MozReview-Commit-ID: 7tdKT8Wo3t4

--HG--
extra : rebase_source : 49b36a171f0bedf3ca04255af478bcec733d991b
 2017-12-08 13:10:25 -05:00
Edouard Oger ea2b2a9409 Bug 633062 p2 - Make getTokenFromBrowserIDAssertion async. r=markh 
Also move promiseStopServer to the common/ head_helpers.js

MozReview-Commit-ID: B3Idnj6rPAZ

--HG--
extra : rebase_source : adb07d381aca118b9b49971f87e68a239dbcfb70
 2017-12-07 14:45:15 -05:00
Edouard Oger b8b1fbbf52 Bug 633062 p1 - Introduce AsyncQueueCaller and AsyncObserver. r=markh 
MozReview-Commit-ID: GGuSkA5DZUQ

--HG--
extra : rebase_source : 54446d6d3758c17e2ce7423a4684f8cd35d052c5
 2018-01-04 18:06:57 -05:00
Mark Banner 204f9ceae9 Bug 1433983 - Remove deprecated PlacesUtils.setPostDataForBookmark/getPostDataForBookmark functions. r=mak 
MozReview-Commit-ID: 9WD2A4jA761

--HG--
extra : rebase_source : 63a66fe95f29102db6a8486525bd430985a8f8ed
 2018-01-29 18:31:42 +00:00
Andreea Pavel 2ebbd41c08 Backed out 8 changesets (bug 633062) for failing xpcshell on Windows at services/sync/tests/unit/test_hmac_error.js on a CLOSED TREE 
Backed out changeset b4e9cd0d61ab (bug 633062)
Backed out changeset ee294cebe485 (bug 633062)
Backed out changeset 3d1ad6b3bbee (bug 633062)
Backed out changeset c053f43da9e8 (bug 633062)
Backed out changeset 549e1282ae8e (bug 633062)
Backed out changeset 35058a83dab0 (bug 633062)
Backed out changeset 2e9dc98eabf0 (bug 633062)
Backed out changeset dbbacd08392c (bug 633062)
 2018-01-31 10:07:34 +02:00
Edouard Oger 4c8c0752bd Bug 633062 p8 - Add Async observers. r=kitcambridge,markh,tcsc 
MozReview-Commit-ID: IvwyleXBcNH

--HG--
extra : rebase_source : a517b2fbaede8e8b7566d127710f0dceb8e7d4f2
 2018-01-04 18:07:10 -05:00
Edouard Oger c44950332a Bug 633062 p7 - Make most of the addon reconciler async. r=markh 
Except observers, which will be handled in the last commit of this series.

MozReview-Commit-ID: IvwyleXBcNH

--HG--
extra : rebase_source : b5f9fe43ac2fd956253c571f4cc7b68eb1d928ec
 2017-12-07 17:56:50 -05:00
Edouard Oger 072adbdabf Bug 633062 p6 - Remove event loop spinning from head_helper.js addon-related methods. r=markh 
MozReview-Commit-ID: 4Be253tJlXq

--HG--
extra : rebase_source : f0f094132beb18960fc1115adfa82bfb15caae28
 2017-12-08 16:07:49 -05:00
Edouard Oger b6df353d2b Bug 633062 p5 - Remove event loop spinning from addonutils.js. r=markh 
MozReview-Commit-ID: 1PSX4tOieEH

--HG--
extra : rebase_source : e8804e1428c78d47fbc776e74da61d5de4e5f402
 2017-12-08 15:34:29 -05:00
Edouard Oger b8cb936b01 Bug 633062 p4 - Remove miscellaneous uses of event loop spinning in services/. r=markh 
MozReview-Commit-ID: IDGWJevEHLK

--HG--
extra : rebase_source : 8471048a68b9b6204402f3ea9039a21af8c3740c
 2017-12-08 14:41:02 -05:00
Edouard Oger b2c2739a4d Bug 633062 p3 - Remove event loop spinning from the EngineManager. r=markh 
MozReview-Commit-ID: 7tdKT8Wo3t4

--HG--
extra : rebase_source : a99f8f1f30010829bf2d4ebd7590953c46b244e2
 2017-12-08 13:10:25 -05:00
Edouard Oger ffdd8c898f Bug 633062 p2 - Make getTokenFromBrowserIDAssertion async. r=markh 
Also move promiseStopServer to the common/ head_helpers.js

MozReview-Commit-ID: B3Idnj6rPAZ

--HG--
extra : rebase_source : 0c3ee2b37448467fdd7fec04dbdf39255608901b
 2017-12-07 14:45:15 -05:00
Edouard Oger a99869ed33 Bug 633062 p1 - Introduce AsyncQueueCaller and AsyncObserver. r=markh 
MozReview-Commit-ID: GGuSkA5DZUQ

--HG--
extra : rebase_source : 496d90945ec2e6d41f5751d26cf87a14458961bb
 2018-01-04 18:06:57 -05:00
Dorel Luca 9f8b519dae Backed out 8 changesets (bug 633062) for xpcshell failures on browser/extensions/formautofill/test/unit/test_sync.js on a CLOSED TREE 
Backed out changeset d60ca66f2b62 (bug 633062)
Backed out changeset d80494d5bc36 (bug 633062)
Backed out changeset 33f832b59e86 (bug 633062)
Backed out changeset 968db19986aa (bug 633062)
Backed out changeset a55a3647ea49 (bug 633062)
Backed out changeset bb1030bdab48 (bug 633062)
Backed out changeset 9c4cd2a6965c (bug 633062)
Backed out changeset 669c76bd2618 (bug 633062)

--HG--
extra : amend_source : cf95d15507de46de393cdef797a5808c4e0407ff
 2018-01-31 07:28:06 +02:00
Edouard Oger 65e746d5d2 Bug 633062 p8 - Add Async observers. r=kitcambridge,markh,tcsc 
MozReview-Commit-ID: IvwyleXBcNH

--HG--
extra : rebase_source : 254006b5d64f425e4cabca6c02e8b20dce983d8e
 2018-01-04 18:07:10 -05:00
Edouard Oger bd9720e7f2 Bug 633062 p7 - Make most of the addon reconciler async. r=markh 
Except observers, which will be handled in the last commit of this series.

MozReview-Commit-ID: IvwyleXBcNH

--HG--
extra : rebase_source : b5f9fe43ac2fd956253c571f4cc7b68eb1d928ec
 2017-12-07 17:56:50 -05:00
Edouard Oger 3b8568a77b Bug 633062 p6 - Remove event loop spinning from head_helper.js addon-related methods. r=markh 
MozReview-Commit-ID: 4Be253tJlXq

--HG--
extra : rebase_source : f0f094132beb18960fc1115adfa82bfb15caae28
 2017-12-08 16:07:49 -05:00
Edouard Oger 5491e15085 Bug 633062 p5 - Remove event loop spinning from addonutils.js. r=markh 
MozReview-Commit-ID: 1PSX4tOieEH

--HG--
extra : rebase_source : e8804e1428c78d47fbc776e74da61d5de4e5f402
 2017-12-08 15:34:29 -05:00
Edouard Oger 3e4633d6e3 Bug 633062 p4 - Remove miscellaneous uses of event loop spinning in services/. r=markh 
MozReview-Commit-ID: IDGWJevEHLK

--HG--
extra : rebase_source : 8471048a68b9b6204402f3ea9039a21af8c3740c
 2017-12-08 14:41:02 -05:00
Edouard Oger d3a0ee9183 Bug 633062 p3 - Remove event loop spinning from the EngineManager. r=markh 
MozReview-Commit-ID: 7tdKT8Wo3t4

--HG--
extra : rebase_source : a99f8f1f30010829bf2d4ebd7590953c46b244e2
 2017-12-08 13:10:25 -05:00
Edouard Oger 546a23d489 Bug 633062 p2 - Make getTokenFromBrowserIDAssertion async. r=markh 
Also move promiseStopServer to the common/ head_helpers.js

MozReview-Commit-ID: B3Idnj6rPAZ

--HG--
extra : rebase_source : 0c3ee2b37448467fdd7fec04dbdf39255608901b
 2017-12-07 14:45:15 -05:00
Edouard Oger 139cd14eb0 Bug 633062 p1 - Introduce AsyncQueueCaller and AsyncObserver. r=markh 
MozReview-Commit-ID: GGuSkA5DZUQ

--HG--
extra : rebase_source : 496d90945ec2e6d41f5751d26cf87a14458961bb
 2018-01-04 18:06:57 -05:00
Andrew Swan 1acce175af Bug 1356331 Remove hotfix code from addons manager and related tests r=rhelmer 
MozReview-Commit-ID: EjCOOgmXvVH

--HG--
extra : rebase_source : 051c618bd73e7bac41d5dc9339972742b029a879
extra : source : 9af7407fa9309e1fa2dc590309ed2329f02dc61e
 2017-12-13 12:33:52 -08:00
Kris Maglione 918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian 
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
 2018-01-29 15:20:18 -08:00
Cosmin Sabou 9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE 
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
 2018-01-30 07:17:48 +02:00
Kris Maglione 6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian 
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
 2018-01-29 15:20:18 -08:00
Brindusan Cristian af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE 
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
 2018-01-30 02:32:43 +02:00
Kris Maglione c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian 
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
 2018-01-29 15:20:18 -08:00
vinicius 970b471265 Bug 1433234 - Replace do_check_array_eq by Assert.deepEqual. r=eoger 
MozReview-Commit-ID: 7goh46IkVrW
***

--HG--
extra : rebase_source : 2ffdacce0843341c23d43354c135c21ca3d3ec14
 2018-01-27 19:29:55 -02:00
Kit Cambridge 2449a744b8 Bug 1305563 - Add a `BufferedBookmarksEngine` that can be toggled with a pref. r=markh,tcsc 
This patch adds a new bookmarks engine, pref'd off, that writes to the
buffer instead of Places.

MozReview-Commit-ID: 7idBa03kOzm

--HG--
extra : rebase_source : 671ebeb3de824dc43c0ef14b2dfe065a33e2911a
 2017-12-19 17:10:54 -08:00
Kit Cambridge 8d7187be91 Bug 1305563 - Add a bookmark mirror and two-way merger for synced bookmarks. r=mak,markh,rnewman,tcsc 
The mirror matches the complete bookmark tree stored on the Sync
server, stores new bookmarks changed on the server since the last
sync, merges the local and remote trees, applies the resulting merged
tree back to Places, fires observer notifications for all items changed
in the merge, and stages locally changed bookmarks for upload.

MozReview-Commit-ID: MbeFQUargt

--HG--
extra : rebase_source : b635fd65ef10ab9ce3a2f9af2e527d342a790f6e
 2018-01-06 07:44:33 -08:00
Thom Chiovoloni 6321345295 Bug 1429250 - Avoid repeated traversals of toFetch in _processIncoming. r=eoger,kitcambridge 
MozReview-Commit-ID: N1Zr8iT7da

--HG--
extra : rebase_source : ddaa51704c93985219d15b31aec7ff7e19b2832f
 2018-01-09 19:22:33 -05:00
Marco Bonardo 592194dc76 Bug 1432437 - Remove synchronous changeBookmarkURI. r=standard8 
MozReview-Commit-ID: Jy76eKCN7wp

--HG--
extra : rebase_source : 84958fcaaacdcdd9a400a546b14eb49fc897752c
 2018-01-24 12:13:02 +01:00
Dorel Luca 7831647b90 Backed out changeset 8ebfca2b0c21 (bug 1432437) for Xpcshell test failure on toolkit/components/places/tests/unit/test_sync_utils.js 2018-01-26 01:43:17 +02:00
Marco Bonardo 86b21609be Bug 1432437 - Remove synchronous changeBookmarkURI. r=standard8 
MozReview-Commit-ID: Jy76eKCN7wp

--HG--
extra : rebase_source : 2d453281eb9c77c3f23f15a5a390a17e7b880c34
 2018-01-24 12:13:02 +01:00
Edouard Oger f15c1f618e Bug 1433042 - Fix initial FxA login flow. r=tcsc 
MozReview-Commit-ID: kaD6Bx7oRk

--HG--
extra : rebase_source : 5eaeda96125215917f5e00d5f6863a0f86020b4e
 2018-01-25 11:34:32 -05:00
Thom Chiovoloni fca1cd0193 Bug 1433003 - Optimize sync by using digestBytes instead of digestUTF8. r=markh 
MozReview-Commit-ID: IbyeOUjKdi9

--HG--
extra : rebase_source : 3eb55106004ef68f749a9188f232dbb60f9d1e3d
 2018-01-24 20:09:16 -05:00
hemant df042c21a8 Bug 1370881 - Replace calls to asyncHistory.isURIVisited and promiseIsURIVisited with PlacesUtils.history.hasVisits r=standard8 
MozReview-Commit-ID: BHWkJpdYA0g

--HG--
extra : rebase_source : 927cd89c69ed2cdbf6ebf8e954c38238ebbdd273
 2018-01-24 20:58:57 +05:30
Thom Chiovoloni 95b5e3bd0e Bug 1405205 - Report bookmark engine as bookmarks-buffered in the sync ping r=kitcambridge 
MozReview-Commit-ID: 490KcmRZkfY

--HG--
extra : rebase_source : d3fe0f03c8ed3607c3c0b0ce2a063645dc0d9a70
 2017-10-11 17:13:04 -04:00
Mark Hammond 4772b1fe2e Bug 1432277 - Replace iOS and Android link in Prefs for signed-in users with device actions. r=eoger 
MozReview-Commit-ID: 1Lwe2g1bFpw

--HG--
extra : rebase_source : 6529420b5a2e1b4438f2472313abbc7e7dcf7dc1
 2018-01-23 17:47:19 +11:00
Edouard Oger d149a0176b Bug 1426306 - Store only derived keys instead of storing kB/kA. r=glasserc,markh,rfkelly 
MozReview-Commit-ID: Hgv5hxSH4qX

--HG--
extra : rebase_source : fa6d45480a2078e841c72b2c8c92541811633737
 2018-01-05 15:56:00 -05:00
Mark Banner a773c73dbb Bug 1131491 - Remove old synchronous Place's transactions. r=mak 
MozReview-Commit-ID: FNCijeajgeh

--HG--
extra : rebase_source : 4207cdd7b789fbbcce3b2117324ea22e1a313fe6
 2018-01-22 15:41:12 +00:00
Simon Fraser 638b7b677e Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2018-01-22 11:19:18 +00:00
Edouard Oger 214ca05b67 Bug 1430970 - Fix FxAccounts internal mocking. r=tcsc 
MozReview-Commit-ID: 7ATwZTJ4w5K

--HG--
extra : rebase_source : 6a910fc8b523bfeaaaeef0d53dfaa57f98ff4f52
 2018-01-16 22:24:17 -05:00
Edouard Oger 3a4adb8483 Bug 1429154 - Remove FXA_VERIFICATION_METHOD probe. r=tcsc 
MozReview-Commit-ID: JK8MVkmPRGK

--HG--
extra : rebase_source : 7ec41a8b77c15bf3c40a931e4e6f5e690ff1b911
 2018-01-15 11:21:43 -05:00
Edouard Oger b5962f73eb Bug 1429245 - Optimize CommonUtils.bytesAsHex. r=tcsc 
MozReview-Commit-ID: 2f3o6OwUwn4

--HG--
extra : rebase_source : c18f606ab7963eeee6889c351cf58e61d58fb930
 2018-01-10 16:11:22 -05:00
Thom Chiovoloni 6e3bb55bb8 Bug 1412083 - Avoid syncing preferences that refer to moz-extension or blob urls. r=eoger 
MozReview-Commit-ID: 9Ipq5z1dykr

--HG--
extra : rebase_source : a8616485879268ce31ef74f4b3fdbc3f4dc5a585
 2018-01-09 17:46:24 -05:00
Doug Thayer 1e3446b9cc Bug 1421703 - Fix tests to use onVisits r=mak 
Fairly straightforward. Fixes the tests that were broken due to
the changes introduced in part 1.

MozReview-Commit-ID: GbZ9ZpmG9nE

--HG--
extra : rebase_source : ebb2088288718631a941139d5a4d945259aaa0c6
 2017-12-14 16:55:31 -06:00
Doug Thayer b3eef35a05 Bug 1421703 - replace onVisit with onVisits r=mak 
There's a heavy enough overhead to going through XPConnect for
every observer for every visit on the nsINavHistoryObserver
interface, so this patch reduces that by replacing the single-
visit notification with one which accepts an array of visits.

Some notes: To avoid problems with the orderings of the various
ways in which we notify about visits, we have to send our bulk
onVisits notification before doing any of the others. This does
mean it technically behaves slightly different than the prior
approach of interleaving the notifications, but I can't find any
way in which this has any consequences to the end result, and it
doesn't break any tests.

MozReview-Commit-ID: GdeooH8mCkg

--HG--
extra : rebase_source : 48b5f886c4650a756e70f4657cb9d62c8ce40f74
 2017-12-20 14:27:24 -08:00
Thom Chiovoloni 4f926a87dd Bug 1427835 - Remove redundant TPS addon test and disable validation on the non-restartless XPI test r=markh 
MozReview-Commit-ID: JxNw7qIOheo

--HG--
extra : rebase_source : 33bf748394a248178c85292464c8acccf9e106b8
 2018-01-03 15:01:49 -05:00
Thom Chiovoloni 9c8f02ad08 Bug 1427850 - Check that sync is ready directly instead of reading the sync username to determine it r=markh 
MozReview-Commit-ID: LnQ6Em0GCvM

--HG--
extra : rebase_source : 7455d0eb9b9123d092f6cbacc09cbbf2f686dca3
 2018-01-03 15:22:43 -05:00
Mark Hammond c952b939b9 Bug 1390478 - never block the UI waiting for the FxA profile. r=eoger 
MozReview-Commit-ID: 4MNqo9AUuOz

--HG--
extra : rebase_source : b53f108d880f33246b351c5320e47c235ee9c7fb
 2017-12-08 11:27:40 +11:00
Jeremy Lempereur 010e4ca3fb Bug 692386 - sync: Add missing requested URL on NS_ERROR_NET_RESET. r=markh 
The requested URL was logged on almost each failing request exception.
Added a warn message to log the request method and url when any request fails.

MozReview-Commit-ID: GKwd7HabTp6

--HG--
extra : rebase_source : 012bb9c322ecda93be32f43582492b37e407396d
 2018-01-03 12:59:03 +01:00
Thom Chiovoloni 25d3c801bc Bug 1425960 - Optimize sync preference usage r=markh 
MozReview-Commit-ID: AMwkvF7Dy3G

--HG--
extra : rebase_source : f44ea9674ad0fd45191220ec6845aa85f68efa10
 2017-12-20 12:36:18 -05:00
Thom Chiovoloni 364c629823 Bug 1426742 - Fix TPS test_history and cleanup failures. r=kitcambridge 
MozReview-Commit-ID: 8jR4vtwUpOm

--HG--
extra : rebase_source : 72f655998e1e3380d8d4f569356d247906a032b0
 2017-12-21 15:15:24 -05:00
Thom Chiovoloni 3e7a2e240e Bug 1425544 - Ensure trace level logging is used throughout sync tests. r=markh 
MozReview-Commit-ID: Icl1qk07LKm

--HG--
extra : rebase_source : c0e35f3e435e720f0375b3826ee4ba745d1e134b
 2017-12-20 18:29:21 -05:00
Florian Quèze 0f55cd45be Bug 1421992 - script-generated patch to replace do_execute_soon, do_print and do_register_cleanup with executeSoon, info and registerCleanupFunction, rs=Gijs. 2017-12-21 11:10:23 +01:00
Florian Quèze e0f995ea08 Bug 1421992 - hand written cleanup patch to make xpcshell tests pass after replacing do_check_* with Assert.*, r=Gijs. 2017-12-21 11:08:19 +01:00
Florian Quèze 032c961e0a Bug 1421992 - script-generated patch to replace do_check_* functions with their Assert.* equivalents, rs=Gijs. 2017-12-21 11:08:17 +01:00
Mark Hammond 57f9284cef Bug 1425987 - part 2: Cleanup Sync logging by rationalizing preference management. r=tcsc 
MozReview-Commit-ID: CQ1vhahnQbc

--HG--
extra : rebase_source : 5456b3afcf2d2d3536b9b546dda67199af4e1bdd
 2017-12-19 09:48:31 +11:00
Thom Chiovoloni 4e773dd17f Bug 1423399 - Avoid duplicating synced history visits older than your most recent 20 r=kitcambridge 
MozReview-Commit-ID: 2CAutmuJWhb

--HG--
extra : rebase_source : b145ebe8525fa6cb045f99adabfc5ce3d0984f3a
 2017-12-18 19:40:38 -05:00
Edouard Oger 9aa875bf0b Bug 664590 - Do not track file:/// visits. r=markh 
MozReview-Commit-ID: 6oVDkJU7kai

--HG--
extra : rebase_source : 0d184abb2ba1babc6c6c3ef6ebbb3024a26f81a8
 2017-12-06 16:55:45 -05:00
Thom Chiovoloni 208554ebe1 Bug 1423395 - Clamp and truncate microseconds from incoming history visit dates when deduping r=markh 
MozReview-Commit-ID: H1lljWcSZLZ

--HG--
extra : rebase_source : c64f20dd38bf4b17f05885df1f6b3ba112efdcb6
 2017-12-05 19:40:37 -05:00
Dorel Luca 19230bafde Backed out changeset 0e26ab46cbb7 (bug 1390478) for Xpcshell failure in services/fxaccounts/tests/xpcshell/test_profile.js on a CLOSED TREE 
--HG--
extra : amend_source : 37b6f14e6d869559d8794019ba132a061ec01378
 2017-12-19 15:29:38 +02:00
Mark Hammond 8d3579fb17 Bug 1390478 - never block the UI waiting for the FxA profile. r=eoger 
MozReview-Commit-ID: 4MNqo9AUuOz

--HG--
extra : rebase_source : 283b16e29b7a2a20e9cca87437a08f241bffa832
 2017-12-08 11:27:40 +11:00
Mark Hammond 81ef0051dc Bug 1415560 - ignore insertMany result and add an onError handler to log errors. r=tcsc 
MozReview-Commit-ID: 8aJkRL8WCPr

--HG--
extra : rebase_source : dceb94744eef3ac50253594a70cec9f32f4cf8d3
 2017-12-04 12:49:06 +11:00
Mark Hammond 6b3554dc84 Bug 1423067 - SyncedTabs.jsm now exports the loginFailed getter fixing an issue with the sidebar. r=eoger 
MozReview-Commit-ID: AVjfXH1E9uw

--HG--
extra : rebase_source : 8ee64138f5604b12af1f4ffa0cabb73ab6ad5465
 2017-12-05 14:46:53 +11:00
Mark Hammond b5876a8b65 Bug 1407116 - Sync now enters the "please reconnect" state if Sync is configured but FxA is not. r=eoger 
MozReview-Commit-ID: LuAdYkpe0b7

--HG--
extra : rebase_source : 0fb3ca9ef0912e61354df5ca111a169df3777526
 2017-12-04 15:48:45 +11:00
Mark Hammond 734061ef82 Bug 1380215 - FxA now ensures Sync is loaded before sending observer notifications. r=eoger 
MozReview-Commit-ID: KUKb421guxt

--HG--
extra : rebase_source : 092ad19374c2db477621c0429f45c9b669d85357
 2017-12-05 13:01:05 +11:00
Mark Banner 499ca20f31 Bug 1421968 - Enable ESLint rule mozilla/use-services by default, but whitelist it for various directories still to be fixed. r=mossop 
MozReview-Commit-ID: KOZWr7FiDQZ

--HG--
extra : rebase_source : 92c9bc236c9043f6ce25cc2ba45264918eb2ac15
 2017-11-28 19:24:12 +00:00
Edouard Oger 54088f8c9e Bug 1422115 - Remove storageserver.js from services/. r=markh,tcsc 
MozReview-Commit-ID: 4UGCq6SolY1

--HG--
extra : rebase_source : 49e8a5d072d1cb15d0942e7fbc39c7a2c8c08c6f
 2017-11-30 15:11:19 -05:00
Edouard Oger ae62aef149 Bug 1418466 - Add Connect Another Device button to relevant Sync UI. r=dao,markh 
MozReview-Commit-ID: 5vBKH9NejVV

--HG--
extra : rebase_source : c160a5a1d7753d41c7afec3a822aefa9461684e6
 2017-11-17 16:48:17 -05:00
Noemi Erli e5e82c8496 Backed out changeset 932a77d8fbae (bug 1418466) for ES failures in /builds/worker/checkouts/gecko/browser/base/content/browser-sync.js r=backout on a CLOSED TREE 2017-11-30 18:44:16 +02:00
Edouard Oger 016b5734e5 Bug 1418466 - Add Connect Another Device button to relevant Sync UI. r=dao,markh 
MozReview-Commit-ID: 5vBKH9NejVV

--HG--
extra : rebase_source : e8628aba338b19142dc63add9bb380042096053f
 2017-11-17 16:48:17 -05:00
Margareta Eliza Balazs cb71a3c4fe Merge mozilla-central to mozilla-autoland. r=merge a=merge CLOSED TREE 2017-11-30 12:55:54 +02:00
Edouard Oger 403ad27bae Bug 1420802 - Remove NetworkLinkService from offline check. r=tcsc 
Summary: Remove NetworkLinkService from offline check.

Reviewers: tcsc

Reviewed By: tcsc

Bug #: 1420802

Differential Revision: https://phabricator.services.mozilla.com/D300
 2017-11-29 15:15:28 -05:00
Mark Hammond 0dd353e7d5 Bug 1421850 - ensure Sync is fully initialized before syncing. r=tcsc 
MozReview-Commit-ID: 7hS3fttgqqr

--HG--
extra : rebase_source : b9a342c1a977699c3c4c42e9bca86ee087a51260
 2017-11-30 14:03:57 +11:00
Thom Chiovoloni 788c2ca211 Bug 1421817 - Send a sync ping on shutdown if we have events but no syncs. r=markh 
MozReview-Commit-ID: ExxN6UXs2Ip

--HG--
extra : rebase_source : 356d2f7bbfc856859e7b6246939b785f0984fa82
 2017-11-29 17:41:59 -05:00
Thom Chiovoloni 302308a0a1 Bug 1336257 - Use HTTPS for mozqa url in TPS. r=markh 
MozReview-Commit-ID: Admw1iKeW24

--HG--
extra : rebase_source : 836f3efb3aea6eb2a089c5aecd0f7a10a0bd6787
 2017-11-29 18:35:28 -05:00
Mark Hammond 4b66d38dd6 Bug 1420810 - record why we are syncing for most syncs initiated by the scheduler. r=eoger 
MozReview-Commit-ID: 1ntqG5yQi7q

--HG--
extra : rebase_source : 73b479ac7e602f5f491f63939a4425af17d6ce25
 2017-11-27 17:32:05 +11:00
Mark Hammond 39bf8149a6 Bug 1416788 - limit number of visits we pass to PlacesUtils.history.insertMany to prevent shutdown hangs. r=kitcambridge 
MozReview-Commit-ID: AU9AMUAD1Rw

--HG--
extra : rebase_source : 205ec0f17f94bd399f4663e552bd75e7b63f7da5
 2017-11-23 16:18:55 +11:00
Thom Chiovoloni dc2fe37c66 Bug 1421452 - Fix deprecation warning in test_bookmark_engine by passing an osfile path instead of nsifile. r=markh 
MozReview-Commit-ID: 4XrzA0kUXzE

--HG--
extra : rebase_source : bed7a594b854969dd1932449f43ade4dc068ffeb
 2017-11-28 17:35:51 -05:00
Thom Chiovoloni a004052a6e Bug 1421044 - Make TPS await sync initialization before trying to run r=markh 
MozReview-Commit-ID: JSBXKHRXjc0

--HG--
extra : rebase_source : f18047d5a71d92acb9712244266909fc9e09dd0f
 2017-11-28 13:56:48 -05:00
Thom Chiovoloni 6e7fbdc912 Bug 1420349 - Instantiate the sync scheduler in the service's constructor, instead of in onStartup. r=eoger 
MozReview-Commit-ID: 3bOnRH5jR9e

--HG--
extra : rebase_source : 63eb169666e6b5694e7324f5eb01349189a895ec
 2017-11-28 11:48:10 -05:00
Ryan Leake 7822b14bda Bug 1346072 - Remove accounts.firefox.com from the whitelist of domains allowed to send objects over webchannels. r=markh 
MozReview-Commit-ID: 4ts3uBPuXom

--HG--
extra : rebase_source : 0dced36f4c14f8fb4f7633f3b265ac22d95ecfd7
 2017-11-24 20:24:42 +00:00
Mark Banner efaca11893 Bug 1420422 - Enable ESLint rule mozilla/use-services for services/. r=markh 
MozReview-Commit-ID: LQiMr3ppDuG

--HG--
extra : rebase_source : f509b5360e92db58f14b0f6a41c06e10fe7dd170
 2017-11-24 14:46:33 +00:00
Edouard Oger 9f071e2083 Bug 1409534 - Replace Resource impl by fetch. r=kitcambridge,markh,tcsc 
MozReview-Commit-ID: 5mmVeHeMQKf

--HG--
extra : rebase_source : 84c20e3b90b5bed43e511158270761e2e1da6b15
 2017-11-06 16:24:40 -05:00
Edouard Oger 438ca97ce7 Bug 1419990 - Only sync the tabs collection on sleep if there are changes. r=markh 
MozReview-Commit-ID: GC0KMmQPqqD

--HG--
extra : rebase_source : 2039c7f644b3510dda07839c1e561786ad8c0ba1
 2017-11-23 11:24:41 -05:00
Edouard Oger 0154c0f443 Bug 1416320 - Do a quick sync before going to sleep. r=markh 
MozReview-Commit-ID: I36uvEFlEz5

--HG--
extra : rebase_source : 93812879d3ea19042356e51672f7f464e30e9ee5
 2017-11-10 14:09:44 -05:00
Cosmin Sabou 959009f1a8 Backed out changeset 23fbfd83e957 (bug 1416320) for ESlint failure at gecko/services/sync/modules/policies.js:558:71 on a CLOSED TREE 2017-11-21 07:26:51 +02:00
Edouard Oger ab35b46c98 Bug 1416320 - Do a quick sync before going to sleep. r=markh 
MozReview-Commit-ID: I36uvEFlEz5

--HG--
extra : rebase_source : 1910ac25084f6a8c37a6d21accf17da974d56493
 2017-11-10 14:09:44 -05:00
Dan Banner b2e847755c Bug 1367704 - Enable the semi ESLint rule across the tree. r=standard8 
MozReview-Commit-ID: GrlcOI9K2hJ

--HG--
extra : rebase_source : 6574cf3c67eb11733ffd9999c260f71c8551abc4
 2017-05-28 19:57:46 +01:00
Edouard Oger afa6330a25 Bug 1416322 - Wait until the network is back up to sync after waking-up from sleep. r=markh 
MozReview-Commit-ID: 2vzmj3UkvtD

--HG--
extra : rebase_source : a152684365627cf1ea68efe10f5e27ad15577135
 2017-11-16 13:12:31 -05:00
Edouard Oger 0648f86b7f Bug 1304898 - Include why in sync ping. r=tcsc 
MozReview-Commit-ID: G9WnHhuWD7Z

--HG--
extra : rebase_source : 27cb3c2bdf7432e0db1e6a8431d348be50c2afd8
 2017-11-15 17:10:45 -05:00
Edouard Oger fbd7ca1890 Bug 1416807 - Don't schedule syncs while we're behind to a captive portal. r=markh 
MozReview-Commit-ID: 2CrO3CfKgC3

--HG--
extra : rebase_source : 460fb20172e325a154a4848e6a5ed0bacefd4b77
 2017-11-15 16:01:48 -05:00
Kit Cambridge d6c28d0200 Bug 1417590 - Check for client duplicates in the Sync collection validator. r=tcsc 
MozReview-Commit-ID: LcPnTEDhbis

--HG--
extra : rebase_source : 5070eebbb1495ac14cc140862dd78d46e638615f
 2017-11-10 22:27:30 -08:00
Doug Thayer 43771ba19d Bug 1414892 - Optimize moz_places_afterinsert_trigger r=mak 
This uses a similar strategy as that employed by moz_places_afterdelete_trigger,
creating a temp table which we write host inserts into, and then deleting all
the rows from it when we're done inserting, effectively resulting in a per-
statement trigger to only do the significant work per host.

MozReview-Commit-ID: 5TUueknq3ng

--HG--
extra : rebase_source : 1892edfcaa7b6afd29ce794a93d6ab3d46c48895
 2017-11-07 12:01:53 -08:00
Thom Chiovoloni 9e62cc5726 Bug 1416313 - Drop old or low priority commands rather than failing to sync the clients engine if too many commands are sent. r=eoger,markh 
MozReview-Commit-ID: 6BJGmUL28hp

--HG--
extra : rebase_source : 894cafb34f193b802c90052142174ea3187b8396
 2017-11-10 15:57:33 -05:00
Thom Chiovoloni 892f157456 Bug 1416902 - Fix missing await in test_service_sync_updateEnabledEngines and test_interval_triggers r=kitcambridge 
MozReview-Commit-ID: 6rFOWPsxxxj

--HG--
extra : rebase_source : 62e37062876d4dd38cc43f532df622c09b94cf1b
 2017-11-13 16:53:15 -05:00
Edouard Oger 8a3dc70885 Bug 1416321 - Do a sync after we successfully connect to a captive portal. r=markh 
MozReview-Commit-ID: HuXyJ8IrNwA

--HG--
extra : rebase_source : b1171a1235011d5393dcd90a950b55320302c254
 2017-11-10 14:55:19 -05:00
Thom Chiovoloni 93a711ae04 Bug 1416374 - Handle getting an abortincoming error in sync telemetry r=markh 
MozReview-Commit-ID: LFmbkGa4ypu

--HG--
extra : rebase_source : 93e7e9fcfbdf141c86cede055b58d82985fea370
 2017-11-10 18:02:58 -05:00
Ryan VanderMeulen 177a5a8bdc Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 
--HG--
extra : histedit_source : 46923056fd09298724464a4df4466357821a361f
 2017-11-12 21:22:25 -05:00
Kit Cambridge 31aa407113 Bug 1383623 - Remove synchronous Places API usage from the Sync unit tests. r=tcsc 
MozReview-Commit-ID: Cip7LSSi2fE

--HG--
extra : rebase_source : deaff010d15d7ae9812d1d38f3b39c1100c62cf3
 2017-11-09 15:46:27 -08:00
Ryan VanderMeulen b16410f51c Merge inbound to m-c. a=merge 2017-11-10 16:13:15 -05:00
Geoff Brown cbb956e0c3 Bug 1407679 - Merge nsIIOService and nsIIOService2; r=nwgh 2017-11-10 07:03:36 -07:00
Sebastian Hengst 96b3be2c0d Bug 1415957 - Remove MozMill from TPS: Fix merge conflict. r=conflict-fix a=conflict-fix on a CLOSED TREE 
--HG--
extra : amend_source : fd6fe1681aa192ed44675bd52cd46e954ffad9b8
 2017-11-10 13:45:48 +02:00
Margareta Eliza Balazs 7e070192d7 Merge inbound to mozilla-central r=merge a=merge 2017-11-10 11:55:43 +02:00
Nicholas Nethercote f4dd5e2636 Bug 1414096 (attempt 2) - Remove support for nsISupportsString values in nsPrefBranch::{get,set}ComplexValue(). r=florian. 
Bug 1345294 introduced nsPrefBranch::{get,set}StringPref(), which allowed the
getting of utf8 strings from prefs, which previously required using
nsISupportsString with {get,set}ComplexValue. That bug also converted most
uses.

This patch finishes the job.

- It removes the nsISupportsString support.

- It converts existing code that relied on the nsISupportsString.

- It removes the lint that was set up to detect such uses of nsISupportsString.

--HG--
extra : rebase_source : b885ee784704819e181430200af5ef762e269d14
 2017-11-10 09:07:48 +11:00
Andrea Marchesini 207b8d909e Bug 1347515 - Get rid of nsIJSON.decodeFromStream, r=qdot 2017-11-10 00:27:22 +01:00
Edouard Oger 1873a289f7 Bug 1415957 - Remove MozMill from TPS. r=tcsc 
MozReview-Commit-ID: HyBXrNqhzIf

--HG--
extra : rebase_source : da197fa045f70621d5549e961876cfc6ce15264b
 2017-11-09 15:34:06 -05:00
Mark Banner 315a813f56 Bug 1415343 - Remove useless check for target window from FxAccountsWebChannel.jsm. r=markh 
MozReview-Commit-ID: 4rFCNbMSF0a

--HG--
extra : rebase_source : 5d9ff600453d47afb4791a43bc6b043677c70cdb
 2017-11-09 08:10:37 +00:00
Mark Banner c9b01d9a02 Bug 1415345 - Fix undefined variable in error message in FxAccountsStorageManager#getAccountData. r=markh 
MozReview-Commit-ID: 4mCdPfKX5lz

--HG--
extra : rebase_source : 898771109c879f950d607273bc469734a9a0f99d
 2017-11-07 23:00:26 +00:00
tfe be730a069d Bug 1414438 - Use `getBatched` instead of `get` to backfill records r=kitcambridge 
MozReview-Commit-ID: LLTg0ae5BbW
***
Bug 1414438 - Use `getBatched` instead of `get` in sync

--HG--
extra : rebase_source : b9b057160470ec5bc5544a1a4d5d429bee460452
 2017-11-08 09:05:11 +01:00
Sebastian Hengst 21b6b18b0b merge mozilla-central to autoland. r=merge a=merge on a CLOSED TREE 2017-11-10 13:47:59 +02:00
Kit Cambridge d93840902b Bug 1382937 - Rewrite Sync's master password functions to use the `nsILoginManagerCrypto` wrappers. r=MattN 
Using `nsISecretDecoderRing` directly bypasses
`nsILoginManagerCrypto.uiBusy` and the observer notifications, so other
consumers might not be aware we're already showing the dialog. We also
bail early if the UI is busy, to avoid showing multiple dialogs.

MozReview-Commit-ID: I7xzUWZkyPH

--HG--
extra : rebase_source : 91cef140cc54d1c81fe5c1986ffd2b8983ddd575
 2017-10-23 10:40:56 -07:00
Thom Chiovoloni edeaf1bc14 Bug 1415012 - Don't trigger a resync if the previous sync wasn't completely successful r=kitcambridge 
MozReview-Commit-ID: DcNsFUxXR1O

--HG--
extra : rebase_source : 2632aa8d6db8e9e101e949c237b559015444f808
 2017-11-06 20:56:57 -05:00
Sebastian Hengst af670f4147 merge mozilla-central to mozilla-inbound. r=merge a=merge 2017-11-07 02:47:30 +02:00
Manish Kumar 53383c5b3f Bug 1408108 - Rename "Sync ID" to "record ID" in the bookmarks engine and `PlacesSyncUtils`. r=kitcambridge 
--HG--
extra : rebase_source : da3acfc4f7393a615c44f238c624bb826ff5b766
 2017-11-06 12:17:07 -08:00
Thom Chiovoloni 935734388d Bug 1412351 - Make sync behave better during shutdown r=kitcambridge 
MozReview-Commit-ID: 4zWNph8Zdld

--HG--
extra : rebase_source : 12e9f82222a4bcfe2161ad02669619b57f0442fe
 2017-10-27 13:37:49 -04:00
Sebastian Hengst d61954557d merge mozilla-inbound to mozilla-central. r=merge a=merge 
MozReview-Commit-ID: Ai6Y5GGfkfT
 2017-11-04 10:58:24 +01:00
Nicholas Nethercote b9c6a1d730 Bug 1413413 (part 2) - Remove support for extensions having their own prefs file. r=glandium,kmag. 
It's no longer needed, now that legacy extensions aren't supported.

Pieces removed include the following.

- The "load-extension-default" observer notification.

- The code for reading defaults/preferences/*.js from extensions.

- The unit test for this stuff.

- A crash reporter annotation relating to very long prefs set by add-ons.

- All references to "ExtPrefDL".

MozReview-Commit-ID: KMBoYn3uZ3x

--HG--
extra : rebase_source : 4dc8ffd425c6cdf06806409090c4f9d04a64930b
 2017-10-31 16:34:57 +11:00
Luciano I e4007fdbe7 Bug 1375223 - Remove Async.querySpinningly. r=kitcambridge 
MozReview-Commit-ID: bMo1jyIY5g

--HG--
extra : rebase_source : ac69fde2cb8216300bdb9e7d19528c15cdceb7c8
 2017-10-31 18:50:31 -04:00
Kit Cambridge 604673b3d3 Bug 1366067 - Use `JSONFile.jsm` to persist the backlog and previously failed IDs. r=tcsc 
MozReview-Commit-ID: DAwMrtWI8eh

--HG--
extra : rebase_source : f6713745b09de2e6b0993539cce9ed4e8226dbbf
 2017-11-01 11:10:47 -07:00
Thom Chiovoloni 4a77d5a93f Bug 1388224 - Remove SyncStorageRequest HTTP wrapper class, which is no longer used r=kitcambridge 
MozReview-Commit-ID: EgExfizNll5

--HG--
extra : rebase_source : 85a6098a5b985990bd3a8483936bf6cf768f1f0b
 2017-11-01 17:17:46 -04:00
Kit Cambridge 064ed56076 Bug 1368209 - Refactor `Engine::_processIncoming` into three stages. r=eoger,tcsc 
* In the first stage, we fetch changed records, newest first, up to the
  download limit. We keep track of the oldest record modified time we
  see.
* Once we've fetched all records, we reconcile, noting records that
  fail to decrypt or reconcile for the next sync. We then ask the store
  to apply all remaining records. Previously, `applyIncomingBatchSize`
  specified how many records to apply at a time. I removed this because
  it added an extra layer of indirection that's no longer necessary,
  now that download batching buffers all records in memory, and all
  stores are async.
* In the second stage, we fetch IDs for all remaining records changed
  between the last sync and the oldest modified time we saw in the
  first stage. We *don't* set the download limit here, to ensure we
  add *all* changed records to our backlog, and we use the `"oldest"`
  sort order instead of `"index"`.
* In the third stage, we backfill as before. We don't want large deltas
  to delay other engines from syncing, so we still only take IDs up to
  the download limit from the backlog, and include failed IDs from the
  previous sync. On subsequent syncs, we'll keep fetching from the
  backlog until it's empty.

Other changes to note in this patch:

* `Collection::_rebuildURL` now allows callers to specify both `older`
  and `newer`. According to :rfkelly, this is explicitly and
  intentionally supported.
* Tests that exercise `applyIncomingBatchSize` are gone, since that's
  no longer a thing.
* The test server now shuffles records if the sort order is
  unspecified.

MozReview-Commit-ID: 4EXvNOa8mIo

--HG--
extra : rebase_source : f382f0a883c5aa1f6a4466fefe22ad1a88ab6d20
 2017-11-01 11:09:57 -07:00
Kit Cambridge 96593594d3 Bug 1368209 - Add a test for fetching backlogged history records. r=tcsc 
The test captures the existing logic in `_processIncoming`, even though
it's not quite correct:

* First, we fetch all records changed since the last sync, up to the
  download limit, and without an explicit sort order. This happens to
  work correctly now because the Python server uses "newest" by
  default, but can change in the future.
* If we reached the download limit fetching records, we request
  IDs for all records changed since the last sync, also up to the
  download limit, and sorted by index. This is likely to return IDs
  for records we've already seen, since the index is based on the
  frecency. It's also likely to miss IDs for other changed records,
  because the number of changed records might be higher than the
  download limit.
* Since we then fast-forward the last sync time, we'll never download
  any remaining changed records that we didn't add to our backlog.
* Finally, we backfill previously failed and backlogged records.

MozReview-Commit-ID: 7uQLXMseMIU

--HG--
extra : rebase_source : 719ee2d9e46102195251b410f093da3247095c22
 2017-10-27 17:54:48 -07:00
Kit Cambridge 432850c0aa Bug 1368209 - Add support for `sortindex` and `older` to the mock Sync server. r=tcsc 
MozReview-Commit-ID: 6YI1OEE8x7R

--HG--
extra : rebase_source : 2f0da0cd2a1554685fff5af3de100e4b01564447
 2017-10-27 17:55:30 -07:00
Edouard Oger 3e7662202d Bug 1413685 - Unify AsyncResource and Resource. r=tcsc 
MozReview-Commit-ID: 1yEeAwpbGxJ

--HG--
extra : rebase_source : 8c87b0d16138acf2b55be70767fe0547f4ac1d42
 2017-11-02 14:30:59 -04:00
NARCIS BELEUZU 1b5408583f Backed out 3 changesets (bug 1368209)xpcshell failures services/sync/tests/unit/test_syncengine_sync.js on CLOSED TREE 
Backed out changeset 1b868efa368f (bug 1368209)
Backed out changeset b88c681ccdc1 (bug 1368209)
Backed out changeset 4b8e56844ae9 (bug 1368209)
 2017-11-03 11:40:06 +02:00
Kit Cambridge 4105f1cb3a Bug 1368209 - Refactor `Engine::_processIncoming` into three stages. r=eoger,tcsc 
* In the first stage, we fetch changed records, newest first, up to the
  download limit. We keep track of the oldest record modified time we
  see.
* Once we've fetched all records, we reconcile, noting records that
  fail to decrypt or reconcile for the next sync. We then ask the store
  to apply all remaining records. Previously, `applyIncomingBatchSize`
  specified how many records to apply at a time. I removed this because
  it added an extra layer of indirection that's no longer necessary,
  now that download batching buffers all records in memory, and all
  stores are async.
* In the second stage, we fetch IDs for all remaining records changed
  between the last sync and the oldest modified time we saw in the
  first stage. We *don't* set the download limit here, to ensure we
  add *all* changed records to our backlog, and we use the `"oldest"`
  sort order instead of `"index"`.
* In the third stage, we backfill as before. We don't want large deltas
  to delay other engines from syncing, so we still only take IDs up to
  the download limit from the backlog, and include failed IDs from the
  previous sync. On subsequent syncs, we'll keep fetching from the
  backlog until it's empty.

Other changes to note in this patch:

* `Collection::_rebuildURL` now allows callers to specify both `older`
  and `newer`. According to :rfkelly, this is explicitly and
  intentionally supported.
* Tests that exercise `applyIncomingBatchSize` are gone, since that's
  no longer a thing.
* The test server now shuffles records if the sort order is
  unspecified.

MozReview-Commit-ID: 4EXvNOa8mIo

--HG--
extra : rebase_source : 13605dd3a43569a6d83dc2eb15a578a7bbd5c1ca
 2017-11-01 11:09:57 -07:00
Kit Cambridge 481bdb6dd6 Bug 1368209 - Add a test for fetching backlogged history records. r=tcsc 
The test captures the existing logic in `_processIncoming`, even though
it's not quite correct:

* First, we fetch all records changed since the last sync, up to the
  download limit, and without an explicit sort order. This happens to
  work correctly now because the Python server uses "newest" by
  default, but can change in the future.
* If we reached the download limit fetching records, we request
  IDs for all records changed since the last sync, also up to the
  download limit, and sorted by index. This is likely to return IDs
  for records we've already seen, since the index is based on the
  frecency. It's also likely to miss IDs for other changed records,
  because the number of changed records might be higher than the
  download limit.
* Since we then fast-forward the last sync time, we'll never download
  any remaining changed records that we didn't add to our backlog.
* Finally, we backfill previously failed and backlogged records.

MozReview-Commit-ID: 7uQLXMseMIU

--HG--
extra : rebase_source : 5742474889845b934c3d2e8b479d26d719cd03c0
 2017-10-27 17:54:48 -07:00
Kit Cambridge 8f60eeed17 Bug 1368209 - Add support for `sortindex` and `older` to the mock Sync server. r=tcsc 
MozReview-Commit-ID: 6YI1OEE8x7R

--HG--
extra : rebase_source : 2f0da0cd2a1554685fff5af3de100e4b01564447
 2017-10-27 17:55:30 -07:00
Thom Chiovoloni 4ee948935f Bug 1408176 - Use trace logs when logging PII in sync passwords engine r=kitcambridge 
MozReview-Commit-ID: KueHgdTH02Z

--HG--
extra : rebase_source : a8f5814c5d9baf8e6c370c65da8472f9c7c6213e
 2017-10-27 11:32:22 -04:00
Mark Banner 4de6bf22b1 Bug 1411368 - Automatically fix no-multi-spaces issues raised when using ESLint 4. r=mossop 
MozReview-Commit-ID: H5YVp3rnzGo

--HG--
extra : rebase_source : 5b45b6c0df834131812d094e975047eaad374e06
 2017-10-26 11:47:01 +01:00
Kit Cambridge 3b78d2f449 Bug 1412139 - Prepare existing bookmark engine tests for new buffered engine. r=kitcambridge 
MozReview-Commit-ID: 2HIkdPOuWOy

--HG--
extra : rebase_source : 6c8108f707f59e8d795dfd489453c614f00fd096
 2017-09-11 14:17:24 -07:00
Edouard Oger 76547f53cc Bug 1395460 p1 - Remove usages of about:accounts. r=tcsc 
MozReview-Commit-ID: APdGc9avJDw

--HG--
extra : rebase_source : aaa788be5251607ebedcb5b690da0e2a1a64e2cb
 2017-10-24 14:05:52 -04:00
Sebastian Hengst 93903f0306 Backed out 2 changesets (bug 1395460) for eslint failure at browser/components/uitour/UITour.jsm:556 (no return value from arrow function). r=backout on a CLOSED TREE 
Backed out changeset 0bc6d186d609 (bug 1395460)
Backed out changeset 6c028123001d (bug 1395460)
 2017-10-26 23:33:04 +02:00
Edouard Oger 58876ecbe9 Bug 1395460 p1 - Remove usages of about:accounts. r=tcsc 
MozReview-Commit-ID: APdGc9avJDw

--HG--
extra : rebase_source : 9da1cea9fb6494c057bc6587a7bcbdb4ac127448
 2017-10-24 14:05:52 -04:00
Kit Cambridge 1225809c1d Bug 1411690 - Floor the repair advance and most recent repair timestamps. r=tcsc 
The timestamps are automatically truncated when they're stored in
prefs, which is fine because we don't need millisecond precision.
However, the truncation raises a warning, so we need to explicitly
floor the values.

MozReview-Commit-ID: BRflL6s0b1

--HG--
extra : rebase_source : 6724a1ad05cb8aee4ab8c666545784960c23a0f3
 2017-10-25 13:54:44 -07:00
Edouard Oger 4a0a0ce970 Bug 1411714 - Handle action=email in about:accounts. r=tcsc 
MozReview-Commit-ID: 5U6Qy78S1Nl

--HG--
extra : rebase_source : 69368eca5243d418c9705959be81f724351291c6
 2017-10-25 16:41:37 -04:00
Sebastian Hengst 1ead0a96a9 Backed out changeset dab1c5badddb (bug 1407679) for failing server startup in mochitests on Android. r=backout on a CLOSED TREE 
--HG--
extra : amend_source : 3dc4cb2bbaf55f3f6329687ce64d4e862fc3800b
 2017-10-24 21:18:26 +02:00
Valentin Gosu 9dd47ebf50 Bug 1407679 - Merge nsIIOService and nsIIOService2 r=nwgh 
Removes deprecated nsIIOService2.newChannelFromURIWithProxyFlags

MozReview-Commit-ID: Gr3nA25kcre

--HG--
extra : rebase_source : 3407b5ed0f8f7067523abee28c137db3cac86b14
 2017-10-20 16:41:07 +02:00
Kit Cambridge c31dc99e96 Bug 890217 - Add a test for syncing bookmarks with IMAP URLs. r=tcsc 
MozReview-Commit-ID: KBVInzYk1Rr

--HG--
extra : rebase_source : 9ba1b55c154a9a19f24dcf8b859189123abcad1c
 2017-10-20 08:55:52 -07:00
Tom Prince 0a687f249e Bug 1404577: Actually disable loading blocklist dump in test_cert_blocklist.js. r=leplatrem 
The dump file isn't in the expected location in firefox tests, but is in
thunderbird tests, so the preference to disable loading wasn't originally
implemented.

MozReview-Commit-ID: HvFqfC69yMQ

--HG--
extra : rebase_source : 1d358292f0ab94299e444f4d3e3454a2259d1a64
 2017-10-19 21:26:20 -06:00
Dan Banner 7caa92d5d8 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8 
MozReview-Commit-ID: Jm8BRgt6mIv
 2017-10-15 20:50:39 +01:00
Thom Chiovoloni 2c51427c6d Bug 1408180 - Ensure LoginRec.toString doesn't contain the password. r=kitcambridge 
MozReview-Commit-ID: 5mV0g9LH4vE

--HG--
extra : rebase_source : 33a9c246053448450e6107c3b244d0bf86f7decb
 2017-10-12 18:15:48 -04:00
Sebastian Hengst 87cd48824a merge mozilla-central to autoland. r=merge a=merge on a CLOSED TREE 2017-10-13 00:53:56 +02:00
Sebastian Hengst f7efb5fc2c Merge mozilla-central to mozilla-inbound. r=merge a=merge on a CLOSED TREE 2017-10-12 12:03:15 +02:00
Edouard Oger d8c3cc3c0b Bug 1401700 - Prevent incoming tabs from opening multiple times if client sync fails. r=tcsc 
MozReview-Commit-ID: DhrZ1oFY2WG

--HG--
extra : rebase_source : d8d35bdb08edbad9412d6953a671c3e38e75711c
 2017-10-03 14:45:11 -04:00
Kevin Pellet (Ilphrin) 87b8d9ecb9 Bug 1406488 - Use a set instead of array to store current visits in `_recordToPlaceInfo` r=kitcambridge 
MozReview-Commit-ID: LW6Gg7i5lun
 2017-10-11 19:06:10 -04:00
Sebastian Hengst 30ccd917b0 Backed out changeset 8d5cc47b248f (bug 1401700) for failing xpcshell services/sync/tests/unit/test_bookmark_repair.js on OS X 10.10 opt. r=backout 2017-10-11 23:44:26 +02:00
Edouard Oger 51d18ff941 Bug 1401700 - Prevent incoming tabs from opening multiple times if client sync fails. r=tcsc 
MozReview-Commit-ID: DhrZ1oFY2WG

--HG--
extra : rebase_source : e98e4ee0a3e376840ce89f0908d7210b167154fa
 2017-10-03 14:45:11 -04:00
Edouard Oger 4397201c90 Bug 1407726 - Add reason field to push messages sent with /notify. r=tcsc 
MozReview-Commit-ID: 3sRpheND9Wa

--HG--
extra : rebase_source : 23f7dffb920f9f9f14ccdd16f171c489f36745cc
 2017-10-11 14:58:21 -04:00
Thom Chiovoloni 7555b605f1 Bug 1407082 - Handle more kinds of errors in SyncTelemetry.transformError. r=kitcambridge 
MozReview-Commit-ID: CjwY7w7vUqs

--HG--
extra : rebase_source : 4030ab88c3eccd755272499ff0527e9e316998b1
 2017-10-10 12:31:42 -04:00