7cc5e1d84e
Bug 1268772 (part 5) - Use MOZ_MUST_USE in other parts of xpcom/ds/. r=erahm.
...
As well as adding MOZ_MUST_USE to a number of functions, this patch:
- Changes the return type of nsObserverList::GetObserverList() from |nsresult|
to |void|, because it always returned NS_OK and none of the callers checked
the result.
- Removes an unnecessary |new| check in nsSupportsArray::Enumerate().
--HG--
extra : rebase_source : 3a93124ef2a7db3929119194ceacbc56bc80d2c6
2016-04-28 17:11:17 +10:00
01583602a9
Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat
...
The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout. The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.
CLOSED TREE makes big refactorings like this a piece of cake.
# The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
xargs perl -p -i -e '
s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
s/nsRefPtr ?</RefPtr</g; # handle declarations and variables
'
# Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h
# Handle nsRefPtr.h itself, a couple places that define constructors
# from nsRefPtr, and code generators specially. We do this here, rather
# than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
# things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
mfbt/nsRefPtr.h \
xpcom/glue/nsCOMPtr.h \
xpcom/base/OwningNonNull.h \
ipc/ipdl/ipdl/lower.py \
ipc/ipdl/ipdl/builtin.py \
dom/bindings/Codegen.py \
python/lldbutils/lldbutils/utils.py
# In our indiscriminate substitution above, we renamed
# nsRefPtrGetterAddRefs, the class behind getter_AddRefs. Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'
if [ -d .git ]; then
git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi
--HG--
rename : mfbt/nsRefPtr.h => mfbt/RefPtr.h
2015-10-18 01:24:48 -04:00
1e0f87e27d
Bug 1151541, part 2 - Fix mode lines in xpcom/. r=froydnj
2015-04-09 10:25:05 -07:00
e3b6a8b033
Bug 1150916 - Be sure we aren't iterating over a hashtable while it is modified in nsObserverService::UnmarkGrayStrongObservers(). r=froydnj
...
The QI in xpc_TryUnmarkWrappedGrayObject() might somehow trigger a GC,
which in turn could destroy an observer, that would in turn call
RemoveObserver() which mutates the hash table that we're enumerating.
2015-04-08 17:16:30 -07:00
c236b48231
Bug 1093934 - Create a XPCOM library that can be used to support standalone WebRTC. r=nfroyd
...
--HG--
extra : rebase_source : 93f11457b16b344e148a6fcb924b286ef8a48051
2015-04-03 15:52:00 +02:00
e226c762ee
Backed out changeset 0f5799df920b (bug 1093934) for various test failures CLOSED TREE
...
--HG--
extra : amend_source : 047ed43008cea68775c544cdf0df2819cfb24589
2015-04-02 13:42:34 -07:00
683155c363
Bug 1093934 - Create a XPCOM library that can be used to support standalone WebRTC r=froydnj
2015-04-02 12:12:37 -07:00
68ba4f3767
Bug 1022456 - Convert xpcom/ds/ to Gecko style. r=froydnj
2014-07-09 08:15:21 -07:00
5f1fde8824
Bug 900908 - Part 3: Change uses of numbered macros in nsIClassInfoImpl.h/nsISupportsImpl.h to the variadic variants. r=froydnj
2014-04-27 03:06:00 -04:00
1b83407ce9
Bug 927728 - Part 1: Replace PRUnichar with char16_t; r=roc
...
This patch was automatically generated by the following script:
#!/bin/bash
# Command to convert PRUnichar to char16_t
function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
! -wholename "*security/nss*" \
! -wholename "*modules/libmar*" \
! -wholename "*/.hg*" \
! -wholename "obj-ff-dbg*" \
! -name prtypes.h \
! -name Char16.h \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert PRUnichar char16_t
2014-01-04 10:02:17 -05:00
5f9e07125e
Bug 901976 - don't null-check |new X| in xpcom/; r=bsmedberg
2013-08-05 11:16:53 -04:00
e368dc9c85
Bug 579517 - Part 1: Automated conversion of NSPR numeric types to stdint types in Gecko; r=bsmedberg
...
This patch was generated by a script. Here's the source of the script for
future reference:
function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
! -wholename "*security/nss*" \
! -wholename "*/.hg*" \
! -wholename "obj-ff-dbg*" \
! -name nsXPCOMCID.h \
! -name prtypes.h \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert PRInt8 int8_t
convert PRUint8 uint8_t
convert PRInt16 int16_t
convert PRUint16 uint16_t
convert PRInt32 int32_t
convert PRUint32 uint32_t
convert PRInt64 int64_t
convert PRUint64 uint64_t
convert PRIntn int
convert PRUintn unsigned
convert PRSize size_t
convert PROffset32 int32_t
convert PROffset64 int64_t
convert PRPtrdiff ptrdiff_t
convert PRFloat64 double
2012-08-22 11:56:38 -04:00
82ff7027aa
Bug 716478 - update licence to MPL 2.
2012-05-21 12:12:37 +01:00
05fb8bb993
Bug 737075 - unmark gray strongly held observers implemented in JS. r=bsmedberg, smaug
2012-04-30 12:01:11 -07:00
d2b70213ac
Bug 675553 - Switch from PRBool to bool on a CLOSED TREE , r=bsmedberg,khuey,bz,cjones
...
--HG--
rename : tools/trace-malloc/bloatblame.c => tools/trace-malloc/bloatblame.cpp
2011-09-28 23:19:26 -07:00
8cdc65ab1c
Bug 507114: Make the observer-service deal with do_QueryReferent causing observers to be added or removed. r=bsmedberg
2009-11-16 17:07:41 -08:00
1141ded71b
Back out bug 412320 and various followups because the perf impact was minimal and the code is more complicated
2008-02-21 12:39:20 -08:00
adac3963d9
Bug 412320 - Try code-generation for QI impls, r=roc+luser
2008-01-25 09:14:48 -08:00
6d7584839a
Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros.
2007-07-08 00:08:04 -07:00
094c06b97d
Bug 326491 - leaked observer service leaks things on shutdown - r=darin
2006-03-21 14:43:56 +00:00
160c228151
backing out bsmedberg's patch for bug 326491 to fix bug 329505.
2006-03-09 03:14:32 +00:00
ac2cdadfb2
Bug 326491 - cleanup observers on shutdown even if the observer service is leaked, r=darin
2006-03-04 14:04:05 +00:00
af5a5a9521
Followup to bug 319024 - I double-reversed the list
2005-12-14 00:59:06 +00:00
615da26151
Bug 319024 - Password manager does not remember data - regression from bug 316414 part 1 - observer enumerators need to hand out the strong-ref nsIObserver-implementing object, not the nsIWeakReference-implementing object, r=darin
2005-12-13 21:12:41 +00:00
1b077c22fa
Bug 316414 part 1, try #2 - Add xpcom-shutdown-threads and xpcom-shutdown-loaders notifications, r=darin
2005-11-30 18:51:27 +00:00
eb9350f619
Bug 106386 Correct misspellings in source code
...
patch by unknown@simplemachines.org r=timeless rs=brendan
2005-11-25 19:48:04 +00:00
20b7e83c42
Backing out the rest of 316414 due to persistent orange.
2005-11-23 21:37:16 +00:00
f53711438a
Bug 316414 part 1 - Add "xpcom-shutdown-threads" and "xpcom-shutdown-loaders" notifications during XPCOM Shutdown, r=darin
2005-11-23 14:32:18 +00:00
2bc735d388
Bug 238963 nsObserverList::GetObserverList should return OOM on failure
...
r=dougt
2004-07-30 02:43:13 +00:00
31625ba2b1
Bug 236613: change to MPL/LGPL/GPL tri-license.
2004-04-18 14:21:17 +00:00
b9083989bb
Bug 178643: Remove uses of NS_INIT_ISUPPORTS, since it is no longer needed. r=timeless sr=jag
2003-01-08 23:19:20 +00:00
6faa067b2d
just because an observer supports weak refs doesn't mean it is one. (found while leak hunting in) bug 166442 r=jag,jst
2002-09-11 02:35:26 +00:00
68faeb5241
166917. Clean up xpcom SDK includes. r=rpotts@netscape.com, sr=alecf@netscape.com, a=rjesup@wgate.com
2002-09-07 17:13:19 +00:00
bd4d9e5593
DEBUG_dougt -> DEBUG_dougt_xxx. a=dbaron
2002-03-18 23:40:36 +00:00
59892aa65e
Remove more no-longer-needed nsComponentManager::RegisterComponent calls. Remove remnants of NS_IMPL_IDS macro, associated with long-gone NS_DECLARE_ID. b=125782 r=dougt rs=jag
2002-02-16 16:18:13 +00:00
40ccb42c7c
Fixing some warnings in xpcom. Bug 118377, r=hwaara, sr=shaver.
2002-02-03 07:05:10 +00:00
78caae6067
just removing some dead code that blake spotted, followup to bug 110226
2001-11-29 00:07:42 +00:00
c0f138b6da
notify observers in reverse order, so that if a observer removes itself when it gets notified, we don't forget to notify the next guy
...
r=dougt, sr=bienvenu bug 110226
2001-11-28 02:48:10 +00:00
9cdc5ef58a
debug stuff only - adding MOZ_COUNT_DTOR/CTOR and changing DEBUG to DEBUG_dougt
...
(last part r=dougt)
2001-11-27 23:52:05 +00:00
24ac2f3385
check for null. if the reference ever goes away, we crash
2001-10-27 03:06:09 +00:00
e625fb98e9
Fixes bug 106313 (smoketest blocker). Allowing notification of weak references, regression caused by my nsIObserverService landing. sr=alecf@netscape.com.
2001-10-24 18:02:46 +00:00
d18d7e2b17
nsIObserver and nsIObserverService API freeze. r=rpotts@netscape.com, alecf@netscape.com. bug 99163
2001-10-19 20:52:59 +00:00
4e12e44b2f
Relicensing Round 1, Take 2. Most C-like NPL files -> NPL/GPL/LGPL. Bug 98089.
2001-09-28 20:14:13 +00:00
8ee9e073f5
Fix bug 69729, nsIObserverList had bogus params. Also make it possible to CreateInstance one. r=jag, sr=alecf.
2001-03-03 01:24:36 +00:00
c0497e31be
Bug 21556: Making linux be thread-safe. Making tons of classes implement threadsafe AddRef/Release. a=jar
2000-03-05 21:26:01 +00:00
17c627bc23
fix warning for scc.
1999-12-24 03:42:54 +00:00
f15c00b036
Bug 22212. Re-enable observer service weak ref stuff, now that a good fix is in for PageCycler. a=chofmann
1999-12-21 00:12:25 +00:00
f0008a0cf9
Reverting scc's changes until we can sort out the browser buster stuff. a=chofmann
1999-12-20 22:13:33 +00:00
e765050567
Enabling weak observer lists. Back this code out (if needed) by commenting out the |#define NS_WEAK_OBSERVERS| line since it also contains fixes. bug#18682, r=law, a={dp, chofmann}
1999-12-19 17:14:47 +00:00
f5f06fba37
Fix for unix bustage, r=scc@netscape.com
1999-12-08 06:14:33 +00:00
Nicholas Nethercote
Nathan Froyd
Andrew McCreight
Randall Barker
Wes Kocher
Birunthan Mohanathas
Ehsan Akhgari
Gervase Markham
Andrew McCreight
Michael Wu
Jonas Sicking
benjamin@smedbergs.us
jwalden@mit.edu
benjamin%smedbergs.us
darin%meer.net
bsmedberg%covad.net
timeless%mozdev.org
gerv%gerv.net
dbaron%dbaron.org
danm%netscape.com
dougt%netscape.com
dbaron%fas.harvard.edu
bryner%netscape.com
alecf%netscape.com
sfraser%netscape.com
warren%netscape.com
sspitzer%netscape.com
waterson%netscape.com
scc%netscape.com
rginda%netscape.com