Steve Fink
36169fa9e9
Bug 1626772 - Fixes for gcc 9 warnings r=botond
...
Differential Revision: https://phabricator.services.mozilla.com/D69275
--HG--
extra : moz-landing-system : lando
2020-04-10 20:40:03 +00:00
Mihai Alexandru Michis
f2e4ef7d2a
Backed out 3 changesets (bug 1626772) for causing bustages in DefineEnum.h
...
CLOSED TREE
Backed out changeset f42150bdee2b (bug 1626772)
Backed out changeset ab5b637f714a (bug 1626772)
Backed out changeset fd4026a9f380 (bug 1626772)
2020-04-10 03:49:33 +03:00
Steve Fink
a0f2e976ce
Bug 1626772 - Fixes for gcc 9 warnings r=botond
...
Differential Revision: https://phabricator.services.mozilla.com/D69275
--HG--
extra : moz-landing-system : lando
2020-04-02 17:59:46 +00:00
Chris Peterson
a6d592bbe2
Bug 1620152 - Part 4: Replace MOZ_DIAGNOSTIC_ALWAYS_TRUE() with MOZ_ALWAYS_TRUE(). r=janv
...
MOZ_ALWAYS_TRUE() evaluates its expression in both debug and release builds. This bug will change MOZ_ALWAYS_TRUE() to use MOZ_DIAGNOSTIC_ASSERT() instead of MOZ_ASSERT(), so MOZ_DIAGNOSTIC_ALWAYS_TRUE() will be redundant.
Differential Revision: https://phabricator.services.mozilla.com/D66922
--HG--
extra : moz-landing-system : lando
2020-04-09 02:08:10 +00:00
Chris Peterson
ceb9bb69c5
Bug 1620152 - Part 3: Implement MOZ_ALWAYS_TRUE()/etc using MOZ_DIAGNOSTIC_ASSERT() instead of MOZ_ASSERT(). r=froydnj
...
MOZ_ALWAYS_TRUE() evaluates its expression in both debug and release builds. This bug will change MOZ_ALWAYS_TRUE() to use MOZ_DIAGNOSTIC_ASSERT() instead of MOZ_ASSERT() so it will also assert in Nightly and DevEdition release builds.
Differential Revision: https://phabricator.services.mozilla.com/D66921
--HG--
extra : moz-landing-system : lando
2020-04-09 02:07:00 +00:00
Sebastian Hengst
88bbcf97df
Backed out 4 changesets (bug 1620152) because it blocks the backout of bug 1626967. a=backout
...
Backed out changeset c6fe172dd237 (bug 1620152)
Backed out changeset a13507db74f7 (bug 1620152)
Backed out changeset 005a31ffa4bf (bug 1620152)
Backed out changeset 9c80be97934f (bug 1620152)
2020-04-08 10:06:27 +02:00
Chris Peterson
46bb24451b
Bug 1620152 - Part 4: Replace MOZ_DIAGNOSTIC_ALWAYS_TRUE() with MOZ_ALWAYS_TRUE(). r=janv
...
MOZ_ALWAYS_TRUE() evaluates its expression in both debug and release builds. This bug will change MOZ_ALWAYS_TRUE() to use MOZ_DIAGNOSTIC_ASSERT() instead of MOZ_ASSERT(), so MOZ_DIAGNOSTIC_ALWAYS_TRUE() will be redundant.
Differential Revision: https://phabricator.services.mozilla.com/D66922
--HG--
extra : moz-landing-system : lando
2020-04-08 04:35:01 +00:00
Chris Peterson
fbe277226d
Bug 1620152 - Part 3: Implement MOZ_ALWAYS_TRUE()/etc using MOZ_DIAGNOSTIC_ASSERT() instead of MOZ_ASSERT(). r=froydnj
...
MOZ_ALWAYS_TRUE() evaluates its expression in both debug and release builds. This bug will change MOZ_ALWAYS_TRUE() to use MOZ_DIAGNOSTIC_ASSERT() instead of MOZ_ASSERT() so it will also assert in Nightly and DevEdition release builds.
Differential Revision: https://phabricator.services.mozilla.com/D66921
--HG--
extra : moz-landing-system : lando
2020-04-08 06:02:36 +00:00
Timothy Gu
bfaebdfe1e
Bug 1627285
- Check for NaN before std::min/max() in DOMQuad and DOMRect. r=emilio,jwalden
...
Tests were added as a part of bug 1626471. Expectations that the tests fail
have been removed.
Differential Revision: https://phabricator.services.mozilla.com/D69605
--HG--
extra : moz-landing-system : lando
2020-04-07 22:27:36 +00:00
Simon Giesecke
e3d1db10d9
Bug 1626884 - Make RC non-copyable and declare operator= only in debug builds. r=froydnj
...
RC should be non-copyable. It already is non-copyable in the atomic variant,
but not in the non-atomic variant. This ensures that RefCounted is also
non-copyable, which prevents that classes deriving from RefCounted get
accidentally copied.
Also, RC's operator= should be defined only in debug builds. As already
described in a code comment, it's only used in debug builds (to assign the
dead value), and otherwise no modifications other than incrementing &
decrementing should be possible.
Differential Revision: https://phabricator.services.mozilla.com/D69332
--HG--
extra : moz-landing-system : lando
2020-04-06 09:17:34 +00:00
Sylvestre Ledru
0aa6f03cf3
Bug 1519636 - Reformat recent changes to the Google coding style r=jgilbert
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D67574
--HG--
extra : moz-landing-system : lando
2020-04-05 13:34:58 +00:00
Narcis Beleuzu
f6ebb84618
Backed out 2 changesets (bug 1626884, bug 1627198) for bustages on ElfLoader.h CLOSED TREE
...
Backed out changeset b545e60f385c (bug 1627198)
Backed out changeset 16ee5dd004d3 (bug 1626884)
--HG--
extra : histedit_source : 21258c723c796773307977dabbd50de5aba6bd34
2020-04-03 21:56:38 +03:00
Simon Giesecke
d522d12fb3
Bug 1626884 - Make RC non-copyable and declare operator= only in debug builds. r=froydnj
...
RC should be non-copyable. It already is non-copyable in the atomic variant,
but not in the non-atomic variant. This ensures that RefCounted is also
non-copyable, which prevents that classes deriving from RefCounted get
accidentally copied.
Also, RC's operator= should be defined only in debug builds. As already
described in a code comment, it's only used in debug builds (to assign the
dead value), and otherwise no modifications other than incrementing &
decrementing should be possible.
Differential Revision: https://phabricator.services.mozilla.com/D69332
--HG--
extra : moz-landing-system : lando
2020-04-03 14:27:17 +00:00
Gurzau Raul
76614a9f25
Bug 1626267 - fix build bustage r=bustage-fix on a CLOSED TREE
2020-04-01 19:29:19 +03:00
Simon Giesecke
94fa08db9c
Bug 1626267 - Added transformation algorithms with error handling. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68994
--HG--
extra : moz-landing-system : lando
2020-04-01 15:53:58 +00:00
Simon Giesecke
84dd9a7ef6
Bug 1626197 - Remove custom copy/move operations on EnumeratedArray. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68972
--HG--
extra : moz-landing-system : lando
2020-03-31 13:17:21 +00:00
Chris Fronk
62d6d7db0e
Bug 1345842 - Add Ignore to allow ignore elements in Tie. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68742
--HG--
extra : moz-landing-system : lando
2020-03-31 12:36:22 +00:00
Simon Giesecke
237efbb270
Bug 1625871 - InitializedOnce<const T> should be a literal type for literal types T. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68759
--HG--
extra : moz-landing-system : lando
2020-03-31 08:21:11 +00:00
Simon Giesecke
3eeb9d7e2d
Bug 1625869 - Maybe<T> should be trivially destructible for move-only T. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68758
--HG--
extra : moz-landing-system : lando
2020-03-31 08:20:58 +00:00
Bogdan Tara
d6d7d84fec
Backed out 2 changesets (bug 1625871, bug 1625869) for gtest assertions on Maybe.h CLOSED TREE
...
Backed out changeset 8dee41ad98cf (bug 1625871)
Backed out changeset 39fbc765525b (bug 1625869)
2020-03-30 17:29:09 +03:00
Simon Giesecke
df70dae59a
Bug 1625871 - InitializedOnce<const T> should be a literal type for literal types T. r=froydnj
...
Depends on D68758
Differential Revision: https://phabricator.services.mozilla.com/D68759
--HG--
extra : moz-landing-system : lando
2020-03-30 12:27:10 +00:00
Simon Giesecke
b30450b50d
Bug 1625869 - Maybe<T> should be trivially destructible for move-only T. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68758
--HG--
extra : moz-landing-system : lando
2020-03-30 12:26:58 +00:00
André Bargull
cc2bfc7ab8
Bug 1625473: Use type traits for AbsReturnType. r=froydnj
...
Also removes the comment which allows adding more `AbsReturnType` specialisations,
because that shouldn't be necessary anymore.
Differential Revision: https://phabricator.services.mozilla.com/D68569
--HG--
extra : moz-landing-system : lando
2020-03-28 16:07:06 +00:00
André Bargull
14ca007916
Bug 1625138 - Part 41: Remove no longer needed includes for mozilla/TypeTraits. r=froydnj
...
Also adds missing includes in some files, these were previously only transivitely
included through mozilla/TypeTraits.h.
Differential Revision: https://phabricator.services.mozilla.com/D68561
--HG--
extra : moz-landing-system : lando
2020-03-28 16:00:09 +00:00
André Bargull
13bfe75b97
Bug 1625138 - Part 40: Replace remaining mozilla::IsSame with std::is_same. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68560
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:21 +00:00
André Bargull
5992327185
Bug 1625138 - Part 36: Replace mozilla::IsSame with std::is_same in mfbt/. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68555
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:20 +00:00
André Bargull
2712714d84
Bug 1625138 - Part 35: Replace mozilla::TrueType with std::true_type. r=froydnj,jgilbert
...
Differential Revision: https://phabricator.services.mozilla.com/D68554
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:20 +00:00
André Bargull
f8eb4c162e
Bug 1625138 - Part 34: Replace mozilla::FalseType with std::false_type. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68553
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:20 +00:00
André Bargull
9de017ffb8
Bug 1625138 - Part 33: Replace mozilla::IntegralConstant with std::integral_constant. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68552
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:19 +00:00
André Bargull
32cb16fc45
Bug 1625138 - Part 32: Replace mozilla::RemoveConst with std::remove_const. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68551
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:19 +00:00
André Bargull
8fae6ee9a8
Bug 1625138 - Part 31: Replace mozilla::RemoveVolatile with std::remove_volatile. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68549
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:19 +00:00
André Bargull
8d7aa62e32
Bug 1625138 - Part 29: Replace mozilla::IsVoid with std::is_void. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68548
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:19 +00:00
André Bargull
cf0b1e89e9
Bug 1625138 - Part 30: Replace mozilla::RemoveCV with std::remove_cv. r=froydnj,jgilbert
...
Differential Revision: https://phabricator.services.mozilla.com/D68547
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:18 +00:00
André Bargull
95c76a6863
Bug 1625138 - Part 28: Replace mozilla::AddRvalueReference with std::add_rvalue_reference. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68546
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:18 +00:00
André Bargull
42d4ebbda9
Bug 1625138 - Part 27: Replace mozilla::DeclVal with std::declval. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68545
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:18 +00:00
André Bargull
cae4e1fdbc
Bug 1606962: Replace mozilla::EnableIf with std::enable_if. r=froydnj,jgilbert
...
Differential Revision: https://phabricator.services.mozilla.com/D68401
--HG--
extra : moz-landing-system : lando
2020-03-28 13:35:31 +00:00
André Bargull
1be056677a
Bug 1625138 - Part 26: Replace mozilla::Conditional with std::conditional. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68381
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:18 +00:00
André Bargull
3ee851a1a5
Bug 1625138 - Part 25: Replace mozilla::RemoveReference with std::remove_reference. r=froydnj,jgilbert
...
Differential Revision: https://phabricator.services.mozilla.com/D68380
--HG--
extra : moz-landing-system : lando
2020-03-28 14:16:19 +00:00
André Bargull
08a8c3fc78
Bug 1625138 - Part 24: Replace mozilla::IsConvertible with std::is_convertible. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68379
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:17 +00:00
André Bargull
d53798e749
Bug 1625138 - Part 23: Replace mozilla::RemovePointer with std::remove_pointer. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68378
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:17 +00:00
André Bargull
44a255a4d6
Bug 1625138 - Part 22: Replace mozilla::IsArray with std::is_array. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68377
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:17 +00:00
André Bargull
85dfbced09
Bug 1625138 - Part 21: Replace mozilla::IsFunction with std::is_function. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68376
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:16 +00:00
André Bargull
0731a50d34
Bug 1625138 - Part 20: Replace mozilla::IsVolatile with std::is_volatile. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68375
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:16 +00:00
André Bargull
1455e95dc1
Bug 1625138 - Part 19: Replace mozilla::RemoveExtent with std::remove_extent. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68374
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:16 +00:00
André Bargull
b2e7397c33
Bug 1625138 - Part 18: Replace mozilla::AddPointer with std::add_pointer. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68373
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:16 +00:00
André Bargull
a08be4177e
Bug 1625138 - Part 17: Replace mozilla::Decay with std::decay. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68372
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:15 +00:00
André Bargull
ebec34a898
Bug 1625138 - Part 16: Replace mozilla::IsIntegral with std::is_integral. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68371
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:15 +00:00
André Bargull
1f5d157732
Bug 1625138 - Part 15: Replace mozilla::IsFloatingPoint with std::is_floating_point. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68370
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:15 +00:00
André Bargull
13e9ad3137
Bug 1625138 - Part 14: Replace mozilla::IsSigned with std::is_signed. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68369
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:15 +00:00
André Bargull
9ad58ea608
Bug 1625138 - Part 13: Replace mozilla::IsUnsigned with std::is_unsigned. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68368
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:14 +00:00