Simon Giesecke
6f936dd483
Bug 1695162 - Use ConstIter instead of Iter where possible. r=mccr8
...
Differential Revision: https://phabricator.services.mozilla.com/D106643
2021-03-17 15:49:46 +00:00
Simon Giesecke
ad01a10a3b
Bug 1634281
- Use nsTHashMap instead of nsDataHashtable. r=xpcom-reviewers,necko-reviewers,jgilbert,nika,valentin
...
Note that this patch only transforms the use of the nsDataHashtable type alias
to a directly equivalent use of nsTHashMap. It does not change the specification
of the hash key type to make use of the key class deduction that nsTHashMap
allows for in some cases. That can be done in a separate step, but requires more
attention.
Differential Revision: https://phabricator.services.mozilla.com/D106008
2021-03-10 10:47:47 +00:00
Simon Giesecke
4f75368dcb
Bug 1691913 - Rename nsBaseHashtable::GetOrInsert(With) to LookupOrInsert(With). r=xpcom-reviewers,necko-reviewers,jgilbert,dragana,nika
...
The functions should be called "Lookup" rather than "Get" because they return
a DataType& (rather than UserDataType).
Differential Revision: https://phabricator.services.mozilla.com/D105472
2021-02-26 09:11:45 +00:00
Miko Mynttinen
e312ab88d1
Bug 1674766 - Remove DisplayListChecker r=mattwoodrow
...
Differential Revision: https://phabricator.services.mozilla.com/D95531
2020-11-02 20:04:37 +00:00
Ryan Hunt
d4e1195aed
Bug 1558482 - Apply visibleRect and scaling when painting. r=mattwoodrow
...
visibleRect should affect both WR/layers, and scaling will only affect
layers.
Differential Revision: https://phabricator.services.mozilla.com/D34525
--HG--
extra : rebase_source : 49273db3e10088c9493f693d5f8b58864dcb01aa
2019-06-11 07:52:12 -05:00
Matt Woodrow
d35146931b
Bug 1555819 - Remove invalidated display items during PreProcessDisplayLists, since we might not merge their display list. r=miko
...
Differential Revision: https://phabricator.services.mozilla.com/D33881
--HG--
extra : moz-landing-system : lando
2019-06-11 04:39:17 +00:00
Matt Woodrow
f6b0435e84
Bug 1547802 - Compute a single caret frame for the entire display list, and remove the option to invalidate frames during painting. r=miko,smaug
...
Previously we computed a caret frame each time we started display list building for a pres shell, and tracked a stack of these as we descended through subdocuments.
This meant that we couldn't know if the caret frame had changed before we started building, and we instead had to support invalidations in the middle of building.
Since there should only ever be one focused document, we can instead retrieve this from the focus manager, and find the sole caret frame for all documents we want to paint.
Differential Revision: https://phabricator.services.mozilla.com/D33880
--HG--
extra : moz-landing-system : lando
2019-06-11 04:39:00 +00:00
Cosmin Sabou
3d72a8ffe7
Backed out 2 changesets (bug 1547802, bug 1555819) for build bustages on nsDisplayList.
...
Backed out changeset aea91be6ce82 (bug 1555819)
Backed out changeset 11a69daedddb (bug 1547802)
2019-06-11 06:52:46 +03:00
Matt Woodrow
5dc2d83f7b
Bug 1555819 - Remove invalidated display items during PreProcessDisplayLists, since we might not merge their display list. r=miko
...
Differential Revision: https://phabricator.services.mozilla.com/D33881
--HG--
extra : moz-landing-system : lando
2019-06-11 02:20:21 +00:00
Matt Woodrow
72068e14f5
Bug 1547802 - Compute a single caret frame for the entire display list, and remove the option to invalidate frames during painting. r=miko,smaug
...
Previously we computed a caret frame each time we started display list building for a pres shell, and tracked a stack of these as we descended through subdocuments.
This meant that we couldn't know if the caret frame had changed before we started building, and we instead had to support invalidations in the middle of building.
Since there should only ever be one focused document, we can instead retrieve this from the focus manager, and find the sole caret frame for all documents we want to paint.
Differential Revision: https://phabricator.services.mozilla.com/D33880
--HG--
extra : moz-landing-system : lando
2019-06-11 02:20:09 +00:00
Emilio Cobos Álvarez
95bca607dd
Bug 1487216 - Measure memory usage of RDL. r=mattwoodrow,miko
...
For now I added everything to the same bucket, but I wrote this so it should be
easy to add more buckets as needed (either to mArenaSizes, or more specific ones
like the style system has). But this is probably enough for now.
Differential Revision: https://phabricator.services.mozilla.com/D34126
--HG--
extra : moz-landing-system : lando
2019-06-09 22:58:24 +00:00
Noemi Erli
5b41ddf5f2
Backed out 2 changesets (bug 1547802, bug 1555819) mochitest and marionette failures CLOSED TREE
...
Backed out changeset 10ba83441846 (bug 1555819)
Backed out changeset b9af6aea762d (bug 1547802)
2019-06-07 09:12:09 +03:00
Matt Woodrow
bc3e85dc75
Bug 1555819 - Remove invalidated display items during PreProcessDisplayLists, since we might not merge their display list. r=miko
...
Differential Revision: https://phabricator.services.mozilla.com/D33881
--HG--
extra : moz-landing-system : lando
2019-06-07 01:55:57 +00:00
Matt Woodrow
d436383750
Bug 1547802 - Compute a single caret frame for the entire display list, and remove the option to invalidate frames during painting. r=miko,smaug
...
Previously we computed a caret frame each time we started display list building for a pres shell, and tracked a stack of these as we descended through subdocuments.
This meant that we couldn't know if the caret frame had changed before we started building, and we instead had to support invalidations in the middle of building.
Since there should only ever be one focused document, we can instead retrieve this from the focus manager, and find the sole caret frame for all documents we want to paint.
Differential Revision: https://phabricator.services.mozilla.com/D33880
--HG--
extra : moz-landing-system : lando
2019-06-07 01:55:43 +00:00
Miko Mynttinen
6c57050ada
Bug 1490404 - Part 2: Add retained display list statistics r=mattwoodrow
...
Differential Revision: https://phabricator.services.mozilla.com/D33680
--HG--
extra : moz-landing-system : lando
2019-06-06 17:54:14 +00:00
Miko Mynttinen
fbfcf25cc9
Bug 1490404 - Part 1: Be more consistent with display list and display list builder pointers and references r=mattwoodrow
...
Differential Revision: https://phabricator.services.mozilla.com/D33679
--HG--
extra : moz-landing-system : lando
2019-06-06 17:54:13 +00:00
Matt Woodrow
450f1a6f89
Bug 1544948 - Skip merging display lists that we're sure can't have changed. r=miko
...
ComputeRebuildRegion sets ForceDescendIntoIfVisible on all modified frames and their ancestors,
so we can use this to detect if a display list might have modified children by looking for this
flag on the container item.
We still need to run PreProcessDisplayList on the list, so that we can remove items that belong
to a deleted frame, and build the old items array (including placeholders for the deleted items)
so that it matches our DAG.
If we wanted to skip serialization to the old items array, then we'd need to remove the deleted
item entries from the DAG too, including connecting predecessors of the deleted entry to entries
that have that deleted entry as their predecessor. That's hard to do in-place, so we leave
the empty entries in the old items list to act as placeholders until we next merge this list
properly.
Differential Revision: https://phabricator.services.mozilla.com/D27822
--HG--
extra : moz-landing-system : lando
2019-04-29 03:14:49 +00:00
Matt Woodrow
fed842fadd
Bug 1539673 - Remove old code for handling opacity:0 within the consumers. r=miko
...
Differential Revision: https://phabricator.services.mozilla.com/D25169
--HG--
extra : moz-landing-system : lando
2019-04-01 16:54:07 +00:00
Matt Woodrow
f278a7e08c
Bug 1500864 - Cull items within opacity:0 containers when merging with retained display lists. r=mstange
...
Differential Revision: https://phabricator.services.mozilla.com/D14304
--HG--
extra : moz-landing-system : lando
2018-12-16 23:35:42 +00:00
Ryan VanderMeulen
c105f9ddd8
Backed out changesets b232989d707c and 551e3cbe82ba (bug 1500864) for causing topcrash bug 1514528.
2018-12-16 13:11:32 -05:00
Matt Woodrow
a3aee981a7
Bug 1500864 - Cull items within opacity:0 containers when merging with retained display lists. r=mstange
...
Depends on D14303
Differential Revision: https://phabricator.services.mozilla.com/D14304
--HG--
extra : moz-landing-system : lando
2018-12-14 19:46:51 +00:00
Sylvestre Ledru
265e672179
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Miko Mynttinen
929f8a7027
Bug 1509579 - Part 1: Do not mark frames modified after the rebuild limit has been reached r=mattwoodrow
...
Differential Revision: https://phabricator.services.mozilla.com/D13279
--HG--
extra : moz-landing-system : lando
2018-11-29 05:19:36 +00:00
Miko Mynttinen
03d03110a6
Bug 1488599 - Part 1: Add RetainedDisplayListData that will store frame invalidation information r=mattwoodrow
...
Differential Revision: https://phabricator.services.mozilla.com/D5245
--HG--
extra : moz-landing-system : lando
2018-09-19 10:21:27 +00:00
Ciure Andrei
e7e6a10f94
Backed out 2 changesets (bug 1488599) for causing crashes a=backout
...
Backed out changeset b08b9f2693cd (bug 1488599)
Backed out changeset bba3a8028837 (bug 1488599)
2018-09-18 10:39:23 +03:00
Miko Mynttinen
f0b6dd8c41
Bug 1488599 - Part 1: Add RetainedDisplayListData that will store frame invalidation information r=mattwoodrow
...
Differential Revision: https://phabricator.services.mozilla.com/D5245
--HG--
extra : moz-landing-system : lando
2018-09-17 14:41:08 +00:00
Gurzau Raul
da0121c598
Backed out 2 changesets (bug 1488599) for bustages at /layout/painting/nsDisplayList.cpp on a CLOSED TREE
...
Backed out changeset ed780c8fd413 (bug 1488599)
Backed out changeset 0f40b48ed3b4 (bug 1488599)
2018-09-17 16:57:58 +03:00
Miko Mynttinen
e646042ce1
Bug 1488599 - Part 1: Add RetainedDisplayListData that will store frame invalidation information r=mattwoodrow
...
Differential Revision: https://phabricator.services.mozilla.com/D5245
--HG--
extra : moz-landing-system : lando
2018-09-17 12:38:19 +00:00
Miko Mynttinen
b7eaedb6ea
Bug 1484966 - Part 3: Clang format layout/painting/ r=mattwoodrow
...
Depends on D3870
Differential Revision: https://phabricator.services.mozilla.com/D3871
--HG--
extra : moz-landing-system : lando
2018-09-04 20:46:21 +00:00
Csoregi Natalia
5984db0879
Backed out 2 changesets (bug 1484966) for bustage on RefPtr.h:42. CLOSED TREE
...
Backed out changeset 7b246c8f9de8 (bug 1484966)
Backed out changeset 399158a0a9b3 (bug 1484966)
2018-09-04 23:42:36 +03:00
Miko Mynttinen
bb2d78e17e
Bug 1484966 - Part 3: Clang format layout/painting/ r=mattwoodrow
...
Depends on D3870
Differential Revision: https://phabricator.services.mozilla.com/D3871
--HG--
extra : moz-landing-system : lando
2018-09-04 17:21:36 +00:00
Matt Woodrow
52baaee863
Bug 1462497 - Add assertions to try diagnose which wrapper item went away. r=mstange
...
MozReview-Commit-ID: BkU5tTlgFum
--HG--
extra : rebase_source : f376fb94a99adfe92ae61f6a06a79d872885a5b3
2018-05-18 20:50:04 +12:00
Matt Woodrow
52c6a96582
Bug 1453541
- Part 1: Move more code into ProcessFrame so that we can call it from multiple places. r=mstange
...
MozReview-Commit-ID: AOXPgteSgTL
--HG--
extra : rebase_source : 88da959b50c5ca9681482854e40d5d913aeac57d
2018-04-15 16:38:44 +12:00
Matt Woodrow
9a7f6d89b0
Bug 1443027 - Fix the merging algorithm to pass the new tests correctly. r=mstange
...
MozReview-Commit-ID: JnglCbdhZzE
* * *
[mq]: update-test
--HG--
extra : rebase_source : c9e861bcf811575aedeef5ab9b6fe9d963036740
2018-03-23 16:47:37 +13:00
Sebastian Hengst
a0665934fa
Backed out 2 changesets (bug 1443027) for frequent crashes on OS X. a=backout
...
Backed out changeset 1e3dc6112e76 (bug 1443027)
Backed out changeset d2734042605a (bug 1443027)
2018-04-03 19:51:49 +03:00
Matt Woodrow
8e39fcdbe0
Bug 1443027 - Fix the merging algorithm to pass the new tests correctly. r=mstange
...
MozReview-Commit-ID: JnglCbdhZzE
* * *
[mq]: update-test
--HG--
extra : rebase_source : 1db0cc9843edd9654154d400b578a0432e5d765f
2018-03-23 16:47:37 +13:00
Noemi Erli
42b34ba196
Backed out 2 changesets (bug 1443027) for breacking Gmail on OSX r=pascalc a=backout
...
Backed out changeset 5deb310542a9 (bug 1443027)
Backed out changeset e04979dd66be (bug 1443027)
2018-03-30 19:08:30 +03:00
Matt Woodrow
0ab5810be5
Bug 1443027 - Fix the merging algorithm to pass the new tests correctly. r=mstange
...
MozReview-Commit-ID: JnglCbdhZzE
* * *
[mq]: update-test
MozReview-Commit-ID: JMIzrnVeSTo
--HG--
extra : rebase_source : 0ea5ff0e79d1eb1a8f13ea4a17e37fe2601d44e7
2018-03-23 16:47:37 +13:00
Ryan VanderMeulen
49cc27555d
Backed out changesets d9f154931d6d and 90e564873aa1 (bug 1443027) for causing Nightly topcrash bug 1448841.
2018-03-26 09:13:54 -04:00
Matt Woodrow
0c51f3f066
Bug 1443027 - Fix the merging algorithm to pass the new tests correctly. r=mstange
...
MozReview-Commit-ID: JnglCbdhZzE
* * *
[mq]: update-test
MozReview-Commit-ID: JMIzrnVeSTo
--HG--
extra : rebase_source : 0ea5ff0e79d1eb1a8f13ea4a17e37fe2601d44e7
2018-03-23 16:47:37 +13:00
Matt Woodrow
83e16d1481
Bug 1429932 - Part 4: Determine when AttemptPartialUpdate made no changes, and return the result to the caller. r=miko
...
MozReview-Commit-ID: 6S8WkzHcxP5
* * *
[mq]: detect-changes-merging
MozReview-Commit-ID: KTy7wdE7dPK
--HG--
extra : source : c91a2b710a654530336760b83c6335bc11e4ed0d
2018-01-12 11:46:23 +13:00
arthur.iakab
9c5831300f
Backed out 7 changesets (bug 1429932) for frequently failing layout/reftests/table-background/backgr_layers-opacity.html a=backout
...
Backed out changeset 24cf388d5d5b (bug 1429932)
Backed out changeset 8f7a4df5efcc (bug 1429932)
Backed out changeset c48601351975 (bug 1429932)
Backed out changeset c91a2b710a65 (bug 1429932)
Backed out changeset 5d146aec735e (bug 1429932)
Backed out changeset db244e692584 (bug 1429932)
Backed out changeset 39ffcc432d0c (bug 1429932)
2018-02-12 12:09:21 +02:00
Matt Woodrow
026652fdb6
Bug 1429932 - Part 4: Determine when AttemptPartialUpdate made no changes, and return the result to the caller. r=miko
...
MozReview-Commit-ID: 6S8WkzHcxP5
* * *
[mq]: detect-changes-merging
MozReview-Commit-ID: KTy7wdE7dPK
2018-01-12 11:46:23 +13:00
Gerald Squelart
3f1acad94a
Bug 1435175 - RDL checker also outputs list of modified items before merge - r=mattwoodrow
...
MozReview-Commit-ID: 7ElZT9t5zYH
--HG--
extra : rebase_source : 69d7759533badb2d7b9f61f57fcabed5c32e1557
2018-02-02 18:18:59 +11:00
Timothy Nikkel
f1bc1aa42e
Bug 1417358. Make sure that the override dirty rect that we set when a displayport changes gets cleared even if we don't perform a partial display list update. r=mattwoodrow
...
We do this by tracking them as a property on the root frame the same way we do for modified frames.
We also set the property in ProcessFrame but that is okay because we are guaranteed to finish the partial update at that point.
2018-01-25 23:42:44 -06:00
Miko Mynttinen
ca313152eb
Bug 1428993 - Part 1: Split RetainedDisplayListBuilder::ComputeRebuildRegion() and PreProcessDisplayList() into multiple functions r=mattwoodrow
...
MozReview-Commit-ID: 77DntJk53q2
--HG--
extra : rebase_source : 1225625228c719ad57e31ef652aa45529a4f45d7
2018-01-17 18:27:42 +01:00
Andreea Pavel
353c1b48e7
Backed out 2 changesets (bug 1428993) for failing reftest ayout/reftests/display-list/1428993-1.html on Android
...
Backed out changeset 080c07796f4c (bug 1428993)
Backed out changeset 7f88ebf8d0d1 (bug 1428993)
--HG--
extra : rebase_source : dd7c442728f6086af7c0de714e21090700709d67
2018-01-18 21:03:23 +02:00
Miko Mynttinen
cf6c19945b
Bug 1428993 - Part 1: Split RetainedDisplayListBuilder::ComputeRebuildRegion() and PreProcessDisplayList() into multiple functions r=mattwoodrow
...
MozReview-Commit-ID: 77DntJk53q2
--HG--
extra : rebase_source : a807d7e1bf038fc67e4b964d88560dc39732892d
2018-01-17 18:27:42 +01:00
Miko Mynttinen
8f00af8953
Bug 1415485 - Make the pref layout.display-list.retain live again r=mattwoodrow
...
MozReview-Commit-ID: 6QFc4Sq3WiC
--HG--
extra : rebase_source : 268c2959d38e955d1af9ab39fdb8cce0146788e3
extra : intermediate-source : 7ee9657574a2ee223b6184d1657803a0d382be59
extra : source : 558439637eba09eaae8a653ffc77d5830b16ff42
2017-11-09 16:10:21 +01:00
Sebastian Hengst
c633ffa4c4
Backed out changeset bdab19ff2fef (bug 1415485) for letting web platform tests in /css/CSS2/backgrounds/ frequently fail. r=backout a=backout
2017-11-19 15:05:47 +02:00