Haiyang Xu
3ec3db4f94
Bug 1731267 - Wrap call to ReadStream::Inner::Close() with MOZ_ALWAYS_SUCCEEDS in ReadStream::Inner::CloseStream(); r=dom-storage-reviewers,jstutte
...
Differential Revision: https://phabricator.services.mozilla.com/D126377
2021-10-07 09:11:35 +00:00
Simon Giesecke
971b645fe3
Bug 1660470 - Add missing include directives/forward declarations. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D87865
2020-11-23 16:21:38 +00:00
Sylvestre Ledru
fde06f6d21
Bug 1674637 - Use nested namespaces in dom/ r=sg,andi
...
Also add some missing namespace qualifications
Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')
Differential Revision: https://phabricator.services.mozilla.com/D95456
2020-11-04 17:04:01 +00:00
Butkovits Atila
964cca3198
Backed out changeset c0adbf7522dc (bug 1674637) for bustage on GMPParent.cpp. CLOSED TREE
2020-11-04 10:54:36 +02:00
Sylvestre Ledru
5f29324f60
Bug 1674637 - Use nested namespaces in dom/ r=sg,andi
...
Also add some missing namespace qualifications
Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')
Differential Revision: https://phabricator.services.mozilla.com/D95456
2020-11-04 08:29:00 +00:00
Simon Giesecke
de7bab0f06
Bug 1650145 - Replace all value uses of Empty[C]String by 0-length _ns literals. r=froydnj,geckoview-reviewers,agi
...
Differential Revision: https://phabricator.services.mozilla.com/D82325
2020-09-23 15:17:15 +00:00
ssengupta
3ed5b7a070
Bug 1655115 - Remove unused code paths leading to dom::cache::StreamControl::CloseReadStreams() r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D85364
2020-08-04 07:59:48 +00:00
ssengupta
15e2980688
Bug 1636050 - dom::cache::ReadStream::Controllable now inherits from AtomicSafeRefCounted. r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D77223
2020-06-23 13:34:52 +00:00
Jean-Yves Avenard
87438519f0
Bug 1637500 - P2. Rename methods as they are not always dealing with "threads". r=froydnj
...
Before P1, GetCurrentThreadSerialEventTarget would have always returned the same data as NS_GetCurrentThread, making the comment incorrect Now it will properly return the running TaskQueue if any.
This change of name more clearly exposes what they are doing, as we aren't always dealing with threads directly; but a nsISerialEventTarget
Differential Revision: https://phabricator.services.mozilla.com/D80354
2020-06-23 05:05:36 +00:00
Csoregi Natalia
c644ee9a06
Backed out changeset 99cce83b7e41 (bug 1636050) for assertion failures on ReadStream.cpp. CLOSED TREE
2020-06-09 21:21:34 +03:00
ssengupta
0789e4dfa7
Bug 1636050 - dom::cache::ReadStream::Controllable now inherits from SafeRefCounted r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D77223
2020-06-09 14:32:17 +00:00
Bogdan Tara
5b21d5ce2a
Backed out changeset f1ece7c1dc6e (bug 1636050) for tsan mochitest failure in operator++ CLOSED TREE
2020-06-08 19:14:35 +03:00
ssengupta
0bd79b3130
Bug 1636050 - dom::cache::ReadStream::Controllable now inherits from SafeRefCounted r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D77223
2020-06-08 13:33:49 +00:00
Boris Zbarsky
c878a8bb26
Bug 1619112 part 2. Pass char literals instead of char16_t literals into ErrorResult throwing methods. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D65538
--HG--
extra : moz-landing-system : lando
2020-03-06 21:04:58 +00:00
Simon Giesecke
a813e92dee
Bug 1613985 - Use default for equivalent-to-default constructors/destructors in dom/cache. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D63139
--HG--
extra : moz-landing-system : lando
2020-02-20 15:49:27 +00:00
Boris Zbarsky
e26682d684
Bug 1581173 part 1. Add a way to more easily throw TypeErrors and RangeErrors with custom message strings via ErrorResult. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D45932
--HG--
extra : moz-landing-system : lando
2019-09-20 02:19:18 +00:00
Alex Gaynor
7a604b3851
Bug 1533458 - replace OrVoid cache IPDL types with native maybe syntax; r=ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D22546
--HG--
extra : moz-landing-system : lando
2019-03-21 11:09:44 +00:00
Nika Layzell
4b1ca2241a
Bug 1528493 - Part 2: Move OptionalIPCStream to use new maybe types, r=baku
...
Depends on D20067
Differential Revision: https://phabricator.services.mozilla.com/D20068
--HG--
extra : moz-landing-system : lando
2019-02-22 18:46:14 +00:00
Andrea Marchesini
c0dfa196ce
Bug 1520150 - Single InputStreams can serialize themselves as IPCRemoteStreams (pipe) - part 2 - IPCRemoteSteam part of InputStreamParams union, r=smaug
...
Before this patch, IPCStream was an union containing IPCRemoteSteam or an
InputStreamParamsWithFds. Now InputStreamParamsWithFds is renamed IPCStream and
IPCRemoteSteam is one of the possible InputStreamParams structs.
2019-01-28 10:49:13 +01:00
Sylvestre Ledru
265e672179
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Emilio Cobos Álvarez
fffb25b74f
Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj
...
This was done automatically replacing:
s/mozilla::Move/std::move/
s/ Move(/ std::move(/
s/(Move(/(std::move(/
Removing the 'using mozilla::Move;' lines.
And then with a few manual fixups, see the bug for the split series..
MozReview-Commit-ID: Jxze3adipUh
2018-06-01 10:45:27 +02:00
Nathan Froyd
b9b5a1379d
Bug 1444971 - fix diagnostic assert condition in ReadStream; r=baku
...
Using MOZ_DIAGNOSTIC_ASSERT_ENABLED here is a little clearer than
RELEASE_OR_BETA and makes disabling diagnostic assertions globally
easier.
2018-03-13 09:47:07 -04:00
Ben Kelly
acf4cdb7d2
Bug 1397128 P6 Allow ReadStream to be created with an initially nullptr base stream. r=tt
2017-09-15 12:25:41 -07:00
Ben Kelly
2cf80de4ff
Bug 1397128 P5 Add ReadStream::Inner::EnsureStream() to synchronously open stream when Availabe/Read/ReadSegments is called. r=tt
2017-09-15 12:25:41 -07:00
Ben Kelly
66eb21a04b
Bug 1397128 P1 Make CacheReadStream ipdl struct contain an OptionalIPCStream. r=tt
2017-09-15 12:25:40 -07:00
Sebastian Hengst
285f502fd9
Backed out changeset 3f1e68da9634 (bug 1397128) for bustage at mozilla/dom/cache/CacheStorage.h:108. r=backout on a CLOSED TREE
2017-09-15 18:29:41 +02:00
Sebastian Hengst
8463726683
Backed out changeset 5988716b66bb (bug 1397128)
2017-09-15 18:28:37 +02:00
Sebastian Hengst
ea5ea33329
Backed out changeset bb52082d2d3c (bug 1397128)
2017-09-15 18:28:32 +02:00
Ben Kelly
60cc17beb8
Bug 1397128 P6 Allow ReadStream to be created with an initially nullptr base stream. r=tt
2017-09-15 09:11:23 -07:00
Ben Kelly
1cc7cde5c0
Bug 1397128 P5 Add ReadStream::Inner::EnsureStream() to synchronously open stream when Availabe/Read/ReadSegments is called. r=tt
2017-09-15 09:11:23 -07:00
Ben Kelly
ba86302f10
Bug 1397128 P1 Make CacheReadStream ipdl struct contain an OptionalIPCStream. r=tt
2017-09-15 09:11:22 -07:00
Bill McCloskey
f115503a0b
Bug 1372405
- Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-26 14:19:58 -07:00
Carsten "Tomcat" Book
8a1350b5a6
Backed out changeset 4f6302a98ae4 (bug 1372405
)
...
--HG--
extra : rebase_source : 41632f3158e88e692809731394a683d065a73dfb
2017-06-21 13:59:26 +02:00
Bill McCloskey
6b3e84ed5f
Bug 1372405
- Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-20 21:44:11 -07:00
Carsten "Tomcat" Book
ea1b86680c
Backed out changeset 9846de3bd954 (bug 1372405
)
...
--HG--
extra : rebase_source : 5d4a48e8ec394c329994689d938d2a6e9b2752b0
2017-06-20 08:27:02 +02:00
Bill McCloskey
4592152411
Bug 1372405
- Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-19 22:25:47 -07:00
Bill McCloskey
aefa2aa5da
Bug 1365097 - Convert NS_GetCurrentThread uses in dom (except for dom/media) (r=smaug)
...
For the Quatum DOM project, it's better to work in terms of event targets than
threads. This patch converts DOM code to operate on event targets rather than
threads, when possible.
MozReview-Commit-ID: 5FgvpKadUA2
2017-06-12 20:20:08 -07:00
Ben Kelly
1f1249cf75
Bug 1328642 Protect multi-thread stream access with a mutex. r=asuth
2017-01-18 06:30:24 -08:00
Ben Kelly
180d53d0e9
Bug 1328686 Add diagnostic assertions to dom/cache. r=asuth
2017-01-06 12:41:15 -08:00
Kan-Ru Chen
b6d880aca1
Bug 1297276 - Rename mfbt/unused.h to mfbt/Unused.h for consistency. r=froydnj
...
The patch is generated from following command:
rgrep -l unused.h|xargs sed -i -e s,mozilla/unused.h,mozilla/Unused.h,
MozReview-Commit-ID: AtLcWApZfES
--HG--
rename : mfbt/unused.h => mfbt/Unused.h
2016-08-24 14:47:04 +08:00
Nicholas Nethercote
a54e0fd248
Bug 1295053 (part 9) - Don't use NS_METHOD for dom/ functions. r=froydnj.
...
These don't need __stdcall on Win32.
--HG--
extra : rebase_source : 93aa569789dab107137c5493d1c86acc6701329b
2016-08-16 12:12:30 +10:00
Nicholas Nethercote
e7f10a07fd
Bug 1293603 (part 2) - Make Run() declarations consistent. r=erahm.
...
This patch makes most Run() declarations in subclasses of nsIRunnable have the
same form: |NS_IMETHOD Run() override|.
As a result of these changes, I had to add |override| to a couple of other
functions to satisfy clang's -Winconsistent-missing-override warning.
--HG--
extra : rebase_source : 815d0018b0b13329bb5698c410f500dddcc3ee12
2016-08-08 12:18:10 +10:00
Ben Kelly
62ecdfc256
Bug 1093357 P3 Convert Cache to use IPCStream and AutoIPCStream. r=asuth
...
* * *
Bug 1093357 P3 interdiff 001 Use AutoIPCStream in dom/cache
2016-05-15 10:32:09 -07:00
Ben Kelly
cab3fd4eb2
Bug 1271905 P1 Don't crash if a closed cache::ReadableStream is serialized. r=asuth
2016-05-12 07:29:20 -07:00
Kyle Huey
2709afd167
Bug 1263311: Part 3 - s/nsCancelableRunnable/CancelableRunnable/g. r=froydnj
2016-04-11 11:40:06 -07:00
Kyle Huey
1cc02aa8c6
Bug 1263311: Part 1 - Change the nsICancelableRunnable interface. r=froydnj
2016-04-11 11:40:06 -07:00
Wes Kocher
7d2cebe912
Backed out 3 changesets (bug 1263311) for Windows build failures in ServiceWorkerPrivate.cpp CLOSED TREE
...
Backed out changeset 0434a548e1fe (bug 1263311)
Backed out changeset 60b1be29446c (bug 1263311)
Backed out changeset 18132498bc40 (bug 1263311)
MozReview-Commit-ID: LPEa05QobdQ
2016-04-11 12:50:56 -07:00
Kyle Huey
d200ed89d0
Bug 1263311: Part 3 - s/nsCancelableRunnable/CancelableRunnable/g. r=froydnj
2016-04-11 11:40:06 -07:00
Kyle Huey
f13a6fc866
Bug 1263311: Part 1 - Change the nsICancelableRunnable interface. r=froydnj
2016-04-11 11:40:06 -07:00
Kyle Huey
d9265a3eaf
Bug 1259294: Part 2 - Use MOZ_ALWAYS_SUCCEEDS. r=froydnj
2016-03-28 10:28:15 -07:00