Greg Stoll
4c4a846ade
no bug - fx doc: fix a few links to old pages r=sylvestre DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D162421
2022-11-18 21:20:18 +00:00
Mark Banner
f13a3ea497
Bug 1800874 - Add docs for eslint-build tester. r=aryx
...
Differential Revision: https://phabricator.services.mozilla.com/D162389
2022-11-18 19:34:34 +00:00
Makoto Kato
1756e8266e
Bug 1740799 - Format Kotlin code using ktlint. r=geckoview-reviewers,owlish,linter-reviewers,sylvestre
...
Android-component and Fenix use ktlint, so mozilla-central should use same
tools via spotless.
This is from https://phabricator.services.mozilla.com/D131018
Differential Revision: https://phabricator.services.mozilla.com/D161557
2022-11-18 00:55:03 +00:00
Sylvestre Ledru
2f9f65bbc4
Bug 1799620 - mozlint/clippy: using nightly isn't necessary anymore r=linter-reviewers,marco DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D161564
2022-11-08 15:05:31 +00:00
june wilde
9da4567aa7
Bug 1796723 - Remove docs about foxyeah Compiler Explorer; r=freddyb
...
Differential Revision: https://phabricator.services.mozilla.com/D159912
2022-10-31 12:28:58 +00:00
Mark Banner
9613c19f16
Bug 1795880 - Add an ESLint rule to enforce using static imports where possible. r=arai,geckoview-reviewers,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D160131
2022-10-26 09:37:46 +00:00
Mark Banner
7f3cba09e8
Bug 1795322 - Update toolkit modules references in remaining places. r=mossop,zeid,geckoview-reviewers,calu
...
Differential Revision: https://phabricator.services.mozilla.com/D160036
2022-10-26 08:06:37 +00:00
Csoregi Natalia
5f9da7b301
Backed out 12 changesets (bug 1795322) for causing multiple failures e.g. test_deletion_request_ping.py. CLOSED TREE
...
Backed out changeset aba25cbcda51 (bug 1795322)
Backed out changeset a4a35005ada9 (bug 1795322)
Backed out changeset 8e8d790eb0f4 (bug 1795322)
Backed out changeset db8903454bd3 (bug 1795322)
Backed out changeset 60cc71c61cad (bug 1795322)
Backed out changeset bc6a674994ad (bug 1795322)
Backed out changeset 6ac8a611f8c7 (bug 1795322)
Backed out changeset 9fb873ecfb31 (bug 1795322)
Backed out changeset c8a7a40c2a2f (bug 1795322)
Backed out changeset f2c118b6c6ce (bug 1795322)
Backed out changeset 38df43b4a70f (bug 1795322)
Backed out changeset 89aea8373411 (bug 1795322)
2022-10-25 23:47:58 +03:00
Mark Banner
fc7befc08d
Bug 1795322 - Update toolkit modules references in remaining places. r=mossop,zeid,geckoview-reviewers,calu
...
Differential Revision: https://phabricator.services.mozilla.com/D160036
2022-10-25 19:49:28 +00:00
Greg Stoll
ae193de801
no bug - fx doc: fix link to moved string guide page r=sylvestre DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D159705
2022-10-19 19:51:27 +00:00
Simon Friedberger
81ebfde770
Bug 1788671 - Document how to add Services to eslint. r=Standard8 DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D158753
2022-10-07 18:11:17 +00:00
Mathew Hodson
929b2a7154
Bug 1776578 - Make no-addtask-setup eslint rule check for init tasks. r=mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D150333
2022-09-26 13:58:49 +00:00
Alexandre Poirot
848e2b334e
Bug 1791828 - [devtools] Remove eslint support for DevTools's lazyImporter. r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D158004
2022-09-26 10:48:05 +00:00
Mark Banner
186d63f202
Bug 1479515 - Add an ESLint rule to check for valid property accesses on Services. r=Gijs
...
This is manually run and requires a full build. MOZ_OBJDIR needs to be set to point to the object directory.
Differential Revision: https://phabricator.services.mozilla.com/D156426
2022-09-12 16:38:44 +00:00
Mark Banner
274f8662e6
Bug 1479515 - Extend the ESLint rule for checking Ci properties to check for unknown interfaces as well. r=Gijs,application-update-reviewers,nalexander
...
Differential Revision: https://phabricator.services.mozilla.com/D156425
2022-09-12 16:38:44 +00:00
Mark Banner
fd892006be
Bug 1479515 - Add an ESLint rule to check for unknown property accesses on Ci. r=Gijs
...
This is manually run and requires a full build. MOZ_OBJDIR needs to be set to point to the object directory.
Differential Revision: https://phabricator.services.mozilla.com/D156424
2022-09-12 16:38:43 +00:00
Sylvestre Ledru
213c96564a
Bug 1787590 - Doc: Remove a 404 link r=jandem DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D157112
2022-09-12 12:37:43 +00:00
Kagami Sascha Rosylight
102bd338be
Bug 1695435 - Part 2: Add more words to the chrome script heuristic in use-isInstance r=preferences-reviewers,Gijs,webdriver-reviewers,whimboo,sgalich
...
Differential Revision: https://phabricator.services.mozilla.com/D110932
2022-08-24 22:47:42 +00:00
Kagami Sascha Rosylight
a41415cb68
Bug 1695435 - Part 1: Use isInstance in XUL files r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D154841
2022-08-22 18:34:44 +00:00
André Bargull
60863b7187
Bug 1783404: Support --fix option when eslint-plugin-spidermonkey-js is used. r=tcampbell
...
Differential Revision: https://phabricator.services.mozilla.com/D153843
2022-08-12 06:10:55 +00:00
Max Smolens
8596bc0440
Bug 1617103 - Add documentation for yamllint. r=sylvestre DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D154108
2022-08-09 19:13:45 +00:00
André Bargull
96daf134a0
Bug 1782491 - Part 1: Add self-hosted code environment plugin. r=tcampbell
...
Adds a simple ESLint plugin for custom environments.
The plugin has a single exported value named `globals`, which is an object with
keys for all globally available self-hosted identifiers. All self-hosted values
are read-only, so we set all properties of `globals` to `"readonly"`.
BytecodeEmitter special identifiers are added to the `.eslintrc.js` file,
because that keeps them closer to the SpiderMonkey source tree when compared
to "tools/lint/eslint/eslint-plugin-spidermonkey-js".
Also see:
- tools/lint/eslint/eslint-plugin-mozilla/lib/environments/
- https://eslint.org/docs/latest/user-guide/configuring/language-options
Differential Revision: https://phabricator.services.mozilla.com/D153337
2022-08-05 09:58:58 +00:00
Mark Banner
4ed899ee38
Bug 1782008 - Add existing test directories to the ESLint test path definition file. r=mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D152735
2022-08-03 11:16:19 +00:00
Tooru Fujisawa
de340512f3
Bug 1779988 - Part 2: Add ESLint rule that rejects multiple `ChromeUtils.defineESModuleGetters` call on the same object. r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D152880
2022-07-28 00:54:20 +00:00
Francesco Lodolo (:flod)
2d85581b2c
Bug 1781010: Fluent linter, add checks for hard-coded brand names,r=gregtatum,linter-reviewers,sylvestre
...
Differential Revision: https://phabricator.services.mozilla.com/D152718
2022-07-26 19:48:08 +00:00
Tooru Fujisawa
5cda6987cf
Bug 1780543 - Part 11: Update document for environment. r=Standard8
...
Depends on D152648
Differential Revision: https://phabricator.services.mozilla.com/D152649
2022-07-26 02:46:32 +00:00
Andrew Halberstadt
e818e28315
Bug 1780087 - Convert some searchfox links under 'docs/code-quality' to the new role, r=linter-reviewers,sylvestre
...
This is more to demonstrate the use of the role than anything else.
Differential Revision: https://phabricator.services.mozilla.com/D152125
2022-07-19 15:41:08 +00:00
Mark Banner
a869ce033b
Bug 1779989 - Explicitly disallow ES modules in ESLint import-globals-from statements. r=arai
...
Differential Revision: https://phabricator.services.mozilla.com/D152002
2022-07-19 05:57:15 +00:00
Tooru Fujisawa
c26c3f5551
Bug 1667455 - Part 14: Stop importing Services.jsm in documents. r=kmag,necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D150903
2022-07-11 12:41:54 +00:00
Mark Banner
6cc792275f
Bug 1777451 - Add a rule to prevent/recommend against using globalThis or window in non-system modules for lazy getters. r=arai
...
Differential Revision: https://phabricator.services.mozilla.com/D151083
2022-07-06 08:35:59 +00:00
Mark Banner
e3f245f121
Bug 1764513 - Update ESLint docs for how to set up test configuration and how to use ES modules. r=arai
...
Differential Revision: https://phabricator.services.mozilla.com/D151039
2022-07-05 17:09:43 +00:00
Tooru Fujisawa
8cc73badc6
Bug 1776837 - Part 2: Reject defining lazy getter for module that is already loaded eagerly at top-level. r=mossop
...
Depends on D150935
Differential Revision: https://phabricator.services.mozilla.com/D150936
2022-07-05 01:01:35 +00:00
Mark Banner
05e3f1ea83
Bug 1646183
- Extend ESLint rule reject-importGlobalProperties to also handle defineLazyGlobalGetters. r=arai,webdriver-reviewers,webcompat-reviewers,extension-reviewers,whimboo,twisniewski,kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D150353
2022-06-29 22:37:57 +00:00
Makoto Kato
93e0a3fccb
Bug 1776804 - Update spotless information in firefox-source-docs. r=geckoview-reviewers,agi
...
"Google Java Format plug-in" link is broken now.
Also we should add spotless information to
https://firefox-source-docs.mozilla.org/code-quality/ .
Differential Revision: https://phabricator.services.mozilla.com/D150440
2022-06-28 22:58:11 +00:00
Kagami Sascha Rosylight
39d7ee6f91
Bug 1773740 - Part 3: Cover js files including ChromeUtils r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D148938
2022-06-27 20:31:33 +00:00
Tooru Fujisawa
ab853db23f
Bug 1773747 - Part 6: Add ESLint rule to check immediately-used lazy getter. r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D149867
2022-06-24 11:03:53 +00:00
Tooru Fujisawa
81ada6ab87
Bug 1772358 - Add ESLint rule to reject defining lazy getters for always available modules. r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D149872
2022-06-24 11:03:50 +00:00
Mark Banner
e4e8d3c73f
Bug 1771173 - Add ESLint rule to check for correct usages of lazy. r=arai
...
Differential Revision: https://phabricator.services.mozilla.com/D149718
2022-06-21 20:42:16 +00:00
Tooru Fujisawa
088b6d97cd
Bug 1771097 - Add ESLint rule for ChromeUtils.defineESModuleGetters lazy object name. r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D147400
2022-06-17 04:59:13 +00:00
criss
8fc8ec5d8e
Backed out 8 changesets (bug 1771092, bug 1768870
, bug 1771097, bug 1769002, bug 1768819) for causing mochitest failures on browser_sendQuery.js. CLOSED TREE
...
Backed out changeset 8a4d712f819a (bug 1771092)
Backed out changeset f4e27a35c83c (bug 1771092)
Backed out changeset 072323bc72cc (bug 1771092)
Backed out changeset 2ccf2a00fff7 (bug 1769002)
Backed out changeset ba7086fd9b1f (bug 1768819)
Backed out changeset 6205d3e2c666 (bug 1771097)
Backed out changeset 960f0aee97d5 (bug 1768870
)
Backed out changeset 5f53760c5637 (bug 1768870
)
2022-06-17 05:44:37 +03:00
Tooru Fujisawa
c0ff62bb21
Bug 1771097 - Add ESLint rule for ChromeUtils.defineESModuleGetters lazy object name. r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D147400
2022-06-17 01:30:23 +00:00
Mark Banner
8ca4d49d65
Bug 1766228 - Add an ESLint rule to ensure that member property accesses of Services are valid. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D149393
2022-06-16 21:11:24 +00:00
Molnar Sandor
c1ae6857f8
Backed out 9 changesets (bug 1769002, bug 1768870
, bug 1771097, bug 1771092, bug 1768819) for causing lint failures. CLOSED TREE
...
Backed out changeset 829df1dfad70 (bug 1769002)
Backed out changeset f0537d333adc (bug 1771092)
Backed out changeset 25b43856bc00 (bug 1771092)
Backed out changeset a49f754ca73f (bug 1771092)
Backed out changeset 164f85686a32 (bug 1769002)
Backed out changeset ef5cf9ceb915 (bug 1768819)
Backed out changeset c64e6c1fbfe7 (bug 1771097)
Backed out changeset f85393f988a8 (bug 1768870
)
Backed out changeset fe708d13cc1d (bug 1768870
)
2022-06-16 20:15:14 +03:00
Tooru Fujisawa
a1c76f5683
Bug 1771097 - Add ESLint rule for ChromeUtils.defineESModuleGetters lazy object name. r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D147400
2022-06-16 16:20:36 +00:00
Norisz Fay
7cd43cc697
Backed out 5 changesets (bug 1766228) for causing lint failures on test_restrequest.js CLOSED TREE
...
Backed out changeset 5ff1634cfe18 (bug 1766228)
Backed out changeset 01642c97e7a5 (bug 1766228)
Backed out changeset cbba28151712 (bug 1766228)
Backed out changeset 76a32127865d (bug 1766228)
Backed out changeset 2c7ef1ad380a (bug 1766228)
2022-06-16 16:36:44 +03:00
Mark Banner
1383258437
Bug 1766228 - Add an ESLint rule to ensure that member property accesses of Services are valid. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D149393
2022-06-16 12:09:28 +00:00
Tooru Fujisawa
2337bc5418
Bug 1772299 - Reject modification to globalThis inside system module. r=Standard8,webdriver-reviewers,jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D148116
2022-06-15 22:20:53 +00:00
Ray Kraesig
4fc7f7613e
Bug 1772856 - Clean up formatting r=sylvestre DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D148417
2022-06-15 07:12:02 +00:00
Ray Kraesig
24e0619a0d
Bug 1772856 - Add designated initializers to list of acceptable C++ features r=firefox-build-system-reviewers,bholley,glandium DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D148416
2022-06-15 07:12:02 +00:00
Tooru Fujisawa
9975cd7318
Bug 1771751 - Reject static import for system module from non-system module. r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D149183
2022-06-14 21:56:55 +00:00