This removes the unnecessary setting of c-basic-offset from all
python-mode files.
This was automatically generated using
perl -pi -e 's/; *c-basic-offset: *[0-9]+//'
... on the affected files.
The bulk of these files are moz.build files but there a few others as
well.
MozReview-Commit-ID: 2pPf3DEiZqx
--HG--
extra : rebase_source : 0a7dcac80b924174a2c429b093791148ea6ac204
This patch also renames certain test files to avoid
duplication of test names. Because they are all included in
testing/marionette/client/marionette/tests/webapi-tests.ini through
include statements, the test names must be unique.
--HG--
rename : dom/mobilemessage/tests/marionette/test_dsds_default_service_id.js => dom/mobilemessage/tests/marionette/test_mobilemessage_dsds_default_service_id.js
rename : dom/telephony/test/marionette/test_dsds_default_service_id.js => dom/telephony/test/marionette/test_telephony_dsds_default_service_id.js
rename : dom/voicemail/test/marionette/test_dsds_default_service_id.js => dom/voicemail/test/marionette/test_voicemail_dsds_default_service_id.js
extra : rebase_source : 7fed68c1c8801ce6c981c0314240f0041d9068fa
I think the intent of these calls is to not copy the information strings
passed in, but to simply convert them to a friendlier nsString container
for processing.
In the TelephonyDialCallback case, we're copying the strings only to
convert them to an array of JS::Value, which copies the data again. We
might as well avoid one of the copies.
In the TelephonyParent case, we're copying the strings only to send them
over an IPC channel. Therefore, it's safe to not copy the strings
initially, because the original strings will remain live long enough to
send the IPC message.
The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout. The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.
CLOSED TREE makes big refactorings like this a piece of cake.
# The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
xargs perl -p -i -e '
s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
s/nsRefPtr ?</RefPtr</g; # handle declarations and variables
'
# Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h
# Handle nsRefPtr.h itself, a couple places that define constructors
# from nsRefPtr, and code generators specially. We do this here, rather
# than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
# things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
mfbt/nsRefPtr.h \
xpcom/glue/nsCOMPtr.h \
xpcom/base/OwningNonNull.h \
ipc/ipdl/ipdl/lower.py \
ipc/ipdl/ipdl/builtin.py \
dom/bindings/Codegen.py \
python/lldbutils/lldbutils/utils.py
# In our indiscriminate substitution above, we renamed
# nsRefPtrGetterAddRefs, the class behind getter_AddRefs. Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'
if [ -d .git ]; then
git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi
--HG--
rename : mfbt/nsRefPtr.h => mfbt/RefPtr.h
Kaku Kuo
Andrea Marchesini
Tom Tromey
Jonathan Watt
Bill McCloskey
Gijs Kruitbosch
Chris Peterson
Alastor Wu
Carsten "Tomcat" Book
Edgar Chen
Nathan Froyd
Kyle Huey
Gabriele Svelto
Andreas Tolfsen
Ben Hsu
Sebastian Hengst
Pierre-Eric Pelloux-Prayer
Bevis Tseng
Wes Kocher
Shu-yu Guo