Граф коммитов

360 Коммитов

Автор SHA1 Сообщение Дата
Matthew Gregan db34390cd9 Bug 1388236 - Remove now obsolete AudioChannelConfig in favour of AudioPlaybackConfig. r=alwu 2017-08-10 13:00:09 +12:00
Matthew Gregan 526a07e856 Bug 1388236 - Remove B2G-only AudioChannel code from dom/audiochannel. r=alwu 2017-08-10 13:00:09 +12:00
Nicholas Nethercote 72c884bf74 Bug 1384835 (part 3, attempt 2) - Remove the Preferences::Get*CString() variants that return nsAdoptingCString. r=froydnj.
--HG--
extra : rebase_source : d317b25be2ec21d1a60d25da3689e46cdce0b649
2017-07-31 14:28:48 +10:00
Nicholas Nethercote d4f9aa5530 Bug 1384835 (part 2, attempt 2) - Remove the Preferences::Get*String() variants that return nsAdoptingString. r=froydnj.
--HG--
extra : rebase_source : 6c24fbacb03d4adebe5f22b5e7fc60b069913f20
2017-07-31 14:23:50 +10:00
Nicholas Nethercote 6e6ae2ea9b Bug 1382099 - Remove MOZ_WIDGET_GONK from several dom/ subdirectories. r=mccr8,jdm.
As well as the obvious #ifdef stuff, the patch removes
TCPSocket::SetAppIdAndBrowser(), which means
{TCPSocketParent,TCPServerSocketParent}::{GetAppId,GetInIsolatedMozBrowser}()
can also be removed.
2017-07-21 10:52:44 +10:00
Alastor Wu a3c591450b Bug 1347791 - part3 : update block stauts to front-end side. r=baku,dao,mikedeboer
When the block stauts of the window was changed, we would notify front-end side
to update the vaule, so that we can save it for session restore.

MozReview-Commit-ID: FyclKmAxZHf

--HG--
extra : rebase_source : 5ac8bb9d82279074939caed53dd79c072a5097bc
2017-06-29 05:46:20 -07:00
Alastor Wu 5ea418e1fe Bug 1347791 - part2 : the tab would always be resumed when it goes to foreground first time. r=baku
Since now we move the block/resume logic to front-end side, we can remove
the changing from bug1319771 and other related bugs which are used to ensure the
pinned tab should be blocked successfully after session restore.

MozReview-Commit-ID: Ixe7tOvCEhv

--HG--
extra : rebase_source : 4214c68b4c95df5c33bf1a68c9ffb84ee4c4d5aa
2017-06-29 04:52:02 -07:00
Ben Kelly 4dd00f9b49 Bug 1375235 - Don't create the AudioChannelWindow unnecessarily when checking for audio activity in the window. r=padenot
--HG--
extra : source : af66c0b948814ad0283c57533861d8c63cb14352
2017-06-22 06:40:00 -04:00
Ryan VanderMeulen cdd9ee8a97 Backed out changeset af66c0b94881 for landing with the wrong bug number in the commit message. 2017-06-28 18:37:16 -04:00
Ben Kelly 56c5de52c0 Bug 1375119 - Don't create the AudioChannelWindow unnecessarily when checking for audio activity in the window. r=padenot
--HG--
extra : rebase_source : d06625f6c3475ba4db14438e467b00cf8a04c39a
2017-06-22 06:40:00 -04:00
Bill McCloskey f115503a0b Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-26 14:19:58 -07:00
Carsten "Tomcat" Book 8a1350b5a6 Backed out changeset 4f6302a98ae4 (bug 1372405)
--HG--
extra : rebase_source : 41632f3158e88e692809731394a683d065a73dfb
2017-06-21 13:59:26 +02:00
Bill McCloskey 6b3e84ed5f Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-20 21:44:11 -07:00
Carsten "Tomcat" Book ea1b86680c Backed out changeset 9846de3bd954 (bug 1372405)
--HG--
extra : rebase_source : 5d4a48e8ec394c329994689d938d2a6e9b2752b0
2017-06-20 08:27:02 +02:00
Bill McCloskey 4592152411 Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-19 22:25:47 -07:00
Andrea Marchesini d09988bbc2 Bug 1367075 - Get rid of AudioChannelService::IsParentProcess, r=me - CLOSED TREE 2017-05-24 09:49:35 +02:00
Andrea Marchesini c6a0819b83 Bug 1367075 - AudioChannelService doesn't need to be unregistered as observer for ipc:content-shutdown, r=alwu 2017-05-24 07:31:58 +02:00
btian de5fa4f269 Bug 1299390 - part 5: Remove useless AudioChannelService code. r=alwu
Changes:
- remove code addressed by reviewer
- remove PContent.ipdl, PBrowser.ipdl, and ProcessPriorityManager code
  that relates only to removed AudioChannelService methods
- correct test case listening to event from removed code
- remove useless test case files

MozReview-Commit-ID: I96nR8zTXJt

--HG--
extra : rebase_source : 127876c672744811c025ca55839ff2e8a06b1fce
2017-05-18 09:51:53 +08:00
btian eb73e59657 Bug 1299390 - part 2: Remove AudioChannelService methods required by BrowserElementAudioChannel only. r=alwu,baku
Changes:
- remove nsIAudioChannelService methods
- remove method AudioChannelService::RefreshAgentsVolumeAndPropagate and IPC method AudioChannelChangeNotification
- remove workaround for bug 1183033

MozReview-Commit-ID: BqlXYVhgrat

--HG--
extra : rebase_source : 64905901d645aea801b93e742472ac67ff7fb49e
2017-05-18 09:31:00 +08:00
Carsten "Tomcat" Book b5eb8a2a1b Backed out changeset be04f96bf78b (bug 1347791) 2017-05-17 08:11:09 +02:00
Alastor Wu aae22221f8 Bug 1347791 - part2 : the tab would always be resumed when it goes to foreground first time. r=baku
Since now we move the block/resume logic to front-end side, we can remove
the changing from bug1319771 and other related bugs which are used to ensure the
pinned tab should be blocked successfully after session restore.

MozReview-Commit-ID: Ixe7tOvCEhv

--HG--
extra : rebase_source : 190e63b5df53c85f7282b5c2144ae7e7830d7ad3
2017-05-17 11:56:03 +08:00
Michael Layzell 8b7ba021a4 Bug 1339537 - Part 6: Pass std::function values tree by const reference instead of by value, r=ehsan
MozReview-Commit-ID: PVAqU2DPs2
2017-04-27 12:44:57 -04:00
Alastor Wu d8197f5d08 Bug 1347758 - part4 : add audio channel log. r=Ehsan
MozReview-Commit-ID: 3zVYtD86O82

--HG--
extra : rebase_source : 3a7726760d6e4941cdbe2e6c9ee7132420482bb4
2017-03-24 14:44:18 +08:00
Alastor Wu 9685905d96 Bug 1347758 - part3 : should notify media block for audible agent in the first time. r=Ehsan
When the agent is audible, we should check whether need to notify "blockStart"
immediately.

MozReview-Commit-ID: KmYLo9cEt4X

--HG--
extra : rebase_source : 71ad5892a30727f00fd3c764d83ade074bc85f15
2017-03-24 14:43:55 +08:00
Iris Hsiao 26a234de5d Backed out 6 changesets (bug 1347758) for eslint failure
Backed out changeset 9becd55242c1 (bug 1347758)
Backed out changeset 2abce19f5001 (bug 1347758)
Backed out changeset 80232d4c85d5 (bug 1347758)
Backed out changeset 1fd084ec34d4 (bug 1347758)
Backed out changeset cafb3c12027b (bug 1347758)
Backed out changeset 85846edfe957 (bug 1347758)
2017-03-24 16:58:08 +08:00
Alastor Wu e81c17d1b2 Bug 1347758 - part4 : add audio channel log. r=Ehsan
MozReview-Commit-ID: LNXzRZx2rC2

--HG--
extra : rebase_source : eef0ad3d65161c422d3cab57e6e081796452bdd1
2017-03-24 12:04:15 +08:00
Alastor Wu 1119f7369f Bug 1347758 - part3 : should notify media block for audible agent in the first time. r=Ehsan
When the agent is audible, we should check whether need to notify "blockStart"
immediately.

MozReview-Commit-ID: KmYLo9cEt4X

--HG--
extra : rebase_source : 5f29de593b85113001552ff0497621e603b40bc6
2017-03-24 12:04:00 +08:00
Alastor Wu 860c67add0 Bug 1348783 - use LazyLogModule for AudioChannel logging. r=baku
LazyLog can be used easily via adding the pref("logging.MODULE_NAME", DEBUG_LEVEL).
It's more convenient than PRLog.

MozReview-Commit-ID: T7uSxVAiN3

--HG--
extra : rebase_source : c0b8925e5c60353c690ca68b8fe4361b48a0f57a
2017-03-21 10:38:48 +08:00
Alastor Wu 20af818a6f Bug 1338137 - part2 : remove function IsServiceStarted(). r=baku
The reason we introduced the IsServiceStarted(), check bug1338466 comment5 for
more details.

The patch1 introduces more robust way to check the alive media component, so
we can remove IsServiceStarted().

MozReview-Commit-ID: LIma8hZTuhA

--HG--
extra : rebase_source : 4687ef41cc765f4ffeb97aeac63b727897456167
2017-03-04 01:14:28 +08:00
Joel Maher f297f17181 Bug 1339232 - annotate more dom/* moz.build files with BUG_COMPONENT. r=overholt
MozReview-Commit-ID: 2HbPxGkrVfv
2017-03-01 08:20:25 -05:00
Alastor Wu 9e3e9f85fa Bug 1339230 - part3 : add test. r=baku
MozReview-Commit-ID: FzcEwErGad3

--HG--
extra : rebase_source : 6b1dac545b5ee9f68d0df68347ff21003c8dad5a
2017-02-24 17:17:09 +08:00
Alastor Wu f940903c73 Bug 1339230 - part1 : only need to do audio competing for active agent. r=baku
In Fennec, the audio competiting is to stop the playing tab if there is new
incoming tab. We only implement the way to pause the tab, not including to resume
the tab, so we just need to run the audio competing related stuffs when the agent
is active.

MozReview-Commit-ID: 3F0M2jLw9VY

--HG--
extra : rebase_source : 59eeb82cdda4a976a078663557776f4bc3b5d27b
2017-02-24 17:15:20 +08:00
Tom Tromey 5f8f360823 Bug 1060419 - make log_print use Printf.h, r=froydnj
MozReview-Commit-ID: BIZ1GQEZ1vs

--HG--
extra : rebase_source : 2f1f0aa12493c44f352d9a7e8683e7bb72d2d75b
2016-12-15 20:16:31 -07:00
Ehsan Akhgari f57b29ed8e Bug 1339930 - Don't crash in AudioChannelService when dealing with Windows without a parent; r=baku 2017-02-16 12:35:24 -05:00
Bill McCloskey 194043ae97 Bug 1339289 - Give names to a lot of common runnables (r=ehsan)
MozReview-Commit-ID: 5IdvK6kgoAW
2017-02-15 12:30:01 -08:00
Ehsan Akhgari 8a998d9134 Bug 1336484 - Don't throttle timeouts in background tabs that are playing audio; r=baku
In websites such as Facebook Live, timeout chains are used to drive the
playback of a video or something similar in JavaScript.  Throttling the
minimum timeout values a tab playing a video from such websites in the
background could make the timeout based scheduling of video playback to
not work correctly, and cause audio buffer under-runs that are audible.

In order to address this, other major browsers don't throttle timeouts
in tabs that are playing audio.  This brings us to parity to other
browsers (even though we already do this for websites that use Web Audio
since we've had similar bug reports using the Web Audio API.)

The current audio agent setup that drives the tab audio notification
icons is currently tracking whether a Window is playing audio.  We use
this setup to decide whether to throttle timeouts when a window goes
into background.
2017-02-10 12:08:25 -05:00
Alastor Wu 3e3c405bdd Bug 1328058 - part2 : rename function. r=baku
Rename function MaybeNotifyMediaBlocked() to MaybeNotifyMediaBlockStart().

MozReview-Commit-ID: CJyWiKKkpwd

--HG--
extra : rebase_source : cc9c86f366f580830fec47006da686feeed4030b
2017-02-03 14:47:11 +08:00
Alastor Wu 1694edb819 Bug 1328058 - part1 : notify block-stop event when the tab was resumed. r=baku
In present design, the tab would hide the unblocking icon when receives
the audio-playback event, but it means we can't hide the icon if the media isn't
audible.

For example, we won't show the unblocking icon for audio with audio track, but
we show the icon for audio with silent audio track which can only be detected
after starting decoding.

In this case, we can't receive the audio-playback after resuming that media.
Therefore, we should dispatch the different event to notify tab UI that the
tab has already been resumed.

MozReview-Commit-ID: 3xCWQU7nVCl

--HG--
extra : rebase_source : b5f8855b17664bb1cc2b485f1d85120c0939931f
2017-02-03 14:47:08 +08:00
Phil Ringnalda 3281b2aab2 Backed out 5 changesets (bug 1328058) for timing out in browser_block_silentAudioTrack_media.js
CLOSED TREE

Backed out changeset 0c48cff3db5d (bug 1328058)
Backed out changeset 37d35ca95b1f (bug 1328058)
Backed out changeset 0c177bdf5ec3 (bug 1328058)
Backed out changeset b369d9999b8a (bug 1328058)
Backed out changeset 61dbcbe35565 (bug 1328058)
2017-02-02 20:59:34 -08:00
Alastor Wu 915bb36a5d Bug 1328058 - part2 : rename function. r=baku
Rename function MaybeNotifyMediaBlocked() to MaybeNotifyMediaBlockStart().

MozReview-Commit-ID: CJyWiKKkpwd

--HG--
extra : rebase_source : 63cb95fd65565bfe872546dd2b4cf5c21d57af47
2017-02-03 11:25:06 +08:00
Alastor Wu e684e589c7 Bug 1328058 - part1 : notify block-stop event when the tab was resumed. r=baku
In present design, the tab would hide the unblocking icon when receives
the audio-playback event, but it means we can't hide the icon if the media isn't
audible.

For example, we won't show the unblocking icon for audio with audio track, but
we show the icon for audio with silent audio track which can only be detected
after starting decoding.

In this case, we can't receive the audio-playback after resuming that media.
Therefore, we should dispatch the different event to notify tab UI that the
tab has already been resumed.

MozReview-Commit-ID: 3xCWQU7nVCl

--HG--
extra : rebase_source : 7b4214f1f552ba75da94e4bb1795178983af20f7
2017-02-03 11:25:04 +08:00
Alastor Wu b55cdff3c1 Bug 1319771 - part2 : resume foreground window if it was still be blocked. r=baku
In previous patch, we modify the behavior of nsDocument, now it would only resume
window when document has active media components.

However, it causes another issue. If the tab really goes to foreground, but
there is no active media component, the tab would still be blocked and it won't
be resumed anymore.

Therefore, we need to resume it by ourself if the tab is on the foreground but
doesn't be resumed yet.

MozReview-Commit-ID: EdnQ7sRkSJK

--HG--
extra : rebase_source : c2ab932cc3134531e5c49581c5e63b4aabef6ca4
2017-02-03 10:50:07 +08:00
Alastor Wu 9e4d1c7549 Bug 1319771 - part1 : only resume the window when there has active media components. r=baku
For the first pinned tab, it would be set to visible first and then set to
invisible if there exists other tabs after restarting the whole browser.

If the tab is set to visible, we would activate the media component (set the
|mMediaSuspended| in outer window to none-suspend). In this case, the first
pinned tab would be set to visible briefly, but it doesn't mean the tab is in
the foreground, it's just how DOM manage the tab's visibility.

In that moment, none of the media component has been created yet. Therefore, we
would only activate the media component after the audio channel service exists.

MozReview-Commit-ID: 1FgdMq84yWX

--HG--
extra : rebase_source : d5d7568b9f4bfddf2abd0b2c2a4e9391a856882b
2017-02-03 10:48:38 +08:00
Alastor Wu 504a266d7c Bug 1329179 - only display 'play tab' icon for background tab. r=baku
When user open new tab and then go to the pasted URL (which has autoplaying
media), the "play tab" icon would be displayed briefly, and then change to the
"mute tab" icon.

That is the media element starts before calling nsDocument::PageShow() which
would resume all blocked media in the tab. Before that moment, even the tab is
in the foreground, but we doesn't resume the media yet.

Therefore, we need to check the document's visibility by ourself, and only show
the "play tab" icon for the background blocked tab.

MozReview-Commit-ID: Eg2SD5kpG0j

--HG--
extra : rebase_source : ccf25537904a10e17de2e70650b62fac8f5a3434
2017-01-17 16:30:22 +08:00
Michelangelo De Simone 7baf165ae7 Bug 1313155 - Remove dom/settings and related code. r=Ehsan
MozReview-Commit-ID: Gi7frPFQ6yW

--HG--
extra : rebase_source : 69bb31fe3bc96ca460f0e35abb0b0f82d03defb6
2016-12-29 11:26:49 -08:00
Wes Kocher ca99354e00 Backed out changeset 5566e83980ed (bug 1313155) for mass build bustage a=backout CLOSED TREE
MozReview-Commit-ID: Co3f2Vkbf4y
2017-01-12 14:16:52 -08:00
Michelangelo De Simone 0b3a927918 Bug 1313155 - Remove dom/settings and related code. r=Ehsan
MozReview-Commit-ID: Gi7frPFQ6yW

--HG--
extra : rebase_source : 401a8a202b1d8ebfd719d460bff96c9280062ded
2016-12-29 11:26:49 -08:00
Alastor Wu bdb9940208 Bug 1324311 - window-less agent can't own audio focus. r=baku
MozReview-Commit-ID: HBieQMoIGOv

--HG--
extra : rebase_source : f1a7a1da2d02f941fe4df68035a8328903fbdf8c
2016-12-19 15:04:16 +08:00
Alastor Wu ce4c37a7ff Bug 1320005 - don't show the 'play tab' icon for the media element without audio track. r=baku
MozReview-Commit-ID: K42I0yWaI7N

--HG--
extra : rebase_source : 6b2cd50bb327a644f9092c1e018203854d3d899f
2016-12-13 22:47:13 +08:00
Nathan Froyd 2ebbd09068 Bug 1320752 - remove mozilla/Function.h; r=gerald
We have std::function available now, which is likely to be somewhat more
efficient.
2016-11-28 11:03:53 -05:00