Cameron McCormack
792c4f4eb0
Bug 1295852 - Part 4: Check for generated content containers more precisely when reflowing grid containers. r=me
...
I'm not convinced that we can actually get regular content
<_moz_generated_content_before> elements in here, since it's only if
CompareTreePosition returned 0 that we look at the element name,
but might be best to make this test stronger in any case.
MozReview-Commit-ID: 8CgxcU9AbDA
--HG--
extra : rebase_source : 4a47ed62895d83f720ec7ccfde253e2c1945b34f
2016-08-19 11:46:43 +08:00
Brad Werth
c6e972716a
Bug 1289509
- Supply a default value for mGenerateComputedGridInfo. r=bz
2016-07-26 10:03:26 -07:00
Ting-Yu Lin
d77152fcd0
Bug 1277129 Part 7c - Rename various RS variables to RI. r=dbaron
...
This patch is generated by the following script:
function rename() {
find layout\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -r "s/$1/$2/g" "{}" \;
}
rename aChildRS aChildRI
rename aContainingBlockRS aContainingBlockRI
rename aFrameRS aFrameRI
rename aLastRS aLastRI
rename aOuterRS aOuterRI
rename aRS aRI
rename blockHtmlRS blockHtmlRI
rename captionRS captionRI
rename cellRS cellRI
rename childRS childRI
rename firstAncestorRS firstAncestorRI
rename flexContainerRS flexContainerRI
rename gridRS gridRI
rename innerRS innerRI
rename lastButOneRS lastButOneRI
rename LineContainerRS LineContainerRI
rename mBlockRS mBlockRI
rename parentRS parentRI
rename secondAncestorRS secondAncestorRI
rename lastRSSize lastRISize
rename lastRSPadding lastRIPadding
MozReview-Commit-ID: YEgZs3WMow
--HG--
extra : rebase_source : c26050c71a3a5b13ef46e6d3582e581702d49ee8
2016-07-21 18:36:39 +08:00
Ting-Yu Lin
40fcd21b9a
Bug 1277129 Part 7b - Rename various ReflowState variables to ReflowInput. r=dbaron
...
This patch is generated by the following script:
function rename() {
find .\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -r "s/$1/$2/g" "{}" \;
}
rename "([[:alpha:]]*)([rR])eflowState(s?)" "\1\2eflowInput\3"
MozReview-Commit-ID: ITFO7uMTkSb
--HG--
extra : rebase_source : c91a2e174a0baec60c1b0111ac7636295004ab35
2016-07-21 18:36:39 +08:00
Ting-Yu Lin
55cde36029
Bug 1277129 Part 6b - Rename rendContext to mRenderingContext in SizeComputationInput. r=dbaron
...
MozReview-Commit-ID: LczLJDtDncy
--HG--
extra : rebase_source : c32e928ae25f94305fb907db89278dce7304a903
2016-07-21 18:36:38 +08:00
Ting-Yu Lin
cd13f0ea71
Bug 1277129 Part 6a - Rename frame to mFrame in SizeComputationInput. r=dbaron
...
MozReview-Commit-ID: 3SXZ4qEZJc
--HG--
extra : rebase_source : 577d48f047af163585acea95dda311358f5e8c25
2016-07-21 18:36:38 +08:00
Ting-Yu Lin
4053c4c028
Bug 1277129 Part 5c - Rename nsHTMLReflowMetrics to ReflowOutput. r=dbaron
...
This patch is generated by the following script:
function rename() {
find .\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -e "s/$1/$2/g" "{}" \;
}
rename "nsHTMLReflowMetrics" "ReflowOutput"
MozReview-Commit-ID: 2HBb7DkooH5
--HG--
extra : rebase_source : acfa442a6483772fcb5748dc6f5e7072e599032a
2016-07-21 18:36:38 +08:00
Ting-Yu Lin
154af05659
Bug 1277129 Part 1d - Rename nsCSSOffsetState to SizeComputationInput. r=dbaron
...
This patch is generated by the following script:
function rename() {
find .\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -e "s/$1/$2/g" "{}" \;
}
rename nsCSSOffsetState SizeComputationInput
MozReview-Commit-ID: GUJ99qNiSwD
--HG--
extra : rebase_source : cf4e6c35338e1e9d4ee106305548075b2c1bdcb1
2016-07-21 18:36:35 +08:00
Ting-Yu Lin
820f88de49
Bug 1277129 Part 1c - Rename nsHTMLReflowState to ReflowInput. r=dbaron
...
This patch is generated by the following script:
function rename() {
find .\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -e "s/$1/$2/g" "{}" \;
}
rename nsHTMLReflowState ReflowInput
MozReview-Commit-ID: 9r9vdVv1pXc
--HG--
extra : rebase_source : 623ec822996ba0ea0058dd137acf5a658cdea04a
2016-07-21 18:36:35 +08:00
Brad Werth
dde35eb992
Bug 1241932 - Expose decoded CSS grid line properties via a Chrome API. r=mats
2016-07-07 11:38:12 -07:00
Brad Werth
e0d3269112
Bug 1241932 - Expose decoded CSS grid track properties in a Chrome API. r=heycam, r=khuey
...
--HG--
extra : rebase_source : 0c2a49236a2c71233a1ce6a92e50663b8a9f6238
2016-07-06 11:45:18 -07:00
Carsten "Tomcat" Book
1bb9877c16
Backed out changeset 3de5b79d7373 (bug 1241932) for bustage
2016-07-06 06:00:03 +02:00
Carsten "Tomcat" Book
2de695aebf
Backed out changeset e98d1ac584d6 (bug 1241932)
2016-07-06 05:59:52 +02:00
Brad Werth
1656f9d629
Bug 1241932 - Expose decoded CSS grid line properties via a Chrome API. r=mats
2016-07-05 13:35:52 -07:00
Brad Werth
dd6149d032
Bug 1241932 - Expose decoded CSS grid track properties in a Chrome API. r=heycam, r=khuey
2016-06-24 12:20:05 -07:00
Brad Werth
bb6b3396a0
Bug 1243559
- Removes static casts from calls to FrameProperties::Get, ::Set, and ::Remove, and forces callers to use the type associated with the property. r=dbaron
2016-06-21 13:17:11 -07:00
Phil Ringnalda
28ae5ce216
Back out changeset 0bb00282a4c2 (bug 1243559
) for widespread SVG assertion failures
...
CLOSED TREE
2016-06-22 18:45:08 -07:00
Brad Werth
179aa18d0d
Bug 1243559
- Removes static casts from calls to FrameProperties::Get, ::Set, and ::Remove, and forces callers to use the type associated with the property. r=dbaron
...
--HG--
extra : rebase_source : fd19554f1611f8028a364ce93e833d8939688bfb
2016-06-21 13:17:11 -07:00
Mats Palmgren
583415c203
Bug 1174569 - [css-grid] Use the resolved column sizes to guide intrinsic row sizing. r=dholbert
2016-06-20 13:28:03 +02:00
Jonathan Watt
b15368cfcb
Bug 1279451 - Remove a lot of unnecessary includes of nsAutoPtr.h. rs=sparky
2016-06-07 21:10:18 +01:00
Mats Palmgren
03b9057a17
Bug 1278429 - [css-grid] Align a fragmented grid item with 'align-self' that is anchored at the end ('last-baseline', 'end', etc) at the end of its last track. r=dholbert
2016-06-10 02:56:23 +02:00
Mats Palmgren
16d21bb3d7
Bug 1278007 - [css-grid] Reset all baseline bits when we decide a grid item doesn't participate in [first|last]-baseline alignment. r=dholbert
2016-06-03 17:30:00 +02:00
Mats Palmgren
7b8044d468
Bug 1256429 part 2 - [css-grid] Implement Grid layout for align|justify-content:baseline|last-baseline (aka "Baseline Content-Alignment"). r=dholbert
2016-06-02 17:46:59 +02:00
Mats Palmgren
0bdfe726a9
Bug 1221525 part 4 - [css-grid] Implement Grid layout for align|justify-self:baseline|last-baseline (aka "Baseline Self-Alignment"). r=dholbert
2016-06-02 17:46:58 +02:00
Mats Palmgren
539e419e85
Bug 1221525 part 3 - [css-grid] Caclulate the baseline offset values and baseline subtree alignment. r=dholbert
2016-06-02 17:46:58 +02:00
Mats Palmgren
aa90d52500
Bug 1221525 part 2 - [css-grid] Add GridItemInfo::mState member (for each axis) and make the mIsFlexing bool into a state flag, and add baseline state flags. Also add a baseline offset member. r=dholbert
2016-06-02 17:46:58 +02:00
Mats Palmgren
730431ba99
Bug 1221525 part 1 - [css-grid] Break out the grid item measuring reflow code to a separate function. Also, make the size contribution functions take a GridItemInfo instead of a frame, for use in later parts (idempotent patch). r=dholbert
2016-06-02 17:46:58 +02:00
Mats Palmgren
5e2c16366e
Bug 1266268 - [css-grid] Implement <percentage> for grid gap properties. r=dholbert
2016-05-25 10:48:52 +02:00
Mats Palmgren
e643bbeaf5
Bug 1271392 part 6 - [css-grid] Remove now dead code. r=dholbert
2016-05-18 13:49:33 +02:00
Mats Palmgren
4d19f2a6ef
Bug 1271392 part 4 - [css-grid] Make sure a grid item's last fragment fills its grid area. r=dholbert
2016-05-18 13:49:33 +02:00
Mats Palmgren
a1b690d0f2
Bug 1271392 part 2 - [css-grid] When pulling up grid item, make sure its next-in-flow (if any) is in our next-in-flow. r=dholbert
2016-05-18 13:49:33 +02:00
Mats Palmgren
6dca609754
Bug 1271392 part 1 - [css-grid] Make grid item 'stretch' not require an extra reflow. r=dholbert
...
This part removes the 'stretch' logic in AlignJustifySelf and implements
it in nsLayoutUtils::ComputeSizeWithIntrinsicDimensions /
nsFrame::ComputeSize instead.
2016-05-18 13:49:33 +02:00
Mats Palmgren
5ed9f29039
Bug 1267555
part 1 - [css-grid] Make grid-aligned abs.pos. descendants that span from 'auto' to the first/last line stretch to the outer edge of the first/last track respectively. r=dholbert
2016-04-28 21:21:19 +02:00
Mats Palmgren
91532abbc2
Bug 1266131 part 1 - [css-grid] 'order' doesn't apply to grid-aligned abs.pos. descendants (anymore). r=dholbert
2016-04-25 18:43:04 +02:00
Mats Palmgren
50649ed4b4
Bug 1264067 - [css-grid] 'fr' min-sizing is now invalid. r=dholbert
2016-04-25 18:43:04 +02:00
Mats Palmgren
b7b10f0fb7
Bug 1264607 - Treat track size <percentage> values as 'auto' when the grid container size is indefinite. r=dholbert
2016-04-16 18:16:24 +02:00
Mats Palmgren
fee61ecb6c
Bug 1260614 - Cleanup grid item iterator Reset() calls. r=dholbert
2016-04-01 02:08:15 +02:00
Mats Palmgren
62b5045e23
Bug 1233191 part 1 - Implement sanity checks on the flex/grid container child frame list. Remove the anon grid item sanity checks that the frame constructor now does instead. r=dholbert
2016-03-18 19:52:08 +01:00
Mats Palmgren
c71ca081ec
Bug 1256040 - Bustage fix. r=me
2016-03-13 00:47:41 +01:00
Mats Palmgren
7f3197f8cc
Bug 1256040 - Fix some nsGridContainerFrame.h/cpp compile errors in non-unified build. r=dholbert
2016-03-13 00:30:36 +01:00
Mats Palmgren
3fa78bc392
Bug 1144096 part 25 - [css-grid] Enable fragmentation to occur by reporting our actual reflow status. r=dholbert
2016-03-11 17:39:27 +01:00
Mats Palmgren
3ab9def464
Bug 1144096 part 24 - [css-grid] Move the child frame merging code at the start of ReflowOverflowContainerChildren into a new method: DrainExcessOverflowContainersList. Make both take a param so that we can override how the OC child lists are merged together (normally just an Append; MergeSortedFrameLists for Grid). r=dholbert
2016-03-11 17:39:27 +01:00
Mats Palmgren
a808043f13
Bug 1144096 part 23 - [css-grid] A grid container fragment that is an overflow container can't be INCOMPLETE, only OVERFLOW_INCOMPLETE and it should always have zero BSize. r=dholbert
2016-03-11 17:39:27 +01:00
Mats Palmgren
c46f94cf01
Bug 1144096 part 22 - [css-grid] Check NS_INLINE_IS_BREAK_BEFORE before checking other completion status. r=dholbert
2016-03-11 17:39:27 +01:00
Mats Palmgren
49b7f696e3
Bug 1144096 part 21 - [css-grid] Deal with dynamically inserted/appended/removed child frames. r=dholbert
2016-03-11 17:39:27 +01:00
Mats Palmgren
8a0ee1c101
Bug 1144096 part 20 - [css-grid] Sanity check our child lists before starting a Reflow (DEBUG only). r=dholbert
2016-03-11 17:39:27 +01:00
Mats Palmgren
d44ff85401
Bug 1144096 part 19 - [css-grid] Sanity check the initial child lists we get from the frame constructor (DEBUG only). r=dholbert
2016-03-11 17:39:27 +01:00
Mats Palmgren
6e7fad07b8
Bug 1144096 part 18 - [css-grid] Fix a couple of bugs in how we handle child existing continuations when pushing/pulling children. r=dholbert
...
There were two problems in the existing code (which was exposed by tests
that dynamically insert/remove items). First, the situation when
we have some pushed items two or more fragments away and then pull up
those. This creates a "hole" in the child next-in-flow chain like so:
grid-container-frag-0
child1-frag-0
...
grid-container-frag-1
...
grid-container-frag-2
child1-frag-1
After we reflow grid-container-frag-0 and it's still incomplete we will
reflow its NIF, grid-container-frag-1, but it will "stall" since it
doesn't have a continuation for child1. We need to make sure to
always pull up a fragment for that child. That's what the first hunk
is about in the patch.
Second problem is the opposite problem of pushing a child into a NIF
container that already has an OC child continuation, like so:
grid-container-frag-0
OverflowList = { child1-frag-0 }
grid-container-frag-1
OverflowContinuationsList = { child1-frag-1 }
When we reflow grid-container-frag-1 we'll pull in child1-frag-0
like so:
grid-container-frag-0
...
grid-container-frag-1
PrincipalList = { child1-frag-0 }
OverflowContinuationsList = { child1-frag-1 }
This is bad since we'll consume BSize twice here. The fix is
to move it our ExcessOverflowContinuationsList instead, like so:
grid-container-frag-0
...
grid-container-frag-1
PrincipalList = { child1-frag-0 }
ExcessOverflowContinuationsList = { child1-frag-1 }
That's what the second hunk in this patch does.
2016-03-11 17:39:27 +01:00
Mats Palmgren
703a970a1e
Bug 1144096 part 17 - [css-grid] Add helper methods that add a sorted list of child frames to the Overflow and ExcessOverflowContainers child lists. r=dholbert
2016-03-11 17:39:27 +01:00
Mats Palmgren
f68bdee058
Bug 1144096 part 16 - [css-grid] Implement fragmentation. r=dholbert
2016-03-11 17:39:27 +01:00