Граф коммитов

65301 Коммитов

Автор SHA1 Сообщение Дата
Emilio Cobos Álvarez 1d8637da03 Bug 1479528: Remove FrameConstructionItem::mHasInlineEnds. r=bz
It's write-only.

Looks like this became unused in bug 501847 when we changed how ib splits work
and no longer needed this information.

Differential Revision: https://phabricator.services.mozilla.com/D2521

MozReview-Commit-ID: GDwcheP3bV4
2018-08-03 09:12:31 +02:00
Emilio Cobos Álvarez 1d122a0956 Bug 1479528: Remove FrameConstructionItem::mIsForSVGAElement. r=bz
It was needed presumably because XBL could override the tag name and what not.
But I removed that capability for elements other than XUL elements, so we can
just poke at the content directly.

Differential Revision: https://phabricator.services.mozilla.com/D2520

MozReview-Commit-ID: B5Ihu0gaNd8
2018-08-03 09:12:07 +02:00
Emilio Cobos Álvarez f7180dd264 Bug 1479528: Move all the data-finding related stuff into a single function. r=dholbert
To make it hopefully a bit easier to follow.

Differential Revision: https://phabricator.services.mozilla.com/D2564

MozReview-Commit-ID: 2LMf7IXM1kr
2018-08-03 09:11:40 +02:00
Emilio Cobos Álvarez 3af717e9ff Bug 1479528: Move the XBL binding loads a bit more away. r=dholbert
They're pretty ugly...

Differential Revision: https://phabricator.services.mozilla.com/D2563

MozReview-Commit-ID: CUDUyfe9Bgp
2018-08-03 09:11:13 +02:00
Emilio Cobos Álvarez 48b9fd1d39 Bug 1479528: Make the ShouldSuppressFrameIn* functions take references. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D2562

MozReview-Commit-ID: 8lcn1XW4aik
2018-08-03 09:10:46 +02:00
Narcis Beleuzu 4684ccf98e Merge inbound to mozilla-central. a=merge 2018-08-03 01:28:14 +03:00
Boris Zbarsky d4993da381 Bug 1476142 part 4. Remove some unnecessary QIs on window in various parts of the tree. r=kmag
The crashtest was not testing anything useful, because getInterface is no longer exposed to web content.
2018-08-02 15:26:48 -04:00
Daniel Holbert 1ecc1ef9fb Bug 1480254: Fix typo in nsLayoutUtils::MinSizeContributionForAxis to actually check the specified axis (rather than checking enum value for truthiness). r=bradwerth
Differential Revision: https://phabricator.services.mozilla.com/D2634

--HG--
extra : moz-landing-system : lando
2018-08-01 22:56:26 +00:00
Daniel Holbert 677e9015b8 Bug 1480222 part 4: Give css ErrorReporter.h an actual nsString.h include (not nsStringFwd), since it has actual nsString member-vars which need full definition. r=TYLin
Differential Revision: https://phabricator.services.mozilla.com/D2632
2018-08-01 15:21:07 -07:00
Daniel Holbert deb467f397 Bug 1480222 part 3: Add includes to fix unified bustage in ArenaRefPtrInlines.h and nsComputedDOMStyle.cpp. r=TYLin
* ArenaRefPtrInlines.h calls nsPresArena::RegisterArenaRefPtr()
  and hence needs nsPresArena.h.
* nsComputedDOMStyle.cpp calls nsCSSProps::PropHasFlags()
  and hence needs nsCSSProps.h.

Differential Revision: https://phabricator.services.mozilla.com/D2631
2018-08-01 15:09:54 -07:00
Daniel Holbert e7a333a53b Bug 1480222 part 2: Add include for RefCounted.h to some .cpp files in layout/style that use the mozilla::RefCounted type. r=TYLin
Differential Revision: https://phabricator.services.mozilla.com/D2630
2018-08-01 15:05:30 -07:00
Daniel Holbert 69bb1da9c0 Bug 1480222 part 1: Add include for ServoBindings.h to some .cpp files in layout/style, to fix various non-unified build errors about undeclared identifier 'Servo_XYZ'. r=TYLin
Differential Revision: https://phabricator.services.mozilla.com/D2629
2018-08-01 14:52:07 -07:00
Cosmin Sabou de8c2bd891 Backed out changeset 5950c9d63c3b (bug 1090497) for build bustages on several files. CLOSED TREE 2018-08-02 19:59:53 +03:00
Masatoshi Kimura feea19030c Bug 1090497 - Re-enable warnings as errors on clang-cl. r=froydnj
--HG--
extra : rebase_source : a62521fdc66def4e4d5d7bf52e68365a786b5c55
extra : source : ca1b9a2bcc4381795f556fea2fb59066567c30f3
2018-07-31 22:10:07 +09:00
Kartikaya Gupta 3bf383c2cd Bug 1474885 - Re-enable crashtests that are now passing. r=nical
MozReview-Commit-ID: 334GLtdSzF5

--HG--
extra : rebase_source : 015277f17a77b571ed50e10a5207957e4a0f2bb7
2018-08-02 10:28:15 -04:00
Noemi Erli 8f66a71e70 Merge inbound to mozilla-central. a=merge 2018-08-02 11:54:46 +03:00
dvarga 956d57e7f2 Merge mozilla-central to mozilla-inbound. a=merge CLOSED TREE 2018-08-02 01:26:29 +03:00
dvarga e487e6e564 Merge inbound to mozilla-central. a=merge 2018-08-02 01:09:38 +03:00
Emilio Cobos Álvarez 3cd323e6da Bug 1480043: Remove the concept of 'canonical' pseudos. r=xidorn
We only have this so that ::-moz-placeholder keeps serializing as
::-moz-placeholder, but I don't think anybody really cares.

Edge aliases ::-webkit-input-placeholder to ::-ms-input-placeholder at parse
time as well, as can be seen in:

```
let s = document.createElement('style');
s.innerHTML = `input::-webkit-input-placeholder { color: red };`;
document.body.appendChild(s);
document.body.innerHTML = s.sheet.cssRules[0].cssText;
```

And I think this is more consistent with what we do for CSS properties that are
aliases.

Differential Revision: https://phabricator.services.mozilla.com/D2595

MozReview-Commit-ID: 3ImDWamJhxh
2018-08-01 15:57:47 +02:00
Ryan Hunt a2d89c778c Bug 1480139 - Disable tiling on linux due to high crash rate. r=jrmuizel
We're experiencing a high volume of content crashes on linux, most likely due to
free type thread unsafety seen in bug 1477444 and 1479498. This commit disables
tiling to stop the crashes for now while we investigate further.

--HG--
extra : rebase_source : 9becf3d4c5e41eb6a30ed12008ed342663660291
extra : intermediate-source : b9b178105f1bd1d794e53c2fb128bd9e505f8f32
extra : source : d28438c3e7596af6d6e482f3b227c7cb43dbbf26
2018-08-01 11:31:11 -05:00
Brendan Dahl 6a890f9e34 Bug 1473742 - Fix printing fonts loaded with JS API. r=jfkthame
Copy over non-rule font faces to the static clone document that is used
during printing.

MozReview-Commit-ID: 8ggNrCcVpEK

--HG--
extra : rebase_source : 27e270edd28c3ecf19a99f4df5398a89e6c53e6a
2018-08-01 09:40:24 -07:00
Xidorn Quan ea042b2ab2 Bug 1478455 - Add overflow-wrap: normal for table to html.css. r=dbaron
This would fix this bug as well as webcompat/web-bugs#17900.

The argument for this to be a reasonable change is that, table cells can
never shrink below the min intrinsic size, so overflow-wrap: break-word
doesn't make any sense in table when it didn't affect intrinsic size.
So this change basically revert the behavior of bug 1472386 for tables
which seems to be the biggest problem so far.

Differential Revision: https://phabricator.services.mozilla.com/D2638

--HG--
extra : moz-landing-system : lando
2018-08-02 01:18:26 +00:00
Randall Barker 6d045ccecb Bug 1479549 Add a pref to disable double tap zooming in APZ r=botond
MozReview-Commit-ID: HK5RWuI6lIk
2018-08-01 11:25:32 -07:00
Dorel Luca a6587cb874 Merge mozilla-cental to mozilla-inbound
--HG--
rename : browser/components/payments/test/mochitest/test_labelled_checkbox.html => browser/components/payments/test/mochitest/test_completion_error_page.html
extra : rebase_source : 8549ae557dceba753101a71840a5076783bd1d36
2018-08-01 12:54:59 +03:00
Dorel Luca d0a0ae30d5 Merge mozilla-inbound to mozilla-central. a=merge 2018-08-01 12:51:56 +03:00
Emilio Cobos Álvarez 8f34c12e14 Bug 1479860: Remove unused aCompileEventHandlers argument from BindToTree. r=bz
Mostly automatic via sed. Only parts which I touched manually (apart from a
couple ones where I fixed indentation or which had mispelled arguments) are the
callers. I may have removed a couple redundant `virtual` keywords as well when
I started to do it manually, I can revert those if wanted.

Most of them are just removing the argument, but in Element.cpp I also added an
assertion for GetBindingParent when binding the ShadowRoot's kids (the binding
parent is set from the ShadowRoot constructor, and I don't think we bind a
shadow tree during unlink or what not which could cause a behavior difference).

Differential Revision: https://phabricator.services.mozilla.com/D2574

MozReview-Commit-ID: 2oIgatty2HU
2018-08-01 10:42:54 +02:00
Cameron McCormack 046bd5fe7f Bug 1475197 - Part 1: Shrink selectors::Component to 24 bytes. r=emilio
This saves about 37 KiB of memory across the UA style sheets.

MozReview-Commit-ID: EoZnlmyWwxX

--HG--
extra : rebase_source : cd8ef0ba838618f9a4583b7d9896caa3a0602199
2018-07-16 12:15:47 +10:00
Mihir Iyer f7cad8b983 Bug 1473047 - Re-resolve row-gap percentages after intrinsic block size calculated. r=dholbert
MozReview-Commit-ID: EHX1WFvqwr1

--HG--
extra : rebase_source : fb9c082c1c3f74fcc9404016343eb456cb8948ed
2018-07-24 11:38:54 -07:00
Bogdan Tara cdd4e81c41 Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-07-31 21:33:21 +03:00
Bogdan Tara b95ba78360 Merge inbound to mozilla-central. a=merge 2018-07-31 21:30:12 +03:00
Emilio Cobos Álvarez 27250792bc Bug 1479240: Make system metric queries always return false instead of not matching for fingerprinting-resistance. r=heycam
Looks like these used this mechanism for no great reason, and actually doing
this exposes trivially whether fingerprinting-resistance is enabled, which looks
like an anti-goal (if a media query parses correctly, and doesn't match either 1
or 0, then fingerprinting-resistance is enabled).

Differential Revision: https://phabricator.services.mozilla.com/D2493

MozReview-Commit-ID: 76tIIkwlpeP
2018-07-31 12:55:59 +02:00
shindli eb2f38acfb Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-07-31 13:09:14 +03:00
Emilio Cobos Álvarez 6c81e2e79c Bug 1479450: Convert GetStringValue to use Servo. r=xidorn
And remove gPropertyTable / kCSSRawProperties while at it.

Differential Revision: https://phabricator.services.mozilla.com/D2516

MozReview-Commit-ID: 8U87BcBkrJF
2018-07-31 12:05:00 +02:00
Emilio Cobos Álvarez 2996813963 Bug 1479450: Implement nsCSSProps::LookupProperty using Rust. r=xidorn
Always assume allowed-for-all-content. There are a couple callers which weren't
doing that:

 * A unit test -> removed.

 * ComputeAnimationDistance: Used for testing (in transitions_per_property), and
   for the animation inspector. The animation inspector shouldn't show
   non-enabled properties. The transitions_per_property test already relies on
   getComputedStyle stuff which only uses eForAllContent.

 * GetCSSImageURLs: I added this API for the context menu page and such. It
   doesn't rely on non-enabled-everywhere properties, it was only using
   eInChrome because it was a ChromeOnly API, but it doesn't really need this.

Differential Revision: https://phabricator.services.mozilla.com/D2514

MozReview-Commit-ID: 4VOi5Su3Bos
2018-07-31 12:00:15 +02:00
Emilio Cobos Álvarez 1ad081c136 Bug 1479681: Fix the loop in nsTransitionManager dealing with stopping `all` transitions. r=hiro
The loop was mutating the nsCSSPropertyID used to guard the exit, which is
obviously wrong.

This branch is pretty rarely taken, since people don't usually specify `all` as
a transition property other than the first, for which case we take the fast path
with `checkProperties = false`. Our test-suite failed to catch this.

Added a crashtest that hangs without this patch.

The reason bug 1478990 regressed this is because it changed the order of
nsCSSPropertyID so that `p` actually went backwards causing the infinite loop,
but the bug was introduced (by me, whoops) in bug 1309752.

Differential Revision: https://phabricator.services.mozilla.com/D2552

MozReview-Commit-ID: Ii3D1FaZ31R
2018-07-31 11:54:41 +02:00
Emilio Cobos Álvarez 196560b95f Bug 1479681: Fix the loop in nsTransitionManager dealing with stopping `all` transitions. r=hiro a=aryx
The loop was mutating the nsCSSPropertyID used to guard the exit, which is
obviously wrong.

This branch is pretty rarely taken, since people don't usually specify `all` as
a transition property other than the first, for which case we take the fast path
with `checkProperties = false`. Our test-suite failed to catch this.

Added a crashtest that hangs without this patch.

The reason bug 1478990 regressed this is because it changed the order of
nsCSSPropertyID so that `p` actually went backwards causing the infinite loop,
but the bug was introduced (by me, whoops) in bug 1309752.

Differential Revision: https://phabricator.services.mozilla.com/D2552

MozReview-Commit-ID: Ii3D1FaZ31R

--HG--
extra : source : 78be4bbf4b050f6614bb9f4115f57fb61f4890df
2018-07-31 11:32:53 +02:00
Coroiu Cristina 09c6bcc2ca Merge mozilla-central to autoland a=merge 2018-07-31 05:05:39 +03:00
Coroiu Cristina 6ba5f27325 Backed out 4 changesets (bug 1477693) for perma-failing reftests at tests/layout/reftests/svg/smil/transform/scale-1-ref.svg a=backout
Backed out changeset 069ad25949f3 (bug 1477693)
Backed out changeset 34f12e5543aa (bug 1477693)
Backed out changeset 864e12713e98 (bug 1477693)
Backed out changeset fa4d0ff6f779 (bug 1477693)
2018-07-31 05:02:33 +03:00
Miko Mynttinen df847b113a Bug 1477693 - Part 4: Add one reftest and fuzz two others r=mattwoodrow
MozReview-Commit-ID: 3xGRchvAKeC

--HG--
extra : rebase_source : 6bc45646f9d666f5d83fd0d811d7c769e06ba169
2018-07-26 00:25:08 +02:00
Miko Mynttinen 82395c69d1 Bug 1477693 - Part 3: Refactor FrameLayerBuilder invalidation functions to better handle different coordinate spaces r=mattwoodrow
MozReview-Commit-ID: 1NDcg88a1Ge

--HG--
extra : rebase_source : 97208a584e907473793fd9f4a528bc6166683ebf
2018-07-26 00:22:33 +02:00
Miko Mynttinen 222e57e271 Bug 1477693 - Part 2: Do not allow implicit cast between rect and region with InvalidatePostTransformRegion() r=mattwoodrow
MozReview-Commit-ID: LjIhBb2JjQ

--HG--
extra : rebase_source : 790d92333e2486b243afbde09875c3c9ceccf15f
2018-07-25 22:41:03 +02:00
Miko Mynttinen ca9f5b45f8 Bug 1477693 - Part 1: Move TransformClipNode and TransformWithNode functions to TransformClipNode.h r=mattwoodrow
MozReview-Commit-ID: 13uSenWdNXJ

--HG--
extra : rebase_source : cd1c6cb203bba00ece5dcae833c0c38e1f1ef322
2018-07-25 21:58:22 +02:00
Emilio Cobos Álvarez 410bea1552 No bug - Fix two typos. r=me
MozReview-Commit-ID: F8vq8l4HwCQ
2018-07-31 19:24:23 +02:00
shindli 0a48a3cd3c Backed out 3 changesets (bug 1428676) for bc failures in browser/base/content/test/static/browser_parsable_css.js on a CLOSED TREE
Backed out changeset 6ba5975115fc (bug 1428676)
Backed out changeset 7f1270a9ec3d (bug 1428676)
Backed out changeset 662bfc31a950 (bug 1428676)
2018-07-31 19:30:46 +03:00
Ryan Hunt 0992c716bf Bug 1476724 - Follow up. Mark the css-ui-invalid/**/button.html as fuzzy, not css-invalid/**/button.html. r=me
--HG--
extra : rebase_source : 2087cf1f9676d96b8b841eb914098f3dca6d5e71
extra : source : 9eeb3d73d697574708978995a26549dc73df4050
2018-07-30 10:43:57 -05:00
Miko Mynttinen f0923000a3 Bug 1479092 - Fix comments and whitespace. r=me
--HG--
extra : rebase_source : 2c76ad061319e886659b645efdac7601907050a2
2018-07-30 16:33:07 +02:00
Xidorn Quan 8421040c69 Bug 1479995 - Rename ScrollbarStyles to ScrollStyles. r=mstange
This change also renames several related functions, as well as fields,
and the header is moved into EXPORTS.mozilla given it is defined under
mozilla namespace.

MozReview-Commit-ID: LqCdcW8fmUN

--HG--
rename : layout/base/ScrollbarStyles.cpp => layout/base/ScrollStyles.cpp
rename : layout/base/ScrollbarStyles.h => layout/base/ScrollStyles.h
extra : rebase_source : 8933f3bca88d5db4b9508e3947f695ecf7511b3e
2018-08-01 16:14:26 +10:00
dvarga 09eac64963 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-08-02 01:19:44 +03:00
Daniel Holbert 23f34d63f7 Bug 1480213: Give nsMediaFeatures.h an include for nsCSSProps.h, to provide nsCSSKTableEntry type definition & fix non-unified build bustage. r=TYLin
Differential Revision: https://phabricator.services.mozilla.com/D2628

--HG--
extra : moz-landing-system : lando
2018-08-01 21:25:20 +00:00
Daniel Holbert c6ea3e98c0 Bug 1480212: Give nsCanvasFrame.cpp an #include to provide NS_NewXULElement decl, to fix non-unified builds in layout/generic. r=TYLin
Differential Revision: https://phabricator.services.mozilla.com/D2627

--HG--
extra : moz-landing-system : lando
2018-08-01 20:58:02 +00:00