4b5dec5070
Backed out changeset 0c3bb21d00d4 (bug 1675857) for multiple wpt perma failures at HTMLDialogElement. CLOSED TREE
2020-12-09 01:25:42 +02:00
335e125bcb
Bug 1675857 - Update <dialog> internal styles for spec alignment r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D99146
2020-12-08 22:29:44 +00:00
5a089f37d3
Bug 1680596 - Part 1: Hide <menuitem> behind a flag r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D98684
2020-12-08 05:36:27 +00:00
c405a6ab26
Backed out changeset 29bbd5887d66 (bug 1680951) for failure on browser_blockingCookies.js. CLOSED TREE
2020-12-08 14:46:48 +02:00
f7757cbe10
Bug 1680951 - Do not scroll when calling select() r=masayuki
...
This is intended to be a hotfix for the URL bar regression. Ideally there should be a spec or this behavior should be removed completely.
Previously select() scrolled back to the start position before the regression, but this fix does not restore that behavior.
Differential Revision: https://phabricator.services.mozilla.com/D98972
2020-12-08 07:52:07 +00:00
48ced6860f
Backed out 2 changesets (bug 1680596) for xpcshell and mochitest plain failures. CLOSED TREE
...
Backed out changeset a5fce6a4b5b9 (bug 1680596)
Backed out changeset 8ea7d760b4a8 (bug 1680596)
2020-12-07 22:02:46 +02:00
27e4755fb2
Bug 1680596 - Move the pref at the begining of the manifest. a=trivial-fix CLOSED TREE
2020-12-07 21:25:33 +02:00
5b5178d70c
Bug 1680596 - Hide <menuitem> behind a flag r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D98684
2020-12-07 17:03:27 +00:00
1c53236b70
Bug 1679272 - Include ScopeExit.h exactly where used. r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D98888
2020-12-07 14:25:59 +00:00
007e18402d
Backed out changeset 18c139fe8859 (bug 1675894) for selectionchange.tentative.html failures CLOSED TREE
2020-12-05 14:45:37 +02:00
a8b38a9593
Bug 1680548 - Cache the max length in TextControlState::SelectionProperties r=masayuki
...
GetValue() is not a cheap operation, and this allows to skip it in SetSelectionRange.
Differential Revision: https://phabricator.services.mozilla.com/D98659
2020-12-05 09:34:59 +00:00
a32cbcf59f
Backed out changeset b9fa2c214287 (bug 1680548) for multiple mochitest failures
2020-12-05 10:52:56 +02:00
5cae826a74
Bug 1680798 - Assign forward selection in Select() before bug 1541454 r=masayuki
...
Differential Revision: https://phabricator.services.mozilla.com/D98823
2020-12-05 07:47:50 +00:00
0ee9083699
Bug 1675894 - Fire selectionchange from disconnected text controls r=masayuki
...
Differential Revision: https://phabricator.services.mozilla.com/D98810
2020-12-05 07:50:41 +00:00
551f1c01d0
Bug 1680548 - Cache the max length in TextControlState::SelectionProperties r=masayuki
...
GetValue() is not a cheap operation, and this allows to skip it in SetSelectionRange.
Differential Revision: https://phabricator.services.mozilla.com/D98659
2020-12-05 07:34:41 +00:00
dbc93934c8
Backed out changeset 651187869807 (bug 1680548) for causing valgrid bustages in nsTextControlFrame.
2020-12-05 03:15:59 +02:00
4379c3417b
Bug 1680548 - Cache the max length in TextControlState::SelectionProperties r=masayuki
...
GetValue() is not a cheap operation, and this allows to skip it in SetSelectionRange.
Differential Revision: https://phabricator.services.mozilla.com/D98659
2020-12-04 22:19:33 +00:00
1e9bd44120
Bug 1680167 - Part 2: MOZ_CAN_RUN_SCRIPT in dom/html r=masayuki
...
Differential Revision: https://phabricator.services.mozilla.com/D98625
2020-12-03 22:15:56 +00:00
628b4518df
Bug 1667743 - Remove unused esni code r=necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D98023
2020-12-03 12:17:12 +00:00
aa1ea75c3a
Bug 1679460 - Call Get/SetSelectionRange even when cached r=masayuki
...
No need to special case here as both already use cached selection. This makes it consistent with SetSelectionStart etc.
Differential Revision: https://phabricator.services.mozilla.com/D98185
2020-12-02 19:26:49 +00:00
a2aec71886
Bug 1679461 - Use SetSelectionRange in Select(), regardless of focus state r=masayuki
...
SelectAll() also is no-op without a frame, so this replaces it with SetSelectionRange.
Differential Revision: https://phabricator.services.mozilla.com/D98184
2020-12-02 19:27:19 +00:00
520f54fb37
Backed out changeset 117da9de7f66 (bug 1667743) for handshakeSucceeded related bustage CLOSED TREE
2020-12-03 03:44:59 +02:00
14d936a94d
Bug 1667743 - Remove unused esni code r=necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D98023
2020-12-02 23:18:38 +00:00
225a24f0bc
Backed out 3 changesets (bug 1677263, bug 1679460, bug 1679461) for test_focus.xhtml failures CLOSED TREE
...
Backed out changeset 03db12dabc63 (bug 1677263)
Backed out changeset 75de13448090 (bug 1679460)
Backed out changeset 4f4fd8e7ce93 (bug 1679461)
2020-12-02 21:16:28 +02:00
3a7f9322e4
Bug 1679460 - Call Get/SetSelectionRange even when cached r=masayuki
...
No need to special case here as both already use cached selection. This makes it consistent with SetSelectionStart etc.
Differential Revision: https://phabricator.services.mozilla.com/D98185
2020-12-02 02:21:13 +00:00
b581a12705
Bug 1679461 - Use SetSelectionRange in Select(), regardless of focus state r=masayuki
...
SelectAll() also is no-op without a frame, so this replaces it with SetSelectionRange.
Differential Revision: https://phabricator.services.mozilla.com/D98184
2020-12-02 02:16:52 +00:00
a0c580e9a2
Bug 1676785 - Simplify XUL special code-path for <input> value setter. r=masayuki
...
This allows us to remove nsISelectionController.selectAll() and related
code too, and should not change behavior.
Differential Revision: https://phabricator.services.mozilla.com/D97011
2020-12-02 12:48:41 +00:00
89a2d40ee0
Backed out changeset 93cf5f317f98 (bug 1676785) for causing mochitest failures in test_input_value_set_preserve_undo.xhtml
...
CLOSED TREE
2020-12-02 14:05:18 +02:00
2b6c54e6c1
Bug 1676785 - Simplify XUL special code-path for <input> value setter. r=masayuki
...
This allows us to remove nsISelectionController.selectAll() and related
code too, and should not change behavior.
Differential Revision: https://phabricator.services.mozilla.com/D97011
2020-12-02 10:44:25 +00:00
457daf9cf7
Bug 1679456 - Disable external-protocol-blocking bypass timer in Nightly. r=smaug,edgar
...
As the use case we know it was needed for should be covered by the previous
patch as well.
This is also process-global, which is a bit odd, given whether a popup-opening
operation succeeds ends up depending on other tabs' activity.
Depends on D98020
Differential Revision: https://phabricator.services.mozilla.com/D98021
2020-11-30 16:18:35 +00:00
106b693662
Bug 1679456 - Use transient user activation for iframe external protocol blocking. r=smaug,edgar
...
I think this allows us to remove TryUsePopupOpeningToken (which is a similar
concept to consuming user activation), and also the ad-hoc <iframe> timing
thing we have from bug 1514547, which should be covered by the user activation
timeout.
Depends on D97640
Differential Revision: https://phabricator.services.mozilla.com/D98020
2020-11-30 16:16:41 +00:00
debb6b0fa5
Bug 1678389 - Use transient user activation for <input> file/color picker. r=edgar,smaug
...
This matches other browsers, see [1], and should fix this and other
similar bugs like bug 1610726.
[1]: https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/html/forms/file_input_type.cc;l=163;drc=8a5de62dd01360cfe3d150640d3ff4d974bbe842
Differential Revision: https://phabricator.services.mozilla.com/D97640
2020-11-30 16:00:02 +00:00
60d64f402a
Bug 1388764 - Re-enable test_object_nav.html and 508908-1.xhtml; r=jmaher
...
Re-enable tests previously disabled by this bug, for intermittent crashes.
Differential Revision: https://phabricator.services.mozilla.com/D97929
2020-11-30 12:03:27 +00:00
d0517b5353
Bug 1678580 - Check file picker result for errors before showing ConfirmFolderUpload prompt. r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D97755
2020-11-26 10:54:22 +00:00
ee949b8e10
Bug 1678374 - Reduce dependencies on js, in particular on jsfriendapi.h. r=jandem
...
Differential Revision: https://phabricator.services.mozilla.com/D97617
Depends on D97616
2020-11-23 16:12:19 +00:00
94b0165df6
Bug 1678374 - Avoid including js/RootingAPI.h from header files. r=jandem
...
Differential Revision: https://phabricator.services.mozilla.com/D97616
Depends on D97467
2020-11-23 16:12:12 +00:00
dd80614fa0
Bug 1678062 - Remove unnecessary includes. r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D97467
Depends on D96561
2020-11-23 16:12:02 +00:00
f15895390e
Bug 1673931 - Avoid including Element.h from header files.
...
Differential Revision: https://phabricator.services.mozilla.com/D96535
Depends on D96534
2020-11-23 16:08:40 +00:00
5bfbb2a572
Bug 1673931 - Avoid including Document.h from header files. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D95046
Depends on D95045
2020-11-23 16:07:43 +00:00
971b645fe3
Bug 1660470 - Add missing include directives/forward declarations. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D87865
2020-11-23 16:21:38 +00:00
e52ab350ac
Backed out changeset b21f364898eb (bug 1678389) for causing Android gv-unit failures CLOSED TREE
2020-11-22 04:24:23 +02:00
ec7eb5b86a
Bug 1678389 - Use transient user activation for <input> file/color picker. r=edgar
...
This matches other browsers, see [1], and should fix this and other
similar bugs like bug 1610726.
[1]: https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/html/forms/file_input_type.cc;l=163;drc=8a5de62dd01360cfe3d150640d3ff4d974bbe842
Differential Revision: https://phabricator.services.mozilla.com/D97640
2020-11-22 00:20:03 +00:00
20a5d55af7
Bug 1674829 - part1 : dispatch 'MozNoControlsBlockedVideo' to video control. r=Gijs
...
When autoplay media gets blocked, dispatch `MozNoControlsBlockedVideo` event to video control in order to show `click-to-play` icon.
Differential Revision: https://phabricator.services.mozilla.com/D97505
2020-11-19 17:31:13 +00:00
5d2e319a03
Bug 1338637 - Ask user for confirmation before folder upload. r=Gijs,geckoview-reviewers,baku
...
Differential Revision: https://phabricator.services.mozilla.com/D95324
2020-11-17 17:15:51 +00:00
19e7a1a22f
Bug 1673509 - part3 : stop controlled media when it unbind from DOM tree. r=chunmin
...
When we remove the media from DOM tree, we should not only pause it but also stop controlling it.
Differential Revision: https://phabricator.services.mozilla.com/D95359
2020-11-19 00:33:26 +00:00
187eebabe6
Bug 1675349: Update tests under dom/html/test for the removal of plugins. r=jmathies
...
UPDATED
-------
dom/html/test/test_object_plugin_nav.html
Test focus behavior around <object> element.
Rename to test_object_nav.html and switch to use image/png instead of application/x-test (test plugin)
dom/html/test/test_fullscreen-api.html
Test fullscreen, including in the context of a plugin.
Remove plugin portion of test and the "skip" list that was added to allow headless/linux tests to skip only the plugin part due to bugs 1409805 and 1330553.
REMOVED
-------
dom/html/test/test_iframe_sandbox_plugins.html
Test that `sandbox` attribute on iframe blocks/loads plugins correctly
Differential Revision: https://phabricator.services.mozilla.com/D95909
2020-11-18 15:57:45 +00:00
3ad73d34d7
Bug 1675349: Forbid elements representing blocked plugins from accepting focus r=jmathies
...
As part of the fallback for unsupported plugin elements, we deny them focus. Since elements can be programmatically changed, and object/embed elements can change internal "type" by updating their data/src attributes, and because that type is decided asynchronously, we may need to give up focus if our element has it.
Differential Revision: https://phabricator.services.mozilla.com/D95903
2020-11-18 15:55:52 +00:00
bebb9f9181
Bug 1519636 - Reformat with clang-format-11 to the Google coding style r=andi,sg,geckoview-reviewers,snorp
...
It is bringing some minor changes
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D90795
2020-11-18 09:05:59 +00:00
56346a0425
Backed out 19 changesets (bug 1675349) for lint failures on browser_ext_browsingData_pluginData and test_archive CLOSED TREE
...
Backed out changeset 244e0f2b410c (bug 1675349)
Backed out changeset ba5724069dd4 (bug 1675349)
Backed out changeset 37fca259c7e9 (bug 1675349)
Backed out changeset f2b16caca1fc (bug 1675349)
Backed out changeset 28835d4935be (bug 1675349)
Backed out changeset eb913f58953a (bug 1675349)
Backed out changeset 19e3cb80f469 (bug 1675349)
Backed out changeset d9723f3a3a7e (bug 1675349)
Backed out changeset c888dfcdf70e (bug 1675349)
Backed out changeset 48f153341af6 (bug 1675349)
Backed out changeset 7fc67a9b2932 (bug 1675349)
Backed out changeset 1cee4d97f801 (bug 1675349)
Backed out changeset 59a0cb79c7c1 (bug 1675349)
Backed out changeset 43d349fa37b1 (bug 1675349)
Backed out changeset c84bfb6eae59 (bug 1675349)
Backed out changeset 38e9af69ae57 (bug 1675349)
Backed out changeset 3255c1ab3059 (bug 1675349)
Backed out changeset 2f3eaf9c342c (bug 1675349)
Backed out changeset 769e5c0db4c2 (bug 1675349)
2020-11-18 06:06:36 +02:00
c17667a467
Bug 1675349: Update tests under dom/html/test for the removal of plugins. r=jmathies
...
UPDATED
-------
dom/html/test/test_object_plugin_nav.html
Test focus behavior around <object> element.
Rename to test_object_nav.html and switch to use image/png instead of application/x-test (test plugin)
dom/html/test/test_fullscreen-api.html
Test fullscreen, including in the context of a plugin.
Remove plugin portion of test and the "skip" list that was added to allow headless/linux tests to skip only the plugin part due to bugs 1409805 and 1330553.
REMOVED
-------
dom/html/test/test_iframe_sandbox_plugins.html
Test that `sandbox` attribute on iframe blocks/loads plugins correctly
Differential Revision: https://phabricator.services.mozilla.com/D95909
2020-11-18 03:12:41 +00:00
Razvan Maries
Sean Feng
Kagami Sascha Rosylight
Butkovits Atila
Cosmin Sabou
Simon Giesecke
Bogdan Tara
Mihai Alexandru Michis
Kershaw Chang
Emilio Cobos Álvarez
Geoff Brown
pbz
Noemi Erli
alwu
David Parks
Sylvestre Ledru