There's only one method that is used, and we never need to create any
instances of the object, so turn it into a single method.
Depends on D5592
Differential Revision: https://phabricator.services.mozilla.com/D5593
--HG--
extra : moz-landing-system : lando
There's no state on the object, so all of the methods can be turned
into static methods in the CPP files. I leave the one public method,
Sort, alone for simplicity. The internal data structure definitions
also don't need to be publicly exposed.
This patch is a bit messy because I had to rearrange methods so they
were defined before they were used. This makes the resulting code a
little nicer (as compared to forward declaring methods), but makes the
VCS history worse.
Depends on D5591
Differential Revision: https://phabricator.services.mozilla.com/D5592
--HG--
extra : moz-landing-system : lando
This is only used in a single place, so having a service for it is overkill.
Differential Revision: https://phabricator.services.mozilla.com/D5591
--HG--
extra : moz-landing-system : lando
- sort-statics-last is no longer meaningful now non-static (ie template) items don't exist
- we don't use the 'resource' attribute anywhere in XUL.
- sortResource/sortResource2 are unused.
- we don't have meaningful consumers for sortSeparators
MozReview-Commit-ID: C31vC9MCrDo
--HG--
extra : rebase_source : 539fd84201eaeead62ac73b3213bfdf6f4333e9a