Emilio Cobos Álvarez
011d524740
Bug 1646336 - Don't unnecessarily lose precision in nsComputedDOMStyle. r=hiro
...
We're converting to nscoord in some places unnecessarily, reducing the
precision of the computed value we return.
This makes some tests unnecessarily fail if we change the base of
nscoord.
Differential Revision: https://phabricator.services.mozilla.com/D79996
2020-06-18 00:42:47 +00:00
Brindusan Cristian
f93d2c823e
Backed out changeset 2011f0091ccf (bug 1646336) for dt failures at browser_accessibility_print_to_json.js. CLOSED TREE
2020-06-18 03:17:34 +03:00
Emilio Cobos Álvarez
24a7deb2a4
Bug 1646336 - Don't unnecessarily lose precision in nsComputedDOMStyle. r=hiro
...
We're converting to nscoord in some places unnecessarily, reducing the
precision of the computed value we return.
This makes some tests unnecessarily fail if we change the base of
nscoord.
Differential Revision: https://phabricator.services.mozilla.com/D79996
2020-06-17 22:30:14 +00:00
Nicklas Boman
4f2fa0cfa7
Bug 1515419 - fixing ToNewCString (and ToNewUnicode as well) xpcom/string/nsReadableUtils.cpp r=froydnj,necko-reviewers,valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D17411
2020-05-17 06:58:48 +00:00
Emilio Cobos Álvarez
54cc92c94d
Bug 1617472 - Remove nsCSSKeywords and related infrastructure. r=heycam
...
Seeya
Depends on D63795
Differential Revision: https://phabricator.services.mozilla.com/D63796
--HG--
extra : moz-landing-system : lando
2020-02-24 13:30:48 +00:00
Boris Zbarsky
3d4c7db0aa
Bug 1614165 part 2. Improve some error messages in style code. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D62155
--HG--
extra : moz-landing-system : lando
2020-02-09 03:40:48 +00:00
Sylvestre Ledru
265e672179
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Emilio Cobos Álvarez
40b1e83d81
Bug 1498734 - Always compute angle values to degrees. r=xidorn
...
This matches the spec, https://drafts.csswg.org/css-values/#angles , which says:
> All <angle> units are compatible, and deg is their canonical unit.
And https://drafts.csswg.org/css-values/#compat , which says:
>When serializing computed values [...], compatible units [...] are converted into a single canonical unit.
And also other implementations (Blink always serializes angles as degrees in
computed style for example).
Also allows us to get rid of quite a bit of code, and makes computed angle value
representation just a number, which is nice.
Differential Revision: https://phabricator.services.mozilla.com/D8619
--HG--
extra : moz-landing-system : lando
2018-10-13 00:41:03 +00:00
Emilio Cobos Álvarez
1b0a0261a1
Bug 1494622 - Simplify CSSValue and co a bit more. r=xidorn
...
Just remove the useless stuff.
Differential Revision: https://phabricator.services.mozilla.com/D7071
2018-09-27 16:11:45 +02:00
Emilio Cobos Álvarez
b4bba4d593
Bug 1494622 - Remove nsDOMCSSRect. r=xidorn
...
Differential Revision: https://phabricator.services.mozilla.com/D7070
2018-09-27 16:11:44 +02:00
Emilio Cobos Álvarez
864a303a8c
Bug 1494622 - Remove nsDOMCSSRGBColor. r=xidorn
...
Differential Revision: https://phabricator.services.mozilla.com/D7068
2018-09-27 16:11:42 +02:00
Ting-Yu Lin
74992134e1
Bug 1482665 Part 3 - Remove nsPresContext::AppUnitsPerCSSInch() and replace it with mozilla::AppUnitsPerCSSInch(). r=dholbert
...
Differential Revision: https://phabricator.services.mozilla.com/D3156
2018-08-13 14:29:29 -07:00
Emilio Cobos Álvarez
b293adf1cf
Bug 1459871: Remove other getPropertyCSSValue-related interfaces. r=bz
...
I can land the removal behind a pref first if you want and all that instead.
Again, this doesn't remove the internal usage for getComputedStyle (yet).
MozReview-Commit-ID: LA157ohfLhu
2018-05-15 14:05:13 +02:00
Chris Peterson
71422dcaa9
Bug 1457813 - Part 2: Replace non-asserting NS_PRECONDITIONs with MOZ_ASSERTs. r=froydnj
...
s/NS_PRECONDITION/MOZ_ASSERT/ and reindent
MozReview-Commit-ID: KuUsnVe2h8L
--HG--
extra : source : c14655ab3df2c9b1465dd8102b9d25683359a37b
2018-04-28 12:50:58 -07:00
Daniel Holbert
10b8b4cdb3
Bug 1437723: Preemptively fix unified bustage in layout/style by adding missing includes/namespaces/forward-decls. r=emilio
...
MozReview-Commit-ID: 8ljZkAqgT4N
--HG--
extra : rebase_source : bea400511aa6c6c10e76c8418d6dfc8df2b31d17
2018-02-12 16:53:44 -08:00
Cameron McCormack
6716a7e0eb
Bug 1427512 - Part 28: Remove nsIDOMCSSValue. r=xidorn,bz
...
MozReview-Commit-ID: 6DasjoMa6C8
2018-01-11 16:17:57 +08:00
Cameron McCormack
66141a0c03
Bug 1427512 - Part 27: Remove nsIDOMCSSPrimitiveValue. r=xidorn,bz
...
MozReview-Commit-ID: IcGKAjPWacZ
2018-01-11 16:17:57 +08:00
Cameron McCormack
3c29060132
Bug 1427512 - Part 25: Remove nsIDOMRect. r=xidorn,bz
...
Although this is changing nsIDOMCSSPrimitiveValue, that interface will
go away a couple of patches later.
MozReview-Commit-ID: GSisnYWZhHy
2018-01-11 16:17:57 +08:00
Cameron McCormack
eb5c3b0f3a
Bug 1427512 - Part 23: Remove nsIDOMCounter. r=xidorn,bz
...
It's not actually implemented. Since we never return any Counter
object, and to avoid exposing a Counter Web IDL interface object, we
declare getCounterValue() to return void (since it always throws).
MozReview-Commit-ID: JGvYtPmyeSp
2018-01-11 16:17:57 +08:00
Olli Pettay
0364dbc792
Bug 1326507, remove NS_IMPL_CYCLE_COLLECTION_TRAVERSE_SCRIPT_OBJECTS, r=mccr8
...
--HG--
extra : rebase_source : 3ae1207308de120b7299b13ecaa95dd1612b3459
2017-01-03 21:47:55 +02:00
Nicholas Nethercote
f4ec41d9b5
Bug 1297300 - Add missing checks to GetSpec() calls in layout/. r=dholbert,heycam.
...
--HG--
extra : rebase_source : b3a26866746cde4337f5ffeff94f370b2eb7da3e
2016-08-31 20:10:10 +10:00
Chris Peterson
b175c9fdd5
Bug 1277106 - Part 2: Expand MOZ_UTF16() strings to u"" string literals. r=Waldo
2016-07-20 22:03:25 -07:00
Cameron McCormack
ff6a816c75
Bug 1238403 - Fix inconsistent indenting in layout/style/. r=xidorn
2016-01-11 10:28:35 +11:00
Boris Zbarsky
1540774b0c
Bug 1157898 part 1. Make code of the form "return rv.ErrorCode();" where rv is an ErrorResult use StealNSResult instead. r=peterv
...
This patch was generated with the following command:
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 's/return ([a-zA-Z0-9]+)\.ErrorCode\(\);/return \1.StealNSResult();/'
2015-04-27 09:18:51 -04:00
Mike Hommey
b077d9624d
Bug 1134920 - Use moz_xmalloc/moz_xrealloc/free instead of nsMemory::Alloc/Realloc/Free. r=nfroyd
2015-04-01 13:51:45 +09:00
Boris Zbarsky
dc24477d79
Bug 1117172 part 3. Change the wrappercached WrapObject methods to allow passing in aGivenProto. r=peterv
...
The only manual changes here are to BindingUtils.h, BindingUtils.cpp,
Codegen.py, Element.cpp, IDBFileRequest.cpp, IDBObjectStore.cpp,
dom/workers/Navigator.cpp, WorkerPrivate.cpp, DeviceStorageRequestChild.cpp,
Notification.cpp, nsGlobalWindow.cpp, MessagePort.cpp, nsJSEnvironment.cpp,
Sandbox.cpp, XPCConvert.cpp, ExportHelpers.cpp, and DataStoreService.cpp. The
rest of this diff was generated by running the following commands:
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapObjectInternal\(JSContext *\* *(?:aCx|cx|aContext|aCtx|js))\)/\1, JS::Handle<JSObject*> aGivenProto)/g'
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapObjectInternal\((?:aCx|cx|aContext|aCtx|js))\)/\1, aGivenProto)/g'
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapNode\(JSContext *\* *(?:aCx|cx|aContext|aCtx|js))\)/\1, JS::Handle<JSObject*> aGivenProto)/g'
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapNode\((?:aCx|cx|aContext|aCtx|js))\)/\1, aGivenProto)/g'
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapObject\(JSContext *\* *(?:aCx|cx|aContext|aCtx|js))\)/\1, JS::Handle<JSObject*> aGivenProto)/g'
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(Binding(?:_workers)?::Wrap\((?:aCx|cx|aContext|aCtx|js), [^,)]+)\)/\1, aGivenProto)/g'
2015-03-19 10:13:33 -04:00
Peter Van der Beken
dcda2ba9bb
Bug 1078744 - Replace SetIsDOMBinding with SetIsNonDOMBinding, remove nsWrapperCache::SetIsDOMBinding. r=bz.
...
--HG--
extra : rebase_source : 89c476cd9436530b2df5acc903909e34188417a0
2014-10-07 11:44:49 +02:00
Andrew McCreight
cbe6fbf039
Bug 1029140 - Make the destructor of nsROCSSPrimitiveValue private. r=bz
2014-06-26 09:29:05 -07:00
Neil Rashbrook
ef8d375d0b
Bug 869836 - Part 9a: Use AssignLiteral(MOZ_UTF16(...)) instead of Assign(NS_LITERAL_STRING(...)). r=ehsan
...
Relading with correct bug number so DONTBUILD.
--HG--
extra : amend_source : 6e05de7729c27761564124212b7d4cbe3318e482
2014-05-26 21:54:10 +03:00
Birunthan Mohanathas
7ed88d413a
Backout 8b8bbe7aa1cc due to wrong bug number
2014-05-27 14:42:13 +03:00
Neil Rashbrook
71828ecc1c
Bug 995730 - Part 9a: Use AssignLiteral(MOZ_UTF16(...)) instead of Assign(NS_LITERAL_STRING(...)). r=ehsan
...
--HG--
extra : rebase_source : d2d3d611c06a2a7ec930fb11576d7c8335c0a6e2
2014-05-26 21:54:10 +03:00
Birunthan Mohanathas
952b834c76
Bug 869836 - Part 9: Use AssignLiteral instead of `Assign(NS_LITERAL_STRING(...))`. r=ehsan
2014-05-22 06:48:52 +03:00
Birunthan Mohanathas
0e6f3a6562
Bug 869836 - Part 3: Use `Append('c')` instead of `AppendLiteral("c")`. r=ehsan
2014-05-22 06:48:51 +03:00
Birunthan Mohanathas
19bebbc68d
Bug 869836 - Part 2: Use AppendLiteral instead of `Append(NS_LITERAL_STRING(...))`. r=ehsan
2014-05-22 06:48:50 +03:00
Boris Zbarsky
79dab91ff6
Bug 991742 part 8. Remove the "aScope" argument of WebIDL/nsWrapperCache WrapObject() methods. r=bholley
...
This patch was mostly generated with the following command:
find . -name "*.h" -o -name "*.cpp" | xargs sed -e '/WrapObject(JSContext/ {; N; s/\(WrapObject(JSContext *\* *a\{0,1\}[Cc]x\),\n\{0,1\} *JS::Handle<JSObject\*> a\{0,1\}[sS]cope/\1/ ; }' -i ""
and then reverting the changes that made to
dom/bindings/BindingUtils.h, since those WrapObject methods are not
the ones we're trying to change here, plus a bunch of manual fixups
for cases that this command did not catch (including all the callsites
of WrapObject()).
2014-04-08 18:27:18 -04:00
Boris Zbarsky
d4bd64ee2c
Bug 991742 part 6. Remove the "aScope" argument of binding Wrap() methods. r=bholley
...
This patch was mostly generated with this command:
find . -name "*.h" -o -name "*.cpp" | xargs sed -e 's/Binding::Wrap(aCx, aScope, this/Binding::Wrap(aCx, this/' -e 's/Binding_workers::Wrap(aCx, aScope, this/Binding_workers::Wrap(aCx, this/' -e 's/Binding::Wrap(cx, scope, this/Binding::Wrap(cx, this/' -i ""
plus a few manual fixes to dom/bindings/Codegen.py, js/xpconnect/src/event_impl_gen.py, and a few C++ files that were not caught in the search-and-replace above.
2014-04-08 18:27:17 -04:00
L. David Baron
ce2d7b005c
Bug 470769 - Store computed styles of integer-valued properties as integers in nsROCSSPrimitiveValue, so they round-trip correctly. r=bzbarsky
2014-03-29 09:29:30 -07:00
Ehsan Akhgari
1b83407ce9
Bug 927728 - Part 1: Replace PRUnichar with char16_t; r=roc
...
This patch was automatically generated by the following script:
#!/bin/bash
# Command to convert PRUnichar to char16_t
function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
! -wholename "*security/nss*" \
! -wholename "*modules/libmar*" \
! -wholename "*/.hg*" \
! -wholename "obj-ff-dbg*" \
! -name prtypes.h \
! -name Char16.h \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert PRUnichar char16_t
2014-01-04 10:02:17 -05:00
Jon Coppeard
5d2c44915e
Bug 932102 - Fix rooting hazard in nsStyleUtil::AppendAngleValue r=dbaron
2013-11-21 01:00:57 +00:00
Ms2ger
1a5ae526d9
Bug 901323 - Don't include nsContentUtils.h unnecessarily; r=jlebar
2013-08-14 08:56:21 +02:00
Mike Hommey
2e729aa83d
Bug 881323 - Re-implement CycleCollectorParticipant with actual vtables, with constexpr to avoid static initializers. r=mccr8
2013-08-02 10:29:05 +09:00
Dirk Schulze
569ef7a7ef
Bug 897392 - Implement parsing of filter:hue-rotate(). r=heycam
2013-07-26 16:02:33 +10:00
Boris Zbarsky
b834439797
Bug 864727 part 5. Make all the WrapObject methods take a handle for the scope object. r=ms2ger
2013-04-25 12:29:54 -04:00
Masatoshi Kimura
23ba391ec1
Bug 848339 - Remove the vestigial boolean outparam from nsWrapperCache::WrapObject. r=bz
2013-03-12 08:03:47 +09:00
David Zbarsky
3250bd906e
[Bug 847110] Fix up includes in layout/style r=dbaron
2013-03-02 19:31:48 -05:00
Trevor Saunders
83bcbe0d6b
bug 822289 - remove NS_IMPL_CYCLE_COLLECTION_CLASS and friends r=mccr8
2013-01-12 07:40:33 -05:00
Trevor Saunders
e6efa7865a
bug 824970 - nsROCSSPrimitiveValue::GetRectValue() should return nsDOMCSSRect* r=bz
2012-12-26 12:02:37 -05:00
Trevor Saunders
fec9d2daa0
bug 824970 - use webidl for Rect r=bz
2012-12-26 07:26:36 -05:00
Trevor Saunders
d36283408c
bug 824970 - store nsDOMCSSRect* in nsROCSSPrimitiveValue r=bz
2012-12-25 22:01:06 -05:00
Trevor Saunders
95e78e74f1
bug 821593 - remove nsIDOMCSSPrimitiveValue:::GetRGBColor() r=bz
2012-12-14 04:18:40 -05:00