34dcc7b852
Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm.
...
This change avoids lots of false positives for Coverity's CHECKED_RETURN
warning, caused by NS_WARN_IF's current use in both statement-style and
expression-style.
In the case where the code within the NS_WARN_IF has side-effects, I made the
following change.
> NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
> -->
> Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
In the case where the code within the NS_WARN_IF lacks side-effects, I made the
following change.
> NS_WARN_IF(!condWithoutSideEffects);
> -->
> NS_WARNING_ASSERTION(condWithoutSideEffects, "msg");
This has two improvements.
- The condition is not evaluated in non-debug builds.
- The sense of the condition is inverted to the familiar "this condition should
be true" sense used in assertions.
A common variation on the side-effect-free case is the following.
> nsresult rv = Fn();
> NS_WARN_IF_(NS_FAILED(rv));
> -->
> DebugOnly<nsresult rv> = Fn();
> NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed");
--HG--
extra : rebase_source : 58788245021096efa8372a9dc1d597a611d45611
2016-09-02 17:12:24 +10:00
5bf9de08f0
Bug 1295570 - Entries API - part 7 - Split WebIDL files, r=smaug
2016-08-18 09:19:41 +02:00
87b1535dbc
Bug 1295570 - Entries API - part 6 - Rename Entries Callbacks, r=smaug
2016-08-18 09:19:15 +02:00
8fb5264eef
Bug 1295570 - Entries API - part 5 - Rename DirectoryReader to FileSystemDirectoryReader, r=smaug
...
--HG--
rename : dom/filesystem/compat/DirectoryReader.cpp => dom/filesystem/compat/FileSystemDirectoryReader.cpp
rename : dom/filesystem/compat/DirectoryReader.h => dom/filesystem/compat/FileSystemDirectoryReader.h
rename : dom/filesystem/compat/RootDirectoryReader.cpp => dom/filesystem/compat/FileSystemRootDirectoryReader.cpp
rename : dom/filesystem/compat/RootDirectoryReader.h => dom/filesystem/compat/FileSystemRootDirectoryReader.h
2016-08-18 09:18:51 +02:00
de09eb6947
Bug 1295570 - Entries API - part 4 - Rename DirectoryEntry to FileSystemDirectoryEntry, r=smaug
...
--HG--
rename : dom/filesystem/compat/DirectoryEntry.cpp => dom/filesystem/compat/FileSystemDirectoryEntry.cpp
rename : dom/filesystem/compat/DirectoryEntry.h => dom/filesystem/compat/FileSystemDirectoryEntry.h
rename : dom/filesystem/compat/RootDirectoryEntry.cpp => dom/filesystem/compat/FileSystemRootDirectoryEntry.cpp
rename : dom/filesystem/compat/RootDirectoryEntry.h => dom/filesystem/compat/FileSystemRootDirectoryEntry.h
2016-08-18 09:18:05 +02:00
e06457dcf2
Bug 1295570 - Entries API - part 3 - Rename FileEntry to FileSystemFileEntry, r=smaug
...
--HG--
rename : dom/filesystem/compat/FileEntry.cpp => dom/filesystem/compat/FileSystemFileEntry.cpp
rename : dom/filesystem/compat/FileEntry.h => dom/filesystem/compat/FileSystemFileEntry.h
2016-08-18 09:17:48 +02:00
94d10aeb4c
Bug 1295570 - Entries API - part 2 - Rename Entry to FileSystemEntry, r=smaug
...
--HG--
rename : dom/filesystem/compat/Entry.cpp => dom/filesystem/compat/FileSystemEntry.cpp
rename : dom/filesystem/compat/Entry.h => dom/filesystem/compat/FileSystemEntry.h
2016-08-18 09:17:25 +02:00
f0c18d080e
Bug 1295570 - Entries API - part 1 - Rename DOMFileSystem to FileSystem, r=smaug
...
--HG--
rename : dom/filesystem/compat/DOMFileSystem.cpp => dom/filesystem/compat/FileSystem.cpp
rename : dom/filesystem/compat/DOMFileSystem.h => dom/filesystem/compat/FileSystem.h
rename : dom/webidl/DOMFileSystem.webidl => dom/webidl/FileSystem.webidl
2016-08-18 09:17:02 +02:00
47a98b8ad1
Bug 1289255 - Implement DataTransferItem.webkitGetAsEntry, r=baku
...
--HG--
extra : rebase_source : 10517eeb5b5a68204514527c8a904ab216df6534
2016-07-29 14:42:33 +03:00
5538d692d3
Bug 1286877 - do not set c-basic-offset for python-mode; r=gps
...
This removes the unnecessary setting of c-basic-offset from all
python-mode files.
This was automatically generated using
perl -pi -e 's/; *c-basic-offset: *[0-9]+//'
... on the affected files.
The bulk of these files are moz.build files but there a few others as
well.
MozReview-Commit-ID: 2pPf3DEiZqx
--HG--
extra : rebase_source : 0a7dcac80b924174a2c429b093791148ea6ac204
2016-07-14 10:16:42 -06:00
f01e7c5de3
Bug 1287169 - Fix intermittent failure in test_no_dnd.html, r=smaug
2016-07-16 08:29:31 +02:00
3ef20ed60c
Bug 1186932 - Implement support for form submission of a picked directory - part 5 - preferences enabled for testing, r=smaug
2016-07-14 09:03:35 +02:00
f8488defb9
Bug 1186932 - Implement support for form submission of a picked directory - part 3 - tests + fixes, r=smaug
2016-07-14 09:02:30 +02:00
fca8c62260
Bug 1281545 - FileSystem Blink API tests should remove the test directory, r=smaug
2016-06-23 09:49:34 +02:00
2a437d0c90
Bug 1265767 - Subset of Blink FileSystem API - patch 7 - DnD tests, r=smaug
2016-06-07 00:55:17 +02:00
64fb238b77
Bug 1265767 - Subset of Blink FileSystem API - patch 6 - getFile and getDirectory, r=smaug
2016-06-07 00:55:17 +02:00
ae27692741
Bug 1265767 - Subset of Blink FileSystem API - patch 5 - DOMFileSystem, r=smaug
...
--HG--
rename : dom/filesystem/compat/ErrorCallbackRunnable.h => dom/filesystem/compat/CallbackRunnables.h
2016-06-07 00:55:17 +02:00
5a24e4a0ff
Bug 1265767 - Subset of Blink FileSystem API - patch 4 - DirectoryEntry methods, r=smaug
2016-06-07 00:55:17 +02:00
52fbfbc75d
Bug 1265767 - Subset of Blink FileSystem API - patch 3 - FileEntry methods, r=smaug
2016-06-07 00:55:17 +02:00
5a7749a26f
Bug 1265767 - Subset of Blink FileSystem API - patch 2 - Entries, r=smaug
2016-06-07 00:55:16 +02:00
1a7f4ecbd2
Bug 1265767 - Subset of Blink FileSystem API - patch 1 - WebIDL, r=smaug
2016-06-07 00:55:16 +02:00
Nicholas Nethercote
Andrea Marchesini
Olli Pettay
Tom Tromey