In preparation for making CurrentX11TimeGetter capable of performing an
asynchronous request of the current time, this patch revises the lifetime of
such objects so that they are stored on nsWindow.
--HG--
extra : rebase_source : 486c81ad5e64ee6420907babcc97262412ff5caa
Previously the CurrentX11TimeGetter and CurrentWindowsTimeGetter classes acted
as functors with a single operator() method. In preparation for handling clock
skew, this patch refactors these two helper classes into regular classes with
two named methods:
GetCurrentTime which matches the existing operator() method, and
GetTimeAsyncForPossibleBackwardsSkew which will be used when possible
backwards skew is detected to fetch the current time asynchronously.
Some renaming is also included to match the expanded role of these classes.
--HG--
extra : rebase_source : 4d46e09bd09cbb0dbffcb0aa46742157384d37e8
This patch adds a helper class to widgets/gtk/nsWindow.cpp similar to the one in
widgets/windows/nsWindow.cpp and uses it to convert native event times to
mozilla::TimeStamp objects on events returned by this class.
This is similar to the operations performed for Windows native event times that
were added in bug 77992.
--HG--
extra : rebase_source : a6c4769e7da88bb4644edf8954c923a88e1c04fd
GTK versions prior to 2.24 incorrectly advertise themselves as able to print PDFs,
even when they can't. We were wholesale setting the output format to PostScript for
these older GTK versions, without giving the user the opportunity to override
it. We now lazily determine whether or not the output should be in PostScript,
which should give the user the opportunity to override.
--HG--
extra : commitid : A30C51CukFd
extra : rebase_source : 8800e463753a554902cc22fe6e973dfdab1d7c0d
extra : amend_source : 43b58fd7c2c1605351cbb24d216fb5f781625a3a
Before, we were calling nsDeviceContextSpecGTK::StartPrintJob within the
gtk_enumerate_printers callback function as soon as we found the printer
we wanted to print from. This was causing the GTK printing backend to get
confused about what the capabilities of the selected printer were when running
in the content process, due to https://bugzilla.gnome.org/show_bug.cgi?id=753041.
This moves the call to StartPrintJob to the next tick of the event loop.
--HG--
extra : commitid : CZ5P0hh51QC
extra : rebase_source : 279c6c56a2a22b42d5bbf094fd976a4d8f9c8031
The current situation looks like this: Firefox launches the plugin-container
with two environment variables set:
LD_LIBRARY_PATH=$FIREFOX_DIR:$LD_LIBRARY_PATH
LD_PRELOAD=$FIREFOX_DIR/libmozgtk2.so:$LD_PRELOAD
libxul.so has a dependency on libmozgtk.so (without "2"), but libmozgtk2.so
has a SONAME of libmozgtk.so, so ld.so recognizes libmozgtk2.so as a
dependency of libxul.so, and uses it instead of the actual libmozgtk.so,
making the plugin-container use Gtk+2 instead of Gtk+3 to load Gtk+2 plugins.
Now, ASan sets things up in shared libraries such that they needs a symbol
from the executable binary. So in the case of plugin-container, the
plugin-container executable itself contains some ASan symbols such as
__asan_init_v3. libmozgtk2.so, OTOH, contains an undefined weak reference to
that symbol, like all other Firefox shared libraries.
Since libmozgtk2.so is LD_PRELOADed, it is loaded _before_ the
plugin-container executable, and __asan_init_v3 can't be resolved.
Disabling ASan for libmozgtk2.so would be a possibility, but the build system
doesn't really know how to do that, and filtering out -fsanitize=address
can be fragile.
The alternative possibility, implemented here, is to change the library
loading strategy, renaming libmozgtk2.so to gtk2/libmozgtk.so, and setting
the following environment variable when Firefox launches the plugin-container:
LD_LIBRARY_PATH=$FIREFOX_DIR/gtk2:$FIREFOX_DIR:$LD_LIBRARY_PATH
Andrew Comminos
Ryan VanderMeulen
Andrew Comminos
Masayuki Nakano
Chris Peterson
Lee Salzman
Brian Birtles
Mike Conley
Xidorn Quan
Nick Robson
Gabor Krizsanits
Petr Jasicek
Birunthan Mohanathas
Carsten "Tomcat" Book
Mike Hommey
Makoto Kato
Wes Kocher