зеркало из https://github.com/mozilla/gecko-dev.git
198a38cfc4
This patch changes the paramters to setSearchMode. The original patch to introduce search mode passed engineName to setSearchMode instead of the entire engine object. It was suggested in review that the nsISearchEngine be passed so we could run instanceof to distinguish it from a RESULT_TYPE. This patch reverses this and passes engineName instead through a destructured parameter.
In pickResult, we need to enter search mode synchronously based on the information in a result payload. Result payloads can't/shouldn't pass around complex objects like an nsISearchEngine, so we just pass engineName and the alias as strings. Since pickResult is synchronous, we can't use UrlbarSearchUtils to look up the engine based on the engineName. Besides, setSearchMode only uses engineName, so looking up the engine only to just use its name seems like a waste of resources.
This patch also disables autofill in search mode queries. Autofill was interfering with alias replacement. We were already half doing this (https://searchfox.org/mozilla-central/rev/26b13464c2beb26e0d864d561c30e817a85c348a/browser/components/urlbar/UrlbarController.jsm#391) but adding the searchMode check to UrlbarInput._maybeAutofillOnInput should resolve bug
|
||
|---|---|---|
| .. | ||
| actors | ||
| app | ||
| base | ||
| branding | ||
| components | ||
| config | ||
| docs | ||
| extensions | ||
| fonts | ||
| fxr | ||
| installer | ||
| locales | ||
| modules | ||
| themes | ||
| tools/mozscreenshots | ||
| .eslintrc.js | ||
| LICENSE | ||
| Makefile.in | ||
| app.mozbuild | ||
| build.mk | ||
| confvars.sh | ||
| defs.mk | ||
| l10n-registry.manifest | ||
| moz.build | ||
| moz.configure | ||