зеркало из https://github.com/mozilla/gecko-dev.git
Read-only Git mirror of the Mercurial gecko repositories at https://hg.mozilla.org. How to contribute: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
02bc7e2b1b
The changesets in bug 1412932 changed the semantics for MOZ_PGO. Before, it was effectively being set as an environment variable by client.mk all the time. Afterwards - specifically after 2013c8dd1824 - the variable is set in mozconfigs via ac_add_options, which means it is only exposed to configure, not the environment. Investigation by dmajor revealed that -WX (warnings as errors) was added to a js/src file's compiler invocation after the PGO code refactor. (PGO and warnings as errors have a strange interaction - bug 437002 - and should be disabled there.) Strangely, addition of -WX was only present on Dev Edition PGO builds. The reason for this is likely mozharness. Mozharness will export the MOZ_PGO=1 environment variable for build configurations that it knows are PGO. It appears to do this for all PGO build configurations except Dev Edition. Since make and moz.configure inherit environment variables, mozharness was basically papering over the intended behavior change in 2013c8dd1824. This commit fixes the problem by marking MOZ_PGO as a JS option in moz.configure. This means `ac_add_options MOZ_PGO=1` (the new convention for enabling PGO) will set MOZ_PGO for SpiderMonkey's moz.configure. Of course, MOZ_PGO=1 in an environment variable still works. And mozharness's setting of this variable has the intended effect. Eventually, I'd like to clean up the mozharness code so it is less PGO aware and enables PGO via ac_add_options. But that's for another day. MozReview-Commit-ID: 1KYPJARI6SJ --HG-- extra : amend_source : 5291cead9f1c1af9ed2a1f608af770bc8e4958c5 |
||
---|---|---|
.cargo | ||
.vscode | ||
accessible | ||
browser | ||
build | ||
caps | ||
chrome | ||
config | ||
db | ||
devtools | ||
docshell | ||
dom | ||
editor | ||
embedding | ||
extensions | ||
gfx | ||
gradle/wrapper | ||
hal | ||
image | ||
intl | ||
ipc | ||
js | ||
layout | ||
media | ||
memory | ||
mfbt | ||
mobile | ||
modules | ||
mozglue | ||
netwerk | ||
nsprpub | ||
other-licenses | ||
parser | ||
python | ||
rdf | ||
security | ||
services | ||
servo | ||
startupcache | ||
storage | ||
taskcluster | ||
testing | ||
third_party | ||
toolkit | ||
tools | ||
uriloader | ||
view | ||
widget | ||
xpcom | ||
xpfe | ||
.clang-format | ||
.clang-format-ignore | ||
.clang-tidy | ||
.cron.yml | ||
.eslintignore | ||
.eslintrc.js | ||
.flake8 | ||
.gdbinit | ||
.gdbinit_python | ||
.gitignore | ||
.hgignore | ||
.hgtags | ||
.inferconfig | ||
.lldbinit | ||
.taskcluster.yml | ||
.yamllint | ||
.ycm_extra_conf.py | ||
AUTHORS | ||
CLOBBER | ||
GNUmakefile | ||
LEGAL | ||
LICENSE | ||
Makefile.in | ||
README.txt | ||
aclocal.m4 | ||
build.gradle | ||
client.mk | ||
client.py | ||
configure.in | ||
configure.py | ||
gradle.properties | ||
gradlew | ||
mach | ||
moz.build | ||
moz.configure | ||
mozilla-config.h.in | ||
npm-shrinkwrap.json | ||
old-configure.in | ||
package.json | ||
settings.gradle | ||
test.mozbuild |
README.txt
An explanation of the Mozilla Source Code Directory Structure and links to project pages with documentation can be found at: https://developer.mozilla.org/en/Mozilla_Source_Code_Directory_Structure For information on how to build Mozilla from the source code, see: https://developer.mozilla.org/en/docs/Build_Documentation To have your bug fix / feature added to Mozilla, you should create a patch and submit it to Bugzilla (https://bugzilla.mozilla.org). Instructions are at: https://developer.mozilla.org/en/docs/Creating_a_patch https://developer.mozilla.org/en/docs/Getting_your_patch_in_the_tree If you have a question about developing Mozilla, and can't find the solution on https://developer.mozilla.org, you can try asking your question in a mozilla.* Usenet group, or on IRC at irc.mozilla.org. [The Mozilla news groups are accessible on Google Groups, or news.mozilla.org with a NNTP reader.] You can download nightly development builds from the Mozilla FTP server. Keep in mind that nightly builds, which are used by Mozilla developers for testing, may be buggy. Firefox nightlies, for example, can be found at: https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/ - or - https://nightly.mozilla.org/