gecko-dev/dom
Perry Jiang c0d0830d63 Bug 1578919 - Don't allow AutoIPCStream to outlive its IPCStream r=asuth
In ServiceWorkerPrivateImpl::SendFetchEvent, a heap-allocated AutoIPCStream can
point to a stack-allocated IPCStream (part of an IPCInternalRequest). If this
IPCStream is destroyed before the AutoIPCStream, the AutoIPCStream will have a
dangling pointer (and this is the case if SendFetchEvent is called when the
Service Worker's state is "activating" rather than "activated").

This patch moves around the logic to handle the AutoIPCStream's lifetime to
ensure it its lifetime is within its IPCStream's lifetime. The larger issue
might be that AutoIPCStream doesn't have inherent lifetime guarantees (it'll
definitely outlive its IPCStream if it points to its embedded one, but it
doesn't own any external IPCStreams it might point to).

Differential Revision: https://phabricator.services.mozilla.com/D48935

--HG--
extra : moz-landing-system : lando
2019-10-11 23:22:31 +00:00
..
abort
animation Bug 1585770 - Copy KeyframeEffect::mBaseStyle in the KeyframeEffect copy constructor. r=boris 2019-10-03 20:00:27 +00:00
audiochannel Bug 1585156 - Remove useless inclusions of nsIDOMWindow.h and nsIDOMWindowUtils.h r=smaug 2019-09-30 22:06:47 +00:00
base Bug 1583400: Follow-up: Fix cycle collector assertion. 2019-10-11 23:22:52 +00:00
battery Backed out changeset f065877ca676 (bug 1441976) for wpt failures at battery-status/battery-interface-idlharness.https.window.html on a CLOSED TREE 2019-09-27 00:24:29 +03:00
bindings Backed out 2 changesets (bug 1568883, bug 1568249) for causing c1 failures in dom/base/test/chrome/test_cpows.xul CLOSED TREE 2019-10-12 00:07:48 +03:00
broadcastchannel
browser-element
cache Bug 1581067 - P6 - Change the test due to P5; r=asuth 2019-10-02 10:38:55 +00:00
canvas Backed out changeset 41c6b7e917fd (bug 1367251) for mochitest failures at test_conformance__textures__image_bitmap_from_blob__tex-2d-luminance-luminance-unsigned_byte.html. CLOSED TREE 2019-10-07 04:46:13 +03:00
chrome-webidl Bug 1578624 - P6: Add LoadURI to BrowsingContext's webidl. r=kmag 2019-10-11 02:27:14 +00:00
clients Bug 1578624 - P4: Add an option to set mIsNavigating on the docshell when loading using BrowsingContext. r=kmag 2019-10-11 02:27:05 +00:00
commandhandler Bug 1585156 - Remove useless inclusions of nsIDOMWindow.h and nsIDOMWindowUtils.h r=smaug 2019-09-30 22:06:47 +00:00
console Bug 1585156 - Remove useless inclusions of nsIDOMWindow.h and nsIDOMWindowUtils.h r=smaug 2019-09-30 22:06:47 +00:00
credentialmanagement
crypto Bug 1583646 - make WebCryptoTask dispatch tasks to our background thread; r=keeler,jcj 2019-09-26 20:47:31 +00:00
debugger
docs Bug 1580907 - Remove transferables attribute for SendAsyncMessage and SendQuery in JSWindowActor; r=nika 2019-09-13 16:51:23 +00:00
encoding Bug 1586358 - Replace existing instances of GENERATED_FILES with references to the GeneratedFile template r=firefox-build-system-reviewers,mshal 2019-10-07 21:15:19 +00:00
events Bug 1587746: remove `RangeBoundaryBase::Set` and use constructor instead. r=smaug 2019-10-11 12:43:57 +00:00
fetch Bug 1456995 - give InternalRequest::mMozErrors a default initializer r=asuth 2019-10-08 23:47:36 +00:00
file Bug 1586911: Silence SHEntry assertion after local->remote->local iframe navigation. r=peterv 2019-10-11 19:32:02 +00:00
filehandle
filesystem
flex
gamepad Bug 1585156 - Remove useless inclusions of nsIDOMWindow.h and nsIDOMWindowUtils.h r=smaug 2019-09-30 22:06:47 +00:00
geolocation Bug 1585297- Use Principal->SchemeIs in nsGeolocation.cpp r=ckerschb 2019-10-01 12:54:56 +00:00
grid Bug 1581106 part 3 - [css-grid-2] Implement 'repeat(auto-fill, <line-names>)' in subgridded axis. r=emilio 2019-09-30 17:32:52 +00:00
html Bug 1587457 - Remove Element::GetTokenList. r=bzbarsky 2019-10-11 04:09:40 +00:00
imptests
indexedDB Bug 1587263 - IDB: Use specialized directory locks for database maintenances; r=asuth 2019-10-11 03:03:01 +00:00
interfaces Bug 1583932 - Remove aRequestOrigin from nsCSPContext::ShouldLoad r=ckerschb 2019-09-30 10:38:32 +00:00
ipc Bug 1587559 - Ignore noopener.newprocess preference under Fission. r=nika 2019-10-11 19:59:10 +00:00
jsurl Bug 1490601 part 2 - Move C++ entry points to encoding_c_mem to mfbt/. r=jwalden 2019-09-18 08:26:34 +00:00
l10n Bug 1513325 - Remove textbox binding. r=emilio,dao 2019-10-09 09:27:28 +00:00
locales Bug 1587922 - Remove the remnants of the showModalDialog code; r=smaug 2019-10-10 22:59:28 +00:00
localstorage Bug 1587931 - LSNG: Force kill database actors during shutdown; r=asuth 2019-10-11 03:03:01 +00:00
manifest Bug 1587242 - refactor ValueExtractor prototype into an ES6 class r=marcosc 2019-10-09 01:57:07 +00:00
mathml Bug 1575870. Remove support for XLink on MathML elements. r=emilio 2019-10-05 21:47:38 +00:00
media Bug 1580602 - P3: Implement setActionHandler API. r=bzbarsky 2019-10-11 02:47:54 +00:00
messagechannel Bug 1553804: Part 6 - Fix chrome mochitests which open chrome windows with content openers. r=nika 2019-09-20 10:18:15 -07:00
midi
network Bug 927610 part 1. Stop using NS_ERROR_TYPE_ERR in UDPSocket. r=smaug 2019-09-24 16:53:44 +00:00
notification Bug 1580782 - Change Callsites to use nsIPrincipal->SchemeIs r=ckerschb 2019-09-26 10:47:16 +00:00
offline
payments Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 2019-10-06 18:29:55 +00:00
performance Bug 1583271 - Part 1: Change profiler page information IDs to BrowsingContextID and InnerWindowID r=gerald,nika 2019-10-09 21:25:11 +00:00
permission Bug 1582999 - Disable test_cross_origin_iframe.html of fission because of permafailures r=mccr8 2019-09-26 19:10:58 +00:00
plugins Bug 1585156 - Remove useless inclusions of nsIDOMWindow.h and nsIDOMWindowUtils.h r=smaug 2019-09-30 22:06:47 +00:00
power Bug 1585156 - Remove useless inclusions of nsIDOMWindow.h and nsIDOMWindowUtils.h r=smaug 2019-09-30 22:06:47 +00:00
presentation
prio Bug 1582196 part 4. Get rid of NS_ERROR_RANGE_ERR. r=peterv 2019-09-23 19:14:33 +00:00
promise Bug 1575744 - P4. Add MozPromise::FromDomPromise. r=bholley 2019-09-20 04:09:46 +00:00
prototype Bug 1510785 - Only build XBL related code when MOZ_XBL is defined. r=bzbarsky 2019-10-08 23:52:14 +00:00
push Bug 1575185 - Subscribe content processes spawning Service Workers to permission updates r=asuth 2019-10-09 02:23:41 +00:00
quota Bug 1587258 - QM: Add support for creating specialized directory locks from existing directory locks; r=asuth 2019-10-10 14:55:53 +00:00
reporting Bug 1583684 - Fix some rooting hazards in DOM bindings r=bzbarsky 2019-09-26 23:50:14 +00:00
res
script Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 2019-10-06 18:29:55 +00:00
security Bug 1587417: Add about:logo to allowlist of CSP assertion. r=jkt 2019-10-09 13:33:15 +00:00
serviceworkers Bug 1578919 - Don't allow AutoIPCStream to outlive its IPCStream r=asuth 2019-10-11 23:22:31 +00:00
simpledb
smil Bug 1510785 - Skip all XBL related tests when XBL is disabled. r=bzbarsky 2019-10-08 23:52:46 +00:00
storage Bug 1582196 part 4. Get rid of NS_ERROR_RANGE_ERR. r=peterv 2019-09-23 19:14:33 +00:00
svg Bug 1510785 - Only build XBL related code when MOZ_XBL is defined. r=bzbarsky 2019-10-08 23:52:14 +00:00
system Bug 1587836 - update permissions related Bugzilla components stored in moz.build files. r=johannh 2019-10-11 08:44:00 +00:00
tests Bug 1587559 - Ignore noopener.newprocess preference under Fission. r=nika 2019-10-11 19:59:10 +00:00
u2f
url
vr Bug 1578355 - Part 1: Move user-activation code from EventStateManager to UserActivation; r=smaug 2019-09-20 20:51:25 +00:00
webauthn Bug 1573245 - Change AuthenticatorTransport to be string, not `enum` r=bzbarsky,keeler 2019-09-17 07:50:44 +00:00
webbrowserpersist
webgpu Bug 1581710 - Update WebGPU IDL bindings r=jgilbert,bzbarsky 2019-10-02 16:46:03 +00:00
webidl Backed out 2 changesets (bug 1568883, bug 1568249) for causing c1 failures in dom/base/test/chrome/test_cpows.xul CLOSED TREE 2019-10-12 00:07:48 +03:00
websocket Bug 1585156 - Remove useless inclusions of nsIDOMWindow.h and nsIDOMWindowUtils.h r=smaug 2019-09-30 22:06:47 +00:00
workers Bug 1575185 - Subscribe content processes spawning Service Workers to permission updates r=asuth 2019-10-09 02:23:41 +00:00
worklet Bug 1576254 - Add isSystemOrAddonPrincipal to WorkletPrincipal r=baku 2019-10-04 17:36:40 +00:00
xbl Backed out 2 changesets (bug 1568883, bug 1568249) for causing c1 failures in dom/base/test/chrome/test_cpows.xul CLOSED TREE 2019-10-12 00:07:48 +03:00
xhr Bug 1546185 - Also check mEventDispatchingSuspended to see if we are in sync event loop r=baku 2019-10-01 11:31:43 +00:00
xml Bug 1546112 - Remove the code for XMLDocument.load/async; r=smaug 2019-10-10 18:20:34 +00:00
xslt Bug 1587905 - Remove useless variable 'typeTest' declaration & assignation r=Ehsan 2019-10-10 22:48:49 +00:00
xul Bug 1513325 - Remove textbox binding. r=emilio,dao 2019-10-09 09:27:28 +00:00
jar.mn
moz.build Bug 1510785 - Only build XBL related code when MOZ_XBL is defined. r=bzbarsky 2019-10-08 23:52:14 +00:00