gecko-dev/servo/components/layout
Ramshell 109e0117e6 servo: Merge #20573 - Add support for percentages in column-gap (from Ramshell:issue/20498); r=mbrubeck
<!-- Please describe your changes on the following line: -->
# Changes in this PR
* I've removed the `if product == "gecko"` line in order to make the column_gap type "NonNegativeLengthOrPercentageOrNormal" always.

* Then I've changed this line
```rust
Either::First(len) => len.into(),
```
to
```rust
Either::First(len) => len.0.to_pixel_length(content_inline_size).into(),
```

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach build-geckolib` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #20498  (github issue number if applicable).

<!-- Either: -->
- [X] These changes do not require tests because there are tests already for this in wpt, in particular css/css-align/gaps/column-gap-parsing-001.html for the parsing bits, and css/css-multicol/multicol-gap-percentage-001.html for the layout bits.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: ecf71d77cde1ce998b2d2b7fd7a6d45dfe40343e

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 16a3fc0d6220196432027a859c13b1f364217769
2018-04-06 19:48:59 -04:00
..
display_list servo: Merge #20447 - NCSU Canvas Rendering Project Initial Steps (from Brody-Eastwood:master); r=jdm 2018-04-02 22:24:34 -04:00
tests servo: Merge #19819 - Merge some test crates in their corresponding components (from servo:rm-test-crates); r=<try> 2018-01-20 08:51:27 -06:00
Cargo.toml servo: Merge #20465 - Bump env_logger to 0.5 and log to 0.4 in every servo crate (from Eijebong:log); r=SimonSapin 2018-03-28 15:08:52 -04:00
animation.rs servo: Merge #19842 - style: Cleanup a bit the cascade (from emilio:cascade-cleanup); r=nox,jryans 2018-01-23 06:30:51 -06:00
block.rs servo: Merge #20214 - Stop using LocalClip::RoundedRect (from mrobinson:stop-using-using-localclip-roundedrect); r=glennw 2018-03-06 15:53:11 -05:00
construct.rs servo: Merge #20482 - Implement a URL-generic type for ListStyleImage (from brainlessdeveloper:list-style-image-computed); r=emilio 2018-04-03 18:12:13 -04:00
context.rs servo: Merge #20021 - Lazy load fonts in a FontGroup (from jonleighton:lazy-font-group); r=mbrubeck,glennw 2018-02-22 10:49:52 -05:00
data.rs servo: Merge #18967 - Bump bitflags to 1.0 (from Eijebong:bitflags2.0); r=mbrubeck 2017-10-30 18:25:45 -05:00
flex.rs servo: Merge #20500 - style: Add support for 'flex-basis:content' in the style system (from emilio:1105111); r=xidorn 2018-04-01 21:18:27 -04:00
floats.rs servo: Merge #19868 - Use specific assertions (from CYBAI:specific-assertion); r=emilio 2018-01-25 18:06:33 -06:00
flow.rs servo: Merge #20031 - Reorganise display list builder (from pyfisch:transform); r=mbrubeck 2018-02-24 10:06:16 -05:00
flow_list.rs servo: Merge #18854 - Make optional the usage of some unstable features (from servo:servo-unstable-feature); r=nox 2017-10-13 12:26:39 -05:00
flow_ref.rs servo: Merge #18179 - Automatically verify that derive() lists are alphabetically ordered #… (from davidcl:master); r=jdm 2017-08-23 17:18:31 -05:00
fragment.rs servo: Merge #20447 - NCSU Canvas Rendering Project Initial Steps (from Brody-Eastwood:master); r=jdm 2018-04-02 22:24:34 -04:00
generated_content.rs servo: Merge #20171 - Make ContentItem use a CustomIdent for counter names (from servo:content-item-counters); r=emilio 2018-03-02 11:18:49 -05:00
incremental.rs servo: Merge #19565 - Turn flow::base and friends into methods (from mbrubeck:base); r=emilio 2017-12-15 12:44:50 -06:00
inline.rs servo: Merge #20390 - Don't OOM when laying out basic web pages on Android (from jdm:android-layout-workaround); r=emilio 2018-03-22 18:20:38 -04:00
layout_debug.rs servo: Merge #19868 - Use specific assertions (from CYBAI:specific-assertion); r=emilio 2018-01-25 18:06:33 -06:00
lib.rs servo: Merge #19688 - Detect adjoining text fragments with no line break opportunity between them (from Manishearth:linebreak); r=mbrubeck 2018-01-24 22:42:59 -06:00
linked_list.rs servo: Merge #11930 - Remove some util stuff (from nox:die-util-die); r=SimonSapin 2016-06-29 15:37:42 -05:00
list_item.rs servo: Merge #19852 - Allow floats to impact list item marker position (from jonleighton:issue-19796); r=mbrubeck 2018-01-24 19:35:39 -06:00
model.rs servo: Merge #19829 - Update Rust and use the newly-stable std::ptr::NonNull (from servo:rustup); r=nox 2018-01-22 11:11:44 -06:00
multicol.rs servo: Merge #20573 - Add support for percentages in column-gap (from Ramshell:issue/20498); r=mbrubeck 2018-04-06 19:48:59 -04:00
opaque_node.rs servo: Merge #11754 - Move ServoLayoutNode and related structs to script (from Ms2ger:wrapper-traits-prep2); r=nox 2016-06-20 12:54:20 -05:00
parallel.rs servo: Merge #19565 - Turn flow::base and friends into methods (from mbrubeck:base); r=emilio 2017-12-15 12:44:50 -06:00
persistent_list.rs servo: Merge #18968 - Use try syntax for Option where appropriate (from mbrubeck:try); r=emilio 2017-10-21 03:31:21 -05:00
query.rs servo: Merge #20031 - Reorganise display list builder (from pyfisch:transform); r=mbrubeck 2018-02-24 10:06:16 -05:00
sequential.rs servo: Merge #20031 - Reorganise display list builder (from pyfisch:transform); r=mbrubeck 2018-02-24 10:06:16 -05:00
table.rs servo: Merge #20152 - Support zero rowspans (from Manishearth:rowspan-zero); r=mbrubeck 2018-03-01 13:36:43 -05:00
table_caption.rs servo: Merge #19686 - Create own file for background calculations in layout (from pyfisch:layout-background); r=emilio 2018-01-07 08:53:18 -06:00
table_cell.rs servo: Merge #20128 - Rowspan support for tables (from Manishearth:rowspan); r=mbrubeck 2018-02-28 18:40:39 -05:00
table_colgroup.rs servo: Merge #20034 - Handle table cell backgrounds during display list generation for <table> (from Manishearth:table-backgrounds); r=mbrubeck 2018-02-21 12:00:03 -05:00
table_row.rs servo: Merge #20163 - Don't panic on cells with both a rowspan and colspan in include_sizes_from_previous_rows (from Manishearth:rowspan-crash); r=mbrubeck 2018-03-01 20:36:50 -05:00
table_rowgroup.rs servo: Merge #20128 - Rowspan support for tables (from Manishearth:rowspan); r=mbrubeck 2018-02-28 18:40:39 -05:00
table_wrapper.rs servo: Merge #19686 - Create own file for background calculations in layout (from pyfisch:layout-background); r=emilio 2018-01-07 08:53:18 -06:00
text.rs servo: Merge #20021 - Lazy load fonts in a FontGroup (from jonleighton:lazy-font-group); r=mbrubeck,glennw 2018-02-22 10:49:52 -05:00
traversal.rs servo: Merge #20117 - style: Somewhat miscelaneous cleanup (from emilio:misc-cleanup); r=nox 2018-02-24 17:28:20 -05:00
wrapper.rs servo: Merge #19957 - style: Move content property out of mako (from gootorov:move-counter-from-mako); r=emilio 2018-02-06 17:39:03 -05:00