зеркало из https://github.com/mozilla/gecko-dev.git
20b03783b4
XPIDL has the requirement that [scriptable] interfaces with [notxpcom] methods or attributes are [builtinclass]. Currently, if you don't explicitly mark something builtinclass when it should be, then the XPIDL compiler will just silently treat it like builtinclass. This means that you can cause the JS implementation of an XPCOM to start failing without any warning by marking a method notxpcom. This patch instead makes it an error. A prior patch fixed the existing instances in the tree that relied on the implicit behavior. I also added a test that we reject such classes missing builtinclass at compile time, as well as classes that inherit from builtinclass interfaces without themselves being builtinclass. I left behind a part of the runtime test for this behavior, but now this test just ensures that you can't implement a [builtinclass] interface in JS. Differential Revision: https://phabricator.services.mozilla.com/D30984 --HG-- extra : moz-landing-system : lando |
||
|---|---|---|
| .. | ||
| gtest | ||
| unit | ||
| windows | ||
| NotXPCOMTest.idl | ||
| RegFactory.cpp | ||
| SizeTest01.cpp | ||
| SizeTest02.cpp | ||
| SizeTest03.cpp | ||
| SizeTest04.cpp | ||
| SizeTest05.cpp | ||
| SizeTest06.cpp | ||
| TestArguments.cpp | ||
| TestBlockingProcess.cpp | ||
| TestHarness.h | ||
| TestPRIntN.cpp | ||
| TestQuickReturn.cpp | ||
| TestShutdown.cpp | ||
| TestStackCrawl.cpp | ||
| TestStreamUtils.cpp | ||
| TestUnicodeArguments.cpp | ||
| TestWinReg.js | ||
| TestingAtomList.h | ||
| moz.build | ||
| resources.h | ||
| test.properties | ||