Michael Comella c675959a63 Bug 1245493 - Don't animate when showing toolbar when FF is first unhidden. r=margaret ... After this patch, I still occasionally see the toolbar positioned part way down from the top of the screen. However, this state looks slightly less janky without the animation I removed and I can't consistently reproduce it anymore. Given the DynamicToolbar.setVisible calls I make, I'd guess this is likely to be a bug caused by BrowserApp.onTabChanged (and thus DynamicToolbar.setVisible) not getting called instantly and so the DynamicToolbar is initialized to a different location on screen. I'd guess it's a bug in DynamicToolbar as to why it's positioned partially off-screen. There is a little bit of code duplication, but that is because the code to load a url on a new intent is duplicated (i.e. once from GeckoApp.initialize - the initial load - and once from GeckoApp.onNewIntent). This could potentially be cleaned up if we moved the app loading code into onResume, but that may not be possible since we need to wait for Gecko to start up. Additionally, this patch adds a lot of hard-to-follow global state, which is also not good. Preferred solution (bug 1269041): show the toolbar each time onStart is called (i.e. FF is unhidden). This is good for the user - they'll be more aware which page they're on - but it's janky with the current implementation, where the page content does not scroll when the toolbar is shown so previously visible content is hidden. Thus, I went with the other approach. fwiw, Chrome does this behavior, but scrolls the toolbar offscreen shortly after it is shown. This solution is blocked on bug 1245523. MozReview-Commit-ID: 7JjCrIf4KTm --HG-- extra : rebase_source : 803cc3e6f940462168a61f0a12b32a0391611caa		2016-03-28 18:50:52 -07:00
..
android	Bug 1245493 - Don't animate when showing toolbar when FF is first unhidden. r=margaret	2016-03-28 18:50:52 -07:00
locales	merge mozilla-inbound to mozilla-central a=merge	2016-04-25 11:55:12 +02:00