gecko-dev/netwerk
Valentin Gosu da85d07d64 Bug 1643264 - Failed ResolveWithTRR requests should not be retried to get the TTL r=dragana,necko-reviewers
While doing the TRR dry run experiment it became apparent that we are issuing
a lot of TRR requests that are causing us to DDOS our TRR provider.
We had a hint that this may only be affecting Windows. Upon inspection of the
code and the APIs we use to measure the performance of each TRR service we
discovered that the codepath that is used to get the TTL for DNS records on
Windows was wrongly exercised for TRR too, causing us to keep repeating a
failing TRR request until success (or until the browser was shut down).

We confirmed this with a unit test and logging.

This patch fixes the condition that caused us to look for failed TRR requests.
We also add a second check that ResolveWithTRRServer calls fail if they also
have the RESOLVE_DISABLE_TRR flag set.

Differential Revision: https://phabricator.services.mozilla.com/D78229
2020-06-04 10:43:47 +00:00
..
base Bug 1639833 - IntrisincStoragePrincipal should always be partitioned - part 4 - Renaming storage access permission methods, r=dimi 2020-06-03 06:12:06 +00:00
build Bug 1539819 - P3: Some adjustments to make TRRServiceChannel work on socket process r=dragana,necko-reviewers 2020-05-18 20:18:08 +00:00
cache Bug 1620369 Convert Cache Deleter to use background thread pool r=necko-reviewers,michal 2020-05-27 00:05:58 +00:00
cache2 Bug 1634950 - Add event dispatch-and-run MOZ_LOG to our xpcom threads, r=froydnj 2020-05-12 12:48:49 +00:00
cookie Bug 1640135 - P4: update usage of PartitionKey; r=timhuang 2020-06-04 10:51:21 +00:00
dns Bug 1643264 - Failed ResolveWithTRR requests should not be retried to get the TTL r=dragana,necko-reviewers 2020-06-04 10:43:47 +00:00
ipc Bug 1640135 - P4: update usage of PartitionKey; r=timhuang 2020-06-04 10:51:21 +00:00
locales Bug 1638358 - Cookie Schemeful Same-Site - part 6 - console messages, r=mayhemer 2020-06-02 13:50:32 +00:00
mime Bug 1515419 - fixing ToNewCString (and ToNewUnicode as well) xpcom/string/nsReadableUtils.cpp r=froydnj,necko-reviewers,valentin 2020-05-17 06:58:48 +00:00
protocol Bug 1640135 - P4: update usage of PartitionKey; r=timhuang 2020-06-04 10:51:21 +00:00
sctp Bug 1218356 - P2 - Implement the RTCDataChannel stats;r=dminor 2020-05-29 10:46:42 +00:00
socket Bug 1633006 - Update to Neqo 0.4.0 r=dragana,necko-reviewers 2020-06-02 21:28:31 +00:00
srtp Bug 1624128 - Update CK_GCM_PARAMS uses for PKCS11 v3.0 definition r=keeler 2020-04-14 18:32:19 +00:00
streamconv Bug 1641245 - Make string comparators not virtual. r=froydnj,necko-reviewers,geckoview-reviewers,jgilbert,agi,valentin 2020-05-27 18:11:12 +00:00
system Bug 1637947 - network ID: link status isn't updated in NetlinkService::OnAddrMessage() r=necko-reviewers,valentin 2020-05-21 16:55:42 +00:00
test Bug 1643264 - Failed ResolveWithTRR requests should not be retried to get the TTL r=dragana,necko-reviewers 2020-06-04 10:43:47 +00:00
url-classifier Bug 1639718 - P2. Protection features call OnBeforeBlockChannel before blocking the channel. r=baku 2020-05-28 09:51:23 +00:00
wifi
moz.build Bug 1623593 - Get rid of NECKO_COOKIES compilation flag, r=mayhemer 2020-03-24 16:30:03 +00:00