зеркало из https://github.com/mozilla/gecko-dev.git
58786e1ea7
This patch makes the following changes to the macros.
- Removes PROFILER_LABEL_FUNC. It's only suitable for use in functions outside
classes, due to PROFILER_FUNCTION_NAME not getting class names, and it was
mostly misused.
- Removes PROFILER_FUNCTION_NAME. It's no longer used, and __func__ is
universally available now anyway.
- Combines the first two string literal arguments of PROFILER_LABEL and
PROFILER_LABEL_DYNAMIC into a single argument. There was no good reason for
them to be separate, and it forced a '::' in the label, which isn't always
appropriate. Also, the meaning of the "name_space" argument was interpreted
in an interesting variety of ways.
- Adds an "AUTO_" prefix to PROFILER_LABEL and PROFILER_LABEL_DYNAMIC, to make
it clearer they construct RAII objects rather than just being function calls.
(I myself have screwed up the scoping because of this in the past.)
- Fills in the 'js::ProfileEntry::Category::' qualifier within the macro, so
the caller doesn't need to. This makes a *lot* more of the uses fit onto a
single line.
The patch also makes the following changes to the macro uses (beyond those
required by the changes described above).
- Fixes a bunch of labels that had gotten out of sync with the name of the
class and/or function that encloses them.
- Removes a useless PROFILER_LABEL use within a trivial scope in
EventStateManager::DispatchMouseOrPointerEvent(). It clearly wasn't serving
any useful purpose. It also serves as extra evidence that the AUTO_ prefix is
a good idea.
- Tweaks DecodePool::SyncRunIf{Preferred,Possible} so that the labelling is
done within them, instead of at their callsites, because that's a more
standard way of doing things.
--HG--
extra : rebase_source : 318d1bc6fc1425a94aacbf489dd46e4f83211de4
|
||
|---|---|---|
| .. | ||
| Base64.cpp | ||
| Base64.h | ||
| CocoaFileUtils.h | ||
| CocoaFileUtils.mm | ||
| FileUtilsWin.cpp | ||
| FileUtilsWin.h | ||
| SlicedInputStream.cpp | ||
| SlicedInputStream.h | ||
| SnappyCompressOutputStream.cpp | ||
| SnappyCompressOutputStream.h | ||
| SnappyFrameUtils.cpp | ||
| SnappyFrameUtils.h | ||
| SnappyUncompressInputStream.cpp | ||
| SnappyUncompressInputStream.h | ||
| SpecialSystemDirectory.cpp | ||
| SpecialSystemDirectory.h | ||
| crc32c.c | ||
| crc32c.h | ||
| moz.build | ||
| nsAnonymousTemporaryFile.cpp | ||
| nsAnonymousTemporaryFile.h | ||
| nsAppDirectoryServiceDefs.h | ||
| nsAppFileLocationProvider.cpp | ||
| nsAppFileLocationProvider.h | ||
| nsBinaryStream.cpp | ||
| nsBinaryStream.h | ||
| nsDirectoryService.cpp | ||
| nsDirectoryService.h | ||
| nsDirectoryServiceAtomList.h | ||
| nsDirectoryServiceDefs.h | ||
| nsDirectoryServiceUtils.h | ||
| nsEscape.cpp | ||
| nsEscape.h | ||
| nsIAsyncInputStream.idl | ||
| nsIAsyncOutputStream.idl | ||
| nsIBinaryInputStream.idl | ||
| nsIBinaryOutputStream.idl | ||
| nsICloneableInputStream.idl | ||
| nsIConverterInputStream.idl | ||
| nsIConverterOutputStream.idl | ||
| nsIDirectoryEnumerator.idl | ||
| nsIDirectoryService.idl | ||
| nsIFile.idl | ||
| nsIIOUtil.idl | ||
| nsIInputStream.idl | ||
| nsIInputStreamTee.idl | ||
| nsILineInputStream.idl | ||
| nsILocalFile.idl | ||
| nsILocalFileMac.idl | ||
| nsILocalFileWin.idl | ||
| nsIMultiplexInputStream.idl | ||
| nsIOUtil.cpp | ||
| nsIOUtil.h | ||
| nsIObjectInputStream.idl | ||
| nsIObjectOutputStream.idl | ||
| nsIOutputStream.idl | ||
| nsIPipe.idl | ||
| nsISafeOutputStream.idl | ||
| nsIScriptableBase64Encoder.idl | ||
| nsIScriptableInputStream.idl | ||
| nsISeekableStream.idl | ||
| nsIStorageStream.idl | ||
| nsIStreamBufferAccess.idl | ||
| nsIStringStream.idl | ||
| nsIUnicharInputStream.idl | ||
| nsIUnicharLineInputStream.idl | ||
| nsIUnicharOutputStream.idl | ||
| nsInputStreamTee.cpp | ||
| nsLinebreakConverter.cpp | ||
| nsLinebreakConverter.h | ||
| nsLocalFile.h | ||
| nsLocalFileCommon.cpp | ||
| nsLocalFileUnix.cpp | ||
| nsLocalFileUnix.h | ||
| nsLocalFileWin.cpp | ||
| nsLocalFileWin.h | ||
| nsMultiplexInputStream.cpp | ||
| nsMultiplexInputStream.h | ||
| nsNativeCharsetUtils.cpp | ||
| nsNativeCharsetUtils.h | ||
| nsPipe.h | ||
| nsPipe3.cpp | ||
| nsScriptableBase64Encoder.cpp | ||
| nsScriptableBase64Encoder.h | ||
| nsScriptableInputStream.cpp | ||
| nsScriptableInputStream.h | ||
| nsSegmentedBuffer.cpp | ||
| nsSegmentedBuffer.h | ||
| nsStorageStream.cpp | ||
| nsStorageStream.h | ||
| nsStreamUtils.cpp | ||
| nsStreamUtils.h | ||
| nsStringStream.cpp | ||
| nsStringStream.h | ||
| nsUnicharInputStream.cpp | ||
| nsUnicharInputStream.h | ||
| nsWildCard.cpp | ||
| nsWildCard.h | ||