gecko-dev/dom/quota
Chris Pearce 4a6ff21ab5 Bug 1473671 - Don't store persistent block permission if ESC pressed while showing permission doorhanger. r=florian
While showing a doorhanger permisison prompt, if the user presses the ESC key
we call the secondary action callback, passing in whether any checkbox on
the popup notification was checked.

In the case of an autoplay-media permission prompt, we have a "remember"
checkbox, which is checked by default. So pressing ESC means the user will
remember a "block" result for the current site.

We believe that users don't expect pressing ESC to result in a remembered
decision, they expect pressing ESC to avoid making a decision. So we want to
ignore the checkbox when ESC is pressed for autoplay-media.

So this patch adds a new PopupNotification behaviour which reports the source
of event which caused the action callback to be called. This enables the ESC
key press to ignore storing a permission.

Note: the change here to not store a permission on ESC press applies to all
permissions, not just autoplay-media.


MozReview-Commit-ID: IUWFN8LG9VF

--HG--
extra : rebase_source : b004bc211177a7bfb6dcea563d75db9a6750b214
2018-07-17 14:45:17 +12:00
..
test Bug 1473671 - Don't store persistent block permission if ESC pressed while showing permission doorhanger. r=florian 2018-07-17 14:45:17 +12:00
ActorsChild.cpp Bug 1431029 - Expose timestamp for quota managed storage. r=asuth 2018-02-20 14:54:17 +01:00
ActorsChild.h Bug 1348660 - Part 5: Implement a method to retrieve usage data for all origins at once; r=btseng 2017-03-22 12:14:04 +01:00
ActorsParent.cpp Bug 1473453 - Part 2: QuotaManager: disambiguate null check of bool pointer. r=janv 2018-07-04 14:46:51 -07:00
ActorsParent.h
Client.h Bug 1470811 - Update FF 62 to know about upcoming new quota client; r=asuth 2018-06-29 09:58:09 +02:00
FileStreams.cpp Bug 1436902 part 3. Replace usage of NS_IMPL_ISUPPORTS_INHERITED0 with NS_INLINE_DECL_REFCOUNTING_INHERITED when possible. r=mccr8 2018-02-12 15:44:40 -05:00
FileStreams.h Bug 1436902 part 3. Replace usage of NS_IMPL_ISUPPORTS_INHERITED0 with NS_INLINE_DECL_REFCOUNTING_INHERITED when possible. r=mccr8 2018-02-12 15:44:40 -05:00
OriginScope.h Bug 1328653 - Merging all the various *OriginAttributes to just one, r=huseby 2017-01-12 17:38:48 +01:00
PQuota.ipdl Bug 1348660 - Part 5: Implement a method to retrieve usage data for all origins at once; r=btseng 2017-03-22 12:14:04 +01:00
PQuotaRequest.ipdl Bug 1298329 - Part 1: Implement persist/persisted in QuotaManager and expose them to QuotaManagerService; r=janv 2016-08-25 10:19:31 +08:00
PQuotaUsageRequest.ipdl Bug 1431029 - Expose timestamp for quota managed storage. r=asuth 2018-02-20 14:54:17 +01:00
PersistenceType.h
QuotaCommon.h
QuotaManager.h Bug 1470811 - Update FF 62 to know about upcoming new quota client; r=asuth 2018-06-29 09:58:09 +02:00
QuotaManagerService.cpp Bug 1412125, part 2 - Fix dom/ mode lines. r=qdot 2017-10-26 15:08:41 -07:00
QuotaManagerService.h Bug 1409249: Require singleton constructors to return explicit already_AddRefed. r=froydnj 2017-10-16 21:08:42 -07:00
QuotaObject.h Bug 1252998 - StorageActivityService - part 7 - StorageActivityService in QuotaManager, r=janv 2018-04-18 18:19:13 +02:00
QuotaRequests.cpp Bug 1391005 - Eliminate NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION_INHERITED. r=peterv 2017-08-29 16:02:48 -07:00
QuotaRequests.h Bug 1361511 - change ownership assertion mechanism for various DOM classes; r=baku 2017-05-03 11:48:54 -04:00
QuotaResults.cpp Bug 1431029 - Expose timestamp for quota managed storage. r=asuth 2018-02-20 14:54:17 +01:00
QuotaResults.h Bug 1431029 - Expose timestamp for quota managed storage. r=asuth 2018-02-20 14:54:17 +01:00
SerializationHelpers.h Bug 1350637 - Part 4: Implement serialization for mozilla::OriginAttributesPattern, so we can use it on the receiver side of IPC without bouncing to the main thread; r=asuth 2017-08-08 23:01:14 +02:00
StorageManager.cpp Bug 1471189 - Removing 'Terminating' state in workers, r=mrbkap 2018-07-12 19:33:41 +02:00
StorageManager.h Bug 1419771 - Introduce DOMPrefs, a thread-safe access to preferences for DOM - part 10 - StorageManager enabled, r=asuth 2018-01-08 14:05:04 +01:00
UsageInfo.h Bug 1348660 - Part 4: Extract common code from GetOriginUsageOp to a new base class QuotaUsageRequestBase; r=btseng 2017-03-22 12:13:58 +01:00
moz.build Bug 1432963 - Fixing workers headers - part 17 - no LIBS=[workers] in moz.build files, r=smaug 2018-01-31 08:25:30 +01:00
nsIQuotaCallbacks.idl
nsIQuotaManagerService.idl Bug 1348660 - Part 5: Implement a method to retrieve usage data for all origins at once; r=btseng 2017-03-22 12:14:04 +01:00
nsIQuotaRequests.idl Bug 1348660 - Part 5: Implement a method to retrieve usage data for all origins at once; r=btseng 2017-03-22 12:14:04 +01:00
nsIQuotaResults.idl Bug 1431029 - Expose timestamp for quota managed storage. r=asuth 2018-02-20 14:54:17 +01:00