gecko-dev/security/certverifier
Dana Keeler c4dab46f9c bug 1497258 - remove unsound OCSP assertion from NSSCertDBTrustDomain::CheckRevocation r=mayhemer
In reimplementing the OCSP fetching code in bug 1456489, we improperly
translated an assertion that relied on the nullness of a pointer to rely on the
length of a data structure that was populated by reference. It turns out that
this made the assertion invalid because we could return a successful result and
have filled the data structure with zero-length data and it still would be valid
to operate on (the decoding code returns a malformed input result in this case).
To fix this, we can simply remove the assertion. This patch also adds a test to
exercise this case.

Differential Revision: https://phabricator.services.mozilla.com/D8883

--HG--
extra : moz-landing-system : lando
2018-10-17 19:35:28 +00:00
..
tests/gtest Bug 1493788 - move certificate/binary transparency implementation to its own directory r=jcj 2018-10-01 16:20:41 +00:00
BRNameMatchingPolicy.cpp
BRNameMatchingPolicy.h Bug 1479787 - use NSS mozpkix in Firefox, r=mt,keeler,glandium 2018-10-02 14:59:34 +02:00
CertVerifier.cpp Bug 1479787 - use NSS mozpkix in Firefox, r=mt,keeler,glandium 2018-10-02 14:59:34 +02:00
CertVerifier.h Bug 1479787 - use NSS mozpkix in Firefox, r=mt,keeler,glandium 2018-10-02 14:59:34 +02:00
ExtendedValidation.cpp bug 1478480 - enable GlobalSign Root CA - R6 for EV in PSM r=franziskus 2018-10-11 07:12:48 +00:00
ExtendedValidation.h bug 1421084 - part 4/4 - remove nsNSSShutDown.h and (hopefully) all references to it r=mt,ttaubert 2018-01-24 14:44:01 -08:00
NSSCertDBTrustDomain.cpp bug 1497258 - remove unsound OCSP assertion from NSSCertDBTrustDomain::CheckRevocation r=mayhemer 2018-10-17 19:35:28 +00:00
NSSCertDBTrustDomain.h Bug 1479787 - use NSS mozpkix in Firefox, r=mt,keeler,glandium 2018-10-02 14:59:34 +02:00
OCSPCache.cpp Bug 1479787 - use NSS mozpkix in Firefox, r=mt,keeler,glandium 2018-10-02 14:59:34 +02:00
OCSPCache.h Bug 1479787 - use NSS mozpkix in Firefox, r=mt,keeler,glandium 2018-10-02 14:59:34 +02:00
OCSPVerificationTrustDomain.cpp bug 1349762 - handle two GlobalSign EV root transfers r=Cykesiopka,jcj 2017-04-03 17:17:38 -07:00
OCSPVerificationTrustDomain.h Bug 1479787 - use NSS mozpkix in Firefox, r=mt,keeler,glandium 2018-10-02 14:59:34 +02:00
TrustOverride-AppleGoogleDigiCertData.inc Bug 1434300 - Add the DigiCert whitelisted SPKIs r=keeler 2018-02-21 14:08:59 -05:00
TrustOverride-GlobalSignData.inc Bug 1409259 - Refactor "TrustOverrides" header for existing trust overrides r=keeler 2017-10-16 23:17:52 -07:00
TrustOverride-StartComAndWoSignData.inc Bug 1409259 - Refactor "TrustOverrides" header for existing trust overrides r=keeler 2017-10-16 23:17:52 -07:00
TrustOverride-SymantecData.inc Bug 1434300 - Add a utility to match certificates based on SPKI r=fkiefer,keeler 2018-02-21 14:08:44 -05:00
TrustOverride-TestImminentDistrustData.inc Bug 1439378 - Re-enable the imminent distrust browser-console test r=fkiefer,keeler 2018-02-26 15:55:35 -07:00
TrustOverrideUtils.h Bug 1470985 - s/PodEqual/ArrayEqual/ from ArrayUtils.h. - r=waldo 2018-07-27 14:11:18 -07:00
moz.build Bug 1479787 - use NSS mozpkix in Firefox, r=mt,keeler,glandium 2018-10-02 14:59:34 +02:00