gecko-dev/media/mtransport
Michael Froman 90e4564993 Bug 1405940 - Fix Null Pointer dereference in sigslot::lock_block r=bwc
Caused by several issues:
1) We were allowing an answer with modified ufrag/pass to
   begin an ICE restart even if the offer didn't indicate
   it was restarting.
2) This should no longer happen, but in cases where restart logic
   was started inappropriately, TransportLayerIce::SetParameters
   could get a null stream, and we check for that now.

MozReview-Commit-ID: JFQ1zz3l5wY

--HG--
extra : rebase_source : a6d43aabada86669850ddce07ea86da8118a6bec
2017-10-12 22:38:01 -05:00
..
build Bug 1345511 - pt 2 - add IPC mechanism for getting stun addrs on main process. r=bwc 2017-03-21 19:59:05 -05:00
fuzztest Bug 1373843: Add a libfuzzer test for the stun parser; r=decoder 2017-06-16 16:01:19 -07:00
ipc Bug 1343743 - Part6: Pass a labeled event target to StunAddrsRequestChild's constructor., r=bwc 2017-06-12 00:25:00 +02:00
test Bug 1404198: Part 2g - Switch to NS_NewTimer* in media. r=njn 2017-10-15 23:14:33 -07:00
third_party Bug 1406154: Ensure that we avoid truncating the interface description strings in a couple of corner cases. r+drno 2017-10-12 12:12:40 -05:00
README
common.build Bug 1389598 - Part 2: Remove gonk references from media/ r=jesup 2017-08-11 17:46:15 -07:00
databuffer.h
dtlsidentity.cpp Bug 1372977 - Use nullptr in /media and /dom/media (clang-tidy: modernize-use-nullptr). r=bwc 2017-06-28 15:38:00 -04:00
dtlsidentity.h
logging.h Bug 1354222: fix log level casting warnings. r=erahm 2017-04-06 11:00:35 -07:00
m_cpp_utils.h
moz.build Bug 1373843: Add a libfuzzer test for the stun parser; r=decoder 2017-06-16 16:01:19 -07:00
nr_socket_prsock.cpp Bug 1387002 - Replace .size() by .empty() when applicable in webrtc & mtransport r=jesup 2017-08-04 09:36:19 +02:00
nr_socket_prsock.h Bug 1341374: ensure mtransport refcounting is happening on the same thread r=jesup 2017-02-23 21:57:50 -08:00
nr_timer.cpp Bug 1404198: Part 2g - Switch to NS_NewTimer* in media. r=njn 2017-10-15 23:14:33 -07:00
nricectx.cpp Bug 1404535: Add telemetry that times nr_ice_gather. r+drno r=chutten,drno,liuche 2017-09-29 17:49:32 -05:00
nricectx.h Bug 1391857 - fixing ctx flags for e10s stun addr gathering. r=drno 2017-08-22 10:13:06 -05:00
nricectxhandler.cpp Bug 1342523 - Part 1: Clean up how controlling/offerer is specified. r=drno 2017-02-24 14:05:27 -06:00
nricectxhandler.h Bug 1342523 - Part 1: Clean up how controlling/offerer is specified. r=drno 2017-02-24 14:05:27 -06:00
nricemediastream.cpp Bug 1387002 - Replace .size() by .empty() when applicable in webrtc & mtransport r=jesup 2017-08-04 09:36:19 +02:00
nricemediastream.h Bug 1339906 - pt 4 - add last sent and received timestamps to RTCIceCandidatePairStats. r=drno,qdot 2017-06-06 17:36:40 -05:00
nriceresolver.cpp Bug 1372977 - Use nullptr in /media and /dom/media (clang-tidy: modernize-use-nullptr). r=bwc 2017-06-28 15:38:00 -04:00
nriceresolver.h
nriceresolverfake.cpp Bug 1372977 - Use nullptr in /media and /dom/media (clang-tidy: modernize-use-nullptr). r=bwc 2017-06-28 15:38:00 -04:00
nriceresolverfake.h
nricestunaddr.cpp Bug 1345511 - pt 2 - add IPC mechanism for getting stun addrs on main process. r=bwc 2017-03-21 19:59:05 -05:00
nricestunaddr.h Bug 1345511 - pt 2 - add IPC mechanism for getting stun addrs on main process. r=bwc 2017-03-21 19:59:05 -05:00
nrinterfaceprioritizer.cpp Bug 1406154: Ensure that we avoid truncating the interface description strings in a couple of corner cases. r+drno 2017-10-12 12:12:40 -05:00
nrinterfaceprioritizer.h
rlogconnector.cpp
rlogconnector.h
runnable_utils.h bug 1390286 receive WrapRunnable*() parameters by reference r=jesup 2017-08-14 11:33:53 +12:00
sigslot.h Bug 1378712 - Remove all trailing whitespaces r=Ehsan 2017-07-06 14:00:35 +02:00
simpletokenbucket.cpp
simpletokenbucket.h
stun_socket_filter.cpp
stun_socket_filter.h
test_nr_socket.cpp Bug 1372977 - Use nullptr in /media and /dom/media (clang-tidy: modernize-use-nullptr). r=bwc 2017-06-28 15:38:00 -04:00
test_nr_socket.h Bug 1355947 - Add NatDelegate to TestNat; r=bwc 2017-06-13 10:08:45 -04:00
transportflow.cpp
transportflow.h
transportlayer.cpp
transportlayer.h
transportlayerdtls.cpp Bug 1404198: Part 2g - Switch to NS_NewTimer* in media. r=njn 2017-10-15 23:14:33 -07:00
transportlayerdtls.h
transportlayerice.cpp Bug 1405940 - Fix Null Pointer dereference in sigslot::lock_block r=bwc 2017-10-12 22:38:01 -05:00
transportlayerice.h
transportlayerlog.cpp
transportlayerlog.h
transportlayerloopback.cpp Bug 1404198: Part 2g - Switch to NS_NewTimer* in media. r=njn 2017-10-15 23:14:33 -07:00
transportlayerloopback.h Bug 1382172 - Name nsITimerCallback instances in native implementation. r=billm 2017-07-27 02:18:20 +08:00
transportlayerprsock.cpp
transportlayerprsock.h

README

This is a generic media transport system for WebRTC.

The basic model is that you have a TransportFlow which contains a
series of TransportLayers, each of which gets an opportunity to
manipulate data up and down the stack (think SysV STREAMS or a
standard networking stack). You can also address individual
sublayers to manipulate them or to bypass reading and writing
at an upper layer; WebRTC uses this to implement DTLS-SRTP.


DATAFLOW MODEL
Unlike the existing nsSocket I/O system, this is a push rather
than a pull system. Clients of the interface do writes downward
with SendPacket() and receive notification of incoming packets
via callbacks registed via sigslot.h. It is the responsibility
of the bottom layer (or any other layer which needs to reference
external events) to arrange for that somehow; typically by
using nsITimer or the SocketTansportService.

This sort of push model is a much better fit for the demands
of WebRTC, expecially because ICE contexts span multiple
network transports.


THREADING MODEL
There are no thread locks. It is the responsibility of the caller to
arrange that any given TransportLayer/TransportFlow is only
manipulated in one thread at once. One good way to do this is to run
everything on the STS thread. Many of the existing layer implementations
(TransportLayerPrsock, TransportLayerIce, TransportLayerLoopback)
already run on STS so in those cases you must run on STS, though
you can do setup on the main thread and then activate them on the
STS.


EXISTING TRANSPORT LAYERS
The following transport layers are currently implemented:

* DTLS -- a wrapper around NSS's DTLS [RFC 6347] stack
* ICE  -- a wrapper around the nICEr ICE [RFC 5245] stack.
* Prsock -- a wrapper around NSPR sockets
* Loopback -- a loopback IO mechanism
* Logging -- a passthrough that just logs its data

The last three are primarily for debugging.