gecko-dev/browser
Rob Wu 14f47ddcc3 Bug 1481439 - Fix intermittent browser_ext_omnibox.js r=aswan
The "startInputSession" test helper triggers the autocompletion logic to
kick off the test. In all cases except for "testSuggestions", the search
suggestions are set synchronously. Consequently, the
"waitForAutocompleteResultAt" call at the end of starting the input
session would find the expected suggestion item at the given index.

However, in the case of "testSuggestions", the results are generated
asynchronously. There is no guarantee that the results are set. The test
has only been passing so far because the result items from the previous
test are still cached, and cleared after a 100ms delay by:
https://searchfox.org/mozilla-central/rev/a41fd8cb947266ea2e3f463fc6e31c88bfab9d41/toolkit/components/places/UnifiedComplete.js#1728
On slow test runs, the test fails intermittently when the clean-up logic
runs before the test checked the suggestion item.

This patch fixes the issue by splitting "startInputSession", and only
use "waitForAutocompleteResultAt" after having sent the suggestions.

Differential Revision: https://phabricator.services.mozilla.com/D5170

--HG--
extra : moz-landing-system : lando
2018-09-10 20:06:24 +00:00
..
actors Bug 1438857 - Remove the Flash plugin infobar. r=Felipe 2018-09-06 14:50:16 +00:00
app Bug 1465251 - use PrioEncoder to encode Telemetry values for pilot project r=kmag 2018-09-09 00:23:52 +00:00
base Bug 1438402 - Fix intermittent browser_csp_block_all_mixedcontent.js. r=nhnt11 2018-09-10 13:53:19 +00:00
branding Bug 1471657 - Update Nightly DMG background to high-res r=Dolske 2018-08-21 20:54:30 +00:00
components Bug 1481439 - Fix intermittent browser_ext_omnibox.js r=aswan 2018-09-10 20:06:24 +00:00
config Bug 1473786 - Enable LTO on macOS builds. r=ted 2018-09-06 06:45:32 +09:00
docs
extensions Backed out changeset c80bc4f44b7f (bug 1489996) for bc failures in browser/extensions/pdfjs/test/browser_pdfjs_main.js 2018-09-10 16:43:52 +03:00
fonts
installer Bug 1489812 - Part 2: Remove @mozilla.org/editor-utils;1; r=masayuki 2018-09-10 08:42:27 -04:00
locales Backed out changeset c80bc4f44b7f (bug 1489996) for bc failures in browser/extensions/pdfjs/test/browser_pdfjs_main.js 2018-09-10 16:43:52 +03:00
modules Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-09-06 01:27:49 +03:00
themes Bug 1489485 - Don't apply -moz-appearance on macOS on selected synced tab items when themed. r=jaws 2018-09-07 15:47:07 +00:00
tools/mozscreenshots Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop 2018-08-31 05:59:17 +00:00
.eslintrc.js
LICENSE
Makefile.in
app.mozbuild
build.mk
confvars.sh Bug 1482256 - Support switching to browser.xul to browser.xhtml. r=mossop 2018-08-14 13:13:38 -07:00
defs.mk
moz.build Bug 1465251 - use PrioEncoder to encode Telemetry values for pilot project r=kmag 2018-09-09 00:23:52 +00:00
moz.configure Bug 1079662 - Always enable PIE. r=froydnj 2018-09-08 07:41:21 +09:00