gecko-dev/servo/python
E. Dunham 8a07e63ea4 servo: Merge #18051 - Continue after failed attempt to delete old nightly (from edunham:cleannightly); r=larsbergstrom
Failure to catch this error broke bholley's PR https://github.com/servo/servo/pull/18048

http://build.servo.org/builders/linux-dev/builds/8616/steps/shell__1/logs/stdio.
Logs below for posterity.

```
Current Rust nightly version: 599be0d18f4c6ddf36366d2a5a2ca6dc65886896
Current Rust stable version: 1.19.0
Removing /home/servo/.servo/cargo/13d94d5fa8129a34f5c77a1bcd76983f5aed2434
Error running mach:

    ['clean-nightlies', '--keep', '3', '--force']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

OSError: [Errno 2] No such file or directory:
'/home/servo/.servo/cargo/13d94d5fa8129a34f5c77a1bcd76983f5aed2434'

  File
"/home/servo/buildbot/slave/linux-dev/build/python/servo/bootstrap_commands.py",
line 334, in clean_nightlies
    delete(full_path)
  File "/home/servo/buildbot/slave/linux-dev/build/python/servo/util.py", line
28, in delete
    os.remove(path)
```

I don't know how the builder got into the edge case where the old nightly wasn't there for deletion, but in the case that removal fails for some reason, mach should just keep going. In the incredibly unlikely event that the failure to remove the file has consequences down the line, we'll have the failed remove in the log for troubleshooting.

Also this passed tidy so if I failed to python I'll need to fix tidy as well as this.

Source-Repo: https://github.com/servo/servo
Source-Revision: 3ed6c22e45df06bf381356b394d01493fc0322a2

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : cf30cf007ef6e071b1852fbbd8b3b9f20b3f536d
2017-08-11 15:02:30 -05:00
..
servo servo: Merge #18051 - Continue after failed attempt to delete old nightly (from edunham:cleannightly); r=larsbergstrom 2017-08-11 15:02:30 -05:00
tidy servo: Merge #17749 - Extra space check (from SergeevPavel:extra-space-check); r=jdm 2017-07-19 16:03:51 -07:00
README.md servo: Merge #10984 - Minor python/README fixes (from frewsxcv:python-cleanup); r=metajack 2016-05-03 03:20:19 -07:00
mach_bootstrap.py servo: Merge #17163 - Update mach bootstrap for changes to wpt harness path in gecko (from jgraham:gecko_wpt_update); r=jdm 2017-06-05 06:26:31 -07:00
requirements-salt.txt servo: Merge #14974 - Use Salt for mach bootstrap (from aneeshusa:add-mach-bootstrap); r=metajack 2017-01-19 20:58:19 -08:00
requirements.txt servo: Merge #16565 - Convert nightly upload script to Python (from aneeshusa:move-upload-nightly-script-to-python); r=metajack 2017-05-22 18:11:19 -05:00
tox.ini servo: Merge #11073 - Added tox.ini (from autrilla:tox); r=Ms2ger 2016-05-09 01:37:09 -07:00

README.md

This directory contains various Python modules used to support servo development.

servo

servo-specific python code e.g. implementations of mach commands. This is the canonical repository for this code.

tidy

servo-tidy is used to check licenses, line lengths, whitespace, flake8 on Python files, lock file versions, and more.