зеркало из https://github.com/mozilla/gecko-dev.git
2745f694aa
This modifies the Nimbus update observer in UrlbarPrefs so that it does not update the Firefox Suggest scenario unnecessarily. The scenario and the prefs related to the scenario only need to be updated when either of these happens: * A relevant Nimbus variable changes * The current default-branch value of a relevant pref is incorrect for the intended scenario Currently, any time a pref changes that is declared as a fallback pref for a Nimbus urlbar variable, we end up updating the scenario all over again even if it was some totally unrelated variable like `bestMatchEnabled`. We have very good test coverage for scenario updates, so I'm confident that this revision works properly and that we can catch regressions when we modify related code in the future. While working on this, I found that the `quickSuggestNonSponsoredEnabled` was accidentally removed by D130159 (https://hg.mozilla.org/mozilla-central/rev/ccda4432cdc4d7180a9304e05b52f046616bbf2b) so I added it back. We haven't used this variable in any experiments or rollouts so it was never a problem. Differential Revision: https://phabricator.services.mozilla.com/D140425 |
||
|---|---|---|
| .. | ||
| actors | ||
| components | ||
| content | ||
| crashreporter | ||
| docs | ||
| library | ||
| locales | ||
| modules | ||
| mozapps | ||
| profile | ||
| system | ||
| themes | ||
| xre | ||
| .eslintrc.js | ||
| l10n-registry.manifest | ||
| moz.build | ||
| moz.configure | ||
| toolkit.mozbuild | ||