зеркало из https://github.com/mozilla/gecko-dev.git
d4aafcce6d
In `getTokenLocation`, the call to `coordsChar` needed an extra parameter so the coordinates are relative to the top left corner fo the currently visible window. We were passing the center of the bounding client rect to `getTokenLocation`, but a token could wrap and have it's bounding rect center not being on the token. To fix this we're passing the center of the first box quads of the token. The inline preview widgets were causing some troubles on CodeMirror internal state too. Since we're using React to populate the bookmark we set on the line, and given that React.render is asynchronous, we were setting an empty element as a bookmark on the editor, which React populates later. But CodeMirror probably update its internal state when the bookmark is added, so that was causing wrong computation later. To avoid that, we only set the bookmark once React actually rendered the element in the DOM. Finally, while codeMirror already listen for window resize to update its internal state, the Editor can be resized without the window being resized, when primary/secondary panels are resized. In such case, we manually trigger a codeMirror refresh. We add a test to cover this, and also modify test helpers so we would query the DOM instead of relying on CodeMirror methods. Differential Revision: https://phabricator.services.mozilla.com/D190272 |
||
|---|---|---|
| .. | ||
| client | ||
| docs | ||
| perfdocs | ||
| platform | ||
| server | ||
| shared | ||
| startup | ||
| .eslintrc.js | ||
| .eslintrc.xpcshell.js | ||
| CODE_OF_CONDUCT.md | ||
| moz.build | ||
| rename.py | ||
| templates.mozbuild | ||
| tsconfig.json | ||