gecko-dev/widget/windows
Aaron Klotz 12bdf4e7a1 Bug 1569756: Check for S_FALSE after calling IShellWindows::FindWindowSW; r=jmathies
`IShellWindows::FindWindowSW` may return the dreaded `S_FALSE`, so we need to
ensure that we're handling that.

I checked the remaining functions called by this code and none of the others
do this; this is the only call site that requires the check.

I'm not sure why we're seeing this error code. I added an explicit cast to
ensure that `CSIDL_DESKTOP` is being interpreted as an `int`, though I doubt
that this actually makes any difference.

Differential Revision: https://phabricator.services.mozilla.com/D39799

--HG--
extra : moz-landing-system : lando
2019-07-31 15:31:07 +00:00
..
res
tests Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
AudioSession.cpp Bug 1533675 - Name all threads in Firefox r=Ehsan 2019-06-06 21:07:29 +00:00
AudioSession.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
CompositorWidgetChild.cpp Bug 1524591 - Call SetParent in UI process r=mattwoodrow 2019-02-07 16:01:41 +09:00
CompositorWidgetChild.h Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 2019-02-15 08:15:57 +00:00
CompositorWidgetParent.cpp Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 2019-02-15 08:15:57 +00:00
CompositorWidgetParent.h Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 2019-02-15 08:15:57 +00:00
GfxInfo.cpp Bug 1554540 - Expose window protocol (X11, Wayland) in nsIGfxInfo and about:support. r=kats,stransky,flod 2019-05-28 06:40:34 -04:00
GfxInfo.h Bug 1554540 - Expose window protocol (X11, Wayland) in nsIGfxInfo and about:support. r=kats,stransky,flod 2019-05-28 06:40:34 -04:00
IEnumFE.cpp Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan 2019-05-01 08:47:10 +00:00
IEnumFE.h Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan 2019-05-01 08:47:10 +00:00
IMMHandler.cpp Bug 1259660 - Moved mozilla::WidgetMosueEventBase::buttonType in MouseEvents.h to mozilla::MouseButton in EventForwards.h, and mozilla::WidgetMouseEventBase::buttonsFlag to mozilla::MouseButtonsFlag r=masayuki 2019-04-21 20:13:34 +00:00
IMMHandler.h Bug 1289211 - Rename InfallibleTArray to nsTArray in widget/ r=jmathies 2019-07-10 03:33:42 +00:00
InProcessWinCompositorWidget.cpp Bug 1523969 part 26 - Move method definition inline comments to new line in 'widget/'. r=mstange 2019-02-25 16:13:48 -06:00
InProcessWinCompositorWidget.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
InkCollector.cpp Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
InkCollector.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
InputDeviceUtils.cpp Bug 1511393 - Use c-basic-offset: 2 in Emacs mode line for C/C++ code. r=nbp 2018-12-01 04:52:05 +09:00
InputDeviceUtils.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
JumpListBuilder.cpp Bug 1400344: Rename mscom::MainThreadRuntime to mscom::ProcessRuntime and make it aware of Win32k lockdown and of multiple instantiations; r=Jamie 2019-02-14 18:56:20 +00:00
JumpListBuilder.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
JumpListItem.cpp Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan 2019-05-01 08:47:10 +00:00
JumpListItem.h Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan 2019-05-01 08:47:10 +00:00
KeyboardLayout.cpp Bug 1534395 - Rename TabChild to BrowserChild. r=nika 2019-04-09 17:39:01 -05:00
KeyboardLayout.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
LSPAnnotator.cpp Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
PCompositorWidget.ipdl Bug 1524591 - Call SetParent in UI process r=mattwoodrow 2019-02-07 16:01:41 +09:00
PlatformWidgetTypes.ipdlh
ProcInfo.cpp Bug 1529022 - Add a GeckoChildProcessHosts iterator r=jld 2019-06-21 01:33:47 +00:00
ScreenHelperWin.cpp Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ScreenHelperWin.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ShellHeaderOnlyUtils.h Bug 1569756: Check for S_FALSE after calling IShellWindows::FindWindowSW; r=jmathies 2019-07-31 15:31:07 +00:00
TSFTextStore.cpp Bug 1259660 - Moved mozilla::WidgetMosueEventBase::buttonType in MouseEvents.h to mozilla::MouseButton in EventForwards.h, and mozilla::WidgetMouseEventBase::buttonsFlag to mozilla::MouseButtonsFlag r=masayuki 2019-04-21 20:13:34 +00:00
TSFTextStore.h Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre 2019-01-18 10:16:18 +01:00
TaskbarPreview.cpp Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan 2019-05-01 08:47:10 +00:00
TaskbarPreview.h Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan 2019-05-01 08:47:10 +00:00
TaskbarPreviewButton.cpp Bug 1560081 - Convert CSS pixels to device pixels in CursorForImage. r=jmathies 2019-06-20 20:00:24 +00:00
TaskbarPreviewButton.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
TaskbarTabPreview.cpp Bug 1560081 - Convert CSS pixels to device pixels in CursorForImage. r=jmathies 2019-06-20 20:00:24 +00:00
TaskbarTabPreview.h Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan 2019-05-01 08:47:10 +00:00
TaskbarWindowPreview.cpp Bug 1560081 - Convert CSS pixels to device pixels in CursorForImage. r=jmathies 2019-06-20 20:00:24 +00:00
TaskbarWindowPreview.h Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan 2019-05-01 08:47:10 +00:00
ToastNotification.cpp Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ToastNotification.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ToastNotificationHandler.cpp Bug 1557793 part 2. Stop using [array] in nsIStringBundle. r=Pike 2019-06-11 15:51:51 +00:00
ToastNotificationHandler.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
WidgetTraceEvent.cpp Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
WinCompositorWidget.cpp Bug 1563139 - Remove StaticPrefs.h. r=glandium 2019-07-26 01:10:23 +00:00
WinCompositorWidget.h Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 2019-02-15 08:15:57 +00:00
WinCompositorWindowThread.cpp Bug 1544074 - Remove WS_EX_LAYERED and WS_EX_TRANSPARENT r=mattwoodrow 2019-04-15 01:24:26 +00:00
WinCompositorWindowThread.h Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 2019-02-15 08:15:57 +00:00
WinHeaderOnlyUtils.h Bug 1567614: Part 2 - Add ShellExecuteByExplorer overload to handle absolute PIDL lists; r=jmathies 2019-07-23 20:18:07 +00:00
WinIMEHandler.cpp Bug 1534395 - Rename TabParent to BrowserParent. r=nika 2019-04-09 16:38:15 -05:00
WinIMEHandler.h Bug 1504963 - part 4: Make IMEHandler create native caret over our caret if it's necessary r=Jamie,m_kato 2018-12-18 08:38:23 +00:00
WinMessages.h Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre 2019-01-18 10:16:18 +01:00
WinModifierKeyState.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
WinMouseScrollHandler.cpp Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
WinMouseScrollHandler.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
WinNativeEventData.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
WinPointerEvents.cpp Bug 1490044 - Move all prefs used in WebIDL to StaticPrefs. r=bzbarsky 2019-06-13 09:00:59 +00:00
WinPointerEvents.h Bug 1490044 - Move all prefs used in WebIDL to StaticPrefs. r=bzbarsky 2019-06-13 09:00:59 +00:00
WinTaskbar.cpp Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan 2019-05-01 08:47:10 +00:00
WinTaskbar.h Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan 2019-05-01 08:47:10 +00:00
WinTextEventDispatcherListener.cpp Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
WinTextEventDispatcherListener.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
WinUtils.cpp Bug 1523969 part 26 - Move method definition inline comments to new line in 'widget/'. r=mstange 2019-02-25 16:13:48 -06:00
WinUtils.h Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre 2019-01-18 10:16:18 +01:00
WindowHook.cpp Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan 2019-05-01 08:47:10 +00:00
WindowHook.h Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan 2019-05-01 08:47:10 +00:00
WindowsConsole.cpp Bug 1528963 - Attach console before launching child. r=aklotz 2019-03-29 18:05:03 +00:00
WindowsConsole.h Bug 1528963 - Attach console before launching child. r=aklotz 2019-03-29 18:05:03 +00:00
WindowsEMF.cpp Bug 1511393 - Use c-basic-offset: 2 in Emacs mode line for C/C++ code. r=nbp 2018-12-01 04:52:05 +09:00
WindowsEMF.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
WindowsUIUtils.cpp Bug 827976 - Tablet Mode detection should favor using an existing window instead of the hidden window. r=aklotz 2019-03-04 20:21:09 +00:00
WindowsUIUtils.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
components.conf Bug 1539029 - pt 1 - give RDD its own process selector. r=froydnj 2019-04-09 21:13:16 +00:00
moz.build Bug 1567614: Part 1 - Refactor launcher process's LaunchUnelevated to delegate to ShellExecuteByExplorer; r=jmathies 2019-07-23 20:17:58 +00:00
nsAppShell.cpp Bug 1539577 - Avoid calling InitUIThread when native event processing is turned off. r=bobowen 2019-04-01 08:13:11 +00:00
nsAppShell.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
nsBidiKeyboard.cpp Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
nsBidiKeyboard.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
nsClipboard.cpp Bug 1557847. Stop using [array] in nsIClipboard. r=NeilDeakin 2019-06-09 01:06:39 +00:00
nsClipboard.h Bug 1557847. Stop using [array] in nsIClipboard. r=NeilDeakin 2019-06-09 01:06:39 +00:00
nsColorPicker.cpp Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
nsColorPicker.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
nsDataObj.cpp Bug 1532140 - Cleanup nsDataObj. r=jmathies 2019-03-13 19:00:59 +00:00
nsDataObj.h Bug 1532140 - Cleanup nsDataObj. r=jmathies 2019-03-13 19:00:59 +00:00
nsDataObjCollection.cpp Bug 1532140 - Cleanup nsDataObj. r=jmathies 2019-03-13 19:00:59 +00:00
nsDataObjCollection.h Bug 1532140 - Cleanup nsDataObj. r=jmathies 2019-03-13 19:00:59 +00:00
nsDeviceContextSpecWin.cpp Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre 2019-01-18 10:16:18 +01:00
nsDeviceContextSpecWin.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
nsDragService.cpp Bug 1543315 - part 17: Mark PresShell::HandleDOMEventWithTarget() as MOZ_CAN_RUN_SCRIPT r=smaug 2019-05-09 20:21:28 +00:00
nsDragService.h Bug 1543315 - part 17: Mark PresShell::HandleDOMEventWithTarget() as MOZ_CAN_RUN_SCRIPT r=smaug 2019-05-09 20:21:28 +00:00
nsFilePicker.cpp Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan 2019-05-01 08:47:10 +00:00
nsFilePicker.h Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan 2019-05-01 08:47:10 +00:00
nsIdleServiceWin.cpp Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan 2019-05-01 08:47:10 +00:00
nsIdleServiceWin.h Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre 2019-01-18 10:16:18 +01:00
nsLookAndFeel.cpp Bug 1554433 - Move system colors to values::specified::color. r=xidorn 2019-05-26 13:10:00 +00:00
nsLookAndFeel.h Bug 1526294 - Should not need a pres context to get a system font. r=jfkthame 2019-02-15 01:35:13 +01:00
nsNativeDragSource.cpp Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
nsNativeDragSource.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
nsNativeDragTarget.cpp Bug 1543315 - part 17: Mark PresShell::HandleDOMEventWithTarget() as MOZ_CAN_RUN_SCRIPT r=smaug 2019-05-09 20:21:28 +00:00
nsNativeDragTarget.h Bug 1543315 - part 17: Mark PresShell::HandleDOMEventWithTarget() as MOZ_CAN_RUN_SCRIPT r=smaug 2019-05-09 20:21:28 +00:00
nsNativeThemeWin.cpp Bug 1563139 - Remove StaticPrefs.h. r=glandium 2019-07-26 01:10:23 +00:00
nsNativeThemeWin.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
nsPrintDialogUtil.cpp Bug 1552785. Remove Windows print dialog UI for selecting frameset behavior. r=bobowen 2019-05-15 10:36:08 +01:00
nsPrintDialogUtil.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
nsPrintDialogWin.cpp Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
nsPrintDialogWin.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
nsPrintSettingsServiceWin.cpp Bug 1552785. Remove printing related isFramesetDocument and isFramesetFrameSelected code. r=bobowen 2019-05-21 23:25:57 +01:00
nsPrintSettingsServiceWin.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
nsPrintSettingsWin.cpp Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre 2019-01-18 10:16:18 +01:00
nsPrintSettingsWin.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
nsSound.cpp Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan 2019-05-01 08:47:10 +00:00
nsSound.h Bug 1482659 - Purge the last sound, free then start to play a sound r=m_kato,masayuki 2019-01-09 12:26:46 +00:00
nsToolkit.cpp Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
nsToolkit.h Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre 2019-01-18 10:16:18 +01:00
nsUXThemeConstants.h Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre 2019-01-18 10:16:18 +01:00
nsUXThemeData.cpp Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan 2019-05-01 08:47:10 +00:00
nsUXThemeData.h Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan 2019-05-01 08:47:10 +00:00
nsWidgetFactory.cpp Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 2019-03-13 10:19:06 +01:00
nsWidgetFactory.h Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan 2019-05-01 08:47:10 +00:00
nsWinGesture.cpp Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
nsWinGesture.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
nsWindow.cpp Bug 1557710 - Fire eMouseExitFromWidget when transitioning from a draggable to a non-draggable non-client region on Windows. r=jmathies 2019-07-10 15:34:54 +00:00
nsWindow.h Bug 1553769 - Make nsIWidget::SetFocus infallible, and make it take an enum class. r=NeilDeakin 2019-05-31 22:13:56 +00:00
nsWindowBase.cpp Bug 1563139 - Remove StaticPrefs.h. r=glandium 2019-07-26 01:10:23 +00:00
nsWindowBase.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
nsWindowDbg.cpp Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan 2019-05-01 08:47:10 +00:00
nsWindowDbg.h Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan 2019-05-01 08:47:10 +00:00
nsWindowDefs.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
nsWindowGfx.cpp Bug 1560081 - Convert CSS pixels to device pixels in CursorForImage. r=jmathies 2019-06-20 20:00:24 +00:00
nsWindowGfx.h Bug 1560081 - Convert CSS pixels to device pixels in CursorForImage. r=jmathies 2019-06-20 20:00:24 +00:00
nsdefs.h Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre 2019-01-18 10:16:18 +01:00
resource.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
touchinjection_sdk80.h Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre 2019-01-18 10:16:18 +01:00
widget.rc